[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-05-29 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r432580685 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r422577368 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r422575326 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1185,70 +1275,189 @@ static long

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415446216 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1185,70 +1275,189 @@ static long

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415444590 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415444590 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415444590 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415440161 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415440161 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-04-26 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415429416 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCipher.java ## @@ -90,6 +102,10 @@ // Update last two bytes with new page