wgtmac commented on PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1838002383
BTW, it would be good to add an interoperability test to read parquet files
from here:
https://github.com/apache/parquet-testing/commit/da467dac2f095b979af37bcf40fa0d1dee5ff652.
You
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1413455235
##
pom.xml:
##
@@ -596,6 +597,9 @@
org.apache.parquet.arrow.schema.SchemaMapping
+
+
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1413353347
##
pom.xml:
##
@@ -596,6 +597,9 @@
org.apache.parquet.arrow.schema.SchemaMapping
+
+ org.apache.parquet.io.api.Binary
zhangjiashen commented on PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1837800275
> Could you please rebase it?
Rebased, can you help merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wgtmac commented on PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1833370284
Could you please rebase it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zhangjiashen commented on PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1827206658
> @zhangjiashen This can be rebased to adopt parquet-format 2.10.0
@wgtmac I just rebased with master branch and please help take a look when
you get a chance?
--
This
wgtmac commented on PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1825081998
@zhangjiashen This can be rebased to adopt parquet-format 2.10.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wgtmac commented on PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1783745746
> @wgtmac, I don't think we automatically deploy snapshot versions. And, we
will need a final release of parquet-format anyway, before we can get this one
merged.
OK, then let's
gszadovszky commented on PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1783252917
@wgtmac, I don't think we automatically deploy snapshot versions. And, we
will need a final release of parquet-format anyway, before we can get this one
merged.
--
This is an
wgtmac commented on PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1783165574
https://github.com/apache/parquet-format/pull/184 is merged. Could you try
to set `parquet.format.version` to 2.10.0-SNAPSHOT in the pom.xml and check if
the CIs are green?
--
This
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1371134589
##
parquet-column/src/main/java/org/apache/parquet/schema/Float16.java:
##
@@ -46,29 +46,10 @@
* Ref:
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1371132290
##
parquet-column/src/main/java/org/apache/parquet/column/statistics/Statistics.java:
##
@@ -150,26 +150,26 @@ public Float16Builder(PrimitiveType type) {
gszadovszky commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1368247647
##
parquet-column/src/main/java/org/apache/parquet/column/statistics/Statistics.java:
##
@@ -150,26 +150,26 @@ public Float16Builder(PrimitiveType type) {
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1367832738
##
parquet-column/src/main/java/org/apache/parquet/column/statistics/Float16Statistics.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1367832612
##
parquet-column/src/test/java/org/apache/parquet/io/api/TestBinary.java:
##
@@ -268,4 +268,19 @@ public void testCompare() {
assertTrue(b1.compareTo(b3)
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1367832542
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,307 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1367832331
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1363539290
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,307 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
gszadovszky commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1363371525
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,307 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1362333511
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,307 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1362335145
##
parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestFloat16Statistics.java:
##
@@ -0,0 +1,272 @@
+/*
+ * Licensed to the Apache Software Foundation
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1362272287
##
parquet-column/src/main/java/org/apache/parquet/column/statistics/Float16Statistics.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1359678599
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1359657237
##
parquet-column/src/test/java/org/apache/parquet/schema/TestTypeBuildersWithLogicalTypes.java:
##
@@ -205,10 +206,20 @@ public void testBinaryAnnotations() {
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1359656883
##
parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestFloat16Statistics.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software
zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1359649367
##
parquet-column/src/main/java/org/apache/parquet/column/statistics/Float16Statistics.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software
gszadovszky commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1356337298
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1355951576
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1355948744
##
parquet-column/src/main/java/org/apache/parquet/column/statistics/Statistics.java:
##
@@ -139,6 +140,43 @@ public Statistics build() {
}
}
+ // Builder
benibus commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1355712865
##
parquet-column/src/main/java/org/apache/parquet/column/statistics/Statistics.java:
##
@@ -139,6 +140,43 @@ public Statistics build() {
}
}
+ //
gszadovszky commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1349905085
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1349815502
##
parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestFloat16Statistics.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1349815242
##
parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestFloat16Statistics.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1349814639
##
parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestFloat16Statistics.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation
wgtmac commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1349533756
##
parquet-column/src/test/java/org/apache/parquet/schema/TestTypeBuildersWithLogicalTypes.java:
##
@@ -205,10 +206,20 @@ public void testBinaryAnnotations() {
gszadovszky commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1346873547
##
parquet-common/src/main/java/org/apache/parquet/type/Float16.java:
##
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
36 matches
Mail list logo
