Re: -DMODPERL, -DMOD_PERL, -DMOD_PERL2, -DMODPERL2 conundrum

2003-01-28 Thread Philippe M. Chiasson
On Wed, 2003-01-29 at 14:57, Stas Bekman wrote: > In 1.0 mod_perl extensions were passed -DMOD_PERL by Apache::src, so shouldn't > we pass -DMOD_PERL2 from ModPerl::MM and not -DMOD_PERL? > > At the same time we use and not MOD_PERL2, so it gets all > confusing. Can we decide on consistently us

-DMODPERL, -DMOD_PERL, -DMOD_PERL2, -DMODPERL2 conundrum

2003-01-28 Thread Stas Bekman
In 1.0 mod_perl extensions were passed -DMOD_PERL by Apache::src, so shouldn't we pass -DMOD_PERL2 from ModPerl::MM and not -DMOD_PERL? At the same time we use and not MOD_PERL2, so it gets all confusing. Can we decide on consistently using the underscore or none in both cases? I know that it'

Re: [mp2 Patch] Apache::Directive->lookup($directive, [$args]);

2003-01-28 Thread Stas Bekman
Regarding the xs and the test, you still had quite a few indentation problems, plus too wide lines (keep under 74 or so), but I've fixed those and committed. Hargh ! I am still trying to figure out a way to automatically indent my stuff, but I am failing miserably... Can't get indent to produc

Re: [mp2 Patch] Apache::Directive->lookup($directive, [$args]);

2003-01-28 Thread Philippe M. Chiasson
On Wed, 2003-01-29 at 11:57, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > Made a few minor style changes to the original patches. Thanks for the > > extra eyeballing Stas ;-) > > I've committed the doc after massaging it. Still can't decide what the best > look-n-feel for the API docs to

Re: [mp2 Patch] Apache::Directive->lookup($directive, [$args]);

2003-01-28 Thread Stas Bekman
Philippe M. Chiasson wrote: Made a few minor style changes to the original patches. Thanks for the extra eyeballing Stas ;-) I've committed the doc after massaging it. Still can't decide what the best look-n-feel for the API docs to choose, but we are getting there. Regarding the xs and the te

Re: [mp2 Patch] Apache::Directive->lookup($directive, [$args]);

2003-01-28 Thread Philippe M. Chiasson
Made a few minor style changes to the original patches. Thanks for the extra eyeballing Stas ;-) --- /dev/null 2002-08-31 07:31:37.0 +0800 +++ docs/api/Apache/Directive.pod 2003-01-29 10:59:37.0 +0800 @@ -0,0 +1,133 @@ +=head1 NAME + +Apache::Directive -- A Perl API for man

Re: [mp2 Patch] Apache::Directive->lookup($directive, [$args]);

2003-01-28 Thread Stas Bekman
BTW, the Apache::Directive->as_hash method is nice, but I guess that it's not very useful, since the original order of things is lost, which will break things if you try to feed them back or just trying to view them. If we could use the functionality of Tie::IxHash where the keys sorting is pres

Re: Mitigating XSS in the mod_perl API

2003-01-28 Thread Thomas Eibner
On Tue, Jan 28, 2003 at 02:50:54PM +, Matt Sergeant wrote: > For geoff... > > On Tue, 28 Jan 2003, Matt Sergeant wrote: > > > Index: src/main/http_protocol.c > > === > > RCS file: /home/cvs/apache-1.3/src/main/http_protocol.c,v

Re: Mitigating XSS in the mod_perl API

2003-01-28 Thread Thomas Eibner
On Tue, Jan 28, 2003 at 11:30:18AM +, Matt Sergeant wrote: > Here's the patch in case anyone is interested in applying it to their own > apache. I think there's probably a bug in that \n might not always be the > right thing to look for (CRLF issues), so please send me corrections ;-) > > I ha

Re: Mitigating XSS in the mod_perl API

2003-01-28 Thread Thomas Eibner
On Tue, Jan 28, 2003 at 01:08:28PM +0200, Issac Goldstand wrote: > - Original Message - > From: "Thomas Eibner" <[EMAIL PROTECTED]> > Subject: Re: Mitigating XSS in the mod_perl API > > > > On Mon, Jan 27, 2003 at 02:45:13PM +, Matt Sergeant wrote: > > > On Mon, 27 Jan 2003, Thomas E

Re: Mitigating XSS in the mod_perl API

2003-01-28 Thread Geoffrey Young
Matt Sergeant wrote: Here's the patch in case anyone is interested in applying it to their own apache. I think there's probably a bug in that \n might not always be the right thing to look for (CRLF issues), so please send me corrections ;-) I'm not a C guy, but there are some constants in htt

Re: Mitigating XSS in the mod_perl API

2003-01-28 Thread Matt Sergeant
Here's the patch in case anyone is interested in applying it to their own apache. I think there's probably a bug in that \n might not always be the right thing to look for (CRLF issues), so please send me corrections ;-) I haven't actually run this, so it might not work. But to quote Lord Flashhea

Re: Mitigating XSS in the mod_perl API

2003-01-28 Thread Issac Goldstand
- Original Message - From: "Thomas Eibner" <[EMAIL PROTECTED]> Subject: Re: Mitigating XSS in the mod_perl API > On Mon, Jan 27, 2003 at 02:45:13PM +, Matt Sergeant wrote: > > On Mon, 27 Jan 2003, Thomas Eibner wrote: > > > > > So, because a programmer doesn't check the validity of th