Re: [PATCH mp2] Fix api/server_util.t failures on Win32

2004-01-22 Thread Randy Kobes
On Thu, 22 Jan 2004, Stas Bekman wrote: > Randy Kobes wrote: > > On Thu, 22 Jan 2004, Stas Bekman wrote: > > > > > >>Steve Hay wrote: > >> > >>>The attached patch fixes these errors on Win32: > >> > >>Thanks Steve. I've committed all 3 patches for: > >> > >>t/response/TestVhost/config.pm > >>t/res

Re: [Apache::Reload] possible patch/addition/feature (code included)

2004-01-22 Thread stevan little
Stas, Thanks for taking time out to answer my post. On Jan 22, 2004, at 9:49 PM, Stas Bekman wrote: stevan little wrote: All, (I sent this originally to Matt Sergeant, and he suggested i post it here instead) Apache::Reload a great module, there was however one thing that always drove me cra

Re: [Apache::Reload] possible patch/addition/feature (code included)

2004-01-22 Thread Stas Bekman
stevan little wrote: All, (I sent this originally to Matt Sergeant, and he suggested i post it here instead) Apache::Reload a great module, there was however one thing that always drove me crazy. When a module reload failed, I found myself alot of times faced with the "Internal Server Error

Re: modperl/perl_options failures on Win32

2004-01-22 Thread Stas Bekman
Steve Hay wrote: The modperl/perl_options.t test currently fails on Win32. Here's the client console window output running under -verbose: C:\Temp\modperl-2.0>perl t/TEST modperl/perl_options.t -verbose [...] modperl/perl_optionsrequest has failed (the response code was: 403) see t/logs/error

Re: cvs commit: modperl-2.0 Changes

2004-01-22 Thread Stas Bekman
Geoffrey Young wrote: #test adding config at request time -my $errmsg = $r->add_config(['require valid-user']); -die $errmsg if $errmsg; +$r->add_config(['require valid-user']); I don't know about this. I was going to work up my thoughts as a result of another thread, but I

Re: cvs commit: modperl-2.0 Changes

2004-01-22 Thread Geoffrey Young
>#test adding config at request time > -my $errmsg = $r->add_config(['require valid-user']); > -die $errmsg if $errmsg; > +$r->add_config(['require valid-user']); I don't know about this. I was going to work up my thoughts as a result of another thread, but I might as w

Re: cvs commit: modperl-2.0/t/response/TestAPI server_util.pm

2004-01-22 Thread Stas Bekman
Geoffrey Young wrote: ok t_cmp(qr/server_root_relative.*no .* key/, - $@, + canonpath($@), "Apache::Server::server_root_relative(\$obj, 'conf')"); I don't understand this change. not only does it not make sense to me (using canonpath

Re: cvs commit: modperl-2.0/t/response/TestAPI server_util.pm

2004-01-22 Thread Geoffrey Young
>ok t_cmp(qr/server_root_relative.*no .* key/, > - $@, > + canonpath($@), > "Apache::Server::server_root_relative(\$obj, 'conf')"); I don't understand this change. not only does it not make sense to me (using canonpath on a non-

Re: [PATCH mp2] Fix api/server_util.t failures on Win32

2004-01-22 Thread Stas Bekman
Randy Kobes wrote: On Thu, 22 Jan 2004, Stas Bekman wrote: Steve Hay wrote: The attached patch fixes these errors on Win32: Thanks Steve. I've committed all 3 patches for: t/response/TestVhost/config.pm t/response/TestCompat/apache.pm t/response/TestAPI/server_util.pm As I mentioned before I ca

Re: [PATCH mp2] Fix api/server_util.t failures on Win32

2004-01-22 Thread Randy Kobes
On Thu, 22 Jan 2004, Stas Bekman wrote: > Steve Hay wrote: > > The attached patch fixes these errors on Win32: > > Thanks Steve. I've committed all 3 patches for: > > t/response/TestVhost/config.pm > t/response/TestCompat/apache.pm > t/response/TestAPI/server_util.pm > > As I mentioned before I ca

Re: [PATCH mp2] Fix api/server_util.t failures on Win32

2004-01-22 Thread Stas Bekman
Steve Hay wrote: The attached patch fixes these errors on Win32: Thanks Steve. I've committed all 3 patches for: t/response/TestVhost/config.pm t/response/TestCompat/apache.pm t/response/TestAPI/server_util.pm As I mentioned before I can't apply your patches as is, because the path is in windows-

Re: [mp2] changing add_config() to croak on error

2004-01-22 Thread Stas Bekman
Philippe M. Chiasson wrote: On Wed, 2004-01-21 at 23:33, Stas Bekman wrote: Philippe, Adding this to httpd.conf: PerlModule Does::not::ExiST aborts the startup and prints the error message. The following section should be an equivalent one and behave the same: use Apache::ServerUtil;

Re: early perl startup in vhost on win32

2004-01-22 Thread Stas Bekman
Steve Hay wrote: Ok, so here is a proper patch for modperl_cmd.c. Please try it (attached as well), it's a bit different from the previous one. Works a treat. The server starts up OK with the vhost test stuff in place, and the three conf files still work too. Thanks Steve. We have missed the

Re: [mp2] changing add_config() to croak on error

2004-01-22 Thread Philippe M. Chiasson
On Wed, 2004-01-21 at 23:33, Stas Bekman wrote: > Philippe, > > Adding this to httpd.conf: > >PerlModule Does::not::ExiST > > aborts the startup and prints the error message. > > The following section should be an equivalent one and behave the same: > > > use Apache::ServerUtil; >

[Apache::Reload] possible patch/addition/feature (code included)

2004-01-22 Thread stevan little
All, (I sent this originally to Matt Sergeant, and he suggested i post it here instead) Apache::Reload a great module, there was however one thing that always drove me crazy. When a module reload failed, I found myself alot of times faced with the "Internal Server Error" page, and then i wo

[PATCH mp2] Fix vhost/basic.t failure on Win32

2004-01-22 Thread Steve Hay
Another patch to fix another failing test on Win32. (Attached is also the vhost test files that I was using that had this problem. I think they're the most recent ones posted by Stas.) Here's what the problem was (again!): C:\Temp\modperl-2.0>perl t/TEST vhost/basic.t -verbose C:\apache2\bin\A

modperl/perl_options failures on Win32

2004-01-22 Thread Steve Hay
The modperl/perl_options.t test currently fails on Win32. Here's the client console window output running under -verbose: C:\Temp\modperl-2.0>perl t/TEST modperl/perl_options.t -verbose C:\apache2\bin\Apache.EXE -d C:/Temp/modperl-2.0/t -f C:/Temp/modperl-2.0/t/conf /httpd.conf -DAPACHE2 -DPERL_

[PATCH mp2] Fix compat/apache.t failures on Win32

2004-01-22 Thread Steve Hay
The attached patch fixes these failures on Win32: C:\Temp\modperl-2.0>perl t/TEST compat/apache.t -verbose C:\apache2\bin\Apache.EXE -d C:/Temp/modperl-2.0/t -f C:/Temp/modperl-2.0/t/conf /httpd.conf -DAPACHE2 -DPERL_USEITHREADS using Apache/2.0.48 (winnt MPM) waiting 180 seconds for server to s

[PATCH mp2] Fix api/server_util.t failures on Win32

2004-01-22 Thread Steve Hay
The attached patch fixes these errors on Win32: C:\Temp\modperl-2.0>perl t/TEST api/server_util.t -verbose C:\apache2\bin\Apache.EXE -d C:/Temp/modperl-2.0/t -f C:/Temp/modperl-2.0/t/conf /httpd.conf -DAPACHE2 -DPERL_USEITHREADS using Apache/2.0.48 (winnt MPM) waiting 180 seconds for server to s

Re: early perl startup in vhost on win32

2004-01-22 Thread Steve Hay
Stas Bekman wrote: >Stas Bekman wrote: > > > >>I'll post later a better patch. That one was just a proof of concept. >> >> > >Ok, so here is a proper patch for modperl_cmd.c. Please try it (attached as >well), it's a bit different from the previous one. > Works a treat. The server starts

Re: early perl startup in vhost on win32

2004-01-22 Thread Stas Bekman
Stas Bekman wrote: I'll post later a better patch. That one was just a proof of concept. Ok, so here is a proper patch for modperl_cmd.c. Please try it (attached as well), it's a bit different from the previous one. Plus added some macros to make the code more readable. I should add another tes

[mp2] changing Apache->server

2004-01-22 Thread Stas Bekman
If you have followed the end of the long story on windows with free to wrong pool, you'd have known that one of the reason for the problem was the use of the wrong context in add_config in the following snippet: PerlOptions +Parent use Apache::ServerUtil; my $s = Apache->server;

Re: early perl startup in vhost on win32

2004-01-22 Thread Stas Bekman
Steve Hay wrote: I also have a couple of test failures, including one from the vhost test itself: Failed TestStat Wstat Total Fail Failed List of Failed api\server_util.t24 10 41.67% 4-13 c

Re: early perl startup in vhost on win32

2004-01-22 Thread Steve Hay
Stas Bekman wrote: >Randy Kobes wrote: > > >>On Wed, 21 Jan 2004, Stas Bekman wrote: >> >> >> >> >>>Stas Bekman wrote: >>> >>> >>> It looks like Jan's patch allows me to reproduce the problems that you see. So if that's true, we will be all set shortly. So don't waste your

Re: early perl startup in vhost on win32

2004-01-22 Thread Stas Bekman
Randy Kobes wrote: On Wed, 21 Jan 2004, Stas Bekman wrote: Stas Bekman wrote: It looks like Jan's patch allows me to reproduce the problems that you see. So if that's true, we will be all set shortly. So don't waste your time on testing things I've asked to. I'll keep you posted. Thanks. It's so

[mp2] changing add_config() to croak on error

2004-01-22 Thread Stas Bekman
Philippe, Adding this to httpd.conf: PerlModule Does::not::ExiST aborts the startup and prints the error message. The following section should be an equivalent one and behave the same: use Apache::ServerUtil; my $s = Apache->server->add_config(['PerlModule Does::not::ExiST']); bu

Re: early perl startup in vhost on win32

2004-01-22 Thread Randy Kobes
On Wed, 21 Jan 2004, Stas Bekman wrote: > Stas Bekman wrote: > > It looks like Jan's patch allows me to reproduce the problems that you > > see. So if that's true, we will be all set shortly. So don't waste your > > time on testing things I've asked to. I'll keep you posted. Thanks. > > It's so mu