[patch] adjusting for API changes

2001-08-25 Thread Stas Bekman
this patch is needed to build mod_perl with the latest httpd-2.0 all tests now pass with the pre-fork MPM. Index: src/modules/perl/modperl_pcw.c === RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_pcw.c,v retrieving revisi

[patch] make xs_generate

2001-08-25 Thread Stas Bekman
a patch to make 'make xs_generate' work stand-alone. not sure whether this is the right fix, but it works. Index: lib/Apache/Build.pm === RCS file: /home/cvs/modperl-2.0/lib/Apache/Build.pm,v retrieving revision 1.45 diff -u -r1.45

[patch] Makefile.PL prerequisites

2001-08-25 Thread Stas Bekman
this patch adds the prerequisites checking functionality. Add more modules as needed. Index: Makefile.PL === RCS file: /home/cvs/modperl-2.0/Makefile.PL,v retrieving revision 1.37 diff -u -r1.37 Makefile.PL --- Makefile.PL 2001/08/08

[patch] adding more checks

2001-08-25 Thread Stas Bekman
I've messed something and I've started to get some problems, so I've added these checks: Index: Apache-Test/lib/Apache/TestConfig.pm === RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v retrieving

scan's diff

2001-08-25 Thread Stas Bekman
With a small problem, 'make source_scan' works for me!!! I've attached the whole thing (and not inlined, since you can generate it yourself :)! I wanted to ask why on my side I seemingly get a better scanning. If you look at the snippet below, the previous var names seem to be "badly" parsed. @

Re: [patch] adjusting for API changes

2001-08-25 Thread Doug MacEachern
On Sun, 26 Aug 2001, Stas Bekman wrote: > > this patch is needed to build mod_perl with the latest httpd-2.0 please go ahead and commit, thanks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EM

Re: pushing method handlers by reference

2001-08-25 Thread Doug MacEachern
On Wed, 15 Aug 2001, Geoffrey Young wrote: > hi all... > > I just got around to fixing something that has been a splinter in my mind > for a while now... > > it all started with Andrew Ford documenting that push_handlers() didn't > work for method handlers. it turns out they work just fine

Re: apxs verifications checks

2001-08-25 Thread Doug MacEachern
On Wed, 22 Aug 2001, Stas Bekman wrote: > in the perlframework if you run perl Makefile.PL without passing apxs as > an argument or having it wrong, the whole thing goes havoc, the following > patch does the required testing: it is not a requirement that apxs is passed to Makefile.PL, that is ju

Re: Apache::ExtUtils patch

2001-08-25 Thread Doug MacEachern
On Wed, 22 Aug 2001, Geoffrey Young wrote: > hi all... > > this brief patch allows you to override container directives using the > func parameter in a Makefile.PL, as in thanks, that's in. - To unsubscribe, e-mail: [EMAIL

Re: [patch] make xs_generate

2001-08-25 Thread Doug MacEachern
On Sun, 26 Aug 2001, Stas Bekman wrote: > a patch to make 'make xs_generate' work stand-alone. +1 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

RE: pushing method handlers by reference

2001-08-25 Thread Geoffrey Young
> > > > the below patches allow the following formats, in > addition to what is > > already currently supported > > > > $r->push_handlers(PerlFixupHandler => My::Class->can('foo')); > > $r->set_handlers(PerlFixupHandler => [My::Class->can('foo')]); > > cool! i don't understand why univ

Re: [patch] Makefile.PL prerequisites

2001-08-25 Thread Doug MacEachern
On Sun, 26 Aug 2001, Stas Bekman wrote: > this patch adds the prerequisites checking functionality. Add more modules > as needed. > + 'Tie::IxHash' => "1.21", this is only required to run source scan. we will be distributing the already scanned tables, so this should be a nice to have, i g

Re: [patch] adding more checks

2001-08-25 Thread Doug MacEachern
On Sun, 26 Aug 2001, Stas Bekman wrote: > +# $thaw wasn't blessed > +if (ref $thaw eq 'HASH') { > +die "couldn't find apache_test_config.pm"; > +} > + this isn't right, it will die whenever things are clean. maybe you meant to do that only if $args->{thaw} ? > sub find_apa

Re: scan's diff

2001-08-25 Thread Doug MacEachern
On Sun, 26 Aug 2001, Stas Bekman wrote: > With a small problem, 'make source_scan' works for me!!! > > I've attached the whole thing (and not inlined, since you can generate it > yourself :)! > > I wanted to ask why on my side I seemingly get a better scanning. If you > look at the snippet belo

RE: pushing method handlers by reference

2001-08-25 Thread Doug MacEachern
On Sat, 25 Aug 2001, Geoffrey Young wrote: > cv = sv_2cv(sv, &stash, &gv, FALSE); > if (cv && (CvFLAGS(cv) & CVf_METHOD)) { > PUSHMARK(SP); > XPUSHs(newSVpv(HvNAME(stash),0)); > PUTBACK; > perl_call_sv(sv, G_METHOD); > } you should be able to use the current code: is_metho

RE: pushing method handlers by reference

2001-08-25 Thread Geoffrey Young
>you should be able to use the current code: >is_method = 1; #based on your check >pclass = HvNAME(stash); >method = GvNAME(CvGV(cv)); cool. ok, I'll work on it and see what I come up with... --Geoff - To unsubscribe, e-ma

Re: apxs verifications checks

2001-08-25 Thread Stas Bekman
On Sat, 25 Aug 2001, Doug MacEachern wrote: > On Wed, 22 Aug 2001, Stas Bekman wrote: > > > in the perlframework if you run perl Makefile.PL without passing apxs as > > an argument or having it wrong, the whole thing goes havoc, the following > > patch does the required testing: > > it is not a r

Re: [patch] Makefile.PL prerequisites

2001-08-25 Thread Stas Bekman
On Sat, 25 Aug 2001, Doug MacEachern wrote: > On Sun, 26 Aug 2001, Stas Bekman wrote: > > > this patch adds the prerequisites checking functionality. Add more modules > > as needed. > > > + 'Tie::IxHash' => "1.21", > > this is only required to run source scan. we will be distributing the > a