[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15543471#comment-15543471 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user lomoree closed the pull request at:

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537670#comment-15537670 ] James Taylor commented on PHOENIX-3264: --- Nice job, [~lomoree] & [~maryannxue] - this fixed 92 unit

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533807#comment-15533807 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user lomoree commented on a diff in the pull

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533770#comment-15533770 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533755#comment-15533755 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533744#comment-15533744 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user lomoree commented on a diff in the pull

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533743#comment-15533743 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user lomoree commented on a diff in the pull

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533724#comment-15533724 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533716#comment-15533716 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user lomoree commented on a diff in the pull

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533711#comment-15533711 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533710#comment-15533710 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user lomoree commented on a diff in the pull

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533705#comment-15533705 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user lomoree commented on a diff in the pull

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533605#comment-15533605 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533600#comment-15533600 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533599#comment-15533599 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533603#comment-15533603 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533602#comment-15533602 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533601#comment-15533601 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533604#comment-15533604 ] ASF GitHub Bot commented on PHOENIX-3264: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533016#comment-15533016 ] ASF GitHub Bot commented on PHOENIX-3264: - GitHub user lomoree opened a pull request:

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514734#comment-15514734 ] Maryann Xue commented on PHOENIX-3264: -- Thank you, [~julianhyde], for the solution! Actually it's

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513988#comment-15513988 ] Julian Hyde commented on PHOENIX-3264: -- Hopefully you can understand why I am pushing back and do

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513741#comment-15513741 ] Eric Lomore commented on PHOENIX-3264: -- The exprConverter field in SqlToRelConverter is the only

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513622#comment-15513622 ] Julian Hyde commented on PHOENIX-3264: -- Probably convertLiteral is intentionally private and there

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513605#comment-15513605 ] Eric Lomore commented on PHOENIX-3264: -- Thanks for the help everyone! There is one last piece that

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504370#comment-15504370 ] Julian Hyde commented on PHOENIX-3264: -- Yeah, you need to be in a particular environment (i.e.

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504354#comment-15504354 ] Eric Lomore commented on PHOENIX-3264: -- Hi Julian- Thanks that makes sense. I've looked into this

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494919#comment-15494919 ] Julian Hyde commented on PHOENIX-3264: -- The "Impl" in the class name is a clue that it is

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494816#comment-15494816 ] James Taylor commented on PHOENIX-3264: --- [~maryannxue] will know > Allow TRUE and FALSE to be

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494813#comment-15494813 ] Eric Lomore commented on PHOENIX-3264: -- Thanks James that makes it very clear :) [~julianhyde] you

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493977#comment-15493977 ] James Taylor commented on PHOENIX-3264: --- Once you have a RexNode, you'll need to: - convert from

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493928#comment-15493928 ] James Taylor commented on PHOENIX-3264: --- Here's a pointer to the CREATE TABLE commits:

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493902#comment-15493902 ] Eric Lomore commented on PHOENIX-3264: -- One of the queries it is failing for: Particularly, the

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[ https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491394#comment-15491394 ] Eric Lomore commented on PHOENIX-3264: -- As seen here, the Calcite SqlLiteral class doesn't have any