[jira] [Commented] (PHOENIX-3174) Make minor upgrade a manual step

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495003#comment-15495003
 ] 

Hadoop QA commented on PHOENIX-3174:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12828757/PHOENIX-3174_v3_master.patch
  against master branch at commit 2a223adfbeb32f598308da1dc6d3251ee0980d79.
  ATTACHMENT ID: 12828757

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
36 warning messages.

{color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+updateIndexState(indexTableFullName, env, 
PIndexState.DISABLE, PIndexState.INACTIVE);
+String indexTableFullName = 
SchemaUtil.getTableName(indexPTable.getSchemaName()
+updateIndexState(indexTableFullName, env, 
PIndexState.INACTIVE, PIndexState.ACTIVE);
+private static void updateIndexState(String indexTableName, 
RegionCoprocessorEnvironment env, PIndexState oldState,
+put.addColumn(PhoenixDatabaseMetaData.TABLE_FAMILY_BYTES, 
PhoenixDatabaseMetaData.INDEX_STATE_BYTES,
+put.addColumn(PhoenixDatabaseMetaData.TABLE_FAMILY_BYTES, 
PhoenixDatabaseMetaData.INDEX_DISABLE_TIMESTAMP_BYTES,
+if (code == MutationCode.TABLE_NOT_FOUND) { throw new 
TableNotFoundException(schemaName, indexName); }
+.setMessage(" currentState=" + oldState + ". requestedState=" 
+ newState).setSchemaName(schemaName)
+SQLExceptionCode.UPGRADE_REQUIRED.getSQLState(), 
SQLExceptionCode.UPGRADE_REQUIRED.getErrorCode());
+public PhoenixConnection(PhoenixConnection connection, boolean 
isDescRowKeyOrderUpgrade, boolean isRunningUpgrade) throws SQLException {

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableIndexToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CsvBulkLoadToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AutoPartitionViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AppendOnlySchemaIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.iterate.ScannerLeaseRenewalIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConnectionUtilIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.AsyncImmutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MapReduceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryTimeoutIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/579//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/579//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/579//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/579//console

This message is automatically generated.

> Make minor upgrade a manual step
> 
>
> Key: PHOENIX-3174
> URL: https://issues.apache.org/jira/browse/PHOENIX-3174
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: Samarth Jain
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3174.patch, PHOENIX-3174_v2.patch, 
> PHOENIX-3174_v3_master.patch
>
>
> Instead of automatically performing minor release upgrades to system tables 
> in an automated manner (on first connection), we should make upgrade a 
> separate manual step. If a newer client attempts to connect to a newer server 
> without the upgrade step having occurred, we'd fail the connection.
> Though not as automated, this would give users more control and visibility 
> into when an upgrade over system tables occurs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (PHOENIX-3287) SecureUserConnectionsTest is flapping

[James Taylor (JIRA)]

James Taylor created PHOENIX-3287:
-

 Summary: SecureUserConnectionsTest is flapping
 Key: PHOENIX-3287
 URL: https://issues.apache.org/jira/browse/PHOENIX-3287
 Project: Phoenix
  Issue Type: Bug
Reporter: James Taylor
Assignee: Josh Elser
Priority: Minor



Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 99.229 sec <<< 
FAILURE! - in org.apache.phoenix.jdbc.SecureUserConnectionsTest
org.apache.phoenix.jdbc.SecureUserConnectionsTest  Time elapsed: 99.229 sec  
<<< ERROR!
java.net.BindException: Address already in use

See https://builds.apache.org/job/Phoenix-master/1404/changes for example (and 
another earlier one). Wild guess, but maybe the port needs to be randomized? 
Can it be?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3174) Make minor upgrade a manual step

[James Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494978#comment-15494978
 ] 

James Taylor commented on PHOENIX-3174:
---

Looks really good, [~samarthjain]. Here's some feedback:
- Given that we plan to cut an RC for 4.8.1 very soon (on Monday), I think we 
should put this only in 4.9.0 (i.e. 4.x and master branches)
- Did you get a chance to manually test that server-side tracing continues to 
work when we have a newer server with an older client?
- I think it'd be good to start a DISCUSS thread pointing people to this JIRA 
to see if folks think perhaps the default should be to manually upgrade
- I think we should keep the {{if not exists}} here, only because there's a 
small race condition on the table creation. If we're not yet upgraded, it won't 
make a difference - you'll still get the error.
{code}
 private void createTable(Connection conn, String table) throws 
SQLException {
 // only primary-key columns can be marked non-null
 String ddl =
-"create table if not exists " + table + "( " +
+"create table " + table + "( " +
{code}
- Minor nit, but couldn't this be written more simply like this?
{code}
+private boolean traceTableExists(Connection conn, String traceTableName) 
throws SQLException {
+try {
+PhoenixRuntime.getTable(conn, traceTableName);
+return true;
+} catch (TableNotFoundException e) {
+return false;
+}
+}
{code}

+1 apart from those minor comments.

> Make minor upgrade a manual step
> 
>
> Key: PHOENIX-3174
> URL: https://issues.apache.org/jira/browse/PHOENIX-3174
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: Samarth Jain
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3174.patch, PHOENIX-3174_v2.patch, 
> PHOENIX-3174_v3_master.patch
>
>
> Instead of automatically performing minor release upgrades to system tables 
> in an automated manner (on first connection), we should make upgrade a 
> separate manual step. If a newer client attempts to connect to a newer server 
> without the upgrade step having occurred, we'd fail the connection.
> Though not as automated, this would give users more control and visibility 
> into when an upgrade over system tables occurs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (PHOENIX-3285) Add test name in Parameters name since failsafe uses that to form report file name

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor resolved PHOENIX-3285.
---
Resolution: Fixed
  Assignee: James Taylor

> Add test name in Parameters name since failsafe uses that to form report file 
> name
> --
>
> Key: PHOENIX-3285
> URL: https://issues.apache.org/jira/browse/PHOENIX-3285
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3285.patch
>
>
> To work around an apparent surefire bug, we need to add the test suite name 
> to the @Parameters name attribute so that runs from other test suites don't 
> override each other.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (PHOENIX-3249) Make changes in LocalIndexIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor resolved PHOENIX-3249.
---
Resolution: Fixed

> Make changes in  LocalIndexIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3249
> URL: https://issues.apache.org/jira/browse/PHOENIX-3249
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3249.patch
>
>
> Error Log
> {code}
>   
> LocalIndexIT.testBuildIndexWhenUserTableAlreadyHasData:280->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testDropLocalIndexShouldDeleteDataFromLocalIndexTable:619->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testDropLocalIndexTable:217->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testIndexPlanSelectionIfBothGlobalAndLocalIndexesHasSameColumnsAndOrder:596->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSaltingShouldFail:166->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSplitsShouldFail:147->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexRoundTrip:124->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testLocalIndexRowsShouldBeDeletedWhenUserTableRowsDeleted:665->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexScanWithInList:762->createBaseTable:99 » 
> PhoenixIO ...
>   LocalIndexIT.testLocalIndexScanWithSmallChunks:909->createBaseTable:99 » 
> PhoenixIO
>   LocalIndexIT.testLocalIndexScan:320->createBaseTable:99 » PhoenixIO 
> org.apache...
>   
> LocalIndexIT.testLocalIndexTableRegionSplitPolicyAndSplitKeys:187->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexesOnTableWithImmutableRows:715->createBaseTable:99 
> » PhoenixIO
>   LocalIndexIT.testPutsToLocalIndexTable:240->createBaseTable:99 » PhoenixIO 
> org...
>   
> LocalIndexIT.testScanWhenATableHasMultipleLocalIndexes:690->createBaseTable:99
>  » PhoenixIO
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3253) Make changes to BaseHBaseTimeManagedIT tests to support method level parallelization

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494930#comment-15494930
 ] 

Hudson commented on PHOENIX-3253:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1404 (See 
[https://builds.apache.org/job/Phoenix-master/1404/])
PHOENIX-3253 Make changes to BaseHBaseTimeManagedIT tests to support 
(jamestaylor: rev 1a3bd43a595f3ba23db823486f476c31e890b3d2)
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTracingEndToEndIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/tx/TransactionIT.java


> Make changes to BaseHBaseTimeManagedIT tests to support method level 
> parallelization
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch, PHOENIX-3253_addendum1.patch
>
>
> Changes are necessary in our BaseHBaseTimeManagedIT tests to ensure that they 
> can run in parallel:
> - Using unique table names in all tests
> - Removing any usage of BaseTest.ensureTableCreated()
> - Change static methods and member variables to be instance level
> - Remove any required state dependencies between tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3286) Use regular queue depth instead of overriding it to zero for tests

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494929#comment-15494929
 ] 

Hudson commented on PHOENIX-3286:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1404 (See 
[https://builds.apache.org/job/Phoenix-master/1404/])
PHOENIX-3286 Use regular queue depth instead of overriding it to zero 
(jamestaylor: rev a4ebcfdd262dcc311f96a80c3dd47290bce2c236)
* (edit) 
phoenix-core/src/test/java/org/apache/phoenix/query/QueryServicesTestImpl.java


> Use regular queue depth instead of overriding it to zero for tests
> --
>
> Key: PHOENIX-3286
> URL: https://issues.apache.org/jira/browse/PHOENIX-3286
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: PHOENIX-3286.patch
>
>
> Setting the queue depth to zero makes our thread pool synchronized which 
> won't work when parallelizing the tests. We should remove that override and 
> just use the default value for that. The thread pool size is higher than we 
> need it as well. We should lower that to value of around 10.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3249) Make changes in LocalIndexIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494927#comment-15494927
 ] 

Hudson commented on PHOENIX-3249:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1404 (See 
[https://builds.apache.org/job/Phoenix-master/1404/])
PHOENIX-3249 Make changes in LocalIndexIT for method level (jamestaylor: rev 
b0f900488dec92d0eaac8e2576991281e78984f5)
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java
* (delete) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/AsyncImmutableIndexIT.java
* (add) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexOnOwnClusterIT.java


> Make changes in  LocalIndexIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3249
> URL: https://issues.apache.org/jira/browse/PHOENIX-3249
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Attachments: PHOENIX-3249.patch
>
>
> Error Log
> {code}
>   
> LocalIndexIT.testBuildIndexWhenUserTableAlreadyHasData:280->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testDropLocalIndexShouldDeleteDataFromLocalIndexTable:619->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testDropLocalIndexTable:217->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testIndexPlanSelectionIfBothGlobalAndLocalIndexesHasSameColumnsAndOrder:596->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSaltingShouldFail:166->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSplitsShouldFail:147->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexRoundTrip:124->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testLocalIndexRowsShouldBeDeletedWhenUserTableRowsDeleted:665->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexScanWithInList:762->createBaseTable:99 » 
> PhoenixIO ...
>   LocalIndexIT.testLocalIndexScanWithSmallChunks:909->createBaseTable:99 » 
> PhoenixIO
>   LocalIndexIT.testLocalIndexScan:320->createBaseTable:99 » PhoenixIO 
> org.apache...
>   
> LocalIndexIT.testLocalIndexTableRegionSplitPolicyAndSplitKeys:187->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexesOnTableWithImmutableRows:715->createBaseTable:99 
> » PhoenixIO
>   LocalIndexIT.testPutsToLocalIndexTable:240->createBaseTable:99 » PhoenixIO 
> org...
>   
> LocalIndexIT.testScanWhenATableHasMultipleLocalIndexes:690->createBaseTable:99
>  » PhoenixIO
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3285) Add test name in Parameters name since failsafe uses that to form report file name

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494928#comment-15494928
 ] 

Hudson commented on PHOENIX-3285:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1404 (See 
[https://builds.apache.org/job/Phoenix-master/1404/])
PHOENIX-3285 Add test name in Parameters name since failsafe uses that 
(jamestaylor: rev 4c8bda1510606148e6d3d5154ed9004098ff239d)
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/AutoPartitionViewsIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/GroupByIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/DropSchemaIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/SequenceBulkAllocationIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/txn/TxWriteFailureIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantIdTypeIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexOnOwnClusterIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/NotQueryIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/CastAndCoerceIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/tx/TxCheckpointIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/CaseStatementIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ScanQueryIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/txn/MutableRollbackIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/txn/RollbackIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ReadOnlyIndexFailureIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/execute/PartialCommitIT.java


> Add test name in Parameters name since failsafe uses that to form report file 
> name
> --
>
> Key: PHOENIX-3285
> URL: https://issues.apache.org/jira/browse/PHOENIX-3285
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3285.patch
>
>
> To work around an apparent surefire bug, we need to add the test suite name 
> to the @Parameters name attribute so that runs from other test suites don't 
> override each other.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[Julian Hyde (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494919#comment-15494919
 ] 

Julian Hyde commented on PHOENIX-3264:
--

The "Impl" in the class name is a clue that it is deliberately hidden. 
{{SqlToRelConverter}} instantiates a {{SqlNodeToRexConverterImpl}}, and uses it 
in various places, notably the {{convertLiteral}} method. If you have access to 
a {{SqlToRelConverter}} I suspect you could use that method.

> Allow TRUE and FALSE to be used as literal constants
> 
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: SqlLiteral.png, SqlNodeToRexConverterImpl.png, 
> SqlOptionNode.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3285) Add test name in Parameters name since failsafe uses that to form report file name

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3285:
--
Fix Version/s: 4.9.0

> Add test name in Parameters name since failsafe uses that to form report file 
> name
> --
>
> Key: PHOENIX-3285
> URL: https://issues.apache.org/jira/browse/PHOENIX-3285
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3285.patch
>
>
> To work around an apparent surefire bug, we need to add the test suite name 
> to the @Parameters name attribute so that runs from other test suites don't 
> override each other.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3285) Add test name in Parameters name since failsafe uses that to form report file name

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3285:
--
Attachment: PHOENIX-3285.patch

> Add test name in Parameters name since failsafe uses that to form report file 
> name
> --
>
> Key: PHOENIX-3285
> URL: https://issues.apache.org/jira/browse/PHOENIX-3285
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3285.patch
>
>
> To work around an apparent surefire bug, we need to add the test suite name 
> to the @Parameters name attribute so that runs from other test suites don't 
> override each other.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3249) Make changes in LocalIndexIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3249:
--
Attachment: PHOENIX-3249.patch

Work around hanging caused by two LocalIndexIT tests when run in parallel by 
moving them into another IT that runs in it's own cluster.

> Make changes in  LocalIndexIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3249
> URL: https://issues.apache.org/jira/browse/PHOENIX-3249
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Attachments: PHOENIX-3249.patch
>
>
> Error Log
> {code}
>   
> LocalIndexIT.testBuildIndexWhenUserTableAlreadyHasData:280->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testDropLocalIndexShouldDeleteDataFromLocalIndexTable:619->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testDropLocalIndexTable:217->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testIndexPlanSelectionIfBothGlobalAndLocalIndexesHasSameColumnsAndOrder:596->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSaltingShouldFail:166->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSplitsShouldFail:147->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexRoundTrip:124->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testLocalIndexRowsShouldBeDeletedWhenUserTableRowsDeleted:665->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexScanWithInList:762->createBaseTable:99 » 
> PhoenixIO ...
>   LocalIndexIT.testLocalIndexScanWithSmallChunks:909->createBaseTable:99 » 
> PhoenixIO
>   LocalIndexIT.testLocalIndexScan:320->createBaseTable:99 » PhoenixIO 
> org.apache...
>   
> LocalIndexIT.testLocalIndexTableRegionSplitPolicyAndSplitKeys:187->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexesOnTableWithImmutableRows:715->createBaseTable:99 
> » PhoenixIO
>   LocalIndexIT.testPutsToLocalIndexTable:240->createBaseTable:99 » PhoenixIO 
> org...
>   
> LocalIndexIT.testScanWhenATableHasMultipleLocalIndexes:690->createBaseTable:99
>  » PhoenixIO
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (PHOENIX-3249) Make changes in LocalIndexIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor reassigned PHOENIX-3249:
-

Assignee: James Taylor

> Make changes in  LocalIndexIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3249
> URL: https://issues.apache.org/jira/browse/PHOENIX-3249
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
>
> Error Log
> {code}
>   
> LocalIndexIT.testBuildIndexWhenUserTableAlreadyHasData:280->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testDropLocalIndexShouldDeleteDataFromLocalIndexTable:619->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testDropLocalIndexTable:217->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testIndexPlanSelectionIfBothGlobalAndLocalIndexesHasSameColumnsAndOrder:596->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSaltingShouldFail:166->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSplitsShouldFail:147->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexRoundTrip:124->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testLocalIndexRowsShouldBeDeletedWhenUserTableRowsDeleted:665->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexScanWithInList:762->createBaseTable:99 » 
> PhoenixIO ...
>   LocalIndexIT.testLocalIndexScanWithSmallChunks:909->createBaseTable:99 » 
> PhoenixIO
>   LocalIndexIT.testLocalIndexScan:320->createBaseTable:99 » PhoenixIO 
> org.apache...
>   
> LocalIndexIT.testLocalIndexTableRegionSplitPolicyAndSplitKeys:187->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexesOnTableWithImmutableRows:715->createBaseTable:99 
> » PhoenixIO
>   LocalIndexIT.testPutsToLocalIndexTable:240->createBaseTable:99 » PhoenixIO 
> org...
>   
> LocalIndexIT.testScanWhenATableHasMultipleLocalIndexes:690->createBaseTable:99
>  » PhoenixIO
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3174) Make minor upgrade a manual step

[Samarth Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Samarth Jain updated PHOENIX-3174:
--
Attachment: PHOENIX-3174_v3_master.patch

Updated patch that introduces a new EXECUTE UPGRADE statement. For now, by 
default, we allow phoenix clients to automatically run upgrades. It can be 
controlled by setting phoenix.autoupgrade.enable to false in the 
hbase-site.xml. When a new client connects to the cluster, it isn't able to 
execute any SQL unless EXECUTE UPGRADE is run to upgrade the metadata. To make 
sure Phoenix's internal background services like index rebuild and tracing 
still work, I have changed the code to use HBase or lower level Phoenix API. 
For ex - for tracing,  I changed it use a lower level API (MutationPlan and 
MutationState) so that traces could still be inserted into the trace table.

[~jamestaylor] - please review.

> Make minor upgrade a manual step
> 
>
> Key: PHOENIX-3174
> URL: https://issues.apache.org/jira/browse/PHOENIX-3174
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: Samarth Jain
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3174.patch, PHOENIX-3174_v2.patch, 
> PHOENIX-3174_v3_master.patch
>
>
> Instead of automatically performing minor release upgrades to system tables 
> in an automated manner (on first connection), we should make upgrade a 
> separate manual step. If a newer client attempts to connect to a newer server 
> without the upgrade step having occurred, we'd fail the connection.
> Though not as automated, this would give users more control and visibility 
> into when an upgrade over system tables occurs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[James Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494816#comment-15494816
 ] 

James Taylor commented on PHOENIX-3264:
---

[~maryannxue] will know

> Allow TRUE and FALSE to be used as literal constants
> 
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: SqlLiteral.png, SqlNodeToRexConverterImpl.png, 
> SqlOptionNode.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[Eric Lomore (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494813#comment-15494813
 ] 

Eric Lomore commented on PHOENIX-3264:
--

Thanks James that makes it very clear :)
[~julianhyde] you  mentioned using SqlNodeToRexConverterImpl to do the 
conversion.
On the calcite side, its constructor has no access identifier, and hence can't 
be accessed by the phoenix package.
I have been unable to circumvent this through other means - do you have any 
thoughts or is there something I am missing?

!SqlNodeToRexConverterImpl.png!
Thanks very much!





> Allow TRUE and FALSE to be used as literal constants
> 
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: SqlLiteral.png, SqlNodeToRexConverterImpl.png, 
> SqlOptionNode.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[Eric Lomore (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Lomore updated PHOENIX-3264:
-
Attachment: SqlNodeToRexConverterImpl.png

> Allow TRUE and FALSE to be used as literal constants
> 
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: SqlLiteral.png, SqlNodeToRexConverterImpl.png, 
> SqlOptionNode.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3253) Make changes to BaseHBaseTimeManagedIT tests to support method level parallelization

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3253:
--
Attachment: PHOENIX-3253_addendum1.patch

> Make changes to BaseHBaseTimeManagedIT tests to support method level 
> parallelization
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch, PHOENIX-3253_addendum1.patch
>
>
> Changes are necessary in our BaseHBaseTimeManagedIT tests to ensure that they 
> can run in parallel:
> - Using unique table names in all tests
> - Removing any usage of BaseTest.ensureTableCreated()
> - Change static methods and member variables to be instance level
> - Remove any required state dependencies between tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3253) Make changes to BaseHBaseTimeManagedIT tests to support method level parallelization

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3253:
--
Summary: Make changes to BaseHBaseTimeManagedIT tests to support method 
level parallelization  (was: Make changes to support method level 
parallelization)

> Make changes to BaseHBaseTimeManagedIT tests to support method level 
> parallelization
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch
>
>
> Changes are necessary in our BaseHBaseTimeManagedIT tests to ensure that they 
> can run in parallel:
> - Using unique table names in all tests
> - Removing any usage of BaseTest.ensureTableCreated()
> - Change static methods and member variables to be instance level
> - Remove any required state dependencies between tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3253) Make changes to support method level parallelization

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3253:
--
Description: 
Changes are necessary in our BaseHBaseTimeManagedIT tests to ensure that they 
can run in parallel:
- Using unique table names in all tests
- Removing any usage of BaseTest.ensureTableCreated()
- Change static methods and member variables to be instance level
- Remove any required state dependencies between tests

  was:
error log
{code}  
GroupByCaseIT.testScanUri:172 expected: but was:
   StoreNullsIT.testQueryingHistory:116
  PhoenixTraceReaderIT.testMultipleSpans:122->validateTraces:132 Got an 
unexpected traceid expected:<12345> but was:<987654>
  TransactionIT.testTxnClosedCorrecty:152 There should be no invalid 
transactions
  DynamicUpsertIT.testFullUpsert:152 expected:<[a]Value> but was:<[DynCol]Value>
{code}


> Make changes to support method level parallelization
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch
>
>
> Changes are necessary in our BaseHBaseTimeManagedIT tests to ensure that they 
> can run in parallel:
> - Using unique table names in all tests
> - Removing any usage of BaseTest.ensureTableCreated()
> - Change static methods and member variables to be instance level
> - Remove any required state dependencies between tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3253) Make changes to support method level parallelization

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3253:
--
Summary: Make changes to support method level parallelization  (was: Make 
changes in various classes for method level parallelization in 
BaseHBaseManagedTimeTableReuseIT)

> Make changes to support method level parallelization
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch
>
>
> error log
> {code}  
> GroupByCaseIT.testScanUri:172 expected: but was:
>StoreNullsIT.testQueryingHistory:116
>   PhoenixTraceReaderIT.testMultipleSpans:122->validateTraces:132 Got an 
> unexpected traceid expected:<12345> but was:<987654>
>   TransactionIT.testTxnClosedCorrecty:152 There should be no invalid 
> transactions
>   DynamicUpsertIT.testFullUpsert:152 expected:<[a]Value> but 
> was:<[DynCol]Value>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (PHOENIX-3253) Make changes to support method level parallelization

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor reopened PHOENIX-3253:
---

> Make changes to support method level parallelization
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch
>
>
> error log
> {code}  
> GroupByCaseIT.testScanUri:172 expected: but was:
>StoreNullsIT.testQueryingHistory:116
>   PhoenixTraceReaderIT.testMultipleSpans:122->validateTraces:132 Got an 
> unexpected traceid expected:<12345> but was:<987654>
>   TransactionIT.testTxnClosedCorrecty:152 There should be no invalid 
> transactions
>   DynamicUpsertIT.testFullUpsert:152 expected:<[a]Value> but 
> was:<[DynCol]Value>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3286) Use regular queue depth instead of overriding it to zero for tests

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3286:
--
Attachment: PHOENIX-3286.patch

> Use regular queue depth instead of overriding it to zero for tests
> --
>
> Key: PHOENIX-3286
> URL: https://issues.apache.org/jira/browse/PHOENIX-3286
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: PHOENIX-3286.patch
>
>
> Setting the queue depth to zero makes our thread pool synchronized which 
> won't work when parallelizing the tests. We should remove that override and 
> just use the default value for that. The thread pool size is higher than we 
> need it as well. We should lower that to value of around 10.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3286) Use regular queue depth instead of overriding it to zero for tests

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3286:
--
Description: Setting the queue depth to zero makes our thread pool 
synchronized which won't work when parallelizing the tests. We should remove 
that override and just use the default value for that. The thread pool size is 
higher than we need it as well. We should lower that to value of around 10.  
(was: Setting the queue depth to zero makes our thread pool synchronized which 
won't work when parallelizing the tests. We should remove that override and 
just use the default value for that.)

> Use regular queue depth instead of overriding it to zero for tests
> --
>
> Key: PHOENIX-3286
> URL: https://issues.apache.org/jira/browse/PHOENIX-3286
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>
> Setting the queue depth to zero makes our thread pool synchronized which 
> won't work when parallelizing the tests. We should remove that override and 
> just use the default value for that. The thread pool size is higher than we 
> need it as well. We should lower that to value of around 10.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (PHOENIX-3286) Use regular queue depth instead of overriding it to zero for tests

[James Taylor (JIRA)]

James Taylor created PHOENIX-3286:
-

 Summary: Use regular queue depth instead of overriding it to zero 
for tests
 Key: PHOENIX-3286
 URL: https://issues.apache.org/jira/browse/PHOENIX-3286
 Project: Phoenix
  Issue Type: Sub-task
Reporter: James Taylor


Setting the queue depth to zero makes our thread pool synchronized which won't 
work when parallelizing the tests. We should remove that override and just use 
the default value for that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (PHOENIX-3285) Add test name in Parameters name since failsafe uses that to form report file name

[James Taylor (JIRA)]

James Taylor created PHOENIX-3285:
-

 Summary: Add test name in Parameters name since failsafe uses that 
to form report file name
 Key: PHOENIX-3285
 URL: https://issues.apache.org/jira/browse/PHOENIX-3285
 Project: Phoenix
  Issue Type: Sub-task
Reporter: James Taylor


To work around an apparent surefire bug, we need to add the test suite name to 
the @Parameters name attribute so that runs from other test suites don't 
override each other.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3140) Convert UpgradeIT to be derived from BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3140:
--
Summary: Convert UpgradeIT to be derived from 
BaseHBaseManagedTimeTableReuseIT  (was: UpgradeIT.java -> 
testSettingBaseColumnCountForMultipleViewsOnTable() fails randomly with 
randomized tenantViewName and TableReuse class)

> Convert UpgradeIT to be derived from BaseHBaseManagedTimeTableReuseIT
> -
>
> Key: PHOENIX-3140
> URL: https://issues.apache.org/jira/browse/PHOENIX-3140
> Project: Phoenix
>  Issue Type: Bug
>Reporter: prakul agarwal
>Assignee: prakul agarwal
>Priority: Minor
> Attachments: UpgradeIT.diff
>
>
> Stacktrace:
> {code}
> java.lang.AssertionError: 
> Expected :-100
> Actual   :0
>  
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:645)
>   at org.junit.Assert.assertEquals(Assert.java:631)
>   at 
> org.apache.phoenix.end2end.UpgradeIT.checkBaseColumnCount(UpgradeIT.java:555)
>   at 
> org.apache.phoenix.end2end.UpgradeIT.testSettingBaseColumnCountForMultipleViewsOnTable(UpgradeIT.java:453)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3140) Convert UpgradeIT to be derived from BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3140:
--
Issue Type: Sub-task  (was: Bug)
Parent: PHOENIX-3181

> Convert UpgradeIT to be derived from BaseHBaseManagedTimeTableReuseIT
> -
>
> Key: PHOENIX-3140
> URL: https://issues.apache.org/jira/browse/PHOENIX-3140
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: prakul agarwal
>Priority: Minor
> Attachments: UpgradeIT.diff
>
>
> Stacktrace:
> {code}
> java.lang.AssertionError: 
> Expected :-100
> Actual   :0
>  
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:645)
>   at org.junit.Assert.assertEquals(Assert.java:631)
>   at 
> org.apache.phoenix.end2end.UpgradeIT.checkBaseColumnCount(UpgradeIT.java:555)
>   at 
> org.apache.phoenix.end2end.UpgradeIT.testSettingBaseColumnCountForMultipleViewsOnTable(UpgradeIT.java:453)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3153) Convert join-related IT tests to be derived from BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3153:
--
Issue Type: Sub-task  (was: Task)
Parent: PHOENIX-3181

> Convert join-related IT tests to be derived from 
> BaseHBaseManagedTimeTableReuseIT
> -
>
> Key: PHOENIX-3153
> URL: https://issues.apache.org/jira/browse/PHOENIX-3153
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Priority: Minor
>
> The following 5 test cases follow same pattern (initJoinTableValues method 
> for table generation) and are still extending BaseHBaseManagedTimeIT .
> HashJoinIt
> SortMergeJoinIT
> HashJoinLocal index
> SubqueryIT
> SubqueryUsingSortMergeJoinIT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3153) Convert join-related IT tests to be derived from BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3153:
--
Assignee: (was: prakul agarwal)

> Convert join-related IT tests to be derived from 
> BaseHBaseManagedTimeTableReuseIT
> -
>
> Key: PHOENIX-3153
> URL: https://issues.apache.org/jira/browse/PHOENIX-3153
> Project: Phoenix
>  Issue Type: Task
>Reporter: prakul agarwal
>Priority: Minor
>
> The following 5 test cases follow same pattern (initJoinTableValues method 
> for table generation) and are still extending BaseHBaseManagedTimeIT .
> HashJoinIt
> SortMergeJoinIT
> HashJoinLocal index
> SubqueryIT
> SubqueryUsingSortMergeJoinIT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3036) Modify BaseHBaseTimeManagedIT tests to extend BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3036:
--
Summary: Modify BaseHBaseTimeManagedIT tests to extend 
BaseHBaseManagedTimeTableReuseIT  (was: Modify BaseHBaseManagedTimeIT tests to 
extend BaseHBaseManagedTimeTableReuseIT)

> Modify BaseHBaseTimeManagedIT tests to extend BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3036
> URL: https://issues.apache.org/jira/browse/PHOENIX-3036
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Samarth Jain
>Assignee: prakul agarwal
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3036.patch, PHOENIX-3036_4.x-HBase-1.1.patch, 
> PHOENIX-3036_addendum.patch, PHOENIX-3036_addendum2.patch, 
> PHOENIX-3036_master.patch, PHOENIX-3036_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3036) Modify BaseHBaseManagedTimeIT tests to extend BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3036:
--
Summary: Modify BaseHBaseManagedTimeIT tests to extend 
BaseHBaseManagedTimeTableReuseIT  (was: Modify phoenix IT tests to extend 
BaseHBaseManagedTimeTableReuseIT)

> Modify BaseHBaseManagedTimeIT tests to extend BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3036
> URL: https://issues.apache.org/jira/browse/PHOENIX-3036
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Samarth Jain
>Assignee: prakul agarwal
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3036.patch, PHOENIX-3036_4.x-HBase-1.1.patch, 
> PHOENIX-3036_addendum.patch, PHOENIX-3036_addendum2.patch, 
> PHOENIX-3036_master.patch, PHOENIX-3036_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3036) Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3036:
--
Assignee: prakul agarwal  (was: Samarth Jain)

> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3036
> URL: https://issues.apache.org/jira/browse/PHOENIX-3036
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Samarth Jain
>Assignee: prakul agarwal
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3036.patch, PHOENIX-3036_4.x-HBase-1.1.patch, 
> PHOENIX-3036_addendum.patch, PHOENIX-3036_addendum2.patch, 
> PHOENIX-3036_master.patch, PHOENIX-3036_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: I want to provide a module that provides the unshaded version of the jdbc client.

[Nick Dimiduk]

So how is no shading better than this partial shading? You'd end up with
the same conflicts, no?

As far as I know, a JDBC implementation exposes nothing outside java.sql.*.
Anything else exposed by the shaded jar is probably a bug. Can you provide
more details on what you're seeing, or -- better still -- file a JIRA?

On Thu, Sep 15, 2016 at 11:45 AM, Marco Villalobos <
mvillalo...@kineteque.com> wrote:

> Not all of its dependencies are repackaged though, which leads to
> class loading conflicts.  When is that ever a good thing?
>
> On Thu, Sep 15, 2016 at 9:28 AM, Nick Dimiduk  wrote:
> > Maybe I'm missing something, but...
> >
> > The whole point of providing a shaded client jar is to prevent exposing
> > Phoenix implementation details to the applications that consume it --
> > effectively allowing people to manage their own dependencies. Using a
> > shaded client jar means you don't have to worry about dependency conflict
> > because by definition there's only one dependency: the shaded client.
> What
> > are you able to achieve now with, say, the 4.7.0 unshaded client that you
> > cannot with the new 4.8.0 shaded client?
> >
> > Thanks for the explanation.
> > -n
> >
> > On Thu, Sep 15, 2016 at 7:56 AM, Marco Villalobos <
> mvillalo...@kineteque.com
> >> wrote:
> >
> >> Good morning.
> >>
> >> I want to provide a module that provides the unshaded version of the
> jdbc
> >> client.
> >>
> >> This will allow people to manage their own dependencies without worry of
> >> conflict.
> >>
> >> -Marco.
> >>
> >>
> >>
>

[jira] [Reopened] (PHOENIX-3115) Create e2e workflow test for async secondary mr based index building

[Loknath Priyatham Teja Singamsetty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Loknath Priyatham Teja Singamsetty  reopened PHOENIX-3115:
--

> Create e2e workflow test for async secondary mr based index building 
> -
>
> Key: PHOENIX-3115
> URL: https://issues.apache.org/jira/browse/PHOENIX-3115
> Project: Phoenix
>  Issue Type: Test
>Reporter: Loknath Priyatham Teja Singamsetty 
>Assignee: Loknath Priyatham Teja Singamsetty 
>
> Need for e2e workflow test for async secondary mr based index building 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (PHOENIX-3115) Create e2e workflow test for async secondary mr based index building

[Loknath Priyatham Teja Singamsetty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Loknath Priyatham Teja Singamsetty  resolved PHOENIX-3115.
--
Resolution: Later

> Create e2e workflow test for async secondary mr based index building 
> -
>
> Key: PHOENIX-3115
> URL: https://issues.apache.org/jira/browse/PHOENIX-3115
> Project: Phoenix
>  Issue Type: Test
>Reporter: Loknath Priyatham Teja Singamsetty 
>Assignee: Loknath Priyatham Teja Singamsetty 
>
> Need for e2e workflow test for async secondary mr based index building 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: I want to provide a module that provides the unshaded version of the jdbc client.

[Marco Villalobos]

Not all of its dependencies are repackaged though, which leads to
class loading conflicts.  When is that ever a good thing?

On Thu, Sep 15, 2016 at 9:28 AM, Nick Dimiduk  wrote:
> Maybe I'm missing something, but...
>
> The whole point of providing a shaded client jar is to prevent exposing
> Phoenix implementation details to the applications that consume it --
> effectively allowing people to manage their own dependencies. Using a
> shaded client jar means you don't have to worry about dependency conflict
> because by definition there's only one dependency: the shaded client. What
> are you able to achieve now with, say, the 4.7.0 unshaded client that you
> cannot with the new 4.8.0 shaded client?
>
> Thanks for the explanation.
> -n
>
> On Thu, Sep 15, 2016 at 7:56 AM, Marco Villalobos > wrote:
>
>> Good morning.
>>
>> I want to provide a module that provides the unshaded version of the jdbc
>> client.
>>
>> This will allow people to manage their own dependencies without worry of
>> conflict.
>>
>> -Marco.
>>
>>
>>

[jira] [Commented] (PHOENIX-2930) Cannot resolve columns aliased to its own name

[Maryann Xue (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494094#comment-15494094
 ] 

Maryann Xue commented on PHOENIX-2930:
--

Sorry, [~an...@apache.org], I somehow missed [~jamestaylor]'s ping for this 
issue. I think the fix should be in the resolver instead of in the 
ParseNodeRewriter or anywhere else. You were getting an 
AmbiguousColumnException and you wanted the alias to take precedence over the 
original column name. So looks like we need to build that logic into the 
ColumnResolver. I'll also take a look to see how to implement it.

> Cannot resolve columns aliased to its own name
> --
>
> Key: PHOENIX-2930
> URL: https://issues.apache.org/jira/browse/PHOENIX-2930
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.4.0
>Reporter: Kevin Liew
>Assignee: Ankit Singhal
>  Labels: alias
> Fix For: 4.9.0
>
> Attachments: PHOENIX-2930.patch
>
>
> Tableau generates queries that alias a fully-qualified column name to its 
> shortened name.
> Similar to:
> {code}
> create table test (pk integer primary key);
> select test.pk as pk from test group by pk;
> {code}
> Phoenix reports:
> {code}
> 8org.apache.calcite.avatica.proto.Responses$ErrorResponse¨
> ðjava.lang.RuntimeException: 
> org.apache.phoenix.schema.AmbiguousColumnException: ERROR 502 (42702): Column 
> reference ambiguous or duplicate names. columnName=PK
>   at org.apache.calcite.avatica.jdbc.JdbcMeta.propagate(JdbcMeta.java:671)
>   at org.apache.calcite.avatica.jdbc.JdbcMeta.prepare(JdbcMeta.java:695)
>   at 
> org.apache.calcite.avatica.remote.LocalService.apply(LocalService.java:208)
>   at 
> org.apache.calcite.avatica.remote.Service$PrepareRequest.accept(Service.java:1157)
>   at 
> org.apache.calcite.avatica.remote.Service$PrepareRequest.accept(Service.java:1131)
>   at 
> org.apache.calcite.avatica.remote.AbstractHandler.apply(AbstractHandler.java:95)
>   at 
> org.apache.calcite.avatica.remote.ProtobufHandler.apply(ProtobufHandler.java:46)
>   at 
> org.apache.calcite.avatica.server.AvaticaProtobufHandler.handle(AvaticaProtobufHandler.java:127)
>   at 
> org.eclipse.jetty.server.handler.HandlerList.handle(HandlerList.java:52)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
>   at org.eclipse.jetty.server.Server.handle(Server.java:499)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
>   at 
> org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
>   at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
>   at 
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: org.apache.phoenix.schema.AmbiguousColumnException: ERROR 502 
> (42702): Column reference ambiguous or duplicate names. columnName=PK
>   at 
> org.apache.phoenix.parse.ParseNodeRewriter.visit(ParseNodeRewriter.java:406)
>   at 
> org.apache.phoenix.compile.StatementNormalizer.visit(StatementNormalizer.java:177)
>   at 
> org.apache.phoenix.compile.StatementNormalizer.visit(StatementNormalizer.java:58)
>   at 
> org.apache.phoenix.parse.ColumnParseNode.accept(ColumnParseNode.java:56)
>   at 
> org.apache.phoenix.parse.ParseNodeRewriter.rewrite(ParseNodeRewriter.java:111)
>   at 
> org.apache.phoenix.compile.StatementNormalizer.normalize(StatementNormalizer.java:107)
>   at 
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableSelectStatement.compilePlan(PhoenixStatement.java:398)
>   at 
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableSelectStatement.compilePlan(PhoenixStatement.java:378)
>   at 
> org.apache.phoenix.jdbc.PhoenixPreparedStatement.getMetaData(PhoenixPreparedStatement.java:223)
>   at org.apache.calcite.avatica.jdbc.JdbcMeta.prepare(JdbcMeta.java:689)
>   ... 15 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3284) Track incompatibilities between Calcite/Phoenix and Phoenix

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3284:
--
Issue Type: Task  (was: Sub-task)
Parent: (was: PHOENIX-3104)

> Track incompatibilities between Calcite/Phoenix and Phoenix
> ---
>
> Key: PHOENIX-3284
> URL: https://issues.apache.org/jira/browse/PHOENIX-3284
> Project: Phoenix
>  Issue Type: Task
>Reporter: James Taylor
>  Labels: calcite
>
> As we get deeper into moving Phoenix to run on top of Calcite, we may find 
> non standard Phoenix-specific syntax which we don't want to support in 
> Phoenix/Calcite. An example might be not supporting != but requiring these to 
> be changed to <>.  This epic JIRA can serve as the root for tracking purposes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (PHOENIX-3283) Track incompatibilities between Calcite/Phoenix and Phoenix

[James Taylor (JIRA)]

James Taylor created PHOENIX-3283:
-

 Summary: Track incompatibilities between Calcite/Phoenix and 
Phoenix
 Key: PHOENIX-3283
 URL: https://issues.apache.org/jira/browse/PHOENIX-3283
 Project: Phoenix
  Issue Type: Sub-task
Reporter: James Taylor


As we get deeper into moving Phoenix to run on top of Calcite, we may find non 
standard Phoenix-specific syntax which we don't want to support in 
Phoenix/Calcite. An example might be not supporting != but requiring these to 
be changed to <>.  This epic JIRA can serve as the root for tracking purposes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (PHOENIX-3284) Track incompatibilities between Calcite/Phoenix and Phoenix

[James Taylor (JIRA)]

James Taylor created PHOENIX-3284:
-

 Summary: Track incompatibilities between Calcite/Phoenix and 
Phoenix
 Key: PHOENIX-3284
 URL: https://issues.apache.org/jira/browse/PHOENIX-3284
 Project: Phoenix
  Issue Type: Sub-task
Reporter: James Taylor


As we get deeper into moving Phoenix to run on top of Calcite, we may find non 
standard Phoenix-specific syntax which we don't want to support in 
Phoenix/Calcite. An example might be not supporting != but requiring these to 
be changed to <>.  This epic JIRA can serve as the root for tracking purposes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[James Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493977#comment-15493977
 ] 

James Taylor commented on PHOENIX-3264:
---

Once you have a RexNode, you'll need to:
- convert from RexNode to Expression ([~maryannxue] can point you to this)
- evaluate the Expression using 
ExpressionUtil.getConstantExpression(expression,ptr);
- convert the bytes of ptr to an Object using 
expression.getDataType().toObject(ptr);

> Allow TRUE and FALSE to be used as literal constants
> 
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: SqlLiteral.png, SqlOptionNode.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[James Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493928#comment-15493928
 ] 

James Taylor commented on PHOENIX-3264:
---

Here's a pointer to the CREATE TABLE commits:
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=be86d1fb2831d6e4c34501bb23869ffed4cf1e81
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=fd579c1b8276d58cccd482177ec41308be1ddff4

> Allow TRUE and FALSE to be used as literal constants
> 
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: SqlLiteral.png, SqlOptionNode.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[Eric Lomore (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Lomore updated PHOENIX-3264:
-
Attachment: stacktrace.png

> Allow TRUE and FALSE to be used as literal constants
> 
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: SqlLiteral.png, SqlOptionNode.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3264) Allow TRUE and FALSE to be used as literal constants

[Eric Lomore (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493902#comment-15493902
 ] 

Eric Lomore commented on PHOENIX-3264:
--

One of the queries it is failing for:
Particularly, the IMMUTABLE_ROWS=true

conn.createStatement().execute("CREATE TABLE FOO(\n" + 
"a VARCHAR NOT NULL,\n" + 
"b TIMESTAMP NOT NULL,\n" + 
"c VARCHAR,\n" + 
"CONSTRAINT pk PRIMARY KEY (a, b DESC, 
c)\n" + 
"  ) IMMUTABLE_ROWS=true\n" + 
",SALT_BUCKETS=20");

> Allow TRUE and FALSE to be used as literal constants
> 
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
> Attachments: SqlLiteral.png, SqlOptionNode.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: I want to provide a module that provides the unshaded version of the jdbc client.

[Nick Dimiduk]

Maybe I'm missing something, but...

The whole point of providing a shaded client jar is to prevent exposing
Phoenix implementation details to the applications that consume it --
effectively allowing people to manage their own dependencies. Using a
shaded client jar means you don't have to worry about dependency conflict
because by definition there's only one dependency: the shaded client. What
are you able to achieve now with, say, the 4.7.0 unshaded client that you
cannot with the new 4.8.0 shaded client?

Thanks for the explanation.
-n

On Thu, Sep 15, 2016 at 7:56 AM, Marco Villalobos  wrote:

> Good morning.
>
> I want to provide a module that provides the unshaded version of the jdbc
> client.
>
> This will allow people to manage their own dependencies without worry of
> conflict.
>
> -Marco.
>
>
>

I want to provide a module that provides the unshaded version of the jdbc client.

[Marco Villalobos]

Good morning.

I want to provide a module that provides the unshaded version of the jdbc 
client.

This will allow people to manage their own dependencies without worry of 
conflict.

-Marco.

[jira] [Commented] (PHOENIX-3280) Automatic attempt to rebuild all disabled index

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492979#comment-15492979
 ] 

Hudson commented on PHOENIX-3280:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1403 (See 
[https://builds.apache.org/job/Phoenix-master/1403/])
PHOENIX-3280 Automatic attempt to rebuild all disabled index (jamestaylor: rev 
2a223adfbeb32f598308da1dc6d3251ee0980d79)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataRegionObserver.java


> Automatic attempt to rebuild all disabled index
> ---
>
> Key: PHOENIX-3280
> URL: https://issues.apache.org/jira/browse/PHOENIX-3280
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3280.patch, PHOENIX-3280_v2.patch
>
>
> Instead of only attempting to rebuild the first disabled index, we should 
> attempt to build each of them. Otherwise, a failure of the first one would 
> block the building of the others. This is follow up work for PHOENIX-3237 and 
> further improvements are identified in PHOENIX-3277.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3280) Automatic attempt to rebuild all disabled index

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492968#comment-15492968
 ] 

Hudson commented on PHOENIX-3280:
-

SUCCESS: Integrated in Jenkins build Phoenix-4.8-HBase-1.2 #24 (See 
[https://builds.apache.org/job/Phoenix-4.8-HBase-1.2/24/])
PHOENIX-3280 Automatic attempt to rebuild all disabled index (jamestaylor: rev 
496872c6e85e8e2cfe792035f9635b0817b78135)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataRegionObserver.java


> Automatic attempt to rebuild all disabled index
> ---
>
> Key: PHOENIX-3280
> URL: https://issues.apache.org/jira/browse/PHOENIX-3280
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3280.patch, PHOENIX-3280_v2.patch
>
>
> Instead of only attempting to rebuild the first disabled index, we should 
> attempt to build each of them. Otherwise, a failure of the first one would 
> block the building of the others. This is follow up work for PHOENIX-3237 and 
> further improvements are identified in PHOENIX-3277.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3280) Automatic attempt to rebuild all disabled index

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492825#comment-15492825
 ] 

Hadoop QA commented on PHOENIX-3280:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12828598/PHOENIX-3280_v2.patch
  against master branch at commit 27697b364511f8557a87d4007bff1a560e4b8490.
  ATTACHMENT ID: 12828598

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
34 warning messages.

{color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+if ((dataTable == null || dataTable.length == 0) || 
(indexState == null || indexState.length == 0)) {
+if 
(Bytes.compareTo(PIndexState.DISABLE.getSerializedBytes(), indexState) == 0) {
+indexesToPartiallyRebuild = 
Lists.newArrayListWithExpectedSize(dataPTable.getIndexes().size());
+
QueryServicesOptions.DEFAULT_INDEX_FAILURE_HANDLING_REBUILD_OVERLAP_TIME);
+LOG.info("Starting to build " + dataPTable + " 
indexes " + indexesToPartiallyRebuild
+try (HTableInterface dataHTable = 
conn.getQueryServices().getTable(physicalTableName)) {
+try (ResultScanner dataTableScanner = 
dataHTable.getScanner(dataTableScan)) {
+List mutations = 
Lists.newArrayListWithExpectedSize(batchSize);
+ImmutableBytesWritable indexMetaDataPtr = 
new ImmutableBytesWritable(
+
IndexMaintainer.serializeAdditional(dataPTable, indexMetaDataPtr,

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/577//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/577//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/577//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/577//console

This message is automatically generated.

> Automatic attempt to rebuild all disabled index
> ---
>
> Key: PHOENIX-3280
> URL: https://issues.apache.org/jira/browse/PHOENIX-3280
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3280.patch, PHOENIX-3280_v2.patch
>
>
> Instead of only attempting to rebuild the first disabled index, we should 
> attempt to build each of them. Otherwise, a failure of the first one would 
> block the building of the others. This is follow up work for PHOENIX-3237 and 
> further improvements are identified in PHOENIX-3277.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3253) Make changes in various classes for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492781#comment-15492781
 ] 

Hudson commented on PHOENIX-3253:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1402 (See 
[https://builds.apache.org/job/Phoenix-master/1402/])
PHOENIX-3253 Make changes in various classes for method level (jamestaylor: rev 
27697b364511f8557a87d4007bff1a560e4b8490)
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTraceReaderIT.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/trace/TraceReader.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTracingEndToEndIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixRuntimeIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/tx/TransactionIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTableMetricsWriterIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java


> Make changes in various classes for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch
>
>
> error log
> {code}  
> GroupByCaseIT.testScanUri:172 expected: but was:
>StoreNullsIT.testQueryingHistory:116
>   PhoenixTraceReaderIT.testMultipleSpans:122->validateTraces:132 Got an 
> unexpected traceid expected:<12345> but was:<987654>
>   TransactionIT.testTxnClosedCorrecty:152 There should be no invalid 
> transactions
>   DynamicUpsertIT.testFullUpsert:152 expected:<[a]Value> but 
> was:<[DynCol]Value>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (PHOENIX-3282) Convert BaseClientManagedTimeIT to be derived from BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

James Taylor created PHOENIX-3282:
-

 Summary: Convert BaseClientManagedTimeIT to be derived from 
BaseHBaseManagedTimeTableReuseIT
 Key: PHOENIX-3282
 URL: https://issues.apache.org/jira/browse/PHOENIX-3282
 Project: Phoenix
  Issue Type: Sub-task
Reporter: James Taylor


Convert BaseClientManagedTimeIT to be derived from 
BaseHBaseManagedTimeTableReuseIT by:
- Using unique table names in all tests
- Removing any usage of BaseTest.ensureTableCreated()
- Change static methods and member variables to be instance level



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3251) Make changes in HashJoinMoreIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3251:
--
Fix Version/s: 4.9.0

> Make changes in   HashJoinMoreIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> -
>
> Key: PHOENIX-3251
> URL: https://issues.apache.org/jira/browse/PHOENIX-3251
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
>
> {code}
>   HashJoinMoreIT.assertNoUnfreedMemory:112 expected:<0> but was:<908>
>   HashJoinMoreIT.assertNoUnfreedMemory:112 expected:<0> but was:<2811>
>   HashJoinMoreIT.testBug2894:843 » PhoenixIO 
> org.apache.phoenix.exception.Phoeni...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (PHOENIX-3251) Make changes in HashJoinMoreIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor reassigned PHOENIX-3251:
-

Assignee: James Taylor

> Make changes in   HashJoinMoreIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> -
>
> Key: PHOENIX-3251
> URL: https://issues.apache.org/jira/browse/PHOENIX-3251
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
>
> {code}
>   HashJoinMoreIT.assertNoUnfreedMemory:112 expected:<0> but was:<908>
>   HashJoinMoreIT.assertNoUnfreedMemory:112 expected:<0> but was:<2811>
>   HashJoinMoreIT.testBug2894:843 » PhoenixIO 
> org.apache.phoenix.exception.Phoeni...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (PHOENIX-3251) Make changes in HashJoinMoreIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor resolved PHOENIX-3251.
---
Resolution: Duplicate

Duplicate of PHOENIX-3253

> Make changes in   HashJoinMoreIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> -
>
> Key: PHOENIX-3251
> URL: https://issues.apache.org/jira/browse/PHOENIX-3251
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
>
> {code}
>   HashJoinMoreIT.assertNoUnfreedMemory:112 expected:<0> but was:<908>
>   HashJoinMoreIT.assertNoUnfreedMemory:112 expected:<0> but was:<2811>
>   HashJoinMoreIT.testBug2894:843 » PhoenixIO 
> org.apache.phoenix.exception.Phoeni...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (PHOENIX-3276) Make changes in PrimitiveTypeIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor reassigned PHOENIX-3276:
-

Assignee: James Taylor

> Make changes in PrimitiveTypeIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> 
>
> Key: PHOENIX-3276
> URL: https://issues.apache.org/jira/browse/PHOENIX-3276
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: James Taylor
>
>   PrimitiveTypeIT.testBooleanAsObject:219 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongGTDecimal:60 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongGTEDecimal:81 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongGTEDecimal2:158 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongLTDecimal2:177 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongLTEDecimal:121 » PhoenixIO



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3252) Make changes in PhoenixRuntimeIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3252:
--
Fix Version/s: 4.9.0

> Make changes in  PhoenixRuntimeIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3252
> URL: https://issues.apache.org/jira/browse/PHOENIX-3252
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
>
> {code}
>   
> PhoenixRuntimeIT.testGetTenantIdExpressionForSaltedTable:81->testGetTenantIdExpression:117->assertTenantIds:76
>  expected:<[, t1]> but was:<[, , t1, t1]>
>   
> PhoenixRuntimeIT.testGetTenantIdExpressionForUnsaltedTable:86->testGetTenantIdExpression:117->assertTenantIds:76
>  expected:<[, t1]> but was:<[, , t1, t1]>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (PHOENIX-3252) Make changes in PhoenixRuntimeIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor reassigned PHOENIX-3252:
-

Assignee: James Taylor  (was: prakul agarwal)

> Make changes in  PhoenixRuntimeIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3252
> URL: https://issues.apache.org/jira/browse/PHOENIX-3252
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
>
> {code}
>   
> PhoenixRuntimeIT.testGetTenantIdExpressionForSaltedTable:81->testGetTenantIdExpression:117->assertTenantIds:76
>  expected:<[, t1]> but was:<[, , t1, t1]>
>   
> PhoenixRuntimeIT.testGetTenantIdExpressionForUnsaltedTable:86->testGetTenantIdExpression:117->assertTenantIds:76
>  expected:<[, t1]> but was:<[, , t1, t1]>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (PHOENIX-3276) Make changes in PrimitiveTypeIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor resolved PHOENIX-3276.
---
Resolution: Duplicate

Duplicate of PHOENIX-3253

> Make changes in PrimitiveTypeIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> 
>
> Key: PHOENIX-3276
> URL: https://issues.apache.org/jira/browse/PHOENIX-3276
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>
>   PrimitiveTypeIT.testBooleanAsObject:219 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongGTDecimal:60 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongGTEDecimal:81 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongGTEDecimal2:158 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongLTDecimal2:177 » PhoenixIO
>   PrimitiveTypeIT.testCompareLongLTEDecimal:121 » PhoenixIO



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3249) Make changes in LocalIndexIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3249:
--
Assignee: (was: prakul agarwal)

> Make changes in  LocalIndexIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3249
> URL: https://issues.apache.org/jira/browse/PHOENIX-3249
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>
> Error Log
> {code}
>   
> LocalIndexIT.testBuildIndexWhenUserTableAlreadyHasData:280->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testDropLocalIndexShouldDeleteDataFromLocalIndexTable:619->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testDropLocalIndexTable:217->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testIndexPlanSelectionIfBothGlobalAndLocalIndexesHasSameColumnsAndOrder:596->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSaltingShouldFail:166->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexCreationWithSplitsShouldFail:147->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexRoundTrip:124->createBaseTable:99 » PhoenixIO 
> org.a...
>   
> LocalIndexIT.testLocalIndexRowsShouldBeDeletedWhenUserTableRowsDeleted:665->createBaseTable:99
>  » PhoenixIO
>   LocalIndexIT.testLocalIndexScanWithInList:762->createBaseTable:99 » 
> PhoenixIO ...
>   LocalIndexIT.testLocalIndexScanWithSmallChunks:909->createBaseTable:99 » 
> PhoenixIO
>   LocalIndexIT.testLocalIndexScan:320->createBaseTable:99 » PhoenixIO 
> org.apache...
>   
> LocalIndexIT.testLocalIndexTableRegionSplitPolicyAndSplitKeys:187->createBaseTable:99
>  » PhoenixIO
>   
> LocalIndexIT.testLocalIndexesOnTableWithImmutableRows:715->createBaseTable:99 
> » PhoenixIO
>   LocalIndexIT.testPutsToLocalIndexTable:240->createBaseTable:99 » PhoenixIO 
> org...
>   
> LocalIndexIT.testScanWhenATableHasMultipleLocalIndexes:690->createBaseTable:99
>  » PhoenixIO
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (PHOENIX-3252) Make changes in PhoenixRuntimeIT for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor resolved PHOENIX-3252.
---
Resolution: Duplicate

Duplicate of PHOENIX-3253

> Make changes in  PhoenixRuntimeIT for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> --
>
> Key: PHOENIX-3252
> URL: https://issues.apache.org/jira/browse/PHOENIX-3252
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
>
> {code}
>   
> PhoenixRuntimeIT.testGetTenantIdExpressionForSaltedTable:81->testGetTenantIdExpression:117->assertTenantIds:76
>  expected:<[, t1]> but was:<[, , t1, t1]>
>   
> PhoenixRuntimeIT.testGetTenantIdExpressionForUnsaltedTable:86->testGetTenantIdExpression:117->assertTenantIds:76
>  expected:<[, t1]> but was:<[, , t1, t1]>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3253) Make changes in various classes for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3253:
--
Fix Version/s: 4.9.0

> Make changes in various classes for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch
>
>
> error log
> {code}  
> GroupByCaseIT.testScanUri:172 expected: but was:
>StoreNullsIT.testQueryingHistory:116
>   PhoenixTraceReaderIT.testMultipleSpans:122->validateTraces:132 Got an 
> unexpected traceid expected:<12345> but was:<987654>
>   TransactionIT.testTxnClosedCorrecty:152 There should be no invalid 
> transactions
>   DynamicUpsertIT.testFullUpsert:152 expected:<[a]Value> but 
> was:<[DynCol]Value>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (PHOENIX-3253) Make changes in various classes for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor reassigned PHOENIX-3253:
-

Assignee: James Taylor

> Make changes in various classes for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch
>
>
> error log
> {code}  
> GroupByCaseIT.testScanUri:172 expected: but was:
>StoreNullsIT.testQueryingHistory:116
>   PhoenixTraceReaderIT.testMultipleSpans:122->validateTraces:132 Got an 
> unexpected traceid expected:<12345> but was:<987654>
>   TransactionIT.testTxnClosedCorrecty:152 There should be no invalid 
> transactions
>   DynamicUpsertIT.testFullUpsert:152 expected:<[a]Value> but 
> was:<[DynCol]Value>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (PHOENIX-3253) Make changes in various classes for method level parallelization in BaseHBaseManagedTimeTableReuseIT

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor resolved PHOENIX-3253.
---
Resolution: Fixed

> Make changes in various classes for method level parallelization in 
> BaseHBaseManagedTimeTableReuseIT
> 
>
> Key: PHOENIX-3253
> URL: https://issues.apache.org/jira/browse/PHOENIX-3253
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: prakul agarwal
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3253.patch
>
>
> error log
> {code}  
> GroupByCaseIT.testScanUri:172 expected: but was:
>StoreNullsIT.testQueryingHistory:116
>   PhoenixTraceReaderIT.testMultipleSpans:122->validateTraces:132 Got an 
> unexpected traceid expected:<12345> but was:<987654>
>   TransactionIT.testTxnClosedCorrecty:152 There should be no invalid 
> transactions
>   DynamicUpsertIT.testFullUpsert:152 expected:<[a]Value> but 
> was:<[DynCol]Value>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (PHOENIX-3278) Remove usage of BaseTest.ensureTableCreated()

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor resolved PHOENIX-3278.
---
Resolution: Fixed

> Remove usage of BaseTest.ensureTableCreated()
> -
>
> Key: PHOENIX-3278
> URL: https://issues.apache.org/jira/browse/PHOENIX-3278
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3278.patch
>
>
> The BaseTest.ensureTableCreated() is not thread safe when there are multiple 
> table mappings to the same key. It was never a good idea in the first place 
> and should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3278) Remove usage of BaseTest.ensureTableCreated()

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3278:
--
Fix Version/s: 4.9.0

> Remove usage of BaseTest.ensureTableCreated()
> -
>
> Key: PHOENIX-3278
> URL: https://issues.apache.org/jira/browse/PHOENIX-3278
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3278.patch
>
>
> The BaseTest.ensureTableCreated() is not thread safe when there are multiple 
> table mappings to the same key. It was never a good idea in the first place 
> and should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3280) Automatic attempt to rebuild all disabled index

[Ankit Singhal (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492710#comment-15492710
 ] 

Ankit Singhal commented on PHOENIX-3280:


+1 , Thanks [~jamestaylor]

> Automatic attempt to rebuild all disabled index
> ---
>
> Key: PHOENIX-3280
> URL: https://issues.apache.org/jira/browse/PHOENIX-3280
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3280.patch, PHOENIX-3280_v2.patch
>
>
> Instead of only attempting to rebuild the first disabled index, we should 
> attempt to build each of them. Otherwise, a failure of the first one would 
> block the building of the others. This is follow up work for PHOENIX-3237 and 
> further improvements are identified in PHOENIX-3277.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3181) Run test methods in parallel to reduce test suite run time

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3181:
--
Attachment: PHOENIX-3181_v4.patch

Thanks, [~rajeshbabu]. Here's the patch you need to apply to master - I've set 
a couple of tests in LocalIndexIT to ignore - I can just move these out to a 
separate class derived from BaseHBaseManagedTimeIT if need be, so it's not 
critical. You just need to run mvn verify a few times after removing the ignore 
tags. At least on my Mac, it pretty consistently hangs.

If you can figure out PHOENIX-3281, you win a prize :-). That's the real 
blocker. Seems like the JVMs aren't exiting as they should.

> Run test methods in parallel to reduce test suite run time
> --
>
> Key: PHOENIX-3181
> URL: https://issues.apache.org/jira/browse/PHOENIX-3181
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
> Attachments: PHOENIX-3181_4.x-HBase-1.1_WIP.patch, 
> PHOENIX-3181_v1.patch, PHOENIX-3181_v2.patch, PHOENIX-3181_v3.patch, 
> PHOENIX-3181_v4.patch, parallelize_4.x-Hbase1.1_wip.patch, 
> serverLogForParallelTests.txt
>
>
> With PHOENIX-3036, the tests within a test class can be executed in parallel 
> since the table names won't conflict. This should greatly reduce the time 
> taken to run all of our tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PHOENIX-3280) Automatic attempt to rebuild all disabled index

[James Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-3280:
--
Attachment: PHOENIX-3280_v2.patch

Thanks, [~an...@apache.org]. Great feedback and great catch on the missing 
mutations.clear() call. Here's a v2 with a couple of sanity checks added too.

> Automatic attempt to rebuild all disabled index
> ---
>
> Key: PHOENIX-3280
> URL: https://issues.apache.org/jira/browse/PHOENIX-3280
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3280.patch, PHOENIX-3280_v2.patch
>
>
> Instead of only attempting to rebuild the first disabled index, we should 
> attempt to build each of them. Otherwise, a failure of the first one would 
> block the building of the others. This is follow up work for PHOENIX-3237 and 
> further improvements are identified in PHOENIX-3277.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3181) Run test methods in parallel to reduce test suite run time

[Rajeshbabu Chintaguntla (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492641#comment-15492641
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-3181:
--

[~jamestaylor] Will take a look at the ignored tests today.

> Run test methods in parallel to reduce test suite run time
> --
>
> Key: PHOENIX-3181
> URL: https://issues.apache.org/jira/browse/PHOENIX-3181
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
> Attachments: PHOENIX-3181_4.x-HBase-1.1_WIP.patch, 
> PHOENIX-3181_v1.patch, PHOENIX-3181_v2.patch, PHOENIX-3181_v3.patch, 
> parallelize_4.x-Hbase1.1_wip.patch, serverLogForParallelTests.txt
>
>
> With PHOENIX-3036, the tests within a test class can be executed in parallel 
> since the table names won't conflict. This should greatly reduce the time 
> taken to run all of our tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3181) Run test methods in parallel to reduce test suite run time

[James Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492634#comment-15492634
 ] 

James Taylor commented on PHOENIX-3181:
---

All tests passing (with ignoring split/merge tests in LocalIndexIT - will 
separate these into a separate test for now), but getting the mysterious "There 
was a timeout or other error in the fork" from surefire. Filed PHOENIX-3281 to 
follow up on.

> Run test methods in parallel to reduce test suite run time
> --
>
> Key: PHOENIX-3181
> URL: https://issues.apache.org/jira/browse/PHOENIX-3181
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
> Attachments: PHOENIX-3181_4.x-HBase-1.1_WIP.patch, 
> PHOENIX-3181_v1.patch, PHOENIX-3181_v2.patch, PHOENIX-3181_v3.patch, 
> parallelize_4.x-Hbase1.1_wip.patch, serverLogForParallelTests.txt
>
>
> With PHOENIX-3036, the tests within a test class can be executed in parallel 
> since the table names won't conflict. This should greatly reduce the time 
> taken to run all of our tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (PHOENIX-3281) Workaround surefire error of there was a timeout or other error in the fork

[James Taylor (JIRA)]

James Taylor created PHOENIX-3281:
-

 Summary: Workaround surefire error of there was a timeout or other 
error in the fork
 Key: PHOENIX-3281
 URL: https://issues.apache.org/jira/browse/PHOENIX-3281
 Project: Phoenix
  Issue Type: Sub-task
Reporter: James Taylor


The following error is occurring when running the methods in parallel, though 
all tests are passing. It seems that the JVM is not shutting down as expected.
{code}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:verify 
(HBaseManagedTimeTableReuseTest) on project phoenix-core: There was a timeout 
or other error in the fork -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:verify 
(HBaseManagedTimeTableReuseTest) on project phoenix-core: There was a timeout 
or other error in the fork
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: There was a timeout 
or other error in the fork
at 
org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:87)
at 
org.apache.maven.plugin.failsafe.VerifyMojo.execute(VerifyMojo.java:202)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
... 20 more
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-2930) Cannot resolve columns aliased to its own name

[Ankit Singhal (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492606#comment-15492606
 ] 

Ankit Singhal commented on PHOENIX-2930:


[~maryannxue], any idea to fix it in a better way?

> Cannot resolve columns aliased to its own name
> --
>
> Key: PHOENIX-2930
> URL: https://issues.apache.org/jira/browse/PHOENIX-2930
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.4.0
>Reporter: Kevin Liew
>Assignee: Ankit Singhal
>  Labels: alias
> Fix For: 4.9.0
>
> Attachments: PHOENIX-2930.patch
>
>
> Tableau generates queries that alias a fully-qualified column name to its 
> shortened name.
> Similar to:
> {code}
> create table test (pk integer primary key);
> select test.pk as pk from test group by pk;
> {code}
> Phoenix reports:
> {code}
> 8org.apache.calcite.avatica.proto.Responses$ErrorResponse¨
> ðjava.lang.RuntimeException: 
> org.apache.phoenix.schema.AmbiguousColumnException: ERROR 502 (42702): Column 
> reference ambiguous or duplicate names. columnName=PK
>   at org.apache.calcite.avatica.jdbc.JdbcMeta.propagate(JdbcMeta.java:671)
>   at org.apache.calcite.avatica.jdbc.JdbcMeta.prepare(JdbcMeta.java:695)
>   at 
> org.apache.calcite.avatica.remote.LocalService.apply(LocalService.java:208)
>   at 
> org.apache.calcite.avatica.remote.Service$PrepareRequest.accept(Service.java:1157)
>   at 
> org.apache.calcite.avatica.remote.Service$PrepareRequest.accept(Service.java:1131)
>   at 
> org.apache.calcite.avatica.remote.AbstractHandler.apply(AbstractHandler.java:95)
>   at 
> org.apache.calcite.avatica.remote.ProtobufHandler.apply(ProtobufHandler.java:46)
>   at 
> org.apache.calcite.avatica.server.AvaticaProtobufHandler.handle(AvaticaProtobufHandler.java:127)
>   at 
> org.eclipse.jetty.server.handler.HandlerList.handle(HandlerList.java:52)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
>   at org.eclipse.jetty.server.Server.handle(Server.java:499)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
>   at 
> org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
>   at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
>   at 
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: org.apache.phoenix.schema.AmbiguousColumnException: ERROR 502 
> (42702): Column reference ambiguous or duplicate names. columnName=PK
>   at 
> org.apache.phoenix.parse.ParseNodeRewriter.visit(ParseNodeRewriter.java:406)
>   at 
> org.apache.phoenix.compile.StatementNormalizer.visit(StatementNormalizer.java:177)
>   at 
> org.apache.phoenix.compile.StatementNormalizer.visit(StatementNormalizer.java:58)
>   at 
> org.apache.phoenix.parse.ColumnParseNode.accept(ColumnParseNode.java:56)
>   at 
> org.apache.phoenix.parse.ParseNodeRewriter.rewrite(ParseNodeRewriter.java:111)
>   at 
> org.apache.phoenix.compile.StatementNormalizer.normalize(StatementNormalizer.java:107)
>   at 
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableSelectStatement.compilePlan(PhoenixStatement.java:398)
>   at 
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableSelectStatement.compilePlan(PhoenixStatement.java:378)
>   at 
> org.apache.phoenix.jdbc.PhoenixPreparedStatement.getMetaData(PhoenixPreparedStatement.java:223)
>   at org.apache.calcite.avatica.jdbc.JdbcMeta.prepare(JdbcMeta.java:689)
>   ... 15 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3277) Parallelize index rebuild of datatables

[Ankit Singhal (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492597#comment-15492597
 ] 

Ankit Singhal commented on PHOENIX-3277:


yes agreed, we can re-use the current timer task in SYSTEM.CATALOG to run scan 
jobs and rebuild indexes on all the regions(by using Observer) of a data table 
, as we need to have single triggering point so that we can make Index active 
at the end of the rebuild. Have raised this before PHOENIX-3161.



> Parallelize index rebuild of datatables
> ---
>
> Key: PHOENIX-3277
> URL: https://issues.apache.org/jira/browse/PHOENIX-3277
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
> Fix For: 4.9.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3280) Automatic attempt to rebuild all disabled index

[Ankit Singhal (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492569#comment-15492569
 ] 

Ankit Singhal commented on PHOENIX-3280:


Thanks [~giacomotaylor] , it looks good but have some minor comments.

Instead, Existing PhoenixRuntime#getTableNoCache() can be used.
{code}
+
+/**
+ * Get the latest table from the server, bypassing the client cache
+ * 
+ * @param conn
+ * @param name
+ * @return
+ * @throws SQLException
+ */
+public static PTable forceGetTable(Connection conn, String name) throws 
SQLException {
{code}

Could be a existing bug, Shouldn't we clear mutations after executing them.
{code}
+if (mutations.size() == batchSize) {
+dataHTable.batch(mutations);
+uuidValue = 
ServerCacheClient.generateId();
 }
{code}

Is the second version more optimized and can be used?
{code}
+List indexesToPartiallyRebuild = 
Lists.newArrayListWithExpectedSize(dataPTable.getIndexes()
+.size());
+List oldIndexesToPartiallyRebuild = 
dataTableToIndexesMap.put(dataPTable,
+indexesToPartiallyRebuild);
+// If there already were indexes, then combine them with 
the new ones
+if (oldIndexesToPartiallyRebuild != null) {
+
indexesToPartiallyRebuild.addAll(oldIndexesToPartiallyRebuild);
+}
 indexesToPartiallyRebuild.add(indexPTable);
{code}
{code}
+
+List oldIndexesToPartiallyRebuild= 
dataTableToIndexesMap.get(dataPTable);
+if (oldIndexesToPartiallyRebuild == null) {
+   oldIndexesToPartiallyRebuild = 
Lists.newArrayListWithExpectedSize(dataPTable.getIndexes()
+.size());
+   
dataTableToIndexesMap.put(dataPTable,indexesToPartiallyRebuild);
+}
 oldIndexesToPartiallyRebuild.add(indexPTable);
 {code}

please remove the comment as it is not valid now.
{code}
 // we need to build indexes of same data table. so 
skip other indexes for this task.
 continue;
{code}

> Automatic attempt to rebuild all disabled index
> ---
>
> Key: PHOENIX-3280
> URL: https://issues.apache.org/jira/browse/PHOENIX-3280
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3280.patch
>
>
> Instead of only attempting to rebuild the first disabled index, we should 
> attempt to build each of them. Otherwise, a failure of the first one would 
> block the building of the others. This is follow up work for PHOENIX-3237 and 
> further improvements are identified in PHOENIX-3277.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)