Re: [DISCUSS] Make libpcap mandatory?

2020-04-06 Thread Christofer Dutz
Let's not introduce yet another way to do such things ... these annotations seem to work fine and we/I've used them all over the place to make the testsuite runnable in all sorts of different scenarios. So-far we have: - RequireInternetConnection - RequireNonCaptureAllDns - RequirePcap -

Re: [DISCUSS] Make libpcap mandatory?

2020-04-06 Thread Googlemail OS
Also one can use „assumeThat()“ in junit for such things. > Am 06.04.2020 um 10:25 schrieb Julian Feinauer : > > Nice, then thats the way to go! > > Am 06.04.20, 10:21 schrieb "Christofer Dutz" : > >I've already got an annotation you can use: >@RequirePcap together with a Junit

Re: [DISCUSS] Make libpcap mandatory?

2020-04-06 Thread Julian Feinauer
Nice, then thats the way to go! Am 06.04.20, 10:21 schrieb "Christofer Dutz" : I've already got an annotation you can use: @RequirePcap together with a Junit Condition, that skips the test if the condition is not met ... just noticed a bug in my condition however __ ... just fixing

Re: [DISCUSS] Make libpcap mandatory?

2020-04-06 Thread Christofer Dutz
I've already got an annotation you can use: @RequirePcap together with a Junit Condition, that skips the test if the condition is not met ... just noticed a bug in my condition however __ ... just fixing it. Chris Am 06.04.20, 10:11 schrieb "Julian Feinauer" : Hey, I would not

Re: [DISCUSS] Make libpcap mandatory?

2020-04-06 Thread Julian Feinauer
Hey, I would not choose 1, as you say. Perhaps we can make this tests conditional (dont know how easy this is with junit5) an das you say, only allow releases with libpcap. Julian Am 06.04.20, 10:07 schrieb "Christofer Dutz" : Hi, I’m currently working on the prerequisiteCheck