[GitHub] [plc4x] splatch commented on a change in pull request #170: PLC4X-207 When a Handler Timeout occurs cancel the read future to not…

2020-12-15 Thread GitBox
splatch commented on a change in pull request #170: URL: https://github.com/apache/plc4x/pull/170#discussion_r543316951 ## File path: plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java ## @@ -136,32 +154,27 @@ public void

[GitHub] [plc4x] splatch commented on a change in pull request #170: PLC4X-207 When a Handler Timeout occurs cancel the read future to not…

2020-12-15 Thread GitBox
splatch commented on a change in pull request #170: URL: https://github.com/apache/plc4x/pull/170#discussion_r543316951 ## File path: plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java ## @@ -136,32 +154,27 @@ public void

[GitHub] [plc4x] hutcheb commented on a change in pull request #210: Bug/driver opcua read arrays [PLC4X-202]

2020-12-15 Thread GitBox
hutcheb commented on a change in pull request #210: URL: https://github.com/apache/plc4x/pull/210#discussion_r543293832 ## File path: plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java ## @@ -30,30 +30,34 @@ Licensed to the Apache Software

[GitHub] [plc4x] splatch commented on pull request #201: PLC4X-252 Support passing of PlcField in subscription builder.

2020-12-15 Thread GitBox
splatch commented on pull request #201: URL: https://github.com/apache/plc4x/pull/201#issuecomment-745250414 Ok, code is rebased to current develop and ready for further review. This is an automated message from the Apache

[GitHub] [plc4x] splatch commented on a change in pull request #170: PLC4X-207 When a Handler Timeout occurs cancel the read future to not…

2020-12-15 Thread GitBox
splatch commented on a change in pull request #170: URL: https://github.com/apache/plc4x/pull/170#discussion_r543318546 ## File path: plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java ## @@ -69,7 +72,7 @@ */ public class

[jira] [Created] (PLC4X-264) CANopen support

2020-12-15 Thread Jira
Łukasz Dywicki created PLC4X-264: Summary: CANopen support Key: PLC4X-264 URL: https://issues.apache.org/jira/browse/PLC4X-264 Project: Apache PLC4X Issue Type: New Feature Affects

[GitHub] [plc4x] splatch commented on pull request #211: CANopen over socketcan transport

2020-12-15 Thread GitBox
splatch commented on pull request #211: URL: https://github.com/apache/plc4x/pull/211#issuecomment-745469826 I've added necessary documentation and links. Awaiting Jenkins to complete his job :pray:. This is an automated

[GitHub] [plc4x] splatch merged pull request #211: [WIP] CANopen over socketcan transport

2020-12-15 Thread GitBox
splatch merged pull request #211: URL: https://github.com/apache/plc4x/pull/211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] splatch edited a comment on pull request #201: PLC4X-252 Support passing of PlcField in subscription builder.

2020-12-15 Thread GitBox
splatch edited a comment on pull request #201: URL: https://github.com/apache/plc4x/pull/201#issuecomment-745244392 > If a user uses the driver module directly and directly instantiates the custom driver field types, then his code is no longer portable That's user decision how he

[GitHub] [plc4x] splatch commented on pull request #201: PLC4X-252 Support passing of PlcField in subscription builder.

2020-12-15 Thread GitBox
splatch commented on pull request #201: URL: https://github.com/apache/plc4x/pull/201#issuecomment-745244392 > If a user uses the driver module directly and directly instantiates the custom driver field types, then his code is no longer portable That's user decision how he uses

[BUILD-UNSTABLE]: Job 'PLC4X/PLC4X/develop [develop] [152]'

2020-12-15 Thread Apache Jenkins Server
BUILD-UNSTABLE: Job 'PLC4X/PLC4X/develop [develop] [152]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/152/;>PLC4X/PLC4X/develop [develop] [152]"

[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [153]'

2020-12-15 Thread Apache Jenkins Server
BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [153]': Is back to normal.

[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [151]'

2020-12-15 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [151]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/151/;>PLC4X/PLC4X/develop [develop] [151]"

[GitHub] [plc4x] splatch commented on pull request #170: PLC4X-207 When a Handler Timeout occurs cancel the read future to not…

2020-12-15 Thread GitBox
splatch commented on pull request #170: URL: https://github.com/apache/plc4x/pull/170#issuecomment-745236270 I've updated code so it works with recent develop. Now S7 driver should properly handle timeouts. This is an

[GitHub] [plc4x] chrisdutz commented on a change in pull request #170: PLC4X-207 When a Handler Timeout occurs cancel the read future to not…

2020-12-15 Thread GitBox
chrisdutz commented on a change in pull request #170: URL: https://github.com/apache/plc4x/pull/170#discussion_r543274480 ## File path: plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java ## @@ -69,7 +72,7 @@ */ public class

[GitHub] [plc4x] splatch opened a new pull request #212: Add ConnectorIO as Apache PLC4X adopter

2020-12-15 Thread GitBox
splatch opened a new pull request #212: URL: https://github.com/apache/plc4x/pull/212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [plc4x] ottlukas merged pull request #212: Add ConnectorIO as Apache PLC4X adopter

2020-12-15 Thread GitBox
ottlukas merged pull request #212: URL: https://github.com/apache/plc4x/pull/212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

AW: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0 RC2

2020-12-15 Thread Christofer Dutz
+1 (binding) Run on Windows 10 Professional x64 with Java: openjdk 11.0.9.1 2020-11-04 LTS OpenJDK Runtime Environment 18.9 (build 11.0.9.1+1-LTS) OpenJDK 64-Bit Server VM 18.9 (build 11.0.9.1+1-LTS, mixed mode) [OK] Download all staged artifacts under the url specified in the release vote

[GitHub] [plc4x] chrisdutz commented on a change in pull request #210: Bug/driver opcua read arrays [PLC4X-202]

2020-12-15 Thread GitBox
chrisdutz commented on a change in pull request #210: URL: https://github.com/apache/plc4x/pull/210#discussion_r543164459 ## File path: plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java ## @@ -30,30 +30,34 @@ Licensed to the Apache

[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [147]'

2020-12-15 Thread Apache Jenkins Server
BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [147]': Is back to normal.

[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [146]'

2020-12-15 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [146]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/146/;>PLC4X/PLC4X/develop [develop] [146]"

[GitHub] [plc4x] splatch commented on pull request #211: [WIP] CANopen over socketcan transport

2020-12-15 Thread GitBox
splatch commented on pull request #211: URL: https://github.com/apache/plc4x/pull/211#issuecomment-745178213 > data-io-template doesn't break anything It seems not, all the tests are working fine and it is aimed to help with plain arrays. A lot of canopen stuff is mapped to

[GitHub] [plc4x] chrisdutz merged pull request #67: poll loop fetches data in a continous loop

2020-12-15 Thread GitBox
chrisdutz merged pull request #67: URL: https://github.com/apache/plc4x/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [148]'

2020-12-15 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [148]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/148/;>PLC4X/PLC4X/develop [develop] [148]"

[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [150]'

2020-12-15 Thread Apache Jenkins Server
BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [150]': Is back to normal.