Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
sruehl commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699093520 I could not get it working with the `go.work` at I don't know what it does. So if I follow your steps without the `go work use .` (which doesn't work if you strictly follow your

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
p3tr0v commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699059925 > what does your import statement look like in the `main.go`? Can you post the code of that file? thanks for your time! The main is simple, when trying to code, VScode just

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
p3tr0v commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699061060 reopening -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
p3tr0v closed issue #1089: [Bug]: Module not imported after following the guide URL: https://github.com/apache/plc4x/issues/1089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
sruehl commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699096326 (also I might update the documentation if I find some time or create a PR if you want integrating the steps I posted above) -- This is an automated message from the Apache Git

Re: [D] Should we extend PLCValues with a map of Meta-Information?

2023-09-04 Thread via GitHub
GitHub user chrisdutz added a comment to the discussion: Should we extend PLCValues with a map of Meta-Information? So ... as I only got questions and no suggestions, I'll merge my version ... we can always change it later on ... Right now I know of multiple protocols, that generally have

Re: [PR] Feature/iec 60870 5 104

2023-09-04 Thread via GitHub
chrisdutz merged PR #1088: URL: https://github.com/apache/plc4x/pull/1088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [D] [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany

2023-09-17 Thread via GitHub
GitHub user hutcheb added a comment to the discussion: [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany It sounds like fun, count me in. GitHub link: https://github.com/apache/plc4x/discussions/1082#discussioncomment-7027680 This is an automatically sent

Re: [D] Should we extend PLCValues with a map of Meta-Information?

2023-08-28 Thread via GitHub
GitHub user chrisdutz added a comment to the discussion: Should we extend PLCValues with a map of Meta-Information? Unfortunately PlcValue is defined in API and PlcStruct in SPI, so I cant reference it from there. GitHub link:

Re: [D] [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany

2023-08-28 Thread via GitHub
GitHub user ottlukas added a comment to the discussion: [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany Preparing the next release does not mean that we will release during the Hackathon, but have a clearer pathway towards the release and will see what happens

Re: [D] Should we extend PLCValues with a map of Meta-Information?

2023-08-28 Thread via GitHub
GitHub user chrisdutz added a comment to the discussion: Should we extend PLCValues with a map of Meta-Information? How does it complicate the handling? We generally never use that for writing ... it's just for additional information passed to the client from the Server/PLC? Using another

Re: [D] Should we extend PLCValues with a map of Meta-Information?

2023-08-28 Thread via GitHub
GitHub user splatch added a comment to the discussion: Should we extend PLCValues with a map of Meta-Information? As far I remember in early days `PlcStruct` was intended for complex types which could be reported by various equipment. In principle this is the type for values which can not be

Re: [PR] Feature/iec 60870 5 104

2023-09-01 Thread via GitHub
sruehl commented on code in PR #1088: URL: https://github.com/apache/plc4x/pull/1088#discussion_r1311253205 ## plc4j/spi/src/main/java/org/apache/plc4x/java/spi/values/PlcNull.java: ## @@ -271,6 +271,21 @@ public PlcValue getValue(String key) { return null; } +

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
sruehl commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699257172 yes, but as you can see it works for you. The pcap error is because you need pcap on your system -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
p3tr0v commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699249855 > ![result](https://github.com/apache/plc4x/assets/28512249/4443bbd8-5e58-44d7-89c1-3814925a8897) -- This is an automated message from the Apache Git Service. To respond

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
p3tr0v closed issue #1089: [Bug]: Module not imported after following the guide URL: https://github.com/apache/plc4x/issues/1089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
sruehl commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699278831 no sorry can't help you with that :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
p3tr0v commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699279876 thank you for your time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
p3tr0v closed issue #1089: [Bug]: Module not imported after following the guide URL: https://github.com/apache/plc4x/issues/1089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
sruehl commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699259954 try `apt-get install libpcap` if you are on a ubuntu system. Guess we need to update the documentation. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
p3tr0v commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699276672 > apt-get install libpcap Got success after installing. But I have to understand why without go.work, from my golang workspace projects, my IDE still saying it:

Re: [I] [Bug]: Module not imported after following the guide

2023-08-30 Thread via GitHub
p3tr0v commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1699251182 sorry, im not familiar with github, always when i post something, it close the issue, eopening again -- This is an automated message from the Apache Git Service. To respond to the

Re: [D] Should we extend PLCValues with a map of Meta-Information?

2023-09-01 Thread via GitHub
GitHub user chrisdutz added a comment to the discussion: Should we extend PLCValues with a map of Meta-Information? So ... how would you then handle all this additional informaiton? Would you simply discard it? Because everything except discarding it would make things complicated in some

Re: [D] Should we extend PLCValues with a map of Meta-Information?

2023-09-01 Thread via GitHub
GitHub user splatch added a comment to the discussion: Should we extend PLCValues with a map of Meta-Information? I think that current way complicates handling of values, because collaboration with drivers will need to take into account this metadata. Any code which is a generic callback for

Re: [D] [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany

2023-09-01 Thread via GitHub
GitHub user ottlukas edited a discussion: [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany The PLC4X Hackathon has the following goals: 1. Preparing the next release - "The journey of a thousand miles begins with a single step." - Lao Tzu 2. The hackathon is a

Re: [D] [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany

2023-09-13 Thread via GitHub
GitHub user chrisdutz added a comment to the discussion: [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany Actually I also think we should possibly start the release train now so we have something to report for Community Over Code GitHub link:

Re: [D] [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany

2023-09-13 Thread via GitHub
GitHub user chrisdutz added a comment to the discussion: [POLL] PLC4X - Hackathon - 16 / 17th December 2023 - Frankfurt/Main - Germany But we could concentrate on discussing the "road to 1.0.0" ;-) GitHub link: https://github.com/apache/plc4x/discussions/1082#discussioncomment-6987481

Re: [PR] Feature/iec 60870 5 104

2023-08-31 Thread via GitHub
chrisdutz commented on PR #1088: URL: https://github.com/apache/plc4x/pull/1088#issuecomment-1700463740 So ... I guess I'll be merging this tomorrow, if I don't hear any opposition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [D] Should we extend PLCValues with a map of Meta-Information?

2023-08-31 Thread via GitHub
GitHub user chrisdutz added a comment to the discussion: Should we extend PLCValues with a map of Meta-Information? https://github.com/apache/plc4x/pull/1088 is waiting for comments ... GitHub link: https://github.com/apache/plc4x/discussions/1086#discussioncomment-6872057 This is an

Re: [PR] build(deps): bump org.yaml:snakeyaml from 2.1 to 2.2

2023-08-31 Thread via GitHub
sruehl merged PR #1083: URL: https://github.com/apache/plc4x/pull/1083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump org.eclipse.jetty:jetty-util from 12.0.0 to 12.0.1

2023-08-31 Thread via GitHub
sruehl merged PR #1090: URL: https://github.com/apache/plc4x/pull/1090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] Feature/iec 60870 5 104

2023-08-31 Thread via GitHub
sruehl commented on code in PR #1088: URL: https://github.com/apache/plc4x/pull/1088#discussion_r1311251604 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcValue.java: ## @@ -149,4 +149,10 @@ public interface PlcValue { Map getStruct(); +Map

Re: [PR] Feature/iec 60870 5 104

2023-08-31 Thread via GitHub
chrisdutz commented on code in PR #1088: URL: https://github.com/apache/plc4x/pull/1088#discussion_r1311272228 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcValue.java: ## @@ -149,4 +149,10 @@ public interface PlcValue { Map getStruct(); +Map

Re: [PR] Feature/iec 60870 5 104

2023-09-04 Thread via GitHub
chrisdutz commented on code in PR #1088: URL: https://github.com/apache/plc4x/pull/1088#discussion_r1314648472 ## plc4j/spi/src/main/java/org/apache/plc4x/java/spi/values/PlcNull.java: ## @@ -271,6 +271,21 @@ public PlcValue getValue(String key) { return null; }

Re: [PR] Feature/iec 60870 5 104

2023-09-04 Thread via GitHub
chrisdutz commented on code in PR #1088: URL: https://github.com/apache/plc4x/pull/1088#discussion_r1314648891 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcValue.java: ## @@ -149,4 +149,10 @@ public interface PlcValue { Map getStruct(); +Map

Re: [PR] build(deps): bump net.bytebuddy:byte-buddy from 1.14.6 to 1.14.7

2023-08-29 Thread via GitHub
sruehl merged PR #1085: URL: https://github.com/apache/plc4x/pull/1085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [I] [Bug]: Module not imported after following the guide

2023-08-29 Thread via GitHub
sruehl commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1698526983 what does your import statement look like in the `main.go`? Can you post the code of that file? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] build(deps): bump com.google.protobuf:protobuf-java from 3.24.1 to 3.24.2

2023-08-29 Thread via GitHub
sruehl merged PR #1084: URL: https://github.com/apache/plc4x/pull/1084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump com.hivemq:hivemq-mqtt-client from 1.3.1 to 1.3.2

2023-08-29 Thread via GitHub
sruehl merged PR #1087: URL: https://github.com/apache/plc4x/pull/1087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [I] [Bug]: Module not imported after following the guide

2023-08-29 Thread via GitHub
sruehl commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1698535753 delete the `go.work` and use this main.go: ```golang package main import plc4go "github.com/apache/plc4x/plc4go/pkg/api" func main() { driverManager :=

Re: [I] [Bug]: Module not imported after following the guide

2023-08-29 Thread via GitHub
sruehl commented on issue #1089: URL: https://github.com/apache/plc4x/issues/1089#issuecomment-1698536443 and what starting guide are you referring to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] fix(opcua): Attempting to fix cyclic subscriptions

2023-10-11 Thread via GitHub
hutcheb merged PR #1124: URL: https://github.com/apache/plc4x/pull/1124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] plc4j-driver-opcua: Await `writeAndFlush(msg)` & send next msg async

2023-10-13 Thread via GitHub
takraj opened a new pull request, #1147: URL: https://github.com/apache/plc4x/pull/1147 All OPC-UA messages contain a sequence number, which is independent from the normal TCP sequence numbers. This sequence number is checked by the server, that may refuse to respond, if the sequence

Re: [PR] Fix race condition causing `RejectedExecutionException` on `PlcConnection.close()`

2023-10-16 Thread via GitHub
hutcheb commented on PR #1151: URL: https://github.com/apache/plc4x/pull/1151#issuecomment-1764932565 I can't think of any negatives with this PR, it seems to handle the case mentioned better than what's there already. Thanks @takraj -- This is an automated message from the Apache Git

Re: [PR] Fix race condition causing `RejectedExecutionException` on `PlcConnection.close()`

2023-10-16 Thread via GitHub
hutcheb merged PR #1151: URL: https://github.com/apache/plc4x/pull/1151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] build(deps): bump io.jsonwebtoken:jjwt-api from 0.12.2 to 0.12.3

2023-10-17 Thread via GitHub
sruehl merged PR #1152: URL: https://github.com/apache/plc4x/pull/1152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps-dev): bump org.json:json from 20230618 to 20231013

2023-10-17 Thread via GitHub
sruehl merged PR #1153: URL: https://github.com/apache/plc4x/pull/1153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump org.jacoco:jacoco-maven-plugin from 0.8.10 to 0.8.11

2023-10-17 Thread via GitHub
sruehl merged PR #1155: URL: https://github.com/apache/plc4x/pull/1155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] plc4j-driver-opcua: Await `writeAndFlush(msg)` & send next msg async

2023-10-17 Thread via GitHub
takraj commented on code in PR #1147: URL: https://github.com/apache/plc4x/pull/1147#discussion_r1361720621 ## plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/SecureChannel.java: ## @@ -361,16 +362,17 @@ public void

Re: [PR] build(deps): bump io.swagger:swagger-annotations from 1.6.11 to 1.6.12

2023-10-17 Thread via GitHub
sruehl merged PR #1154: URL: https://github.com/apache/plc4x/pull/1154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] plc4j-driver-opcua: Await `writeAndFlush(msg)` & send next msg async

2023-10-17 Thread via GitHub
takraj commented on code in PR #1147: URL: https://github.com/apache/plc4x/pull/1147#discussion_r1361680549 ## plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/SecureChannel.java: ## @@ -361,16 +362,17 @@ public void

Re: [PR] plc4j-driver-opcua: Await `writeAndFlush(msg)` & send next msg async

2023-10-17 Thread via GitHub
takraj commented on code in PR #1147: URL: https://github.com/apache/plc4x/pull/1147#discussion_r1361673477 ## plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/SecureChannel.java: ## @@ -361,16 +362,17 @@ public void

[I] [Bug]: PLC4X not buildable on Java 21

2023-10-15 Thread via GitHub
chrisdutz opened a new issue, #1150: URL: https://github.com/apache/plc4x/issues/1150 ### What happened? It seems when building PLC4X with Java 21, the build fails in the Kafka module during the execution of the kafka-connect plugin. `[INFO] ---

Re: [I] [Bug]: PLC4X - 0.11.0 - Issue writing value to a Beckhoff PLC using ads driver

2023-10-17 Thread via GitHub
patrickboisclair commented on issue #1156: URL: https://github.com/apache/plc4x/issues/1156#issuecomment-1766576023 I'll try, think I get "invalid tag", but I will test it out right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] [Bug]: PLC4X - 0.11.0 - Issue writing value to a Beckhoff PLC using ads driver

2023-10-17 Thread via GitHub
patrickboisclair commented on issue #1156: URL: https://github.com/apache/plc4x/issues/1156#issuecomment-1766584513 The tag in the PLC is named ValeurDINT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Bug]: PLC4X - 0.11.0 - Issue writing value to a Beckhoff PLC using ads driver

2023-10-17 Thread via GitHub
patrickboisclair commented on issue #1156: URL: https://github.com/apache/plc4x/issues/1156#issuecomment-1766639474 I did notice tho, that since 0.11.0, in order to write a value, we need to use: writeBuilder.addTagAddress("ValueDINT", "MAIN.ValeurDINT", **new PlcDINT(value)**);

Re: [I] [Bug]: PLC4X - 0.11.0 - Issue writing value to a Beckhoff PLC using ads driver

2023-10-17 Thread via GitHub
patrickboisclair commented on issue #1156: URL: https://github.com/apache/plc4x/issues/1156#issuecomment-170688 Looks like when writing a tag, without specifying a PLCxxx datatype, in the class "PlcValueHandler.java": public static PlcValue of(PlcTag tag, Object[] values) {

Re: [I] [Bug]: PLC4X - 0.11.0 - Issue writing value to a Beckhoff PLC using ads driver

2023-10-17 Thread via GitHub
splatch commented on issue #1156: URL: https://github.com/apache/plc4x/issues/1156#issuecomment-1766571139 @patrickboisclair can you check with different syntax of tag - i.e. `MAIN.Valeur:DINT`? Currently your tag does not specify type, I believe it should be resolved through symbol

Re: [I] [Bug]: PLC4X - 0.11.0 - Issue writing value to a Beckhoff PLC using ads driver

2023-10-17 Thread via GitHub
patrickboisclair commented on issue #1156: URL: https://github.com/apache/plc4x/issues/1156#issuecomment-1766580784 I get the following exception: xception in thread "main" org.apache.plc4x.java.api.exceptions.PlcInvalidTagException: Couldn't resolve symbolic address:

Re: [I] [Bug]: PLC4X - 0.11.0 - Issue writing value to a Beckhoff PLC using ads driver

2023-10-17 Thread via GitHub
splatch commented on issue #1156: URL: https://github.com/apache/plc4x/issues/1156#issuecomment-1766616344 Yeah, I see now why you got it without `:DINT`. There was a change in how symbolic tags are handled, they got smarter from 0.8 release where, beyond symbol name, its type had to be

Re: [I] [Bug]: PLC4X - 0.11.0 - Issue writing value to a Beckhoff PLC using ads driver

2023-10-17 Thread via GitHub
patrickboisclair commented on issue #1156: URL: https://github.com/apache/plc4x/issues/1156#issuecomment-1766628739 Yep, it works: Constants.bMulticoreSupport SymbolicAdsTag{symbolicAddress='Constants.bMulticoreSupport'} {group-id=16448, offset=385430, size-in-bytes=1, comment=""}

Re: [I] How to modify the value inside TcpTransportConfiguration

2023-10-27 Thread via GitHub
chrisdutz commented on issue #1175: URL: https://github.com/apache/plc4x/issues/1175#issuecomment-1782373596 Well, as I said: I think this is a vegetal problem with all transport options. Currently I don't know what broke, as this worked before. However I can't say when I'll have the time

Re: [I] How to modify the value inside TcpTransportConfiguration

2023-10-26 Thread via GitHub
cptjackwu commented on issue #1175: URL: https://github.com/apache/plc4x/issues/1175#issuecomment-1782126694 I want to modify the default values of these two TCPs. How do I do this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [Bug]: S7_1500 String can be read, but cannot be written

2023-10-26 Thread via GitHub
cptjackwu closed issue #938: [Bug]: S7_1500 String can be read, but cannot be written URL: https://github.com/apache/plc4x/issues/938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] How to modify the value inside TcpTransportConfiguration

2023-10-27 Thread via GitHub
cptjackwu closed issue #1175: How to modify the value inside TcpTransportConfiguration URL: https://github.com/apache/plc4x/issues/1175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat: Moved the code-generation into a separate profile

2023-10-27 Thread via GitHub
sruehl merged PR #1172: URL: https://github.com/apache/plc4x/pull/1172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump github.com/google/uuid from 1.3.1 to 1.4.0 in /plc4go

2023-10-27 Thread via GitHub
sruehl merged PR #1176: URL: https://github.com/apache/plc4x/pull/1176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] Feature/transport configuration rework

2023-10-30 Thread via GitHub
chrisdutz merged PR #1179: URL: https://github.com/apache/plc4x/pull/1179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] build(deps): bump org.checkerframework:checker-qual from 3.39.0 to 3.40.0

2023-11-02 Thread via GitHub
sruehl merged PR #1182: URL: https://github.com/apache/plc4x/pull/1182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump com.google.protobuf:protobuf-java from 3.24.4 to 3.25.0

2023-11-02 Thread via GitHub
sruehl merged PR #1183: URL: https://github.com/apache/plc4x/pull/1183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump nl.jqno.equalsverifier:equalsverifier from 3.15.2 to 3.15.3

2023-11-02 Thread via GitHub
sruehl merged PR #1184: URL: https://github.com/apache/plc4x/pull/1184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump mockito.version from 5.6.0 to 5.7.0

2023-11-03 Thread via GitHub
sruehl merged PR #1185: URL: https://github.com/apache/plc4x/pull/1185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[I] PLCJ-0.10.0 Concurrency problem : RequestTransactionManager workLog.remove()

2023-11-06 Thread via GitHub
cptjackwu opened a new issue, #1191: URL: https://github.com/apache/plc4x/issues/1191 ### What happened? private void processWorklog() { while (runningRequests.size() < getNumberOfConcurrentRequests() && !workLog.isEmpty()) { RequestTransaction next =

Re: [I] PLCJ-0.10.0 Concurrency problem : RequestTransactionManager workLog.remove()

2023-11-07 Thread via GitHub
chrisdutz commented on issue #1191: URL: https://github.com/apache/plc4x/issues/1191#issuecomment-1798201335 Admittedly I habe absolutely no idea what you are doing ... it looks as if you're trying to write something to a number of S7 devices. Well we definitely don't support that type of

Re: [PR] build(deps): bump junit.jupiter.version from 5.10.0 to 5.10.1

2023-11-07 Thread via GitHub
sruehl commented on PR #1187: URL: https://github.com/apache/plc4x/pull/1187#issuecomment-1798052198 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] build(deps): bump com.fazecast:jSerialComm from 2.10.3 to 2.10.4

2023-11-07 Thread via GitHub
sruehl merged PR #1192: URL: https://github.com/apache/plc4x/pull/1192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump github.com/schollz/progressbar/v3 from 3.13.1 to 3.14.0 in /plc4go

2023-11-07 Thread via GitHub
sruehl merged PR #1193: URL: https://github.com/apache/plc4x/pull/1193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump junit.jupiter.version from 5.10.0 to 5.10.1

2023-11-07 Thread via GitHub
sruehl merged PR #1187: URL: https://github.com/apache/plc4x/pull/1187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump github.com/spf13/cobra from 1.7.0 to 1.8.0 in /plc4go

2023-11-07 Thread via GitHub
sruehl merged PR #1189: URL: https://github.com/apache/plc4x/pull/1189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump com.googlecode.cmake-maven-project:cmake-maven-plugin from 3.26.3-b1 to 3.27.7-b1

2023-11-07 Thread via GitHub
sruehl merged PR #1188: URL: https://github.com/apache/plc4x/pull/1188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump github.com/schollz/progressbar/v3 from 3.13.1 to 3.14.0 in /plc4go

2023-11-07 Thread via GitHub
sruehl commented on PR #1193: URL: https://github.com/apache/plc4x/pull/1193#issuecomment-1798052431 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] build(deps): bump github.com/fatih/color from 1.15.0 to 1.16.0 in /plc4go

2023-11-07 Thread via GitHub
sruehl merged PR #1194: URL: https://github.com/apache/plc4x/pull/1194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [I] Create a set of connection-tests that potentially could lead to crash or leak

2023-11-07 Thread via GitHub
ottlukas closed issue #583: Create a set of connection-tests that potentially could lead to crash or leak URL: https://github.com/apache/plc4x/issues/583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [S7] Communication to S7 PLC dies in some situations

2023-11-07 Thread via GitHub
ottlukas closed issue #586: [S7] Communication to S7 PLC dies in some situations URL: https://github.com/apache/plc4x/issues/586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] S7 Cannot write string

2023-11-07 Thread via GitHub
ottlukas closed issue #624: S7 Cannot write string URL: https://github.com/apache/plc4x/issues/624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] build(deps): bump org.eclipse.jetty:jetty-util from 12.0.2 to 12.0.3

2023-10-31 Thread via GitHub
sruehl merged PR #1180: URL: https://github.com/apache/plc4x/pull/1180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump kotlin.version from 1.7.22 to 1.9.20

2023-10-31 Thread via GitHub
sruehl closed pull request #1181: build(deps): bump kotlin.version from 1.7.22 to 1.9.20 URL: https://github.com/apache/plc4x/pull/1181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] build(deps): bump org.cyclonedx:cyclonedx-maven-plugin from 2.7.9 to 2.7.10

2023-10-30 Thread via GitHub
sruehl merged PR #1178: URL: https://github.com/apache/plc4x/pull/1178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] Feature/transport configuration rework

2023-10-30 Thread via GitHub
chrisdutz commented on code in PR #1179: URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376202402 ## plc4j/drivers/c-bus/src/main/java/org/apache/plc4x/java/cbus/configuration/CBusTcpTransportConfiguration.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache

Re: [PR] Feature/transport configuration rework

2023-10-30 Thread via GitHub
chrisdutz commented on code in PR #1179: URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376200487 ## plc4j/drivers/firmata/pom.xml: ## @@ -122,12 +122,6 @@ 0.12.0-SNAPSHOT - - org.apache.plc4x - plc4j-transport-serial Review Comment:

Re: [PR] Feature/transport configuration rework

2023-10-30 Thread via GitHub
chrisdutz commented on code in PR #1179: URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376205060 ## plc4j/drivers/ads/pom.xml: ## @@ -140,11 +140,6 @@ plc4j-transport-tcp 0.12.0-SNAPSHOT - - org.apache.plc4x -

[PR] Feature/transport configuration rework

2023-10-30 Thread via GitHub
chrisdutz opened a new pull request, #1179: URL: https://github.com/apache/plc4x/pull/1179 Reworked the configuration of transports so a transports configuration options are referenced by a prefix, that matches the transport code. So for example in S7 I can customize the timeout like

Re: [PR] Feature/transport configuration rework

2023-10-30 Thread via GitHub
sruehl commented on code in PR #1179: URL: https://github.com/apache/plc4x/pull/1179#discussion_r1375982833 ## plc4j/drivers/ads/pom.xml: ## @@ -140,11 +140,6 @@ plc4j-transport-tcp 0.12.0-SNAPSHOT - - org.apache.plc4x - plc4j-transport-serial

Re: [PR] Feature/transport configuration rework

2023-10-30 Thread via GitHub
sruehl commented on PR #1179: URL: https://github.com/apache/plc4x/pull/1179#issuecomment-1784911154 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] feat: Moved the code-generation into a separate profile

2023-10-23 Thread via GitHub
chrisdutz opened a new pull request, #1172: URL: https://github.com/apache/plc4x/pull/1172 Added a new maven profile `update-generated-code` to the build, that allows explicitly enabling code-generation. This is needed in preparation to supporting reproducible-builds. -- This is

[I] How to S7-1500 network disconnected but S7HDefaultNettyPlcConnection The connected() method is still true

2023-10-26 Thread via GitHub
cptjackwu opened a new issue, #1174: URL: https://github.com/apache/plc4x/issues/1174 ### What happened? An exception occurs when I call the following method, PlcReadResponse response = plcReadRequest.execute().get(10, TimeUnit.SECONDS);

Re: [PR] build(deps): bump org.codehaus.mojo:properties-maven-plugin from 1.2.0 to 1.2.1

2023-10-25 Thread via GitHub
sruehl merged PR #1173: URL: https://github.com/apache/plc4x/pull/1173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump com.microsoft.azure.sdk.iot:iot-device-client from 2.3.0 to 2.3.1

2023-10-25 Thread via GitHub
sruehl merged PR #1171: URL: https://github.com/apache/plc4x/pull/1171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump org.glassfish.jaxb:jaxb-runtime from 4.0.2 to 4.0.4

2023-10-25 Thread via GitHub
sruehl merged PR #1170: URL: https://github.com/apache/plc4x/pull/1170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] feat(plc4j/spi): Add option to synchronously await response from PLC

2023-10-25 Thread via GitHub
sruehl merged PR #1163: URL: https://github.com/apache/plc4x/pull/1163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

  1   2   3   4   5   6   7   8   9   10   >