RE: style guidelines?

2015-06-01 Thread Allison, Timothy B.
[mailto:dominik.stad...@gmx.at] Sent: Saturday, May 30, 2015 7:20 AM To: POI Developers List Subject: Re: style guidelines? Hi, I though about performing an automatic cleanup via Eclipse tooling at some point, this would fix some of the inconsistencies across the whole source and should provide

Re: style guidelines?

2015-05-30 Thread Dominik Stadler
Hi, I though about performing an automatic cleanup via Eclipse tooling at some point, this would fix some of the inconsistencies across the whole source and should provide a bit more consistency, albeit a full automated reformatting is probably too much as it would make some code less readable.

Re: style guidelines?

2015-05-29 Thread David kerber
to debug that way, and to ensure that I have the exact ones I want when they are all explicit. -Original Message- From: Andreas Beeker [mailto:kiwiwi...@apache.org] Sent: Thursday, May 28, 2015 5:11 PM To: POI Developers List Subject: Re: style guidelines? On 28.05.2015 21:36, Allison

RE: style guidelines?

2015-05-29 Thread Allison, Timothy B.
, to you and the other devs on this item. -Original Message- From: Andreas Beeker [mailto:kiwiwi...@apache.org] Sent: Thursday, May 28, 2015 5:11 PM To: POI Developers List Subject: Re: style guidelines? On 28.05.2015 21:36, Allison, Timothy B. wrote: 4) don't use wildcards on imports

Re: style guidelines?

2015-05-29 Thread Andreas Beeker
Thank you, David and Tim. Before I ask you to go a bit more into detail, I wanted to add a few of my motivation points - everything is minor and I can live without it, but when choosing between wildcards and full import, I tend towards wildcards: - when writing junit4 test, every time I use a

Re: style guidelines?

2015-05-28 Thread Nick Burch
On Thu, 28 May 2015, Allison, Timothy B. wrote: As ongoing penance for my regrettable past (really it is behind me...I hope...), I'd like to start cleaning up some of the code whenever I come across style issues. I'll follow the guidance of fixing whitespace in separate patches from content

Re: style guidelines?

2015-05-28 Thread Andreas Beeker
On 28.05.2015 21:36, Allison, Timothy B. wrote: 4) don't use wildcards on imports This is something I'd like to change. Can we limit this to X classes per package or X static imports? For common_sl, I've used a setting of 3 full imports, and for a higher number wildcards will be used. The

style guidelines?

2015-05-28 Thread Allison, Timothy B.
Hi All, As ongoing penance for my regrettable past (really it is behind me...I hope...), I'd like to start cleaning up some of the code whenever I come across style issues. I'll follow the guidance of fixing whitespace in separate patches from content patches. I found this: