Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

[Dave Fisher]

Hi Jerry,

> On Jul 23, 2018, at 3:05 PM, Jerry Peng  wrote:
> 
> +1 for the 5th release candidate for Apache Pulsar, version 2.1.0-incubating
> 
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/
> 
> I followed the release candidate validation guide:
> 
> https://github.com/apache/incubator-pulsar/wiki/Release-Candidate-Validation

These instruction don’t cover validating the source release, signatures and 
hashes. That should be updated.

I am thinking that scripts could be provided….

Regards,
Dave

> 
> 
> Verified the following to be working:
> 
> * Validate Pub/Sub
> * Validate Java Functions
> * Validate Connectors
> * Validate Stateful Functions
> 
> On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher  wrote:
> 
>> Hi -
>> 
>> +1 (IPMC Binding)
>> 
>> Comment #1 - There are many more files to review in this release. :-)
>> 
>> (1) Source release.
>> Signature and checksums pass.
>> Builds from source with the option that Sijie provided.
>> Standalone starts
>> NOTICE, LICENSE and DISCLAIMER look good.
>> 
>> (2) Binary release
>> Signature and checksums pass.
>> Standalone starts
>> NOTICE, LICENSE and DISCLAIMER look good.
>> 
>> (3) Pulsar IO Connectors NAR files.
>> Signature and checksums pass.
>> LICENSE and DISCLAIMER exist in the top level of the package.
>> LICENSE and NOTICE plus DEPENDENCIES exist in the NAR files.
>> 
>> ==> DISCLAIMER should be included in the NAR files.
>> ==> NOTICE should also be at the top level.
>> 
>> (4) DEB
>> Signature and checksums pass
>> NOTICE, LICENSE, and DISCLAIMER look good.
>> 
>> ==> copyright files contain the Apache License. IMO these ought to contain
>> the NOTICE
>> 
>> (5) RPM
>> Signature and checksums pass
>> NOTICE, LICENSE, and DISCLAIMER look good.
>> 
>> ==> I’m curious about how the sqlite binary files are used.
>> 
>> Regards,
>> Dave
>> 
>>> On Jul 22, 2018, at 10:05 PM, Sijie Guo  wrote:
>>> 
>>> any more review comments?
>>> 
>>> - Sijie
>>> 
>>> On Fri, Jul 20, 2018 at 1:13 PM Sijie Guo  wrote:
>>> 
 Okay will remove it.
 
 But just to clarify, the KEYS file I put in the voting email is the one
 used for releases, the one contains my KEY. Please use the one in voting
 email to verify.
 
 - Sijie
 
 On Fri, Jul 20, 2018 at 1:07 PM Dave Fisher 
>> wrote:
 
> Hi Sijie,
> 
> I was looking at the KEYS here:
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/KEYS
> 
> Probably that should be removed or updated from the release version.
> 
> Regards,
> Dave
> 
>> On Jul 20, 2018, at 12:58 PM, Sijie Guo  wrote:
>> 
>> HI Dave,
>> 
>> My key is already there :
>> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
>> 
>> Search "Sijie Guo"
>> 
>> - Sijie
>> 
>> 
>> 
>> On Fri, Jul 20, 2018 at 11:47 AM Dave Fisher 
> wrote:
>> 
>>> Hi Sijie,
>>> 
>>> Please add your key to the KEYS file.
>>> 
>>> Regards,
>>> Dave
>>> 
 On Jul 19, 2018, at 4:43 PM, Sijie Guo  wrote:
 
 This is the 5th release candidate for Apache Pulsar, version
 2.1.0-incubating.
 
 It introduces following main features:
 
 - Pulsar I/O: a serverless connector framework built on top of
>> Pulsar
 Functions.
 - TieredStorage: offloads bookkeeper ledgers to a cold storage (like
> S3).
 - Stateful Function: Pulsar Functions supports storing state back to
 bookkeeper.
 - Go Client: a Go client wrapping over existing cpp client.
 - Avro and Protobuf schema are supported.
 
 Full list of changes and fixes are available:
 
 https://github.com/apache/incubator-pulsar/milestone/13?closed=1
 
 *** Please download, test and vote on this release. This vote will
> stay
>>> open
 for at least 72 hours ***
 
 Note that we are voting upon the source (tag), binaries are provided
> for
 convenience.
 
 Source and binary files:
 
>>> 
> 
>> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/
 
 SHA-1 checksums:
 
 f0f6b6d7c48d119da36fc4fa1f934fd1f9ba8498
 ./apache-pulsar-2.1.0-incubating-bin.tar.gz
 
 b6a968249a7c5d21be89ece27895b862efda9a92
 ./apache-pulsar-2.1.0-incubating-src.tar.gz
 
 ddcf929eb18082ff2b9979507054453e8e803ed3
 ./apache-pulsar-io-connectors-2.1.0-incubating-bin.tar.gz
 
 
 Maven staging repo:
 
> 
>> https://repository.apache.org/content/repositories/orgapachepulsar-1025/
 
 The tag to be voted upon:
 v2.1.0-incubating-candidate-5
> (75f79b77f55fbad351cb517e7f3b8ba4ab2dc177)
 
>>> 
> 

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

[Dave Fisher]

Hi -

> On Jul 23, 2018, at 4:55 PM, Matteo Merli  wrote:
> 
> On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher  wrote:
> 
>> (3) Pulsar IO Connectors NAR files.
>> Signature and checksums pass.
>> LICENSE and DISCLAIMER exist in the top level of the package.
>> LICENSE and NOTICE plus DEPENDENCIES exist in the NAR files.
>> 
>> ==> DISCLAIMER should be included in the NAR files.
>> ==> NOTICE should also be at the top level.
>> 
> 
> It's a bit tricky to add these. We are using the Apache NiFi NAR maven
> plugin to generate the archives. To add custom files, we would probably
> have to customize the plugin itself.

Does the NAR system generate the whole package or just the individual NAR files?

Someone could go to d...@nifi.apache.org and ask.

> 
> 
>> (4) DEB
>> Signature and checksums pass
>> NOTICE, LICENSE, and DISCLAIMER look good.
>> 
>> ==> copyright files contain the Apache License. IMO these ought to contain
>> the NOTICE
>> 
> 
> Yes, I was a bit confused by this. My understanding was that in Debian
> convention the 'copyright' file contains the license. I left both LICENSE
> and 'copyright' just to be on the safe side.

It looks like the Debian project may be finally defining these. 
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

> 
> (5) RPM
>> Signature and checksums pass
>> NOTICE, LICENSE, and DISCLAIMER look good.
>> 
>> ==> I’m curious about how the sqlite binary files are used.
>> 
> 
> The sqlite binary files (and similarly the Packages.gz for Debian) are used
> by the package manages (yum or apt-get) to fetch the metadata of the
> available packages.
> 
> The idea would be for users to first import the YUM repository and then do
> the regular `yum install apache-pulsar-client`.
> 
> Once the binaries are available on mirrors, we'll be adding instructions,
> similar to what Cassandra has for rpm/deb files at
> http://cassandra.apache.org/download/
> 

Great.

Regards,
Dave

> 
> Matteo
> 
> 
> --
> Matteo Merli
> 



signature.asc
Description: Message signed with OpenPGP

Build failed in Jenkins: pulsar-master #641

[Apache Jenkins Server]

See 


Changes:

[guosijie] Cpp client: add multiTopicsConsumer (#1996)

--
[...truncated 1.07 MB...]
2018-07-24 00:14:20.053 INFO  ConsumerImpl:168 | 
[persistent://sample/standalone/ns1/my-python-test-producer-deduplication-1532391259.84,
 my-sub, 0] Created consumer on broker [127.0.0.1:38616 -> 127.0.0.1:8885] 
2018-07-24 00:14:21.099 INFO  ProducerImpl:466 | 
[persistent://sample/standalone/ns1/my-python-test-producer-deduplication-1532391259.84,
 my-producer-name] Closed producer
2018-07-24 00:14:21.101 INFO  HandlerBase:53 | 
[persistent://sample/standalone/ns1/my-python-test-producer-deduplication-1532391259.84,
 my-producer-name] Getting connection from pool
2018-07-24 00:14:21.103 INFO  ProducerImpl:154 | 
[persistent://sample/standalone/ns1/my-python-test-producer-deduplication-1532391259.84,
 my-producer-name] Created producer on broker [127.0.0.1:38616 -> 
127.0.0.1:8885] 
.2018-07-24 00:14:22.105 INFO  ConnectionPool:63 | Created connection for 
pulsar://localhost:8885
2018-07-24 00:14:22.105 INFO  ClientConnection:285 | [127.0.0.1:38622 -> 
127.0.0.1:8885] Connected to broker
2018-07-24 00:14:22.109 INFO  HandlerBase:53 | 
[persistent://public/default/my-python-test-producer, ] Getting connection from 
pool
2018-07-24 00:14:22.162 INFO  ProducerImpl:154 | 
[persistent://public/default/my-python-test-producer, ] Created producer on 
broker [127.0.0.1:38622 -> 127.0.0.1:8885] 
2018-07-24 00:14:22.185 INFO  ProducerImpl:466 | 
[persistent://public/default/my-python-test-producer, standalone-0-92] Closed 
producer
.2018-07-24 00:14:22.186 INFO  ConnectionPool:63 | Created connection for 
pulsar://localhost:8885
2018-07-24 00:14:22.187 INFO  ClientConnection:285 | [127.0.0.1:38624 -> 
127.0.0.1:8885] Connected to broker
2018-07-24 00:14:22.189 INFO  HandlerBase:53 | 
[persistent://sample/standalone/ns/my-python-topic, ] Getting connection from 
pool
2018-07-24 00:14:22.231 INFO  ProducerImpl:154 | 
[persistent://sample/standalone/ns/my-python-topic, ] Created producer on 
broker [127.0.0.1:38624 -> 127.0.0.1:8885] 
2018-07-24 00:14:22.232 WARN  ConsumerImpl:97 | 
[persistent://sample/standalone/ns1/my-python-test-producer-deduplication-1532391259.84,
 my-sub, 0] Destroyed consumer which was not properly closed
2018-07-24 00:14:22.333 INFO  ProducerImpl:466 | 
[persistent://sample/standalone/ns/my-python-topic, standalone-0-93] Closed 
producer
.2018-07-24 00:14:22.404 INFO  ConnectionPool:63 | Created connection for 
pulsar://localhost:8885
2018-07-24 00:14:22.405 INFO  ClientConnection:285 | [127.0.0.1:38628 -> 
127.0.0.1:8885] Connected to broker
2018-07-24 00:14:22.408 INFO  HandlerBase:53 | 
[persistent://sample/standalone/ns1/my-python-test-producer-sequence-after-reconnection-1532391262.4,
 my-producer-name] Getting connection from pool
2018-07-24 00:14:22.521 INFO  ProducerImpl:154 | 
[persistent://sample/standalone/ns1/my-python-test-producer-sequence-after-reconnection-1532391262.4,
 my-producer-name] Created producer on broker [127.0.0.1:38628 -> 
127.0.0.1:8885] 
2018-07-24 00:14:22.643 INFO  ProducerImpl:466 | 
[persistent://sample/standalone/ns1/my-python-test-producer-sequence-after-reconnection-1532391262.4,
 my-producer-name] Closed producer
2018-07-24 00:14:22.645 INFO  HandlerBase:53 | 
[persistent://sample/standalone/ns1/my-python-test-producer-sequence-after-reconnection-1532391262.4,
 my-producer-name] Getting connection from pool
2018-07-24 00:14:22.647 INFO  ProducerImpl:154 | 
[persistent://sample/standalone/ns1/my-python-test-producer-sequence-after-reconnection-1532391262.4,
 my-producer-name] Created producer on broker [127.0.0.1:38628 -> 
127.0.0.1:8885] 
.2018-07-24 00:14:22.727 INFO  ConnectionPool:63 | Created connection for 
pulsar://localhost:8885
2018-07-24 00:14:22.728 INFO  ClientConnection:285 | [127.0.0.1:38630 -> 
127.0.0.1:8885] Connected to broker
2018-07-24 00:14:22.730 INFO  HandlerBase:53 | 
[persistent://sample/standalone/ns1/my-python-test_publish_compact_and_consume, 
my-producer-name] Getting connection from pool
2018-07-24 00:14:22.829 INFO  ProducerImpl:154 | 
[persistent://sample/standalone/ns1/my-python-test_publish_compact_and_consume, 
my-producer-name] Created producer on broker [127.0.0.1:38630 -> 
127.0.0.1:8885] 
2018-07-24 00:14:22.831 INFO  HandlerBase:53 | 
[persistent://sample/standalone/ns1/my-python-test_publish_compact_and_consume, 
my-sub1, 0] Getting connection from pool
2018-07-24 00:14:22.879 INFO  ConsumerImpl:168 | 
[persistent://sample/standalone/ns1/my-python-test_publish_compact_and_consume, 
my-sub1, 0] Created consumer on broker [127.0.0.1:38630 -> 127.0.0.1:8885] 
2018-07-24 00:14:22.883 INFO  ConsumerImpl:761 | 
[persistent://sample/standalone/ns1/my-python-test_publish_compact_and_consume, 
my-sub1, 0] Closed consumer 0
2018-07-24 00:14:22.890 INFO  HandlerBase:53 | 
[persistent://sample/standalone/ns1

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

[Matteo Merli]

On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher  wrote:

> (3) Pulsar IO Connectors NAR files.
> Signature and checksums pass.
> LICENSE and DISCLAIMER exist in the top level of the package.
> LICENSE and NOTICE plus DEPENDENCIES exist in the NAR files.
>
> ==> DISCLAIMER should be included in the NAR files.
> ==> NOTICE should also be at the top level.
>

It's a bit tricky to add these. We are using the Apache NiFi NAR maven
plugin to generate the archives. To add custom files, we would probably
have to customize the plugin itself.


> (4) DEB
> Signature and checksums pass
> NOTICE, LICENSE, and DISCLAIMER look good.
>
> ==> copyright files contain the Apache License. IMO these ought to contain
> the NOTICE
>

Yes, I was a bit confused by this. My understanding was that in Debian
convention the 'copyright' file contains the license. I left both LICENSE
and 'copyright' just to be on the safe side.

(5) RPM
> Signature and checksums pass
> NOTICE, LICENSE, and DISCLAIMER look good.
>
> ==> I’m curious about how the sqlite binary files are used.
>

The sqlite binary files (and similarly the Packages.gz for Debian) are used
by the package manages (yum or apt-get) to fetch the metadata of the
available packages.

The idea would be for users to first import the YUM repository and then do
the regular `yum install apache-pulsar-client`.

Once the binaries are available on mirrors, we'll be adding instructions,
similar to what Cassandra has for rpm/deb files at
http://cassandra.apache.org/download/


Matteo


-- 
Matteo Merli

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

[Matteo Merli]

+1

Environment: MacOS 10.13

Checked:
 * Signatures, crc
 * Bin distribution:
 - NOTICE, README, LICENSE
 - Start standalone service and producer/consumer test
 * Src distribution:
 - NOTICE,  README, LICENSE
 - Compile and unit tests
 - RAT check
 - Start standalone service
 * Checked staging maven repository artifacts


Matteo

On Mon, Jul 23, 2018 at 3:06 PM Jerry Peng 
wrote:

> +1 for the 5th release candidate for Apache Pulsar, version
> 2.1.0-incubating
>
> Source and binary files:
>
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/
>
> I followed the release candidate validation guide:
>
>
> https://github.com/apache/incubator-pulsar/wiki/Release-Candidate-Validation
>
>
> Verified the following to be working:
>
> * Validate Pub/Sub
> * Validate Java Functions
> * Validate Connectors
> * Validate Stateful Functions
>
> On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher 
> wrote:
>
> > Hi -
> >
> > +1 (IPMC Binding)
> >
> > Comment #1 - There are many more files to review in this release. :-)
> >
> > (1) Source release.
> > Signature and checksums pass.
> > Builds from source with the option that Sijie provided.
> > Standalone starts
> > NOTICE, LICENSE and DISCLAIMER look good.
> >
> > (2) Binary release
> > Signature and checksums pass.
> > Standalone starts
> > NOTICE, LICENSE and DISCLAIMER look good.
> >
> > (3) Pulsar IO Connectors NAR files.
> > Signature and checksums pass.
> > LICENSE and DISCLAIMER exist in the top level of the package.
> > LICENSE and NOTICE plus DEPENDENCIES exist in the NAR files.
> >
> > ==> DISCLAIMER should be included in the NAR files.
> > ==> NOTICE should also be at the top level.
> >
> > (4) DEB
> > Signature and checksums pass
> > NOTICE, LICENSE, and DISCLAIMER look good.
> >
> > ==> copyright files contain the Apache License. IMO these ought to
> contain
> > the NOTICE
> >
> > (5) RPM
> > Signature and checksums pass
> > NOTICE, LICENSE, and DISCLAIMER look good.
> >
> > ==> I’m curious about how the sqlite binary files are used.
> >
> > Regards,
> > Dave
> >
> > > On Jul 22, 2018, at 10:05 PM, Sijie Guo  wrote:
> > >
> > > any more review comments?
> > >
> > > - Sijie
> > >
> > > On Fri, Jul 20, 2018 at 1:13 PM Sijie Guo  wrote:
> > >
> > >> Okay will remove it.
> > >>
> > >> But just to clarify, the KEYS file I put in the voting email is the
> one
> > >> used for releases, the one contains my KEY. Please use the one in
> voting
> > >> email to verify.
> > >>
> > >> - Sijie
> > >>
> > >> On Fri, Jul 20, 2018 at 1:07 PM Dave Fisher 
> > wrote:
> > >>
> > >>> Hi Sijie,
> > >>>
> > >>> I was looking at the KEYS here:
> > >>> https://dist.apache.org/repos/dist/dev/incubator/pulsar/KEYS
> > >>>
> > >>> Probably that should be removed or updated from the release version.
> > >>>
> > >>> Regards,
> > >>> Dave
> > >>>
> >  On Jul 20, 2018, at 12:58 PM, Sijie Guo  wrote:
> > 
> >  HI Dave,
> > 
> >  My key is already there :
> >  https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> > 
> >  Search "Sijie Guo"
> > 
> >  - Sijie
> > 
> > 
> > 
> >  On Fri, Jul 20, 2018 at 11:47 AM Dave Fisher  >
> > >>> wrote:
> > 
> > > Hi Sijie,
> > >
> > > Please add your key to the KEYS file.
> > >
> > > Regards,
> > > Dave
> > >
> > >> On Jul 19, 2018, at 4:43 PM, Sijie Guo  wrote:
> > >>
> > >> This is the 5th release candidate for Apache Pulsar, version
> > >> 2.1.0-incubating.
> > >>
> > >> It introduces following main features:
> > >>
> > >> - Pulsar I/O: a serverless connector framework built on top of
> > Pulsar
> > >> Functions.
> > >> - TieredStorage: offloads bookkeeper ledgers to a cold storage
> (like
> > >>> S3).
> > >> - Stateful Function: Pulsar Functions supports storing state back
> to
> > >> bookkeeper.
> > >> - Go Client: a Go client wrapping over existing cpp client.
> > >> - Avro and Protobuf schema are supported.
> > >>
> > >> Full list of changes and fixes are available:
> > >>
> > >> https://github.com/apache/incubator-pulsar/milestone/13?closed=1
> > >>
> > >> *** Please download, test and vote on this release. This vote will
> > >>> stay
> > > open
> > >> for at least 72 hours ***
> > >>
> > >> Note that we are voting upon the source (tag), binaries are
> provided
> > >>> for
> > >> convenience.
> > >>
> > >> Source and binary files:
> > >>
> > >
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/
> > >>
> > >> SHA-1 checksums:
> > >>
> > >> f0f6b6d7c48d119da36fc4fa1f934fd1f9ba8498
> > >> ./apache-pulsar-2.1.0-incubating-bin.tar.gz
> > >>
> > >> b6a968249a7c5d21be89ece27895b862efda9a92
> > >> ./apache-pulsar-2.1.0-incubating-src.tar.gz
> > >>
> > >> ddcf929eb18082ff2b9979507054453e8e803ed

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

[Jerry Peng]

+1 for the 5th release candidate for Apache Pulsar, version 2.1.0-incubating

Source and binary files:
https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/

I followed the release candidate validation guide:

https://github.com/apache/incubator-pulsar/wiki/Release-Candidate-Validation


Verified the following to be working:

* Validate Pub/Sub
* Validate Java Functions
* Validate Connectors
* Validate Stateful Functions

On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher  wrote:

> Hi -
>
> +1 (IPMC Binding)
>
> Comment #1 - There are many more files to review in this release. :-)
>
> (1) Source release.
> Signature and checksums pass.
> Builds from source with the option that Sijie provided.
> Standalone starts
> NOTICE, LICENSE and DISCLAIMER look good.
>
> (2) Binary release
> Signature and checksums pass.
> Standalone starts
> NOTICE, LICENSE and DISCLAIMER look good.
>
> (3) Pulsar IO Connectors NAR files.
> Signature and checksums pass.
> LICENSE and DISCLAIMER exist in the top level of the package.
> LICENSE and NOTICE plus DEPENDENCIES exist in the NAR files.
>
> ==> DISCLAIMER should be included in the NAR files.
> ==> NOTICE should also be at the top level.
>
> (4) DEB
> Signature and checksums pass
> NOTICE, LICENSE, and DISCLAIMER look good.
>
> ==> copyright files contain the Apache License. IMO these ought to contain
> the NOTICE
>
> (5) RPM
> Signature and checksums pass
> NOTICE, LICENSE, and DISCLAIMER look good.
>
> ==> I’m curious about how the sqlite binary files are used.
>
> Regards,
> Dave
>
> > On Jul 22, 2018, at 10:05 PM, Sijie Guo  wrote:
> >
> > any more review comments?
> >
> > - Sijie
> >
> > On Fri, Jul 20, 2018 at 1:13 PM Sijie Guo  wrote:
> >
> >> Okay will remove it.
> >>
> >> But just to clarify, the KEYS file I put in the voting email is the one
> >> used for releases, the one contains my KEY. Please use the one in voting
> >> email to verify.
> >>
> >> - Sijie
> >>
> >> On Fri, Jul 20, 2018 at 1:07 PM Dave Fisher 
> wrote:
> >>
> >>> Hi Sijie,
> >>>
> >>> I was looking at the KEYS here:
> >>> https://dist.apache.org/repos/dist/dev/incubator/pulsar/KEYS
> >>>
> >>> Probably that should be removed or updated from the release version.
> >>>
> >>> Regards,
> >>> Dave
> >>>
>  On Jul 20, 2018, at 12:58 PM, Sijie Guo  wrote:
> 
>  HI Dave,
> 
>  My key is already there :
>  https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> 
>  Search "Sijie Guo"
> 
>  - Sijie
> 
> 
> 
>  On Fri, Jul 20, 2018 at 11:47 AM Dave Fisher 
> >>> wrote:
> 
> > Hi Sijie,
> >
> > Please add your key to the KEYS file.
> >
> > Regards,
> > Dave
> >
> >> On Jul 19, 2018, at 4:43 PM, Sijie Guo  wrote:
> >>
> >> This is the 5th release candidate for Apache Pulsar, version
> >> 2.1.0-incubating.
> >>
> >> It introduces following main features:
> >>
> >> - Pulsar I/O: a serverless connector framework built on top of
> Pulsar
> >> Functions.
> >> - TieredStorage: offloads bookkeeper ledgers to a cold storage (like
> >>> S3).
> >> - Stateful Function: Pulsar Functions supports storing state back to
> >> bookkeeper.
> >> - Go Client: a Go client wrapping over existing cpp client.
> >> - Avro and Protobuf schema are supported.
> >>
> >> Full list of changes and fixes are available:
> >>
> >> https://github.com/apache/incubator-pulsar/milestone/13?closed=1
> >>
> >> *** Please download, test and vote on this release. This vote will
> >>> stay
> > open
> >> for at least 72 hours ***
> >>
> >> Note that we are voting upon the source (tag), binaries are provided
> >>> for
> >> convenience.
> >>
> >> Source and binary files:
> >>
> >
> >>>
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/
> >>
> >> SHA-1 checksums:
> >>
> >> f0f6b6d7c48d119da36fc4fa1f934fd1f9ba8498
> >> ./apache-pulsar-2.1.0-incubating-bin.tar.gz
> >>
> >> b6a968249a7c5d21be89ece27895b862efda9a92
> >> ./apache-pulsar-2.1.0-incubating-src.tar.gz
> >>
> >> ddcf929eb18082ff2b9979507054453e8e803ed3
> >> ./apache-pulsar-io-connectors-2.1.0-incubating-bin.tar.gz
> >>
> >>
> >> Maven staging repo:
> >>
> >>>
> https://repository.apache.org/content/repositories/orgapachepulsar-1025/
> >>
> >> The tag to be voted upon:
> >> v2.1.0-incubating-candidate-5
> >>> (75f79b77f55fbad351cb517e7f3b8ba4ab2dc177)
> >>
> >
> >>>
> https://github.com/apache/incubator-pulsar/releases/tag/v2.1.0-incubating-candidate-5
> >>
> >> Pulsar's KEYS file containing PGP keys we use to sign the release:
> >> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> >>
> >> Please download the the source package, and follow the README to
> build
> >> and run the Pulsar standalone s

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

[Dave Fisher]

Hi -

+1 (IPMC Binding)

Comment #1 - There are many more files to review in this release. :-)

(1) Source release.
Signature and checksums pass.
Builds from source with the option that Sijie provided.
Standalone starts
NOTICE, LICENSE and DISCLAIMER look good.

(2) Binary release
Signature and checksums pass.
Standalone starts
NOTICE, LICENSE and DISCLAIMER look good.

(3) Pulsar IO Connectors NAR files.
Signature and checksums pass.
LICENSE and DISCLAIMER exist in the top level of the package.
LICENSE and NOTICE plus DEPENDENCIES exist in the NAR files.

==> DISCLAIMER should be included in the NAR files.
==> NOTICE should also be at the top level.

(4) DEB
Signature and checksums pass
NOTICE, LICENSE, and DISCLAIMER look good.

==> copyright files contain the Apache License. IMO these ought to contain the 
NOTICE

(5) RPM
Signature and checksums pass
NOTICE, LICENSE, and DISCLAIMER look good.

==> I’m curious about how the sqlite binary files are used.

Regards,
Dave

> On Jul 22, 2018, at 10:05 PM, Sijie Guo  wrote:
> 
> any more review comments?
> 
> - Sijie
> 
> On Fri, Jul 20, 2018 at 1:13 PM Sijie Guo  wrote:
> 
>> Okay will remove it.
>> 
>> But just to clarify, the KEYS file I put in the voting email is the one
>> used for releases, the one contains my KEY. Please use the one in voting
>> email to verify.
>> 
>> - Sijie
>> 
>> On Fri, Jul 20, 2018 at 1:07 PM Dave Fisher  wrote:
>> 
>>> Hi Sijie,
>>> 
>>> I was looking at the KEYS here:
>>> https://dist.apache.org/repos/dist/dev/incubator/pulsar/KEYS
>>> 
>>> Probably that should be removed or updated from the release version.
>>> 
>>> Regards,
>>> Dave
>>> 
 On Jul 20, 2018, at 12:58 PM, Sijie Guo  wrote:
 
 HI Dave,
 
 My key is already there :
 https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
 
 Search "Sijie Guo"
 
 - Sijie
 
 
 
 On Fri, Jul 20, 2018 at 11:47 AM Dave Fisher 
>>> wrote:
 
> Hi Sijie,
> 
> Please add your key to the KEYS file.
> 
> Regards,
> Dave
> 
>> On Jul 19, 2018, at 4:43 PM, Sijie Guo  wrote:
>> 
>> This is the 5th release candidate for Apache Pulsar, version
>> 2.1.0-incubating.
>> 
>> It introduces following main features:
>> 
>> - Pulsar I/O: a serverless connector framework built on top of Pulsar
>> Functions.
>> - TieredStorage: offloads bookkeeper ledgers to a cold storage (like
>>> S3).
>> - Stateful Function: Pulsar Functions supports storing state back to
>> bookkeeper.
>> - Go Client: a Go client wrapping over existing cpp client.
>> - Avro and Protobuf schema are supported.
>> 
>> Full list of changes and fixes are available:
>> 
>> https://github.com/apache/incubator-pulsar/milestone/13?closed=1
>> 
>> *** Please download, test and vote on this release. This vote will
>>> stay
> open
>> for at least 72 hours ***
>> 
>> Note that we are voting upon the source (tag), binaries are provided
>>> for
>> convenience.
>> 
>> Source and binary files:
>> 
> 
>>> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/
>> 
>> SHA-1 checksums:
>> 
>> f0f6b6d7c48d119da36fc4fa1f934fd1f9ba8498
>> ./apache-pulsar-2.1.0-incubating-bin.tar.gz
>> 
>> b6a968249a7c5d21be89ece27895b862efda9a92
>> ./apache-pulsar-2.1.0-incubating-src.tar.gz
>> 
>> ddcf929eb18082ff2b9979507054453e8e803ed3
>> ./apache-pulsar-io-connectors-2.1.0-incubating-bin.tar.gz
>> 
>> 
>> Maven staging repo:
>> 
>>> https://repository.apache.org/content/repositories/orgapachepulsar-1025/
>> 
>> The tag to be voted upon:
>> v2.1.0-incubating-candidate-5
>>> (75f79b77f55fbad351cb517e7f3b8ba4ab2dc177)
>> 
> 
>>> https://github.com/apache/incubator-pulsar/releases/tag/v2.1.0-incubating-candidate-5
>> 
>> Pulsar's KEYS file containing PGP keys we use to sign the release:
>> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
>> 
>> Please download the the source package, and follow the README to build
>> and run the Pulsar standalone service.
>> 
>> A few notes for reviewing/voting 2.1.0 release:
>> 
>> - Starting from this release, we are shipping RPM & DEB packages for
> pulsar
>> non-java clients.
>> - Starting from this release, we are shipping a binary distribution
> called
>> `apache-pulsar-io-connectors`
>> including all built-in connectors. Each connector is packaged with all
>> their dependencies and
>> a META-INF/DEPEDENCIES file with licensing information for
>> all dependencies.
>> - Since there are a lot of features introduced in 2.1, I put up an
>> instruction for people to validate release candidate
>> on different features:
>> 
> 
>>> https://github.com/apache/incubator-pulsar/wiki/Release-Candidate-Validation

Jenkins build is unstable: pulsar-master #639

[Apache Jenkins Server]

See 

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

[Ivan Kelly]

The git error can be fixed by adding
false

It already has failOnUnableToExtractRepoInfo as false, which I assumed
would cover this case.

-Ivan

On Mon, Jul 23, 2018 at 6:05 AM, Sijie Guo  wrote:
> any more review comments?
>
> - Sijie
>
> On Fri, Jul 20, 2018 at 1:13 PM Sijie Guo  wrote:
>
>> Okay will remove it.
>>
>> But just to clarify, the KEYS file I put in the voting email is the one
>> used for releases, the one contains my KEY. Please use the one in voting
>> email to verify.
>>
>> - Sijie
>>
>> On Fri, Jul 20, 2018 at 1:07 PM Dave Fisher  wrote:
>>
>>> Hi Sijie,
>>>
>>> I was looking at the KEYS here:
>>> https://dist.apache.org/repos/dist/dev/incubator/pulsar/KEYS
>>>
>>> Probably that should be removed or updated from the release version.
>>>
>>> Regards,
>>> Dave
>>>
>>> > On Jul 20, 2018, at 12:58 PM, Sijie Guo  wrote:
>>> >
>>> > HI Dave,
>>> >
>>> > My key is already there :
>>> > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
>>> >
>>> > Search "Sijie Guo"
>>> >
>>> > - Sijie
>>> >
>>> >
>>> >
>>> > On Fri, Jul 20, 2018 at 11:47 AM Dave Fisher 
>>> wrote:
>>> >
>>> >> Hi Sijie,
>>> >>
>>> >> Please add your key to the KEYS file.
>>> >>
>>> >> Regards,
>>> >> Dave
>>> >>
>>> >>> On Jul 19, 2018, at 4:43 PM, Sijie Guo  wrote:
>>> >>>
>>> >>> This is the 5th release candidate for Apache Pulsar, version
>>> >>> 2.1.0-incubating.
>>> >>>
>>> >>> It introduces following main features:
>>> >>>
>>> >>> - Pulsar I/O: a serverless connector framework built on top of Pulsar
>>> >>> Functions.
>>> >>> - TieredStorage: offloads bookkeeper ledgers to a cold storage (like
>>> S3).
>>> >>> - Stateful Function: Pulsar Functions supports storing state back to
>>> >>> bookkeeper.
>>> >>> - Go Client: a Go client wrapping over existing cpp client.
>>> >>> - Avro and Protobuf schema are supported.
>>> >>>
>>> >>> Full list of changes and fixes are available:
>>> >>>
>>> >>> https://github.com/apache/incubator-pulsar/milestone/13?closed=1
>>> >>>
>>> >>> *** Please download, test and vote on this release. This vote will
>>> stay
>>> >> open
>>> >>> for at least 72 hours ***
>>> >>>
>>> >>> Note that we are voting upon the source (tag), binaries are provided
>>> for
>>> >>> convenience.
>>> >>>
>>> >>> Source and binary files:
>>> >>>
>>> >>
>>> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/
>>> >>>
>>> >>> SHA-1 checksums:
>>> >>>
>>> >>> f0f6b6d7c48d119da36fc4fa1f934fd1f9ba8498
>>> >>> ./apache-pulsar-2.1.0-incubating-bin.tar.gz
>>> >>>
>>> >>> b6a968249a7c5d21be89ece27895b862efda9a92
>>> >>> ./apache-pulsar-2.1.0-incubating-src.tar.gz
>>> >>>
>>> >>> ddcf929eb18082ff2b9979507054453e8e803ed3
>>> >>> ./apache-pulsar-io-connectors-2.1.0-incubating-bin.tar.gz
>>> >>>
>>> >>>
>>> >>> Maven staging repo:
>>> >>>
>>> https://repository.apache.org/content/repositories/orgapachepulsar-1025/
>>> >>>
>>> >>> The tag to be voted upon:
>>> >>> v2.1.0-incubating-candidate-5
>>> (75f79b77f55fbad351cb517e7f3b8ba4ab2dc177)
>>> >>>
>>> >>
>>> https://github.com/apache/incubator-pulsar/releases/tag/v2.1.0-incubating-candidate-5
>>> >>>
>>> >>> Pulsar's KEYS file containing PGP keys we use to sign the release:
>>> >>> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
>>> >>>
>>> >>> Please download the the source package, and follow the README to build
>>> >>> and run the Pulsar standalone service.
>>> >>>
>>> >>> A few notes for reviewing/voting 2.1.0 release:
>>> >>>
>>> >>> - Starting from this release, we are shipping RPM & DEB packages for
>>> >> pulsar
>>> >>> non-java clients.
>>> >>> - Starting from this release, we are shipping a binary distribution
>>> >> called
>>> >>> `apache-pulsar-io-connectors`
>>> >>> including all built-in connectors. Each connector is packaged with all
>>> >>> their dependencies and
>>> >>> a META-INF/DEPEDENCIES file with licensing information for
>>> >>> all dependencies.
>>> >>> - Since there are a lot of features introduced in 2.1, I put up an
>>> >>> instruction for people to validate release candidate
>>> >>>  on different features:
>>> >>>
>>> >>
>>> https://github.com/apache/incubator-pulsar/wiki/Release-Candidate-Validation
>>> >>
>>> >>
>>>
>>>

Build failed in Jenkins: pulsar-website-build #315

[Apache Jenkins Server]

See 

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H17 (Hadoop xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Done
Cloning the remote Git repository
Cloning repository https://github.com/apache/incubator-pulsar.git
 > git init  # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/incubator-pulsar.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/apache/incubator-pulsar.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/apache/incubator-pulsar.git 
 > # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url https://github.com/apache/incubator-pulsar.git 
 > # timeout=10
Fetching upstream changes from https://github.com/apache/incubator-pulsar.git
 > git fetch --tags --progress https://github.com/apache/incubator-pulsar.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 90908e9d950a747820c9ba8b4160372937062f90 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 90908e9d950a747820c9ba8b4160372937062f90
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H17
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:955)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:283)
at com.sun.proxy.$Proxy117.withRepository(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.withRepository(RemoteGitImpl.java:235)
at 
hudson.plugins.git.GitSCM.printCommitMessageToLog(GitSCM.java:1271)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1244)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1794)
at 
hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
java.lang.NoClassDefFoundError: hudson.model.Computer
at 
org.jenkinsci.plugins.gitclient.AbstractGitAPIImpl.withRepository(AbstractGitAPIImpl.java:29)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.withRepository(CliGitAPIImpl.java:72)
at sun.reflect.GeneratedMethodAccessor69.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:929)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:903)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:855)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Caused: java.io.IOException: Remote call on H17 failed
at hudson.remoting.Channel.call(Channel.java:961)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:283)
at com.sun.proxy.$Proxy117.withRepository(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.withRepository(RemoteGitImpl.java:235)
at hudson.plugins.git.GitSCM.printCommitMessageToLog(GitSCM.java:1271)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java