[GitHub] qpid-cpp issue #17: QPID-8187 Allow incompatible function casts for SASL com...

2018-10-21 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-cpp/pull/17 My mistake. It's actually committed at https://github.com/apache/qpid-cpp/commit/706b5f3fb2fd4bb89ef8268575a8592b7b66272e

[GitHub] qpid-cpp issue #14: QPID-8186 Use const ref when catching exceptions

2018-10-21 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-cpp/pull/14 Commited at https://github.com/apache/qpid-cpp/commit/8b09d246f2529ea59809cac743e55af3920b4895 --- - To unsubscribe, e-mail: dev

[GitHub] qpid-cpp issue #17: QPID-8187 Allow incompatible function casts for SASL com...

2018-10-21 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-cpp/pull/17 @chrisrichardson77 , this one is on master at https://github.com/apache/qpid-cpp/commit/8b09d246f2529ea59809cac743e55af3920b4895 Would you close the PR

[GitHub] qpid-proton pull request #:

2018-09-24 Thread ssorj
Github user ssorj commented on the pull request: https://github.com/apache/qpid-proton/commit/3dd3bd4913af915d1632fed57c350d76a5cd0ba2#commitcomment-30626644 In ruby/lib/core/connection.rb: In ruby/lib/core/connection.rb on line 117: I tried and failed to figure it out last

[GitHub] qpid-dispatch issue #296: Introduce a new structure under docs for multiple ...

2018-06-26 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-dispatch/pull/296 Squashed and merged at https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=f77f92c . --- - To unsubscribe, e-mail

[GitHub] qpid-dispatch issue #296: WIP - Introduce a new structure under docs for mul...

2018-06-20 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-dispatch/pull/296 @bhardesty, agreed. I'll get final confirmation from the dispatch folks and then go ahead. --- - To unsubscribe, e-mail

[GitHub] qpid-proton issue #95: PROTON-1412 Add fuzzers to proton-c tests

2018-05-14 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/95 +1 On Mon, May 14, 2018 at 1:55 PM jirkadanek <notificati...@github.com> wrote: > @astitcher <https://github.com/astitcher> @ssorj > <https://gith

[GitHub] qpid-dispatch issue #296: WIP - Introduce a new structure under docs for mul...

2018-05-03 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-dispatch/pull/296 @bhardesty , I think internal-resources/ is too restrictive. We usually notes to mean freestyle topic-oriented stuff, usually in something informal such as markdown or plain text. The content

[GitHub] qpid-dispatch issue #296: WIP - Introduce a new structure under docs for mul...

2018-05-01 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-dispatch/pull/296 That is indeed what I was thinking for book/reference-guide/. But it's not actually there in the source. You should feel free to choose another name if it's a better fit. BTW, I

[GitHub] qpid-dispatch pull request #296: WIP - Introduce a new structure under docs ...

2018-04-27 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-dispatch/pull/296 WIP - Introduce a new structure under docs for multiple books The structure: ``` docs/ notes/ man/ <- Much of the non-book content and script

[GitHub] qpid-proton pull request #132: PROTON-1728: WIP: Reorganize the source tree ...

2018-04-05 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/132 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #136: WIP - Remove deprecated bindings and APIs

2018-04-05 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/136 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #138: WIP - Remove obsolete docs and test code

2018-04-05 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/138 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #140: PROTON-1638, PROTON-1728: Reorganize the sour...

2018-04-05 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/140 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp issue #12: WIP - A batch of C++ updates

2018-03-12 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-cpp/pull/12 The related issues: https://issues.apache.org/jira/issues/?jql=project%20%3D%20QPID%20and%20resolution%20is%20null%20and%20component%20in%20(%22C%2B%2B%20Broker%22%2C%20%22C%2B%2B%20Build%22%2C%20

[GitHub] qpid-cpp pull request #12: WIP - A batch of C++ updates

2018-03-12 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-cpp/pull/12 WIP - A batch of C++ updates This is a slate of doc updates and patch applications for the C++ code base. Please let me know if you see any problems here. You can merge this pull request

[GitHub] qpid-proton pull request #140: PROTON-1638, PROTON-1728: Reorganize the sour...

2018-03-08 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/140 PROTON-1638, PROTON-1728: Reorganize the source tree I plan to squash this on merge. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssorj

[GitHub] qpid-proton pull request #138: WIP - Remove obsolete docs and test code

2018-03-06 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/138 WIP - Remove obsolete docs and test code Part two of the planned source reorg. This is intended to follow after https://github.com/apache/qpid-proton/pull/136 . You can merge this pull

[GitHub] qpid-proton pull request #136: WIP - Remove deprecated bindings and APIs

2018-02-13 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/136 WIP - Remove deprecated bindings and APIs This is part one of the planned source reorg. Note that the SSL test coverage may be impacted by the tests removed in tests/python/proton_tests

[GitHub] qpid-dispatch pull request #244: DISPATCH-89: Exchange Binding forwarder (ex...

2018-01-24 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/244#discussion_r163612727 --- Diff: python/qpid_dispatch/management/qdrouter.json --- @@ -1126,6 +1126,106

[GitHub] qpid-dispatch pull request #244: DISPATCH-89: Exchange Binding forwarder (ex...

2018-01-23 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/244#discussion_r163344546 --- Diff: python/qpid_dispatch/management/qdrouter.json --- @@ -1126,6 +1126,106

[GitHub] qpid-dispatch pull request #244: DISPATCH-89: Exchange Binding forwarder (ex...

2018-01-23 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/244#discussion_r163318304 --- Diff: python/qpid_dispatch/management/qdrouter.json --- @@ -1126,6 +1126,106

[GitHub] qpid-proton issue #132: PROTON-1728: WIP: Reorganize the source tree and rem...

2018-01-11 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/132 One more change I'd like to consider making is moving the language-specific examples with their binding code. That's consistent with how we currently handle docs, and it will make the cmake

[GitHub] qpid-proton pull request #132: PROTON-1728: WIP: Reorganize the source tree ...

2017-12-21 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/132 PROTON-1728: WIP: Reorganize the source tree and remove deprecated bindings WIP! For review only. Note that this doesn't attempt any significant clean up of the cmake logic. I left

[GitHub] qpid-proton pull request #:

2017-12-11 Thread ssorj
Github user ssorj commented on the pull request: https://github.com/apache/qpid-proton/commit/fe9069f9d9f5e27a8c3609eec366517ed8207b20#commitcomment-26196677 In tools/py/proctest.py: In tools/py/proctest.py on line 10: This looks unintended

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-08 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/110 @dmitrytokarev , I was failing at making it merge the way I wanted. I will try to figure out the right sequence of commands so I get it right next time

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-08 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/110 @aikchar , I applied this patch. Please close when you get a chance. https://github.com/apache/qpid-proton/commit/2b033949c54549591113e61ea33e625f9b898cbb

[GitHub] qpid-proton issue #127: PROTON-1651 Fix typos found by the spellchecker

2017-12-08 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/127 @jdanekrh , I adapted this patch and applied it. I excluded any diffs against the Ruby binding since it's been revamped. If you're satisified, please close. https://github.com/apache

[GitHub] qpid-proton issue #130: Add coverage reporting for the Ruby binding

2017-12-08 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/130 We'll get this when 0.20.0 opens. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e

[GitHub] qpid-proton issue #95: PROTON-1412 Add fuzzers to proton-c tests

2017-12-08 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/95 We'll try to get this for 0.20.0. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail

[GitHub] qpid-proton issue #106: Added command line parameters for configure URL and ...

2017-12-08 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/106 @ppatierno , would you close this. It's now part of 0.18.0. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

2017-12-07 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/224#discussion_r155647815 --- Diff: src/connection_manager.c --- @@ -45,6 +45,7 @@ struct qd_config_ssl_profile_t { char*ssl_certificate_file; char

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

2017-12-07 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/224#discussion_r155652198 --- Diff: include/qpid/dispatch/server.h --- @@ -305,6 +305,12 @@ typedef struct qd_server_config_t { */ char *ciphers

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

2017-12-07 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/224#discussion_r155651659 --- Diff: python/qpid_dispatch/management/qdrouter.json --- @@ -515,7 +515,12 @@ "type"

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

2017-12-07 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/224#discussion_r155647744 --- Diff: src/connection_manager.c --- @@ -45,6 +45,7 @@ struct qd_config_ssl_profile_t { char*ssl_certificate_file; char

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

2017-12-07 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/224#discussion_r155649659 --- Diff: include/qpid/dispatch/server.h --- @@ -305,6 +305,12 @@ typedef struct qd_server_config_t { */ char *ciphers

[GitHub] qpid-proton pull request #126: PROTON-1632: WIP: Split library versions

2017-10-16 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/126 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #126: PROTON-1632: WIP: Split library versions

2017-10-16 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/126 https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=7c252e9 --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] qpid-proton pull request #126: PROTON-1632: WIP: Split library versions

2017-10-15 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/126 PROTON-1632: WIP: Split library versions You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssorj/qpid-proton ssorj-versions Alternatively you

[GitHub] qpid-cpp issue #10: Assorted C++ build fixes for review

2017-10-11 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-cpp/pull/10 @chrisrichardson77, thanks for taking a look at this. I really appreciate it. I adjusted my changes locally in according to your suggestions. Only one initialization problem arises now

[GitHub] qpid-proton issue #120: PROTON-1369: Add deprecation warnings to the C++ bin...

2017-10-10 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/120 Changes made per the review. I took part of the logic from the cmake deprecation macro, but kept some of the conditions from the previous iteration because they are more consistent

[GitHub] qpid-proton issue #120: PROTON-1369: Add deprecation warnings to the C++ bin...

2017-10-08 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/120 "I note that it doesn't include the declaration itself - I take this to mean that you can choose the correct place to put the macro do it works for all the supported compilers - This cert

[GitHub] qpid-proton pull request #121: PROTON-1368: Remove parser from the public AP...

2017-09-27 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/121 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #121: PROTON-1368: Remove parser from the public API

2017-09-27 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/121 https://github.com/apache/qpid-proton/commit/ea02b93374b527206eef3a1c7def939eff7804fb --- - To unsubscribe, e-mail: dev

[GitHub] qpid-proton pull request #121: PROTON-1368: Remove parser from the public AP...

2017-09-26 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/121 PROTON-1368: Remove parser from the public API You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssorj/qpid-proton ssorj-make-parser-internal

[GitHub] qpid-proton pull request #120: PROTON-1369: Add deprecation warnings to the ...

2017-09-26 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/120 PROTON-1369: Add deprecation warnings to the C++ binding Changes - Add warnings for default_container.hpp, function.hpp, url.hpp, and some methods in value.hpp - Removed some

[GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review

2017-09-21 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-cpp/pull/10 Assorted C++ build fixes for review Do not merge. For review purposes only. This includes the sketchy initialization changes to make things compile on Fedora 26. It now also includes

[GitHub] qpid-cpp pull request #9: Highly sketchy fixes for initialization warnings

2017-09-21 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-cpp/pull/9 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp pull request #9: Highly sketchy fixes for initialization warnings

2017-09-21 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-cpp/pull/9 Highly sketchy fixes for initialization warnings Don't merge this. This commit gets things building on Fedora 26, addressing QPID-7893 [1]. I'm stabbing in the dark when it comes to C

[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

2017-08-09 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

2017-08-09 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/115 PROTON-1533: Fix swig deprecation warnings For review You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssorj/qpid-proton master Alternatively

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

2017-05-19 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/105#discussion_r117524549 --- Diff: proton-c/bindings/cpp/include/proton/work_queue.hpp --- @@ -0,0 +1,368 @@ +#ifndef PROTON_EVENT_LOOP_HPP --- End diff

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

2017-05-19 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/105#discussion_r117524348 --- Diff: proton-c/bindings/cpp/include/proton/message.hpp --- @@ -329,11 +329,7 @@ class message { mutable annotation_map message_annotations_

[GitHub] qpid-proton pull request #93: PROTON-1312: fix memory leak on BlockingConnec...

2017-01-10 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/93#discussion_r95481951 --- Diff: proton-c/bindings/python/proton/__init__.py --- @@ -2581,6 +2581,9 @@ def close(self): """ se

[GitHub] qpid-proton pull request #93: PROTON-1312: fix memory leak on BlockingConnec...

2017-01-10 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/93#discussion_r95481898 --- Diff: proton-c/bindings/python/proton/utils.py --- @@ -132,10 +132,12 @@ def __init__(self, connection, receiver, fetcher, credit=1

[GitHub] qpid-proton pull request #93: PROTON-1312: fix memory leak on BlockingConnec...

2017-01-10 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/93#discussion_r95426588 --- Diff: proton-c/bindings/python/proton/utils.py --- @@ -132,10 +132,12 @@ def __init__(self, connection, receiver, fetcher, credit=1

[GitHub] qpid-proton pull request #93: PROTON-1312: fix memory leak on BlockingConnec...

2017-01-10 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/93#discussion_r95426083 --- Diff: proton-c/bindings/python/proton/__init__.py --- @@ -2581,6 +2581,9 @@ def close(self): """ se