[GitHub] qpid-proton pull request #:

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on the pull request: https://github.com/apache/qpid-proton/commit/da7f5056a45528196be6733fc56a1f41bda58ded#commitcomment-25156357 In tests/python/proton_tests/utils.py: In tests/python/proton_tests/utils.py on line 180: this has to be `except

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146539425 --- Diff: proton-c/bindings/cpp/src/messaging_adapter.cpp --- @@ -275,7 +275,7 @@ void on_transport_closed(messaging_handler& handler, pn_event_t*

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146539063 --- Diff: tests/python/proton_tests/messenger.py --- @@ -629,7 +629,7 @@ def testDefaultRewriteSUHPN(self): def testDefaultRewriteSUPHPN(self):

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538990 --- Diff: tests/python/proton_tests/message.py --- @@ -69,7 +69,7 @@ def testPriority(self): def testTtl(self): self._test("ttl", 0,

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538930 --- Diff: proton-c/bindings/ruby/lib/reactor/container.rb --- @@ -155,7 +155,7 @@ def create_sender(context, opts = {})

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538833 --- Diff: proton-c/bindings/ruby/lib/handler/endpoint_state_handler.rb --- @@ -164,7 +164,7 @@ def on_link_error(event)

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538752 --- Diff: proton-c/bindings/ruby/lib/core/ssl.rb --- @@ -126,25 +126,25 @@ def cipher_name end # Returns the name of the SSL

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538680 --- Diff: proton-c/bindings/ruby/lib/core/connection.rb --- @@ -201,7 +201,7 @@ def remote_desired_capabilities # @return [Data] The remote

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538625 --- Diff: proton-c/bindings/javascript/module.js --- @@ -327,7 +327,7 @@ Module.EventDispatch = new function() { // Note the use of new to create a

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538458 --- Diff: proton-c/bindings/cpp/src/interop_test.cpp --- @@ -57,8 +57,8 @@ void test_data_ostream() { ASSERT_EQUAL("true, false, 42, 42, -42,

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538275 --- Diff: examples/cpp/multithreaded_client.cpp --- @@ -47,7 +47,7 @@ #include #include -// Lock output from threads to avoid

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton/pull/127 PROTON-1651 Fix typos found by the spellchecker > injecter proton.Injecter * injector, maybe. this is public api, so probably should not be touched, though > Now that we've

[GitHub] qpid-proton pull request #126: PROTON-1632: WIP: Split library versions

2017-10-16 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/126 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #126: PROTON-1632: WIP: Split library versions

2017-10-15 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/126 PROTON-1632: WIP: Split library versions You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssorj/qpid-proton ssorj-versions Alternatively you

[GitHub] qpid-proton pull request #125: Steps to make openssl.c thread safe, marked w...

2017-10-13 Thread alanconway
GitHub user alanconway opened a pull request: https://github.com/apache/qpid-proton/pull/125 Steps to make openssl.c thread safe, marked with FIXME comments. This is not a real PR, just for comments. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] qpid-proton pull request #120: PROTON-1369: Add deprecation warnings to the ...

2017-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/120 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #124: PROTON-1289 Add coverage analysis into build ...

2017-10-12 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton/pull/124 PROTON-1289 Add coverage analysis into build system You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/qpid-proton jd_coverage

[GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings

2017-10-12 Thread jdanekrh
Github user jdanekrh closed the pull request at: https://github.com/apache/qpid-proton/pull/119 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #123: PROTON-1617 - Added Python binding access to ...

2017-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/123 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #123: PROTON-1617 - Added Python binding access to ...

2017-10-09 Thread ted-ross
GitHub user ted-ross opened a pull request: https://github.com/apache/qpid-proton/pull/123 PROTON-1617 - Added Python binding access to the delivery aborted fea… …ture. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] qpid-proton pull request #122: update pointer on reallocated message buffer ...

2017-09-29 Thread Paise
GitHub user Paise opened a pull request: https://github.com/apache/qpid-proton/pull/122 update pointer on reallocated message buffer memory During the reallocation address of the message buffer can be changed. We need to update mbuf.start as well as mbuf.size. You can merge this

[GitHub] qpid-proton pull request #121: PROTON-1368: Remove parser from the public AP...

2017-09-27 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/121 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #121: PROTON-1368: Remove parser from the public AP...

2017-09-26 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/121 PROTON-1368: Remove parser from the public API You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssorj/qpid-proton ssorj-make-parser-internal

[GitHub] qpid-proton pull request #120: PROTON-1369: Add deprecation warnings to the ...

2017-09-26 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/120 PROTON-1369: Add deprecation warnings to the C++ binding Changes - Add warnings for default_container.hpp, function.hpp, url.hpp, and some methods in value.hpp - Removed some

[GitHub] qpid-proton pull request #:

2017-09-07 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/commit/29272ca3948233a417ebc04ba80dedaefc7a4104#commitcomment-24156580 In CMakeLists.txt: In CMakeLists.txt on line 177: On Thu, 2017-09-07 at 09:02 -0700, Andrew Stitcher wrote: >

[GitHub] qpid-proton pull request #:

2017-09-07 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/commit/29272ca3948233a417ebc04ba80dedaefc7a4104#commitcomment-24156365 In CMakeLists.txt: In CMakeLists.txt on line 177: On Thu, 2017-09-07 at 09:02 -0700, Andrew Stitcher wrote: >

[GitHub] qpid-proton pull request #:

2017-09-07 Thread astitcher
Github user astitcher commented on the pull request: https://github.com/apache/qpid-proton/commit/29272ca3948233a417ebc04ba80dedaefc7a4104#commitcomment-24146519 In CMakeLists.txt: In CMakeLists.txt on line 177: I agree with @jdanekrh - very many (most really) of the proton-c

[GitHub] qpid-proton pull request #:

2017-09-07 Thread jdanekrh
Github user jdanekrh commented on the pull request: https://github.com/apache/qpid-proton/commit/29272ca3948233a417ebc04ba80dedaefc7a4104#commitcomment-24146198 In CMakeLists.txt: In CMakeLists.txt on line 177: @alanconway Why not build the Proton binding? It seemed to work

[GitHub] qpid-proton pull request #117: PROTON-1540 Add options to enable Sanitizers ...

2017-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/117 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/119#discussion_r137037295 --- Diff: proton-c/src/proactor/libuv.c --- @@ -1179,7 +1179,10 @@ pn_proactor_t *pn_proactor() { pn_proactor_t *p = (pn_proactor_t*)calloc(1,

[GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/119#discussion_r137036761 --- Diff: proton-c/src/proactor/libuv.c --- @@ -1179,7 +1179,10 @@ pn_proactor_t *pn_proactor() { pn_proactor_t *p = (pn_proactor_t*)calloc(1,

[GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/119#discussion_r136951249 --- Diff: proton-c/src/proactor/libuv.c --- @@ -1179,7 +1179,10 @@ pn_proactor_t *pn_proactor() { pn_proactor_t *p = (pn_proactor_t*)calloc(1,

[GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton/pull/119 NO-JIRA Fix CppCheck warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/qpid-proton jd_cppcheck Alternatively you can

[GitHub] qpid-proton pull request #118: PROTON-1326: update python setup.py to avoid ...

2017-08-25 Thread kgiusti
GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-proton/pull/118 PROTON-1326: update python setup.py to avoid using incompatible opens… …sl 1.1.0 Proposing this patch against 0.17.x to fix a problem in the python-qpid-proton pypi packages.

[GitHub] qpid-proton pull request #116: PROTON-1532: Allow insecure mechanism in SASL

2017-08-23 Thread gberginc
Github user gberginc closed the pull request at: https://github.com/apache/qpid-proton/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request #117: PROTON-1540 Add options to enable Sanitizers ...

2017-08-14 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton/pull/117 PROTON-1540 Add options to enable Sanitizers to CMake build You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/qpid-proton

[GitHub] qpid-proton pull request #116: PROTON-1532: Allow insecure mechanism in SASL

2017-08-11 Thread gberginc
GitHub user gberginc opened a pull request: https://github.com/apache/qpid-proton/pull/116 PROTON-1532: Allow insecure mechanism in SASL This commit extends SASL with the additional allow_insecure_mechs allowing users to override the defailt (false) authentication and use the plain

[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

2017-08-09 Thread ssorj
Github user ssorj closed the pull request at: https://github.com/apache/qpid-proton/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

2017-08-09 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/115#discussion_r132225370 --- Diff: proton-c/bindings/php/CMakeLists.txt --- @@ -34,7 +34,7 @@ list(APPEND SWIG_MODULE_cproton_EXTRA_DEPS

[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

2017-08-09 Thread ssorj
GitHub user ssorj opened a pull request: https://github.com/apache/qpid-proton/pull/115 PROTON-1533: Fix swig deprecation warnings For review You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssorj/qpid-proton master Alternatively

[GitHub] qpid-proton pull request #114: fix ruby Messenger example

2017-07-27 Thread kbrock
GitHub user kbrock opened a pull request: https://github.com/apache/qpid-proton/pull/114 fix ruby Messenger example Some ruby examples have the correct package for `Messenger`, while others have a truncated package. Thanks for the great gem and packages You can merge this

[GitHub] qpid-proton pull request #113: [Solaris] fix build with gcc-4.9

2017-07-26 Thread matlo607
GitHub user matlo607 opened a pull request: https://github.com/apache/qpid-proton/pull/113 [Solaris] fix build with gcc-4.9 You can merge this pull request into a Git repository by running: $ git pull https://github.com/matlo607/qpid-proton fix-build-gcc49-solaris

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

2017-07-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request #111: Fix mapping of LONG for Ruby 2.4+

2017-07-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request #112: fix paths to test binaries

2017-07-21 Thread matlo607
GitHub user matlo607 opened a pull request: https://github.com/apache/qpid-proton/pull/112 fix paths to test binaries I could not execute the unit tests on Linux after a build with the package manager conan. I got various errors as below : ``` Could not find executable

[GitHub] qpid-proton pull request #111: Fix mapping of LONG for Ruby 2.4+

2017-07-20 Thread Fryguy
GitHub user Fryguy reopened a pull request: https://github.com/apache/qpid-proton/pull/111 Fix mapping of LONG for Ruby 2.4+ ``` (Ruby 2.4.1) > irb > RUBY_VERSION < "2.4" ? [Fixnum, Bignum] : [Integer] => [Integer] (Ruby 2.3.3) > irb > RUBY_VERSION < "2.4" ?

[GitHub] qpid-proton pull request #111: Fix mapping of LONG for Ruby 2.4+

2017-07-20 Thread Fryguy
Github user Fryguy closed the pull request at: https://github.com/apache/qpid-proton/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request #111: Fix mapping of LONG for Ruby 2.4+

2017-07-18 Thread Fryguy
GitHub user Fryguy opened a pull request: https://github.com/apache/qpid-proton/pull/111 Fix mapping of LONG for Ruby 2.4+ (Ruby 2.4.1) > irb > RUBY_VERSION < "2.4" ? [Fixnum, Bignum] : [Integer] => [Integer] (Ruby 2.3.3) > irb > RUBY_VERSION < "2.4" ? [Fixnum,

[GitHub] qpid-proton pull request #110: Fix for PROTON-1517

2017-07-17 Thread aikchar
GitHub user aikchar opened a pull request: https://github.com/apache/qpid-proton/pull/110 Fix for PROTON-1517 Fixes the bug reported in [PROTON-1517](https://issues.apache.org/jira/browse/PROTON-1517). You can merge this pull request into a Git repository by running: $ git

[GitHub] qpid-proton pull request #109: Cpp drop thread safe

2017-07-07 Thread alanconway
GitHub user alanconway opened a pull request: https://github.com/apache/qpid-proton/pull/109 Cpp drop thread safe Make container::connect(), open_sender() etc. return void and remove thread_safe<> and returned<>. With the work_queue changes everything works fine with

[GitHub] qpid-proton pull request #108: PROTON-1500: Implement plugin interface for S...

2017-06-20 Thread astitcher
Github user astitcher closed the pull request at: https://github.com/apache/qpid-proton/pull/108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] qpid-proton pull request #108: PROTON-1500: Implement plugin interface for S...

2017-06-09 Thread astitcher
GitHub user astitcher opened a pull request: https://github.com/apache/qpid-proton/pull/108 PROTON-1500: Implement plugin interface for SASL implementations - Allow sasl implementation to be selected per connection - Compile both default and cyrus implementation (if we can)

[GitHub] qpid-proton pull request #107: 0.9.x

2017-06-05 Thread mrawd
Github user mrawd closed the pull request at: https://github.com/apache/qpid-proton/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-proton pull request #107: 0.9.x

2017-06-05 Thread mrawd
GitHub user mrawd opened a pull request: https://github.com/apache/qpid-proton/pull/107 0.9.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/qpid-proton 0.9.x Alternatively you can review and apply these changes as the

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

2017-05-25 Thread alanconway
Github user alanconway commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/105#discussion_r118509113 --- Diff: proton-c/bindings/cpp/src/handler.cpp --- @@ -49,17 +50,33 @@ void messaging_handler::on_transport_error(transport ) {

[GitHub] qpid-proton pull request #106: Added command line parameters for configure U...

2017-05-22 Thread ppatierno
GitHub user ppatierno opened a pull request: https://github.com/apache/qpid-proton/pull/106 Added command line parameters for configure URL and address It refers to this https://issues.apache.org/jira/browse/PROTON-1488 You can merge this pull request into a Git repository by

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

2017-05-19 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/105#discussion_r117555738 --- Diff: proton-c/bindings/cpp/include/proton/message.hpp --- @@ -329,11 +329,7 @@ class message { mutable annotation_map

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

2017-05-19 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/105#discussion_r117554762 --- Diff: proton-c/bindings/cpp/include/proton/work_queue.hpp --- @@ -0,0 +1,368 @@ +#ifndef PROTON_EVENT_LOOP_HPP --- End diff --

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

2017-05-19 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/105#discussion_r117524549 --- Diff: proton-c/bindings/cpp/include/proton/work_queue.hpp --- @@ -0,0 +1,368 @@ +#ifndef PROTON_EVENT_LOOP_HPP --- End diff -- This

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

2017-05-19 Thread ssorj
Github user ssorj commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/105#discussion_r117524348 --- Diff: proton-c/bindings/cpp/include/proton/message.hpp --- @@ -329,11 +329,7 @@ class message { mutable annotation_map message_annotations_;

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

2017-05-17 Thread astitcher
GitHub user astitcher opened a pull request: https://github.com/apache/qpid-proton/pull/105 Port of C++ binding to Proton Proactor This set of changes reimplements the C++ binding do that it no longer uses the Proton Reactor library at all and now only links to the Proton Core and

[GitHub] qpid-proton pull request #104: Port of thre C++ binding to the Proton Proact...

2017-05-17 Thread astitcher
Github user astitcher closed the pull request at: https://github.com/apache/qpid-proton/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] qpid-proton pull request #104: Port of thre C++ binding to the Proton Proact...

2017-05-17 Thread astitcher
GitHub user astitcher opened a pull request: https://github.com/apache/qpid-proton/pull/104 Port of thre C++ binding to the Proton Proactor library This set of changes reimplements the C++ binding do that it no longer uses the Proton Reactor library at all and now only links to the

[GitHub] qpid-proton pull request #:

2017-05-05 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/commit/a61f50e94ceb74ed81665192e1d3051ec8be0208#commitcomment-22036781 DOH! Embarassing. Fixed now on master. --- If your project is set up for it, you can reply to this email and have your

[GitHub] qpid-proton pull request #:

2017-05-05 Thread dwray
Github user dwray commented on the pull request: https://github.com/apache/qpid-proton/commit/a61f50e94ceb74ed81665192e1d3051ec8be0208#commitcomment-22033928 Your update didn't work for me. It looks like the TrimPrefix expression is back to front, swapping it round to: addr :=

[GitHub] qpid-proton pull request #103: PROTON-1463 GO-Bindings Added AMQP Address Me...

2017-04-19 Thread mastash3ff
GitHub user mastash3ff opened a pull request: https://github.com/apache/qpid-proton/pull/103 PROTON-1463 GO-Bindings Added AMQP Address Method Original examples used url.Path variable to return the amqp address. The address returned added an unnecessary prepended slash character.

[GitHub] qpid-proton pull request #102: NO-JIRA: revert temporary workaround for PROT...

2017-04-13 Thread kgiusti
Github user kgiusti closed the pull request at: https://github.com/apache/qpid-proton/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request #100: PROTON-1408 -- fixes for message ID wraparoun...

2017-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request #102: NO-JIRA: revert temporary workaround for PROT...

2017-03-31 Thread kgiusti
GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-proton/pull/102 NO-JIRA: revert temporary workaround for PROTON-1453 Looks like the fix for PROTON-1453 resolves the problems travis hit for the tox tests. This change reverts just the change where the

[GitHub] qpid-proton pull request #101: PROTON-1453: properly terminate output string...

2017-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request #101: PROTON-1453: properly terminate output string...

2017-03-30 Thread kgiusti
GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-proton/pull/101 PROTON-1453: properly terminate output string buffer Fixes the occasional segfault when running travis (as encountered by aconway) You can merge this pull request into a Git repository by

[GitHub] qpid-proton pull request #100: PROTON-1408 -- fixes for message ID wraparoun...

2017-03-29 Thread mgoulish
GitHub user mgoulish opened a pull request: https://github.com/apache/qpid-proton/pull/100 PROTON-1408 -- fixes for message ID wraparound bugs You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgoulish/qpid-proton master

[GitHub] qpid-proton pull request #99: PROTON-1408 -- fix for msg id rollover bug

2017-03-29 Thread mgoulish
Github user mgoulish closed the pull request at: https://github.com/apache/qpid-proton/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request #99: PROTON-1408 -- fix for msg id rollover bug

2017-03-27 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/99#discussion_r108212167 --- Diff: proton-c/src/core/transport.c --- @@ -82,9 +82,11 @@ void pn_delivery_map_free(pn_delivery_map_t *db) pn_free(db->deliveries); }

[GitHub] qpid-proton pull request #99: PROTON-1408 -- fix for msg id rollover bug

2017-03-27 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/99#discussion_r108192064 --- Diff: proton-c/src/core/transport.c --- @@ -1620,12 +1622,12 @@ static int pn_scan_error(pn_data_t *data, pn_condition_t *condition, const char

[GitHub] qpid-proton pull request #99: PROTON-1408 -- partial fix for msg id rollover...

2017-03-21 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/99#discussion_r107258218 --- Diff: proton-c/src/core/transport.c --- @@ -1648,7 +1659,7 @@ int pn_do_disposition(pn_transport_t *transport, uint8_t frame_type, uint16_t ch

[GitHub] qpid-proton pull request #99: PROTON-1408 -- partial fix for msg id rollover...

2017-03-21 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/99#discussion_r107257116 --- Diff: proton-c/src/core/transport.c --- @@ -1619,6 +1619,17 @@ static int pn_scan_error(pn_data_t *data, pn_condition_t *condition, const char

[GitHub] qpid-proton pull request #99: PROTON-1408 -- partial fix for msg id rollover...

2017-03-21 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/99#discussion_r107255885 --- Diff: proton-c/src/core/transport.c --- @@ -1619,6 +1619,17 @@ static int pn_scan_error(pn_data_t *data, pn_condition_t *condition, const char

[GitHub] qpid-proton pull request #99: PROTON-1408 -- partial fix for msg id rollover...

2017-03-21 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/99#discussion_r107256041 --- Diff: proton-c/src/core/transport.c --- @@ -1648,7 +1659,7 @@ int pn_do_disposition(pn_transport_t *transport, uint8_t frame_type, uint16_t ch

[GitHub] qpid-proton pull request #99: PROTON-1408 -- partial fix for msg id rollover...

2017-03-21 Thread mgoulish
GitHub user mgoulish opened a pull request: https://github.com/apache/qpid-proton/pull/99 PROTON-1408 -- partial fix for msg id rollover bug I'm getting a different hang now, but it looks like this part of the code is doing the right thing. Before this, the original

[GitHub] qpid-proton pull request #98: PROTON-1434: add test blacklist to tox tests

2017-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-proton pull request #98: PROTON-1434: add test blacklist to tox tests

2017-03-13 Thread kgiusti
GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-proton/pull/98 PROTON-1434: add test blacklist to tox tests Helps speed up the time spent running the tox tests You can merge this pull request into a Git repository by running: $ git pull

[GitHub] qpid-proton pull request #97: PROTON-1345: update setup.py.in with libuv and...

2017-03-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-proton pull request #71: Adding WebSocket functionality to Proton-J

2017-03-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-proton pull request #96: PROTON-1417 fix TypeError when address is alre...

2017-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-proton pull request #97: PROTON-1345: update setup.py.in with libuv and...

2017-03-07 Thread kgiusti
GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-proton/pull/97 PROTON-1345: update setup.py.in with libuv and cmake source list Had to update the setup.py.in file with Alan Conway's libuv/proactor stuff. You can merge this pull request into a Git

[GitHub] qpid-proton pull request #96: PROTON-1417 fix TypeError when address is alre...

2017-02-27 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton/pull/96 PROTON-1417 fix TypeError when address is already in use You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/qpid-proton-fuzz patch-1

[GitHub] qpid-proton pull request #95: [WIP] PROTON-1412 Add fuzzers to proton-c test...

2017-02-25 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r103089568 --- Diff: proton-c/CMakeLists.txt --- @@ -729,6 +729,12 @@ if (BUILD_PYTHON) endif (BUILD_PYTHON) +# fuzz tests: tests/fuzz

[GitHub] qpid-proton pull request #95: [WIP] PROTON-1412 Add fuzzers to proton-c test...

2017-02-25 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r103089541 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r103038483 --- Diff: proton-c/CMakeLists.txt --- @@ -729,6 +729,12 @@ if (BUILD_PYTHON) endif (BUILD_PYTHON) +# fuzz tests: tests/fuzz

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102987028 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102986492 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102984140 --- Diff: proton-c/src/tests/fuzz/README.md --- @@ -0,0 +1,45 @@ +# Fuzz testing for qpid-proton-c + +## Dockerfile + +Easiest way

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102983561 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102975218 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102974488 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread kcc
Github user kcc commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102974377 --- Diff: proton-c/src/tests/fuzz/README.md --- @@ -0,0 +1,45 @@ +# Fuzz testing for qpid-proton-c + +## Dockerfile + +Easiest way to

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread kcc
Github user kcc commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102973776 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-21 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton/pull/95 [REVIEW] Add fuzzers to proton-c tests I am hoping to get some feedback about the directories where I placed the new files and about what I did in the CMakeFiles and about the fuzzers

[GitHub] qpid-proton pull request #82: optimizations on Decoder/Encoder

2017-02-19 Thread clebertsuconic
Github user clebertsuconic closed the pull request at: https://github.com/apache/qpid-proton/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

<    1   2   3   >