Re: Review Request: Initial CTest support

2013-02-16 Thread Mary Hinton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9433/#review16693 --- For Visual Studio, the add_test will need to be changed slightly to

Re: Review Request: Initial CTest support

2013-02-14 Thread Philip Harvey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9433/#review16579 --- Looks good. I think the Testing section of the top-level README

Re: Review Request: Initial CTest support

2013-02-14 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9433/#review16589 --- Having 2 parllel build systems is a serious pain, as qpid

Re: Review Request: Initial CTest support

2013-02-14 Thread Alan Conway
On Feb. 14, 2013, 2:25 p.m., Philip Harvey wrote: http://svn.apache.org/repos/asf/qpid/proton/trunk/CMakeLists.txt, line 77 https://reviews.apache.org/r/9433/diff/1/?file=258587#file258587line77 If I understand correctly, we are only calling Maven from CMake as a short term hack,

Re: Review Request: Initial CTest support

2013-02-14 Thread Mary Hinton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9433/#review16596 --- I put your changes in my code and ran it. I was trying to figure out

Re: Review Request: Initial CTest support

2013-02-14 Thread Cliff Jansen
I stated that the code only worked for Linux so far. Porting this to Windows up front would have a) made the example less clear and b) delayed getting initial feedback. I already know about the ';', a bad call to env.py, a portability bug in env.py (after fixing the former), and the need to deal

Review Request: Initial CTest support

2013-02-13 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9433/ --- Review request for qpid and Mary Hinton. Description --- The smallest