Re: Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

2013-04-18 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10595/#review19387 --- I basically like this. I don't see the point of str() added to

Re: Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

2013-04-18 Thread Alan Conway
On April 18, 2013, 2:31 p.m., Andrew Stitcher wrote: I basically like this. I don't see the point of str() added to Duration though given there's operator and operator. I assume that the options parser uses boost::lexical_cast internally so can automatically take advantage of

Re: Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

2013-04-18 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10595/ --- (Updated April 18, 2013, 4:14 p.m.) Review request for qpid, Andrew Stitcher

Re: Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

2013-04-18 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10595/#review19393 --- Ship it! Except for removing the declaration of toTimeval() from

Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

2013-04-17 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10595/ --- Review request for qpid, Andrew Stitcher and Gordon Sim. Description ---