Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-26 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/ --- (Updated Nov. 26, 2013, 4:52 p.m.) Review request for qpid and Justin Ross.

Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-26 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/#review29442 --- This looks good to me (but I'm not a python or ruby expert). Did

Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-26 Thread Justin Ross
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/#review29446 --- Ship it! The python looks good to me. - Justin Ross On Nov. 26,

Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-26 Thread Kenneth Giusti
On Nov. 26, 2013, 5:51 p.m., Andrew Stitcher wrote: This looks good to me (but I'm not a python or ruby expert). Did you intend to make the warning unconditional though? It seems there is no way to turn it off if you know what you are doing. That might be a little alarming to end

Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-25 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/#review29372 --- Ship it! Ship It! - Chug Rolke On Nov. 22, 2013, 9:01 p.m.,

Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-25 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/#review29373 --- /trunk/qpid/cpp/include/qmf/Agent.h

Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-22 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/ --- Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross. Bugs:

Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-22 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/ --- (Updated Nov. 22, 2013, 4:55 p.m.) Review request for qpid, Andrew Stitcher,

Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-22 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/#review29304 --- /trunk/qpid/cpp/include/qmf/Agent.h

Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API

2013-11-22 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/ --- (Updated Nov. 22, 2013, 9:01 p.m.) Review request for qpid, Andrew Stitcher,