Re: Review Request 22273: In Proton python tests, start subprocesses with Popen(..., shell=os.name==nt)

2014-06-12 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22273/#review45520 --- Ship it! +1 to andrew's comment - Rafael Schloming On June 11,

Re: Review Request 22273: In Proton python tests, start subprocesses with Popen(..., shell=os.name==nt)

2014-06-11 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22273/ --- (Updated June 11, 2014, 2:13 p.m.) Review request for qpid and Rafael

Re: Review Request 22273: In Proton python tests, start subprocesses with Popen(..., shell=os.name==nt)

2014-06-11 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22273/ --- (Updated June 11, 2014, 2:20 p.m.) Review request for qpid, Andrew Stitcher

Re: Review Request 22273: In Proton python tests, start subprocesses with Popen(..., shell=os.name==nt)

2014-06-11 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22273/#review45439 --- proton/trunk/tests/python/proton_tests/common.py

Re: Review Request 22273: In Proton python tests, start subprocesses with Popen(..., shell=os.name==nt)

2014-06-09 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22273/#review45078 --- This change is not sufficient. It only works on the systems where

Review Request 22273: In Proton python tests, start subprocesses with Popen(..., shell=os.name==nt)

2014-06-05 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22273/ --- Review request for qpid and Rafael Schloming. Bugs: PROTON-595

Re: Review Request 22273: In Proton python tests, start subprocesses with Popen(..., shell=os.name==nt)

2014-06-05 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22273/ --- (Updated June 5, 2014, 6:14 p.m.) Review request for qpid and Rafael