Review Request: QPID-3345: restore/add ability to use sys props to select the NetworkTransport used to make/accept connections
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1087/ --- Review request for qpid. Summary --- QPID-3345: transport implementations for client/broker sides controllable via new System Properties and Reflection. This addresses bug QPID-3345. https://issues.apache.org/jira/browse/QPID-3345 Diffs - /trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java PRE-CREATION /trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java 1145481 /trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java 1145481 /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java 1145481 /trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java 1145481 Diff: https://reviews.apache.org/r/1087/diff Testing --- Additional unit test and exercised by existing system test suite (0-9-1/0-10 code paths) Thanks, Keith
[jira] [Commented] (QPID-3345) Make new transport implementations pluggable
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063789#comment-13063789 ] jirapos...@reviews.apache.org commented on QPID-3345: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1087/ --- Review request for qpid. Summary --- QPID-3345: transport implementations for client/broker sides controllable via new System Properties and Reflection. This addresses bug QPID-3345. https://issues.apache.org/jira/browse/QPID-3345 Diffs - /trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java PRE-CREATION /trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java 1145481 /trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java 1145481 /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java 1145481 /trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java 1145481 Diff: https://reviews.apache.org/r/1087/diff Testing --- Additional unit test and exercised by existing system test suite (0-9-1/0-10 code paths) Thanks, Keith Make new transport implementations pluggable Key: QPID-3345 URL: https://issues.apache.org/jira/browse/QPID-3345 Project: Qpid Issue Type: Improvement Components: Java Client, Java Common Reporter: Keith Wall Assignee: Rajith Attapattu Fix For: 0.13 Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: 0.12 release update - RC1 this week
Given that we voted to stop releasing standalone artifacts for the pure ruby client with the last release, is there any reason to keep it in the repository? I noticed that the first thing that happened with the 0.10 release was that a user came looking for the ruby client when the artifact went missing, found the code in the 'full release' archive instead, and just used that. A highly effective removal. I have said in the past I'd prefer to use a non-trunk attic area, but the concensus was to go for deletion, although nothing has happened since that discussion. Robbie On 11 July 2011 22:13, Darryl L. Pierce dpie...@redhat.com wrote: On Mon, Jul 11, 2011 at 05:07:51PM -0400, Justin Ross wrote: Hello. This is a reminder that I will be producing the first 0.12 release candidate this week, probably Wednesday evening or Thursday morning (my time, US east coast). I haven't seen any requests to merge to the release branch so far. I know of one pending fix for a windows distribution problem (the one Chuck mailed about). If there are others in the wings, let me know so I can kick off the approval process. If posted a fix for BZ#704271. It's a one-line fix for the pure Ruby APIs. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-3341) Remove unused/dead transport code
[ https://issues.apache.org/jira/browse/QPID-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-3341. -- Resolution: Fixed Closing out, patch applied. Remove unused/dead transport code - Key: QPID-3341 URL: https://issues.apache.org/jira/browse/QPID-3341 Project: Qpid Issue Type: Improvement Components: Java Broker, Java Client, Java Common Reporter: Keith Wall Assignee: Robbie Gemmell Fix For: 0.13 Attachments: 0001-QPID-3341-remove-unused-dead-transport-code-and-acco.patch There are several dead sections of transport code within MINANetworkDriver and test support classes that are no longer in use. These will be removed. There are also several features, such as protect IO, that have been broken by many previous commits over four+ years, and have no test coverage. These faetures will also be removed. This improvement will support future work to rationalise the transport implementations. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-2815) Refactor broker startup to enable a uniform method of starting the broker
[ https://issues.apache.org/jira/browse/QPID-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-2815. -- Resolution: Fixed Closing out, patch applied. Refactor broker startup to enable a uniform method of starting the broker - Key: QPID-2815 URL: https://issues.apache.org/jira/browse/QPID-2815 Project: Qpid Issue Type: Improvement Affects Versions: 0.7 Reporter: Andrew Kennedy Assignee: Robbie Gemmell Fix For: 0.13 Attachments: 0006-QPID-2815-refactor-broker-startup-to-present-a-clean.patch Update the way the broker is started to decouple it from any particular protocol version or transport. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-3026) The ApplicationRegistry object should be a singleton
[ https://issues.apache.org/jira/browse/QPID-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-3026. -- Resolution: Fixed Closing out, patch applied. The ApplicationRegistry object should be a singleton Key: QPID-3026 URL: https://issues.apache.org/jira/browse/QPID-3026 Project: Qpid Issue Type: Improvement Components: Java Broker Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Robbie Gemmell Priority: Minor Fix For: 0.11 Attachments: 0005-QPID-3026-remove-incomplete-support-for-multiple-App.patch The ApplicationRegistry can currently have multiple instances, in order to cater for multiple brokers in the same VM. However, *many* parts of the code simply call ApplcationRegistry.getInstance() to obtain a reference, meaning multiple instances are ignored. The only time this is ever useful is for certain types of tests, therefore the capability to have multiple broker instances should be removed. Any tests that require multiple brokers can start a VM broker and an external, or two external brokers. In general, test-only code should not be made available to the rest of the application. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-3343) Refactor testprofiles to allow for the testing of all protocols with client/broker residing in the same VM.
[ https://issues.apache.org/jira/browse/QPID-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-3343. -- Resolution: Fixed Closing out, patch applied. Refactor testprofiles to allow for the testing of all protocols with client/broker residing in the same VM. --- Key: QPID-3343 URL: https://issues.apache.org/jira/browse/QPID-3343 Project: Qpid Issue Type: Improvement Components: Java Tests Reporter: Keith Wall Assignee: Robbie Gemmell Fix For: 0.13 Attachments: 0007-QPID-3343-refactor-test-profiles-to-allow-testing-wi.patch Refactor the test framework to make use of the interface offered by QPID-2815 to start/stop the broker within the JVM. Create new test profiles to test 0-9-1 and 0-10 within the same JVM considerably reducing time taken for test-cycle. Adopt new naming scheme for test profile names. Remove support for the vm:// transport. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-3275) QMF Console asynchronous correlation-id should be scoped to the session, not the specific agent
[ https://issues.apache.org/jira/browse/QPID-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved QPID-3275. Resolution: Fixed Fix Version/s: (was: 0.11) 0.13 QMF Console asynchronous correlation-id should be scoped to the session, not the specific agent --- Key: QPID-3275 URL: https://issues.apache.org/jira/browse/QPID-3275 Project: Qpid Issue Type: Improvement Components: Qpid Managment Framework Affects Versions: 0.10 Reporter: Ted Ross Assignee: Ted Ross Priority: Minor Fix For: 0.13 When using asynchronous operations from the qmf console (qmf::ConsoleSession), the correlation-id returned is scoped to the specific agent. This forces the user to combine the agent identity with the correlation-id to correlate ta response to a request. It would be more efficient if the correlation-id were guaranteed unique across all agents in the session. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3325) Make it possible to access broker shutdown hook from outside
[ https://issues.apache.org/jira/browse/QPID-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063839#comment-13063839 ] Robbie Gemmell commented on QPID-3325: -- Hi Danushka, The work Keith referenced (QPID-3026) has now been completed, in concert with other related work on broker startup (QPID-2815). Keith's suggestion from this this JIRA was not included, but I think its a good idea and should be. My main reservation with the attached patch would be that since none of our code uses the getter and its not obvious why it should be there then it would likely just get 'cleaned up' by someone at some point. Could you let us know if the reasoning behind exposing the shutdown hook thread was as queried, and whether the suggested approach would do what you are looking for? (updated patch welcome too) Thanks, Robbie Make it possible to access broker shutdown hook from outside Key: QPID-3325 URL: https://issues.apache.org/jira/browse/QPID-3325 Project: Qpid Issue Type: Improvement Reporter: Danushka Menikkumbura Assignee: Robbie Gemmell Attachments: QPID-3325.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3323) Make main method throw an exception when something goes wrong at start up so that a host applicaton can act accordingly
[ https://issues.apache.org/jira/browse/QPID-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063879#comment-13063879 ] Robbie Gemmell commented on QPID-3323: -- Hi Danushka, The broker startup refactoring I mentioned above has now been committed (mainly QPID-2815). This provides a cleaner way to configure and start Broker instances within the same JVM as other components, giving ability for the calling applications to control exception handling and isolating the presence of System.exit() calls in the Main class, outwith the actual startup/shutdown code path. As a result of this I am going to close QPID-3323 and QPID-2794. You can see example of how to use and configure one of the new Broker instances by looking at the now significantly reduced Main class. Please let us know if you have any problems using the refactored system to achieve your goal and we can look how best to resolve the issue. Regards, Robbie Make main method throw an exception when something goes wrong at start up so that a host applicaton can act accordingly --- Key: QPID-3323 URL: https://issues.apache.org/jira/browse/QPID-3323 Project: Qpid Issue Type: Improvement Reporter: Danushka Menikkumbura Assignee: Robbie Gemmell Attachments: QPID-3323.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Closed] (QPID-3323) Make main method throw an exception when something goes wrong at start up so that a host applicaton can act accordingly
[ https://issues.apache.org/jira/browse/QPID-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell closed QPID-3323. Resolution: Not A Problem Closing out. There isn't really a matching resolution given the above, so just going with Not A Problem. Make main method throw an exception when something goes wrong at start up so that a host applicaton can act accordingly --- Key: QPID-3323 URL: https://issues.apache.org/jira/browse/QPID-3323 Project: Qpid Issue Type: Improvement Reporter: Danushka Menikkumbura Assignee: Robbie Gemmell Attachments: QPID-3323.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-2794) Broker shutdown logic needs changing to run inside another process
[ https://issues.apache.org/jira/browse/QPID-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063882#comment-13063882 ] Robbie Gemmell commented on QPID-2794: -- Hi Danushka, The broker startup refactoring I mentioned above has now been committed (mainly QPID-2815). This provides a cleaner way to configure and start Broker instances within the same JVM as other components, giving ability for the calling applications to control exception handling and isolating the presence of System.exit() calls in the Main class, outwith the actual startup/shutdown code path. As a result of this I am going to close QPID-3323 and QPID-2794. You can see example of how to use and configure one of the new Broker instances by looking at the now significantly reduced Main class. Please let us know if you have any problems using the refactored system to achieve your goal and we can look how best to resolve the issue. Regards, Robbie Broker shutdown logic needs changing to run inside another process -- Key: QPID-2794 URL: https://issues.apache.org/jira/browse/QPID-2794 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Danushka Menikkumbura Assignee: Robbie Gemmell Attachments: QPID-2794.patch At the moment the broker shutdown terminates the JVM which is a problem when the broker runs inside another process. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Closed] (QPID-2794) Broker shutdown logic needs changing to run inside another process
[ https://issues.apache.org/jira/browse/QPID-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell closed QPID-2794. Resolution: Not A Problem Closing out. There isn't really a matching resolution given the above, so just going with Not A Problem. Broker shutdown logic needs changing to run inside another process -- Key: QPID-2794 URL: https://issues.apache.org/jira/browse/QPID-2794 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Danushka Menikkumbura Assignee: Robbie Gemmell Attachments: QPID-2794.patch At the moment the broker shutdown terminates the JVM which is a problem when the broker runs inside another process. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Closed] (QPID-3322) Can not enable Mina IO throttling
[ https://issues.apache.org/jira/browse/QPID-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell closed QPID-3322. Resolution: Won't Fix The work I referenced above to remove dead/unused/known-defective IO features has now been committed. Having not received a response on use of ProtectIO, and based on the previous commentary about it above, it was included in the code removal. As such I am going to close this JIRA out as a wont-fix. Can not enable Mina IO throttling - Key: QPID-3322 URL: https://issues.apache.org/jira/browse/QPID-3322 Project: Qpid Issue Type: Bug Reporter: Danushka Menikkumbura Assignee: Robbie Gemmell Attachments: QPID-3322.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3307) ClassNotfound Exception when using Qpid java client in Complex classloading Environments.
[ https://issues.apache.org/jira/browse/QPID-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063894#comment-13063894 ] Robbie Gemmell commented on QPID-3307: -- Hi Charith, Have you made any progress on adding at least happy-path unit testing for this? It would be good to get your patch applied. Regards, Robbie ClassNotfound Exception when using Qpid java client in Complex classloading Environments. --- Key: QPID-3307 URL: https://issues.apache.org/jira/browse/QPID-3307 Project: Qpid Issue Type: Bug Components: Java Client Reporter: Charith Dhanushka Wickramarachchi Assignee: Robbie Gemmell Priority: Critical Attachments: QPID-3307_patch.txt, QPID-3307_patch.txt, QPID-3307_patch.txt, QPID-3307_patch_unit_test.txt Hi , When we are using qpid client to receive JMSObject in complex class loading environments like web application containers/Osgi environments .There is a scenario where this issues comes. Scenario. In a web application container normally they use a class loader per web app. and if we have qpid client libs at the root classloader level this error can come. The reason for this is Serializable Object types that are used inside the web app are not visible to the class loader that loads the JMSObject message and unmarshall it. thanks, Charith -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-2720) Qpid broker can not run inside an OSGi container
[ https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063902#comment-13063902 ] Robbie Gemmell commented on QPID-2720: -- Hi Danushka, The work I have referenced in some of your other JIRAs, refactoring of the broker startup via QPID-2815, would seem to offer a way to resolve the above issue with your patch. Instead of using a static method to manipulate the PluginManager directly, you could add a method on the BrokerOptions object to pass the context, or alternatively an instance method to the Broker object that could be used to set the BundleContext before starting the instance, which could then be provided to/sourced by the PluginManager for that Broker instance. This would allow leveraging the new Broker + BrokerOptions combination as a singluar front end for starting the broker and configuring it to function as desired. Regards, Robbie Qpid broker can not run inside an OSGi container Key: QPID-2720 URL: https://issues.apache.org/jira/browse/QPID-2720 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Danushka Menikkumbura Assignee: Robbie Gemmell Fix For: 0.13 Attachments: QPID-2720-V2.patch, QPID-2720-V3.patch, QPID-2720.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: Deleting ruby and dotnet top level directories (was Re: 0.12 release update - RC1 this week)
On Tue, Jul 12, 2011 at 01:47:07PM +0100, Gordon Sim wrote: I'm happy to delete this and the dotnet directory. Any objections to that? +1 -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ pgpcHs42F54M8.pgp Description: PGP signature
Re: 0.12 release update - release branch created, beta available
Chuck, would you create a new jira for this? I looked at using QPID-2905, but it's a little overloaded. Once we have a dedicated jira, I'll get it approved and we can merge the fix over. On Thu, 7 Jul 2011, Chuck Rolke wrote: I tested a vanilla Windows build from the 0.12 beta source. It fails because of a missing file. The beta needs to include 1143995 to get the source file into the C++ source distribution. The file was added in 1104662. -Chuck - Original Message - From: Justin Ross jr...@redhat.com To: dev@qpid.apache.org Sent: Thursday, June 30, 2011 5:39:15 PM Subject: 0.12 release update - release branch created, beta available Hi. I created the release branch this morning at revision 1141543. Some testing revealed a problem in the C++ source distribution, so I fixed that (with Mick's help) and cut the beta from revision 1141708 on the release branch. Get it at http://people.apache.org/~jross/qpid-0.12-beta/ I believe that I've also corrected all the version numbers on trunk and the release branch, to 0.13 and 0.12 respectively. Please let me know if I missed one. I'm keeping a list of files containing version numbers at https://cwiki.apache.org/confluence/display/qpid/Source+files+containing+version+numbers I still need to produce the bug summary, but you can see all the raw information at the jira links on the release page. The next item on the schedule is RC1, in two weeks. If you've been waiting, now is the time to jump in and evaluate the code that will become Qpid 0.12. Thanks, Justin --- 0.12 release page: https://cwiki.apache.org/confluence/display/qpid/0.12+Release - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-2818) Make Transport mechanisms into OSGi plugins
[ https://issues.apache.org/jira/browse/QPID-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-2818: - Fix Version/s: (was: 0.11) Future Bumping to the 'future' version. Make Transport mechanisms into OSGi plugins --- Key: QPID-2818 URL: https://issues.apache.org/jira/browse/QPID-2818 Project: Qpid Issue Type: Improvement Components: Java Broker, Java Client Reporter: Andrew Kennedy Fix For: Future Make the transport mechanism pluggable using OSGi on both the broker and the client -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-3156) Java client implementation of the Address syntax for Destinations throws a ClassCastException when used with the documented 'True' or 'False' values for node durability
[ https://issues.apache.org/jira/browse/QPID-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-3156. -- Resolution: Fixed Closing out, changes were committed long ago to address this. Java client implementation of the Address syntax for Destinations throws a ClassCastException when used with the documented 'True' or 'False' values for node durability Key: QPID-3156 URL: https://issues.apache.org/jira/browse/QPID-3156 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10 Reporter: Robbie Gemmell Fix For: 0.11 Attachments: 0001-QPID-3156-Use-MapAccessor-to-retrieve-Boolean-proper.patch The Java client implementation of the Address syntax for destinations throws a ClassCastException when used with the documented (http://qpid.apache.org/books/0.8/Programming-In-Apache-Qpid/html/ch02s04.html#section-address-string-bnf) 'True' or 'False' values for node durability, instead requiring that users specify 'true' or 'false' as the value to achieve the desired effect. The former is parsed as a boolean value by the AddressParser whereas the later is parsed as a String, but the AddressHelper implementation expects the durable property to be defined as a String and casts the value as such without doing an instanceof check after retrieving it from an untyped Map, thus leading to the ClassCastException observed. Ideally I would suggest the parser/helper should accept both variations going forward, thus preserving compatibility for anyone with already functional code and also making it possible for users to use whichever variant they prefer because e.g. it is best suited to a particular implementation language idiom. Reported by a user via the dev list: I tried to create a durable queue like this queue = queueSession.createQueue(myQueue;{create:always, node:{durable: True}}); QueueSender queueSender = queueSession.createSender(queue); queueSender.send(textMessage); and getting this exception. Caused by: java.lang.ClassCastException: java.lang.Boolean cannot be cast to java.lang.String at org.apache.qpid.client.messaging.address.AddressHelper.getDurability(AddressHelper.java:237) at org.apache.qpid.client.messaging.address.AddressHelper.fillInCommonNodeArgs(AddressHelper.java:222) at org.apache.qpid.client.messaging.address.AddressHelper.createQueueNode(AddressHelper.java:215) at org.apache.qpid.client.messaging.address.AddressHelper.getSourceNode(AddressHelper.java:254) at org.apache.qpid.client.AMQDestination.rebuildTargetAndSourceNodes(AMQDestination.java:888) at org.apache.qpid.client.AMQSession_0_10.resolveAddressType(AMQSession_0_10.java:1272) thanks, Amila. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-2476) Complete ACL implementation for 0-10 code path
[ https://issues.apache.org/jira/browse/QPID-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-2476: - Fix Version/s: (was: 0.11) 0.13 Complete ACL implementation for 0-10 code path -- Key: QPID-2476 URL: https://issues.apache.org/jira/browse/QPID-2476 Project: Qpid Issue Type: New Feature Components: Java Broker Affects Versions: 0.7, 0.9 Reporter: Andrew Kennedy Labels: qpid, security Fix For: 0.13 Attachments: acl.txt, method-considered-harmful.txt, method-redux.txt Original Estimate: 336h Remaining Estimate: 336h Complete ACL implementation for 0-10 code path, providing an ACLv2 implementation that covers the following features/requirements: - Best practice security design - Support for roles/groups - Appropriate for standard stores for authorisation credentials (e.g. LDAP, Kerberos) - Expressable as XML - Easy to store/backup/extract ACL config - Exception handling catching at point of ACL application and return to client via Connection ExceptionListener with correct error code, log failure in broker - No significant performance cost on publish, permissions to be cached - Security handled at correct level of abstraction internally - Interoperability with existing ACLv2 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-2498: - Fix Version/s: (was: 0.11) 0.13 Assignee: Robbie Gemmell (was: Andrew Kennedy) Upgrade Mina to 1.1.7 - Key: QPID-2498 URL: https://issues.apache.org/jira/browse/QPID-2498 Project: Qpid Issue Type: Improvement Components: Java Broker, Java Client Affects Versions: 0.6 Reporter: Emmanuel Bourg Assignee: Robbie Gemmell Fix For: 0.13 Attachments: mina-update.patch, mina-upgrade.patch Upgrading Mina to 1.1.7 would allow the removal of backport-util-concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3231) timeout period used during synchronous 0-8/0-9 operations may begin before transmission of the operation occurs
[ https://issues.apache.org/jira/browse/QPID-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-3231: - Affects Version/s: 0.11 Fix Version/s: (was: 0.11) 0.13 timeout period used during synchronous 0-8/0-9 operations may begin before transmission of the operation occurs --- Key: QPID-3231 URL: https://issues.apache.org/jira/browse/QPID-3231 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11 Reporter: Robbie Gemmell Fix For: 0.13 The timeout period used during synchronous 0-8/0-9 operations may begin before transmission of the operation actually occurs. If a large amount of data is sent (asynchronously) before a synchronous operation is performed (e.g session commit) then this data may still be in the effectively unbounded network buffers and delay transmission of the frames for the synchronous operation. However, the timer used to indicate timeout of the synchronous operation begins as soon as the asynchronous send operation for it returns, and so could also include time spent transmitting the previous data asynchronously. This would mean that the synchronous operation is timed out prematurely, and may later succeed once the command is actually placed on the wire. We should ensure that the send method only returns once the data is actually on the wire when it used for synchronous operations with timeouts. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3255) JMX Console to be changed to remove use of deprecated UserManagement methods
[ https://issues.apache.org/jira/browse/QPID-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-3255: - Affects Version/s: 0.12 Fix Version/s: (was: 0.11) 0.13 Assignee: Robbie Gemmell JMX Console to be changed to remove use of deprecated UserManagement methods Key: QPID-3255 URL: https://issues.apache.org/jira/browse/QPID-3255 Project: Qpid Issue Type: Sub-task Components: Java Management : JMX Console Affects Versions: 0.11, 0.12 Reporter: Keith Wall Assignee: Robbie Gemmell Fix For: 0.13 QPID-2759 deprecated some JMX UserManagement operations whilst removing support for the old jmxremote.access file. This task is to change the Java Management Console to cease using those deprecated methods and remove the on-screen widgets pertaining to access management. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3274) Jenkins CI - JMX test failures under Solaris
[ https://issues.apache.org/jira/browse/QPID-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-3274: - Fix Version/s: (was: 0.11) Assignee: Robbie Gemmell (was: Keith Wall) Jenkins CI - JMX test failures under Solaris Key: QPID-3274 URL: https://issues.apache.org/jira/browse/QPID-3274 Project: Qpid Issue Type: Sub-task Components: Java Tests Affects Versions: 0.11 Environment: Solaris/Hudson Reporter: Keith Wall Assignee: Robbie Gemmell Labels: Hudson, Jenkins, Solaris Andrew K noticed whilst setting up Qpid under Hudson that the JMX tests fail under Hudson on Solaris. The first error was: https://builds.apache.org/hudson/view/M-R/view/Qpid/job/qpid-java-build/3/testReport/junit/org.apache.qpid.management.jmx/ManagementActorLoggingTest/testJMXManagementConsoleConnection/ {code} java.net.MalformedURLException: Bad URL path: _solaris:30099/jndi/rmi://hudson_solaris:2/jmxrmi {code} followed by many instances of: https://builds.apache.org/hudson/view/M-R/view/Qpid/job/qpid-java-build/3/testReport/junit/org.apache.qpid.management.jmx/ManagementActorLoggingTest/testConnectionCloseViaManagement/ {code} internal error: ObjID already in use {code} The full list of test failures is recorded here: https://builds.apache.org/hudson/view/M-R/view/Qpid/job/qpid-java-build/3/#showFailuresLink I tried the test cases standalone under OpenSolaris 11 and could not reproduce the problem. However, I notice that the initial error looks very much like the issue discussed here: http://apache-qpid-users.2158936.n2.nabble.com/Run-qpid-0-6-broker-error-in-Linux-td5517015.html Is the problem just being caused by the hostname on the Solaris host in the Jenkins build farm? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3149) Set up Hudson Continuous Integration
[ https://issues.apache.org/jira/browse/QPID-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-3149: - Affects Version/s: (was: 0.11) Fix Version/s: (was: 0.11) Set up Hudson Continuous Integration Key: QPID-3149 URL: https://issues.apache.org/jira/browse/QPID-3149 Project: Qpid Issue Type: Task Components: Build Tools Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Labels: build, hudson, qpid Set up a Continuous Integration build environment for Java and C++ with full unit, system and integration test suites being run, as well as the Python test kit. This will use the ASF Hudson infrastructure, and will build on both Unix and Windows environments. See here for details: http://wiki.apache.org/general/Hudson -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3052) Java test profiles do not effectively test all AMQP protocol versions
[ https://issues.apache.org/jira/browse/QPID-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-3052: - Affects Version/s: 0.12 0.11 0.10 Fix Version/s: (was: 0.11) 0.13 Java test profiles do not effectively test all AMQP protocol versions - Key: QPID-3052 URL: https://issues.apache.org/jira/browse/QPID-3052 Project: Qpid Issue Type: Bug Components: Java Tests Affects Versions: 0.9, 0.10, 0.11, 0.12 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Fix For: 0.13 The Java test profiles assume that, particularly default one for InVm transports, the 0-10 protocol will fail, causing renegotiation. If 0-10 InVm support is added then the default protocol will use this. It seems to make more sense to specify exactly the version the client and the broker should announce, and force renegotiation explicitly by disabling various protocol versions on the command line when starting an external Java broker. Note that this is not possible to specify for the InVm profiles anyway. Also, the only protocol that is ever tested will be the highest supported by both broker and client, therefore this is AMQP 0-9-1. In order for the tests not to do surprising things when new protocol versions are added, I think that setting versions explicitly is the best idea. I woulsd also like to add an explicit 0-8 test profile for both InVM and external Java brokers, in order to exercise and get coverage on this code. In future, I recommend that some form of combinatorial profile system be investigated for the test subsystem, allowing the required protocol, broker type and so on to be specified separately. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3113) ChannelCloseTest should be excluded from 0-10 test profiles properly
[ https://issues.apache.org/jira/browse/QPID-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-3113: - Issue Type: Test (was: Bug) Summary: ChannelCloseTest should be excluded from 0-10 test profiles properly (was: ChannelCloseTest should be excluded from test profiles properly) ChannelCloseTest should be excluded from 0-10 test profiles properly Key: QPID-3113 URL: https://issues.apache.org/jira/browse/QPID-3113 Project: Qpid Issue Type: Test Components: Java Tests Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Fix For: 0.11 ChannelCloseTest should use the Excludes file mechanism to ensure it is not run for 0-10 profiles, and should also not be restricted to VM broker profiles -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-3113) ChannelCloseTest should be excluded from 0-10 test profiles properly
[ https://issues.apache.org/jira/browse/QPID-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-3113. -- Resolution: Fixed ChannelCloseTest should be excluded from 0-10 test profiles properly Key: QPID-3113 URL: https://issues.apache.org/jira/browse/QPID-3113 Project: Qpid Issue Type: Test Components: Java Tests Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Fix For: 0.11 ChannelCloseTest should use the Excludes file mechanism to ensure it is not run for 0-10 profiles, and should also not be restricted to VM broker profiles -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3157) 'removed' subscriptions may be held in memory by the queues SubscriptionList or 'lastSubscriptionNode' reference
[ https://issues.apache.org/jira/browse/QPID-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-3157: - Affects Version/s: 0.12 0.11 Fix Version/s: (was: 0.11) 0.13 'removed' subscriptions may be held in memory by the queues SubscriptionList or 'lastSubscriptionNode' reference Key: QPID-3157 URL: https://issues.apache.org/jira/browse/QPID-3157 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Priority: Critical Fix For: 0.13 subscriptions 'removed' from a queue subscription list are only marked deleted and can not actually bereleased from memory until the head of the subscription list advances beyond them. Additionally and perhaps more troublesome, a queues 'lastSubscriptionNode' can refer to a particular subscription but hold *all* subscequent subscriptions in memory whether they have been deleted or not and regardless whether the head of the SubscriptionList has advanced beyond them, As a result any memory in use by the now-closed subscription will not be released until the queue is deleted, or all the subscriptions prior to it are closed and removed from the list *and* the 'lastSubscriptionNode' advances beyond them.. This also holds the associated ServerSession in memory, which is currently a rather heavyweight object. This issue is further compounded when the queue has a backlog of messages and consumers are then created, used to recieve one message, and closed. In this scenario the broker sends the client as many messages as it can prefetch, leading to creation of up to prefetch size, default=500 MessageTransfer commands, all which are recorded in the ServerSession but then left retained as 'unprocessed' in the closed session, which might be held in memory as described above. This results in an explosion in the number of MessageTransfer commands retained in memory as each message can have up to prefetch size MessageTransfer commands associated with it before it is eventually consumed by a client and all of thse will also be retained in memory by a 'removed' but not deleted subscription. The last effect can be combated by restricting the preftech size (eg appending maxprefetch='1' to the connection url). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-2693) Broker instability with the topic exchange
[ https://issues.apache.org/jira/browse/QPID-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-2693: - Affects Version/s: 0.12 0.11 Fix Version/s: (was: 0.11) 0.13 Broker instability with the topic exchange -- Key: QPID-2693 URL: https://issues.apache.org/jira/browse/QPID-2693 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.7, 0.8, 0.9, 0.10, 0.11, 0.12 Environment: java version 1.6.0_12 Java(TM) SE Runtime Environment (build 1.6.0_12-b04) Java HotSpot(TM) 64-Bit Server VM (build 11.2-b01, mixed mode) Linux 2.6.24-11-pve #1 SMP PREEMPT Fri May 14 09:28:08 CEST 2010 x86_64 GNU/Linux Reporter: Emmanuel Bourg Assignee: Robbie Gemmell Priority: Critical Fix For: 0.13 Attachments: qpid-dump.txt, qpid-log.txt I've noticed an instability of the Java broker when sending a high volume of messages to the topic exchange. The messages are non acked, non durable. After about 15 minutes the messages can no longer be dispatched and the client gets this exception: org.apache.qpid.transport.SessionException: timed out waiting for sync: complete = 77824, point = 77825 at org.apache.qpid.transport.Session.sync(Session.java:743) at org.apache.qpid.transport.Session.sync(Session.java:712) at org.apache.qpid.transport.Session.invoke(Session.java:672) at org.apache.qpid.transport.Session.invoke(Session.java:518) at org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:96) at org.apache.qpid.transport.Session.messageTransfer(Session.java:880) And in the server log I get these exceptions: 2010-06-25 02:48:48,005 [ERROR] Exception thrown and no ProtocolEngine to handle it org.apache.qpid.transport.SessionException: timed out waiting for completion at org.apache.qpid.transport.Session.invoke(Session.java:635) at org.apache.qpid.server.transport.ServerSession.sendMessage(ServerSession.java:180) at org.apache.qpid.server.subscription.Subscription_0_10.send(Subscription_0_10.java:573) at org.apache.qpid.server.queue.SimpleAMQQueue.deliverMessage(SimpleAMQQueue.java:715) at org.apache.qpid.server.queue.SimpleAMQQueue.deliverToSubscription(SimpleAMQQueue.java:658) at org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:611) at org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:536) at org.apache.qpid.server.transport.ServerSession$1.postCommit(ServerSession.java:157) at org.apache.qpid.server.txn.AutoCommitTransaction.enqueue(AutoCommitTransaction.java:151) at org.apache.qpid.server.transport.ServerSession.enqueue(ServerSession.java:146) at org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:287) at org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:96) at org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:103) at org.apache.qpid.transport.SessionDelegate.command(SessionDelegate.java:46) at org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:110) at org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:96) at org.apache.qpid.transport.Method.delegate(Method.java:159) at org.apache.qpid.transport.Session.received(Session.java:487) at org.apache.qpid.transport.Connection.dispatch(Connection.java:377) at org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:64) at org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:40) at org.apache.qpid.transport.MethodDelegate.messageTransfer(MethodDelegate.java:113) at org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:103) at org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:54) at org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:40) at org.apache.qpid.transport.Method.delegate(Method.java:159) at org.apache.qpid.transport.Connection.received(Connection.java:342) at org.apache.qpid.transport.Connection.received(Connection.java:55) at org.apache.qpid.transport.network.Assembler.emit(Assembler.java:98) at org.apache.qpid.transport.network.Assembler.assemble(Assembler.java:220) at org.apache.qpid.transport.network.Assembler.frame(Assembler.java:132) at
[jira] [Created] (QPID-3352) Federation bridge doesn't recover from session errors
Federation bridge doesn't recover from session errors - Key: QPID-3352 URL: https://issues.apache.org/jira/browse/QPID-3352 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.10, 0.7 Reporter: Jason Dillaman When creating a federated route (bridge) to another broker, if the bridge's AMQP session encounters an error (such as a queue reaching its maximum capacity upon delivery), messages stop flowing. Additionally, if during broker bootstrapping, if the source queue/exchange does not yet exist, the bridge never attempts to recover. Finally, when simulating a network failure, dynamically created bridge queues are not always recreated for dynamic federation routes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Created] (QPID-3353) Windows-specific file is missing from 0.12 beta cpp source kit
Windows-specific file is missing from 0.12 beta cpp source kit -- Key: QPID-3353 URL: https://issues.apache.org/jira/browse/QPID-3353 Project: Qpid Issue Type: Bug Components: Packaging Affects Versions: 0.11 Environment: Windows Reporter: Chuck Rolke Fix For: 0.12 Changes made in QPID-2905 http://svn.apache.org/viewvc?rev=1104662view=rev add a file that is not packaged in the source kit. Checkin 1143995 http://svn.apache.org/viewvc?view=revisionrevision=1143995 adds the file by name to Makefile.am so that it is packaged in the cpp source kit. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: 0.12 release update - release branch created, beta available
Also related to QPID-2905 problems is QPID-3338. I am trying to do a test mingw build on Linux to test the patch (all new to me). It works in the case of Windows CMake and the Visual Studio toolchain. Cliff On Tue, Jul 12, 2011 at 7:45 AM, Justin Ross jr...@redhat.com wrote: Chuck, would you create a new jira for this? I looked at using QPID-2905, but it's a little overloaded. Once we have a dedicated jira, I'll get it approved and we can merge the fix over. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3352) Federation bridge doesn't recover from session errors
[ https://issues.apache.org/jira/browse/QPID-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Dillaman updated QPID-3352: - Attachment: bz703886.patch patch for attempting to auto-recover bridge session errors Federation bridge doesn't recover from session errors - Key: QPID-3352 URL: https://issues.apache.org/jira/browse/QPID-3352 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.7, 0.10 Reporter: Jason Dillaman Attachments: bz703886.patch When creating a federated route (bridge) to another broker, if the bridge's AMQP session encounters an error (such as a queue reaching its maximum capacity upon delivery), messages stop flowing. Additionally, if during broker bootstrapping, if the source queue/exchange does not yet exist, the bridge never attempts to recover. Finally, when simulating a network failure, dynamically created bridge queues are not always recreated for dynamic federation routes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3353) Windows-specific file is missing from 0.12 beta cpp source kit
[ https://issues.apache.org/jira/browse/QPID-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063963#comment-13063963 ] Ted Ross commented on QPID-3353: This looks good for inclusion in 0.12 Windows-specific file is missing from 0.12 beta cpp source kit -- Key: QPID-3353 URL: https://issues.apache.org/jira/browse/QPID-3353 Project: Qpid Issue Type: Bug Components: Packaging Affects Versions: 0.11 Environment: Windows Reporter: Chuck Rolke Fix For: 0.12 Changes made in QPID-2905 http://svn.apache.org/viewvc?rev=1104662view=rev add a file that is not packaged in the source kit. Checkin 1143995 http://svn.apache.org/viewvc?view=revisionrevision=1143995 adds the file by name to Makefile.am so that it is packaged in the cpp source kit. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3353) Windows-specific file is missing from 0.12 beta cpp source kit
[ https://issues.apache.org/jira/browse/QPID-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063965#comment-13063965 ] Justin Ross commented on QPID-3353: --- Approved for 0.12. Windows-specific file is missing from 0.12 beta cpp source kit -- Key: QPID-3353 URL: https://issues.apache.org/jira/browse/QPID-3353 Project: Qpid Issue Type: Bug Components: Packaging Affects Versions: 0.11 Environment: Windows Reporter: Chuck Rolke Fix For: 0.12 Changes made in QPID-2905 http://svn.apache.org/viewvc?rev=1104662view=rev add a file that is not packaged in the source kit. Checkin 1143995 http://svn.apache.org/viewvc?view=revisionrevision=1143995 adds the file by name to Makefile.am so that it is packaged in the cpp source kit. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: 0.12 release update - release branch created, beta available
On 06/30/2011 10:39 PM, Justin Ross wrote: Hi. I created the release branch this morning at revision 1141543. Some testing revealed a problem in the C++ source distribution, so I fixed that (with Mick's help) and cut the beta from revision 1141708 on the release branch. Get it at http://people.apache.org/~jross/qpid-0.12-beta/ Looks good to me I've tested the following (on Fedora 12): * built and installed qpid-cpp (including make check to run all tests) * installed qpid-python, qpid-qmf and qpid-tools * unpacked qpid-java-client * started c++ broker and ran command line tools against it * ran examples from python, c++ and java[1] against each other * ran qpid-perftest and qpid-latency-test * unpacked qpid-java-broker * re-ran examples and some other tests again using java broker [1] Note: there is a minor typo in the README for the java-client. The example command for running an example uses 'qpid-client-examples-version.jar' whereas the actual jar is qpid-client-example-version.jar i.e. singular. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3338) qpidxarm CMake target is missing in 0-12
[ https://issues.apache.org/jira/browse/QPID-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064014#comment-13064014 ] Cliff Jansen commented on QPID-3338: The patch tests fine on Fedora to generate makefiles via cmake qpidxarm CMake target is missing in 0-12 Key: QPID-3338 URL: https://issues.apache.org/jira/browse/QPID-3338 Project: Qpid Issue Type: Bug Components: C++ Broker, C++ Client Affects Versions: 0.12 Environment: Windows with Microsoft compilers (as opposed to mingw) Reporter: Cliff Jansen Assignee: Cliff Jansen Priority: Blocker Fix For: 0.12 Attachments: jira-3338.patch cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662). The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable WIN32. This variable was changed to _MSC_VER for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately _MSC_VER is not a recognized CMAKE variable and the qpidxarm target is never generated. The CMake documentation indicates the the variable MSVC should be used to indicate The Microsoft compiler compared to mingw. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Assigned] (QPID-3352) Federation bridge doesn't recover from session errors
[ https://issues.apache.org/jira/browse/QPID-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross reassigned QPID-3352: -- Assignee: Ted Ross Federation bridge doesn't recover from session errors - Key: QPID-3352 URL: https://issues.apache.org/jira/browse/QPID-3352 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.7, 0.10 Reporter: Jason Dillaman Assignee: Ted Ross Attachments: bz703886.patch When creating a federated route (bridge) to another broker, if the bridge's AMQP session encounters an error (such as a queue reaching its maximum capacity upon delivery), messages stop flowing. Additionally, if during broker bootstrapping, if the source queue/exchange does not yet exist, the bridge never attempts to recover. Finally, when simulating a network failure, dynamically created bridge queues are not always recreated for dynamic federation routes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: 0.12 release update - release branch created, beta available
I have tested the patch for QPID-3338 against qpid-0.12-beta on Linux and it appears to do the right thing for mingw and cmake. I would like to request approval for this patch. cliff - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: 0.12 release update - release branch created, beta available
+1 Ship it. -Chuck - Original Message - From: Cliff Jansen cliffjan...@gmail.com To: dev@qpid.apache.org Sent: Tuesday, July 12, 2011 1:21:57 PM Subject: Re: 0.12 release update - release branch created, beta available I have tested the patch for QPID-3338 against qpid-0.12-beta on Linux and it appears to do the right thing for mingw and cmake. I would like to request approval for this patch. cliff - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3338) qpidxarm CMake target is missing in 0-12
[ https://issues.apache.org/jira/browse/QPID-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064031#comment-13064031 ] Justin Ross commented on QPID-3338: --- Reviewed by Chuck Rolke on the dev list. Approved for 0.12. qpidxarm CMake target is missing in 0-12 Key: QPID-3338 URL: https://issues.apache.org/jira/browse/QPID-3338 Project: Qpid Issue Type: Bug Components: C++ Broker, C++ Client Affects Versions: 0.12 Environment: Windows with Microsoft compilers (as opposed to mingw) Reporter: Cliff Jansen Assignee: Cliff Jansen Priority: Blocker Fix For: 0.12 Attachments: jira-3338.patch cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662). The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable WIN32. This variable was changed to _MSC_VER for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately _MSC_VER is not a recognized CMAKE variable and the qpidxarm target is never generated. The CMake documentation indicates the the variable MSVC should be used to indicate The Microsoft compiler compared to mingw. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3333) Make Python SWIG bindings a drop-in replacement for pure Python qpid.messaging package
[ https://issues.apache.org/jira/browse/QPID-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064044#comment-13064044 ] Gordon Sim commented on QPID-: -- Committed patches 0001-0008 as r1145698. I'll leave this open as there are still some areas to address. Getting pretty close though, thanks Anthony this is invaluable! Make Python SWIG bindings a drop-in replacement for pure Python qpid.messaging package -- Key: QPID- URL: https://issues.apache.org/jira/browse/QPID- Project: Qpid Issue Type: Improvement Components: C++ Client Affects Versions: 0.11, Future Reporter: Anthony Foglia Assignee: Gordon Sim Attachments: 0001-Wrap-NoMessageAvailable-as-Empty-exception.patch, 0002-Change-Connection-interface-to-match-pure-python.patch, 0003-Change-Session-interface-to-match-pure-python.patch, 0004-Change-Receiver-interface-to-match-pure-python.patch, 0005-Change-Sender-interface-to-match-pure-python.patch, 0006-Change-Message-interface-to-match-pure-python.patch, 0007-Handle-connection-options.patch, 0008-Fixes-and-more-improvements-to-Message-objects.patch These patches are make the compile Python SWIG bindings to the C++ client much closer to a drop-in replacement for the Python qpid.messaging package. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3333) Make Python SWIG bindings a drop-in replacement for pure Python qpid.messaging package
[ https://issues.apache.org/jira/browse/QPID-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064046#comment-13064046 ] Gordon Sim commented on QPID-: -- Re auto_delete v. auto-delete, we probably want to support both. Certainly not good that auto_delete is ignored by c++ client. Make Python SWIG bindings a drop-in replacement for pure Python qpid.messaging package -- Key: QPID- URL: https://issues.apache.org/jira/browse/QPID- Project: Qpid Issue Type: Improvement Components: C++ Client Affects Versions: 0.11, Future Reporter: Anthony Foglia Assignee: Gordon Sim Attachments: 0001-Wrap-NoMessageAvailable-as-Empty-exception.patch, 0002-Change-Connection-interface-to-match-pure-python.patch, 0003-Change-Session-interface-to-match-pure-python.patch, 0004-Change-Receiver-interface-to-match-pure-python.patch, 0005-Change-Sender-interface-to-match-pure-python.patch, 0006-Change-Message-interface-to-match-pure-python.patch, 0007-Handle-connection-options.patch, 0008-Fixes-and-more-improvements-to-Message-objects.patch These patches are make the compile Python SWIG bindings to the C++ client much closer to a drop-in replacement for the Python qpid.messaging package. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3256) Application which uses Qpid (in my case Excel) hangs on shutdown
[ https://issues.apache.org/jira/browse/QPID-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064050#comment-13064050 ] Ted Ross commented on QPID-3256: This commit appears to break the mingw32 build. There are two problems that I'm aware of: 1) In the class ThreadPrivate, the initializers in the constructors are not in the same order as the declarations. 2) error: 'OpenThread' was not declared in this scope from line 71. Application which uses Qpid (in my case Excel) hangs on shutdown Key: QPID-3256 URL: https://issues.apache.org/jira/browse/QPID-3256 Project: Qpid Issue Type: Bug Components: C++ Client Affects Versions: 0.8, 0.10 Environment: OS: Windows. Qpid is assembled as DLL. Reporter: Eugene Assignee: Cliff Jansen Fix For: 0.11 Attachments: qpid-3256-3.patch, qpid-3256.patch Hi All I encountered with strange behavior on shutdown when using qpid 0-8 and 0-10. When I use qpid in standalone console-application everything is ok. But when I use qpid in DLL which is loaded into Excel (as RTD module), Excel hangs on shutdown. I found out that in standalone application on shutdown I have next stack: qpidclientd.dll!qpid::client::`anonymous namespace'::IOThread::~IOThread() Line 138C++ qpidclientd.dll!`qpid::client::`anonymous namespace'::theIO'::`2'::`dynamic atexit destructor for 'io''() + 0xd bytes C++ qpidclientd.dll!_CRT_INIT(void * hDllHandle=0x6008, unsigned long dwReason=0, void * lpreserved=0x0001) Line 449 C qpidclientd.dll!__DllMainCRTStartup(void * hDllHandle=0x6008, unsigned long dwReason=0, void * lpreserved=0x0001) Line 560 + 0x11 bytesC qpidclientd.dll!_DllMainCRTStartup(void * hDllHandle=0x6008, unsigned long dwReason=0, void * lpreserved=0x0001) Line 510 + 0x11 bytes C ntdll.dll!77b79960() [Frames below may be incorrect and/or missing, no symbols loaded for ntdll.dll] ntdll.dll!77b9a516() ntdll.dll!77b9a3b8() kernel32.dll!77657363() msvcr90d.dll!__crtExitProcess(int status=0) Line 732 C msvcr90d.dll!doexit(int code=0, int quick=0, int retcaller=0) Line 644 + 0x9 bytes C msvcr90d.dll!exit(int code=0) Line 412 + 0xd bytes C Test.exe!__tmainCRTStartup() Line 599 C Test.exe!mainCRTStartup() Line 403 C kernel32.dll!77653677() ntdll.dll!77b79f02() ntdll.dll!77b79ed5() And in this state all threads of application have been already terminated. The only thread is: 121720 Main Thread Main Thread qpid::client::`anonymous namespace'::IOThread::~IOThreadNormal 0 so code from file ConnectionImpl.cpp works well: ~IOThread() { std::vectorThread threads; { ScopedLockMutex l(threadLock); if (poller_) poller_-shutdown(); t.swap(threads); } for (std::vectorThread::iterator i = threads.begin(); i != threads.end(); ++i) { i-join(); } } BUT in Excel I get stack: qpidclientd.dll!qpid::client::`anonymous namespace'::IOThread::~IOThread() Line 130 C++ qpidclientd.dll!`qpid::client::`anonymous namespace'::theIO'::`2'::`dynamic atexit destructor for 'io''() + 0xd bytes C++ qpidclientd.dll!_CRT_INIT(void * hDllHandle=0x0770, unsigned long dwReason=0, void * lpreserved=0x) Line 449 C qpidclientd.dll!__DllMainCRTStartup(void * hDllHandle=0x0770, unsigned long dwReason=0, void * lpreserved=0x) Line 560 + 0x11 bytesC qpidclientd.dll!_DllMainCRTStartup(void * hDllHandle=0x0770, unsigned long dwReason=0, void * lpreserved=0x) Line 510 + 0x11 bytes C ntdll.dll!77b79960() [Frames below may be incorrect and/or missing, no symbols loaded for ntdll.dll] ntdll.dll!77ba1525() ntdll.dll!77b81231() KernelBase.dll!77281da7() ole32.dll!75bb9562() ole32.dll!75bb9593() ole32.dll!75bb95a7() ole32.dll!75bb98bf() ole32.dll!75bb9805() ole32.dll!75bb9a8c() EXCEL.EXE!2f3811e9() EXCEL.EXE!2f6933e8() EXCEL.EXE!2f32a5af() EXCEL.EXE!2f34894a() EXCEL.EXE!2f670001() MSO.DLL!65bc6ed5() MSO.DLL!65c26a34() MSO.DLL!65c30305() MSO.DLL!65bc910c() MSO.DLL!65c4f420() MSO.DLL!65bbf161() comctl32.dll!7233463d() user32.dll!762971be() user32.dll!76297d31()
[jira] [Created] (QPID-3354) Change default configure/build instructions for UUID headers from e2fsprogs-devel to libuuid-devel
Change default configure/build instructions for UUID headers from e2fsprogs-devel to libuuid-devel -- Key: QPID-3354 URL: https://issues.apache.org/jira/browse/QPID-3354 Project: Qpid Issue Type: Improvement Components: Build Tools Affects Versions: 0.10 Reporter: William Henry Fix For: 0.10 The current build instructions assume older versions of Fedora for build C++. INSTALL file states: INSTALL UUID problems: In some later Linux releases (such as Fedora 12), the uuid/uuid.h file has been moved from e2fsprogs-devel into libuuid-devel. If you are using a newer Linux release and run into a problem during configure in which uuid.h cannot be found, look for and install the libuuid-devel package. \INSTALL We should flip this so that the default is to install libuuid-devel and the the instructions explain that for older releases of linux you need to install e2fsprogs-devel. New INSTALL instructions UUID problems: In some earlier Linux releases (such as Fedora 11), the uuid/uuid.h file is loccated in e2fsprogs-devel instead of libuuid-devel. If you are using an older Linux release and run into a problem during configure in which uuid.h cannot be found, look for and install the e2fsprogs-devel package. \New INSTALL instructions -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3354) Change default configure/build instructions for UUID headers from e2fsprogs-devel to libuuid-devel
[ https://issues.apache.org/jira/browse/QPID-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-3354: -- Fix Version/s: (was: 0.10) 0.13 0.12 Assignee: Justin Ross Change default configure/build instructions for UUID headers from e2fsprogs-devel to libuuid-devel -- Key: QPID-3354 URL: https://issues.apache.org/jira/browse/QPID-3354 Project: Qpid Issue Type: Improvement Components: Build Tools Affects Versions: 0.10 Reporter: William Henry Assignee: Justin Ross Fix For: 0.12, 0.13 The current build instructions assume older versions of Fedora for build C++. INSTALL file states: INSTALL UUID problems: In some later Linux releases (such as Fedora 12), the uuid/uuid.h file has been moved from e2fsprogs-devel into libuuid-devel. If you are using a newer Linux release and run into a problem during configure in which uuid.h cannot be found, look for and install the libuuid-devel package. \INSTALL We should flip this so that the default is to install libuuid-devel and the the instructions explain that for older releases of linux you need to install e2fsprogs-devel. New INSTALL instructions UUID problems: In some earlier Linux releases (such as Fedora 11), the uuid/uuid.h file is loccated in e2fsprogs-devel instead of libuuid-devel. If you are using an older Linux release and run into a problem during configure in which uuid.h cannot be found, look for and install the e2fsprogs-devel package. \New INSTALL instructions -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-3352) Federation bridge doesn't recover from session errors
[ https://issues.apache.org/jira/browse/QPID-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved QPID-3352. Resolution: Fixed Fix Version/s: 0.13 Federation bridge doesn't recover from session errors - Key: QPID-3352 URL: https://issues.apache.org/jira/browse/QPID-3352 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.7, 0.10 Reporter: Jason Dillaman Assignee: Ted Ross Fix For: 0.13 Attachments: bz703886.patch When creating a federated route (bridge) to another broker, if the bridge's AMQP session encounters an error (such as a queue reaching its maximum capacity upon delivery), messages stop flowing. Additionally, if during broker bootstrapping, if the source queue/exchange does not yet exist, the bridge never attempts to recover. Finally, when simulating a network failure, dynamically created bridge queues are not always recreated for dynamic federation routes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Created] (QPID-3355) Client aborts when replaying sender after connection recovery
Client aborts when replaying sender after connection recovery - Key: QPID-3355 URL: https://issues.apache.org/jira/browse/QPID-3355 Project: Qpid Issue Type: Bug Components: C++ Client Affects Versions: 0.10, 0.7 Reporter: Jason Dillaman There is a race condition between qpid::client::SessionImpl::waitForCompletion and qpid::client::SessionImpl::~SessionImpl. If one thread is waiting for a completion and another thread causes the destructor for the session to be invoked, the destructor can abort the client if waitForCompletion is still holding the state mutex. The reason this occurs is because waitForCompletion is not holding a Waiter::ScopedWait, so the destructor completes while the mutex is still being held. This was discovered when testing connection loss and recovery. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3355) Client aborts when replaying sender after connection recovery
[ https://issues.apache.org/jira/browse/QPID-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Dillaman updated QPID-3355: - Attachment: QPID-3355.patch Patch to hold qpid::sys::Waitable::ScopedWait within waitForCompletion Client aborts when replaying sender after connection recovery - Key: QPID-3355 URL: https://issues.apache.org/jira/browse/QPID-3355 Project: Qpid Issue Type: Bug Components: C++ Client Affects Versions: 0.7, 0.10 Reporter: Jason Dillaman Attachments: QPID-3355.patch There is a race condition between qpid::client::SessionImpl::waitForCompletion and qpid::client::SessionImpl::~SessionImpl. If one thread is waiting for a completion and another thread causes the destructor for the session to be invoked, the destructor can abort the client if waitForCompletion is still holding the state mutex. The reason this occurs is because waitForCompletion is not holding a Waiter::ScopedWait, so the destructor completes while the mutex is still being held. This was discovered when testing connection loss and recovery. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Reopened] (QPID-3286) cluster node went down
[ https://issues.apache.org/jira/browse/QPID-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sujith paily reopened QPID-3286: More questions cluster node went down -- Key: QPID-3286 URL: https://issues.apache.org/jira/browse/QPID-3286 Project: Qpid Issue Type: Bug Components: C++ Clustering Affects Versions: 0.10 Environment: Two node persistent cluster using openais. Both nodes are CentOS 5.5. Reporter: sujith paily Assignee: Alan Conway Priority: Critical Labels: adminis, newbie Original Estimate: 24h Remaining Estimate: 24h I have configured qpid 0.10 c++ brocker as 2 node persistent cluster. I was worked without any issue for few hours or sometimes one or two day. But one node went down after some time with following error. --- 2011-05-30 12:55:28 warning Journal OPC_MESSAGE_QUEUE: Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. 2011-05-30 12:55:28 error Unexpected exception: Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. (JournalImpl.cpp:587) 2011-05-30 12:55:28 error Connection 192.168.1.138:5672-192.168.1.10:58839 closed by error: Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. (JournalImpl.cpp:587)(501) 2011-05-30 12:55:28 critical cluster(192.168.1.138:6321 READY/error) local error 11545 did not occur on member 192.168.1.139:25161: Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. (JournalImpl.cpp:587) 2011-05-30 12:55:28 critical Error delivering frames: local error did not occur on all cluster members : Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. (JournalImpl.cpp:587) (qpid/cluster/ErrorCheck.cpp:89) 2011-05-30 12:55:28 notice cluster(192.168.1.138:6321 LEFT/error) leaving cluster QCLUSTER 2011-05-30 12:55:28 notice Shut down -- But the remaining node is working without any issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Issue Comment Edited] (QPID-3286) cluster node went down
[ https://issues.apache.org/jira/browse/QPID-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064267#comment-13064267 ] sujith paily edited comment on QPID-3286 at 7/13/11 1:20 AM: - Hi The cluster node went down due to journal overflow. I have few more questions 1. Is it possible to monitor the journal file size growth and flush the journal files before it reach certain limit, so that we can save the brocker going down. 2. Is there any limit on journal file size was (Author: sujithpaily): More questions cluster node went down -- Key: QPID-3286 URL: https://issues.apache.org/jira/browse/QPID-3286 Project: Qpid Issue Type: Bug Components: C++ Clustering Affects Versions: 0.10 Environment: Two node persistent cluster using openais. Both nodes are CentOS 5.5. Reporter: sujith paily Assignee: Alan Conway Priority: Critical Labels: adminis, newbie Original Estimate: 24h Remaining Estimate: 24h I have configured qpid 0.10 c++ brocker as 2 node persistent cluster. I was worked without any issue for few hours or sometimes one or two day. But one node went down after some time with following error. --- 2011-05-30 12:55:28 warning Journal OPC_MESSAGE_QUEUE: Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. 2011-05-30 12:55:28 error Unexpected exception: Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. (JournalImpl.cpp:587) 2011-05-30 12:55:28 error Connection 192.168.1.138:5672-192.168.1.10:58839 closed by error: Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. (JournalImpl.cpp:587)(501) 2011-05-30 12:55:28 critical cluster(192.168.1.138:6321 READY/error) local error 11545 did not occur on member 192.168.1.139:25161: Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. (JournalImpl.cpp:587) 2011-05-30 12:55:28 critical Error delivering frames: local error did not occur on all cluster members : Enqueue capacity threshold exceeded on queue OPC_MESSAGE_QUEUE. (JournalImpl.cpp:587) (qpid/cluster/ErrorCheck.cpp:89) 2011-05-30 12:55:28 notice cluster(192.168.1.138:6321 LEFT/error) leaving cluster QCLUSTER 2011-05-30 12:55:28 notice Shut down -- But the remaining node is working without any issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: Review Request: QPID-3345: restore/add ability to use sys props to select the NetworkTransport used to make/accept connections
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1087/#review1041 --- /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java https://reviews.apache.org/r/1087/#comment2117 Looking at the Transport class, I see that transports are choosen based on the AMQP protocol version. While it is true that this can be easily overridden using qpid.transport system property, it would have been nice if we had the transport implementations independent of the protocol versions. Perhaps this is the case, and the map is just there to specify the default (or preferred) transport for each version? Is this approach was taken due to the 0-8,0-9 version code paths are heavily tied to MINA (I haven't really looked at the code in this area for a long time) ? - rajith On 2011-07-12 09:38:50, Keith Wall wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1087/ --- (Updated 2011-07-12 09:38:50) Review request for qpid. Summary --- QPID-3345: transport implementations for client/broker sides controllable via new System Properties and Reflection. This addresses bug QPID-3345. https://issues.apache.org/jira/browse/QPID-3345 Diffs - /trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java PRE-CREATION /trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java 1145481 /trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java 1145481 /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java 1145481 /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java 1145481 /trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java 1145481 Diff: https://reviews.apache.org/r/1087/diff Testing --- Additional unit test and exercised by existing system test suite (0-9-1/0-10 code paths) Thanks, Keith
[jira] [Commented] (QPID-3345) Make new transport implementations pluggable
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064335#comment-13064335 ] jirapos...@reviews.apache.org commented on QPID-3345: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1087/#review1041 --- /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java https://reviews.apache.org/r/1087/#comment2117 Looking at the Transport class, I see that transports are choosen based on the AMQP protocol version. While it is true that this can be easily overridden using qpid.transport system property, it would have been nice if we had the transport implementations independent of the protocol versions. Perhaps this is the case, and the map is just there to specify the default (or preferred) transport for each version? Is this approach was taken due to the 0-8,0-9 version code paths are heavily tied to MINA (I haven't really looked at the code in this area for a long time) ? - rajith On 2011-07-12 09:38:50, Keith Wall wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1087/ bq. --- bq. bq. (Updated 2011-07-12 09:38:50) bq. bq. bq. Review request for qpid. bq. bq. bq. Summary bq. --- bq. bq. QPID-3345: transport implementations for client/broker sides controllable via new System Properties and Reflection. bq. bq. bq. This addresses bug QPID-3345. bq. https://issues.apache.org/jira/browse/QPID-3345 bq. bq. bq. Diffs bq. - bq. bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java PRE-CREATION bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java 1145481 bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java 1145481 bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java 1145481 bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java 1145481 bq./trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java 1145481 bq. /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java 1145481 bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java 1145481 bq. /trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java 1145481 bq. bq. Diff: https://reviews.apache.org/r/1087/diff bq. bq. bq. Testing bq. --- bq. bq. Additional unit test and exercised by existing system test suite (0-9-1/0-10 code paths) bq. bq. bq. Thanks, bq. bq. Keith bq. bq. Make new transport implementations pluggable Key: QPID-3345 URL: https://issues.apache.org/jira/browse/QPID-3345 Project: Qpid Issue Type: Improvement Components: Java Client, Java Common Reporter: Keith Wall Assignee: Rajith Attapattu Fix For: 0.13 Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3307) ClassNotfound Exception when using Qpid java client in Complex classloading Environments.
[ https://issues.apache.org/jira/browse/QPID-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064361#comment-13064361 ] Charith Dhanushka Wickramarachchi commented on QPID-3307: - Hi Robbie, Sorry for the delay in updating. Actually i found a way to simulate the Environment but i caught up with some work and couldn't find a time to work on a unit test case. I think happy path is already covered in the current serialization test cases we have. Only thing is i need to add a test case that simulates the above mentioned class loading environment. Will be able to provide a patch for that soon, possibly in next weekend. thanks, Charith ClassNotfound Exception when using Qpid java client in Complex classloading Environments. --- Key: QPID-3307 URL: https://issues.apache.org/jira/browse/QPID-3307 Project: Qpid Issue Type: Bug Components: Java Client Reporter: Charith Dhanushka Wickramarachchi Assignee: Robbie Gemmell Priority: Critical Attachments: QPID-3307_patch.txt, QPID-3307_patch.txt, QPID-3307_patch.txt, QPID-3307_patch_unit_test.txt Hi , When we are using qpid client to receive JMSObject in complex class loading environments like web application containers/Osgi environments .There is a scenario where this issues comes. Scenario. In a web application container normally they use a class loader per web app. and if we have qpid client libs at the root classloader level this error can come. The reason for this is Serializable Object types that are used inside the web app are not visible to the class loader that loads the JMSObject message and unmarshall it. thanks, Charith -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org