Hi Robbie,
Yep, I looked at it. Everything looks good to me. Good work all around.
Regards,
Weston
On Mar 7, 2013, at 7:06 PM, Robbie Gemmell robbie.gemm...@gmail.com wrote:
Hi Weston,
I was wondering if you had a chance to look at the changes? I'd like to get
this committed so
Having 2 build systems is a waste of time and a source of confusion. We
introduced the cmake build with the intent that it would replace the automake
system, I think the time has come to say farewell to automake. The cmake system
is ready: it covers the same ground as automake and more (esp.
[
https://issues.apache.org/jira/browse/QPID-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Ross updated QPID-4632:
---
Attachment: QPID-4632.patch
Proposed Patch
Change Threshold Alerts from Level-Sensitive to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9824/
---
Review request for qpid.
Description
---
Change the queue-depth threshold
+1
I can help with cmake issues as well. I'm not aware of any problems, but the
most likely spot is Linux packaging.
-Original Message-
From: Alan Conway [mailto:acon...@redhat.com]
Sent: Friday, March 08, 2013 9:57 AM
To: Qpid Dev
Subject: Proposal: get rid of automake build
Justin, Chuck, Devs,
In reviewing the work that Chuck is doing with the binding-switchover,
I've discovered that the current queue-depth thresholds are insufficient
to support an external process that wants to know when a queue is
getting full *and* when the queue is again draining. I've
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9824/#review17610
---
I was surprised to see that this patch doesn't break the Java Broker
Hi Alan,
Personally I'd rather cmake was given the heave ho ;-
for all of it's pain automake is something of a defacto standard for a
ton of projects.
Re Anyone know of specific issues that need to be addressed in cmake?
yeah, I don't have cmake installed :-D sorry. I'm just messing.
Hi Fraser,
-Original Message-
From: Fraser Adams [mailto:fraser.ad...@blueyonder.co.uk]
Sent: Friday, March 08, 2013 10:36 AM
To: dev@qpid.apache.org
Subject: Re: Proposal: get rid of automake build system.
Hi Alan,
Personally I'd rather cmake was given the heave ho ;-
Do you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9825/
---
Review request for qpid and Rafael Schloming.
Description
---
Fixes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9825/#review17611
---
Ship it!
Ship It!
- Rafael Schloming
On March 8, 2013, 3:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9802/#review17613
---
Ship it!
Ship It!
- Rafael Schloming
On March 7, 2013, 3:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9824/#review17614
---
trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp
On March 8, 2013, 5:02 p.m., Chug Rolke wrote:
trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp, line 214
https://reviews.apache.org/r/9824/diff/1/?file=268374#file268374line214
How about a test that the new thresholds have the down limit at least
one (or N?) below the up limit?
On Fri, 2013-03-08 at 15:36 +, Fraser Adams wrote:
Hi Alan,
Personally I'd rather cmake was given the heave ho ;-
for all of it's pain automake is something of a defacto standard for a
ton of projects.
cmake is also a de facto standard (just for a different - albeit smaller
- set of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9824/#review17616
---
Ship it!
Aside from the minor nits below, looks good.
Removing the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9824/#review17617
---
Ship it!
- Chug Rolke
On March 8, 2013, 3:13 p.m., Ted Ross
This seems sensible, although it does raise the question of what is
'dev' about this list if the choice of build system is a 'user' issue!
Andrew
That was pretty much the point that Gordon was making :-) There's kind
of a blurry line between Qpid users and developers - certainly given
that
Not that this speaks directly to the issue of instant deletion versus
a more dignified old-folks home retirement, but I would point out that
CMake is the sole build mechanism for AMQP 1.0 support in C/C++. You
can't avoid it going forward for at least part of your build.
Also since a lot of the
[
https://issues.apache.org/jira/browse/QPID-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved QPID-4626.
---
Resolution: Fixed
Fix Version/s: 0.21
Fix checked into trunk r1454437
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9698/
---
(Updated March 8, 2013, 7:42 p.m.)
Review request for qpid, Andrew Stitcher,
On Fri, 2013-03-08 at 18:06 +, Fraser Adams wrote:
This seems sensible, although it does raise the question of what is
'dev' about this list if the choice of build system is a 'user' issue!
Andrew
That was pretty much the point that Gordon was making :-) There's kind
of a blurry
[
https://issues.apache.org/jira/browse/QPID-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher updated QPID-4633:
--
Assignee: Andrew Stitcher
C++ broker compile error on RHEL 5 g++ 4.1.2
[
https://issues.apache.org/jira/browse/QPID-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher updated QPID-4634:
--
Assignee: Andrew Stitcher
C++ broker Boost-related compile errors
[
https://issues.apache.org/jira/browse/QPID-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved QPID-4634.
---
Resolution: Fixed
Fix Version/s: 0.21
fixed in trunk r1454595
C++
[
https://issues.apache.org/jira/browse/QPID-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved QPID-4633.
---
Resolution: Fixed
Fix Version/s: 0.21
fixed in trunk r1454595
C++
[
https://issues.apache.org/jira/browse/QPID-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Ross resolved QPID-4632.
Resolution: Fixed
Fix Version/s: (was: Future)
0.21
Commit 1454601
27 matches
Mail list logo
