[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324067#comment-17324067 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull request #1129:

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615108651 ## File path: src/adaptors/tcp_adaptor.c ## @@ -288,18 +338,87 @@ static int handle_incoming_impl(qdr_tcp_connection_t *conn, bool close_pending)

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324064#comment-17324064 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pull request

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615103944 ## File path: src/adaptors/tcp_adaptor.c ## @@ -288,18 +338,87 @@ static int handle_incoming_impl(qdr_tcp_connection_t *conn, bool close_pending)

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324060#comment-17324060 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: [WIP] PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-16 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615101682 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324058#comment-17324058 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: [WIP] PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-16 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615100630 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324057#comment-17324057 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: [WIP] PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-16 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615100296 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324056#comment-17324056 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: [WIP] PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-16 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615099019 ## File path: cpp/src/delivery.cpp ## @@ -40,6 +42,7 @@ namespace proton { delivery::delivery(pn_delivery_t* d): transfer(make_wrapper(d)) {}

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324053#comment-17324053 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on pull request #309: URL:

[GitHub] [qpid-proton] jiridanek commented on pull request #309: [WIP] PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-16 Thread GitBox
jiridanek commented on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-821532591 > I am still working on fixing tests. Sure. My point was that when you have a CI available, like here, it's best to first get the PR compiling. That way you get some

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324047#comment-17324047 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull request #1129:

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615089829 ## File path: src/adaptors/tcp_adaptor.c ## @@ -288,18 +338,87 @@ static int handle_incoming_impl(qdr_tcp_connection_t *conn, bool close_pending)

[jira] [Created] (DISPATCH-2059) Support running router under rr during test execution

2021-04-16 Thread Jira
Jiri Daněk created DISPATCH-2059: Summary: Support running router under rr during test execution Key: DISPATCH-2059 URL: https://issues.apache.org/jira/browse/DISPATCH-2059 Project: Qpid Dispatch

[jira] [Resolved] (DISPATCH-1858) HTTP1: occasional failure with leak of qd_deferred_call_t item

2021-04-16 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1858. - Resolution: Duplicate > HTTP1: occasional failure with leak of qd_deferred_call_t

[jira] [Updated] (DISPATCH-2048) system_tests_router_mesh failure due to leak of qd_deferred_call_t

2021-04-16 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-2048: Fix Version/s: 1.16.0 > system_tests_router_mesh failure due to leak of

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324035#comment-17324035 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull request #1129:

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615073245 ## File path: src/adaptors/tcp_adaptor.c ## @@ -1257,13 +1489,17 @@ static void qdr_tcp_delivery_update(void *context, qdr_delivery_t *dlv, uint64_t

[jira] [Resolved] (DISPATCH-2034) Rare flaky failure in system_tests_protocol_settings: AssertionError: ' incoming-window=10,' not found in '2021-03-31 00:25:14.317182 +0000 PROTOCOL (trace) [C4]:FRAM

2021-04-16 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-2034. - Resolution: Fixed > Rare flaky failure in system_tests_protocol_settings:

[jira] [Assigned] (DISPATCH-2034) Rare flaky failure in system_tests_protocol_settings: AssertionError: ' incoming-window=10,' not found in '2021-03-31 00:25:14.317182 +0000 PROTOCOL (trace) [C4]:FRAM

2021-04-16 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reassigned DISPATCH-2034: --- Assignee: Ganesh Murthy (was: Ken Giusti) > Rare flaky failure in

[jira] [Commented] (DISPATCH-2034) Rare flaky failure in system_tests_protocol_settings: AssertionError: ' incoming-window=10,' not found in '2021-03-31 00:25:14.317182 +0000 PROTOCOL (trace) [C4]:FRA

2021-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324032#comment-17324032 ] ASF subversion and git services commented on DISPATCH-2034: --- Commit

[jira] [Commented] (DISPATCH-2034) Rare flaky failure in system_tests_protocol_settings: AssertionError: ' incoming-window=10,' not found in '2021-03-31 00:25:14.317182 +0000 PROTOCOL (trace) [C4]:FRA

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324033#comment-17324033 ] ASF GitHub Bot commented on DISPATCH-2034: -- asfgit closed pull request #1131: URL:

[GitHub] [qpid-dispatch] asfgit closed pull request #1131: DISPATCH-2034: Search for the existence of a specific incoming window…

2021-04-16 Thread GitBox
asfgit closed pull request #1131: URL: https://github.com/apache/qpid-dispatch/pull/1131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324031#comment-17324031 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull request #1129:

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324030#comment-17324030 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on pull request #1129: URL:

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615069069 ## File path: src/adaptors/tcp_adaptor.c ## @@ -57,11 +57,15 @@ struct qdr_tcp_connection_t { qdr_delivery_t *outstream; bool

[GitHub] [qpid-dispatch] ChugR commented on pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
ChugR commented on pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#issuecomment-821506067 Adding a self test for this now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324028#comment-17324028 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull request #1129:

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615061964 ## File path: src/adaptors/tcp_adaptor.c ## @@ -782,6 +965,14 @@ static void qdr_tcp_open_server_side_connection(qdr_tcp_connection_t* tc) //

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324027#comment-17324027 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pull request

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615061225 ## File path: src/adaptors/tcp_adaptor.c ## @@ -1257,13 +1489,17 @@ static void qdr_tcp_delivery_update(void *context, qdr_delivery_t *dlv, uint64_t

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324026#comment-17324026 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull request #1129:

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615060537 ## File path: src/adaptors/tcp_adaptor.c ## @@ -116,6 +120,26 @@ static inline uint64_t qdr_tcp_conn_linkid(const qdr_tcp_connection_t *conn)

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324022#comment-17324022 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pull request

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615055634 ## File path: src/adaptors/tcp_adaptor.c ## @@ -782,6 +965,14 @@ static void qdr_tcp_open_server_side_connection(qdr_tcp_connection_t* tc) //

[jira] [Commented] (DISPATCH-2048) system_tests_router_mesh failure due to leak of qd_deferred_call_t

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324019#comment-17324019 ] ASF GitHub Bot commented on DISPATCH-2048: -- ganeshmurthy opened a new pull request #1132:

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1132: DISPATCH-2048: Fix shutdown leak of qd_deferred_call_t

2021-04-16 Thread GitBox
ganeshmurthy opened a new pull request #1132: URL: https://github.com/apache/qpid-dispatch/pull/1132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324018#comment-17324018 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pull request

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615052175 ## File path: src/adaptors/tcp_adaptor.c ## @@ -630,64 +780,92 @@ static void handle_connection_event(pn_event_t *e, qd_server_t *qd_server, void

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324017#comment-17324017 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pull request

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615051274 ## File path: src/adaptors/tcp_adaptor.c ## @@ -288,18 +338,87 @@ static int handle_incoming_impl(qdr_tcp_connection_t *conn, bool close_pending)

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324013#comment-17324013 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pull request

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615047802 ## File path: src/adaptors/tcp_adaptor.c ## @@ -116,6 +120,26 @@ static inline uint64_t qdr_tcp_conn_linkid(const qdr_tcp_connection_t *conn)

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324009#comment-17324009 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pull request

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615043535 ## File path: src/adaptors/tcp_adaptor.c ## @@ -57,11 +57,15 @@ struct qdr_tcp_connection_t { qdr_delivery_t *outstream; bool

[jira] [Commented] (DISPATCH-2034) Rare flaky failure in system_tests_protocol_settings: AssertionError: ' incoming-window=10,' not found in '2021-03-31 00:25:14.317182 +0000 PROTOCOL (trace) [C4]:FRA

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323951#comment-17323951 ] ASF GitHub Bot commented on DISPATCH-2034: -- ganeshmurthy opened a new pull request #1131:

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1131: DISPATCH-2034: Search for the existence of a specific incoming window…

2021-04-16 Thread GitBox
ganeshmurthy opened a new pull request #1131: URL: https://github.com/apache/qpid-dispatch/pull/1131 … in all the lines with a @begin frame, not just the first line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323949#comment-17323949 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull request #1129:

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r614998347 ## File path: src/adaptors/tcp_adaptor.c ## @@ -288,18 +338,87 @@ static int handle_incoming_impl(qdr_tcp_connection_t *conn, bool close_pending)

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323942#comment-17323942 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull request #1129:

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-16 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r614972470 ## File path: src/adaptors/tcp_adaptor.c ## @@ -57,11 +57,15 @@ struct qdr_tcp_connection_t { qdr_delivery_t *outstream; bool

[jira] [Updated] (DISPATCH-2046) Panic in handle due to deleted connector.

2021-04-16 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-2046: Fix Version/s: 1.16.0 > Panic in handle due to deleted connector. >

[jira] [Commented] (DISPATCH-2046) Panic in handle due to deleted connector.

2021-04-16 Thread Alex Ward (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323915#comment-17323915 ] Alex Ward commented on DISPATCH-2046: - Thanks Ganesh, I'll try that on our code too, let me know

[jira] [Updated] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it

2021-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-2039: - Description: >From https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning

[jira] [Commented] (DISPATCH-2058) qdr_delivery_cleanup_t leak in system_tests_grpc

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323862#comment-17323862 ] ASF GitHub Bot commented on DISPATCH-2058: -- ganeshmurthy opened a new pull request #1130:

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1130: DISPATCH-2058: Added code in core free to remove and free everything …

2021-04-16 Thread GitBox
ganeshmurthy opened a new pull request #1130: URL: https://github.com/apache/qpid-dispatch/pull/1130 …in the core->delivery_cleanup_list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (DISPATCH-2058) qdr_delivery_cleanup_t leak in system_tests_grpc

2021-04-16 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323860#comment-17323860 ] Ganesh Murthy commented on DISPATCH-2058: - This leak also happens in other tests as well. >

[jira] [Created] (DISPATCH-2058) qdr_delivery_cleanup_t leak in system_tests_grpc

2021-04-16 Thread Ganesh Murthy (Jira)
Ganesh Murthy created DISPATCH-2058: --- Summary: qdr_delivery_cleanup_t leak in system_tests_grpc Key: DISPATCH-2058 URL: https://issues.apache.org/jira/browse/DISPATCH-2058 Project: Qpid Dispatch

[jira] [Commented] (DISPATCH-2048) system_tests_router_mesh failure due to leak of qd_deferred_call_t

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323846#comment-17323846 ] ASF GitHub Bot commented on DISPATCH-2048: -- ganeshmurthy closed pull request #1127: URL:

[jira] [Commented] (DISPATCH-2050) fields for received delivery state are not relayed

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323845#comment-17323845 ] ASF GitHub Bot commented on DISPATCH-2050: -- gemmellr commented on pull request #1126: URL:

[GitHub] [qpid-dispatch] gemmellr commented on pull request #1126: DISPATCH-2050: propagate section-number and section-offset back to sender

2021-04-16 Thread GitBox
gemmellr commented on pull request #1126: URL: https://github.com/apache/qpid-dispatch/pull/1126#issuecomment-821205534 Obligatory note about tests to help avoid future breakage...especially given the repeated issues in this specific area. -- This is an automated message from the Apache

[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1127: DISPATCH-2048: Added code to clean out the qdr_delivery_cleanup_t on …

2021-04-16 Thread GitBox
ganeshmurthy closed pull request #1127: URL: https://github.com/apache/qpid-dispatch/pull/1127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Comment Edited] (QPIDJMS-535) Looping failure after SASL negotiation with Artemis v2.16

2021-04-16 Thread David Martin (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323840#comment-17323840 ] David Martin edited comment on QPIDJMS-535 at 4/16/21, 2:09 PM:

[jira] [Updated] (DISPATCH-2050) fields for received delivery state are not relayed

2021-04-16 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated DISPATCH-2050: - Fix Version/s: 1.16.0 Affects Version/s: 1.15.0 Adding affects/fix versions

[jira] [Assigned] (DISPATCH-2050) fields for received delivery state are not relayed

2021-04-16 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned DISPATCH-2050: Assignee: Gordon Sim > fields for received delivery state are not relayed >

[jira] [Resolved] (DISPATCH-2050) fields for received delivery state are not relayed

2021-04-16 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved DISPATCH-2050. -- Resolution: Fixed > fields for received delivery state are not relayed >

[jira] [Commented] (QPIDJMS-535) Looping failure after SASL negotiation with Artemis v2.16

2021-04-16 Thread David Martin (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323840#comment-17323840 ] David Martin commented on QPIDJMS-535: -- Encyclopedic memory :) OK I'm not too concerned about it

[jira] [Reopened] (DISPATCH-2050) fields for received delivery state are not relayed

2021-04-16 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reopened DISPATCH-2050: -- > fields for received delivery state are not relayed >

[jira] [Commented] (QPIDJMS-535) Looping failure after SASL negotiation with Artemis v2.16

2021-04-16 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323832#comment-17323832 ] Robbie Gemmell commented on QPIDJMS-535: Took me a while to find but I believe ARTEMIS-2547 is

[jira] [Resolved] (DISPATCH-2050) fields for received delivery state are not relayed

2021-04-16 Thread Gordon Sim (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved DISPATCH-2050. -- Resolution: Fixed > fields for received delivery state are not relayed >

[jira] [Commented] (DISPATCH-2050) fields for received delivery state are not relayed

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323819#comment-17323819 ] ASF GitHub Bot commented on DISPATCH-2050: -- grs closed pull request #1126: URL:

[jira] [Commented] (DISPATCH-2048) system_tests_router_mesh failure due to leak of qd_deferred_call_t

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323823#comment-17323823 ] ASF GitHub Bot commented on DISPATCH-2048: -- kgiusti commented on a change in pull request

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1127: DISPATCH-2048: Added code to clean out the qdr_delivery_cleanup_t on …

2021-04-16 Thread GitBox
kgiusti commented on a change in pull request #1127: URL: https://github.com/apache/qpid-dispatch/pull/1127#discussion_r614846246 ## File path: src/router_core/router_core.c ## @@ -896,6 +914,27 @@ void qdr_del_subscription_ref_CT(qdr_subscription_ref_list_t *list,

[jira] [Comment Edited] (QPIDJMS-535) Looping failure after SASL negotiation with Artemis v2.16

2021-04-16 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323822#comment-17323822 ] Robbie Gemmell edited comment on QPIDJMS-535 at 4/16/21, 1:39 PM: -- The

[jira] [Resolved] (QPIDJMS-535) Looping failure after SASL negotiation with Artemis v2.16

2021-04-16 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPIDJMS-535. Resolution: Not A Bug > Looping failure after SASL negotiation with Artemis v2.16 >

[jira] [Commented] (QPIDJMS-535) Looping failure after SASL negotiation with Artemis v2.16

2021-04-16 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323822#comment-17323822 ] Robbie Gemmell commented on QPIDJMS-535: The connection is being closed/refused by the broker to

[GitHub] [qpid-dispatch] grs closed pull request #1126: DISPATCH-2050: propagate section-number and section-offset back to sender

2021-04-16 Thread GitBox
grs closed pull request #1126: URL: https://github.com/apache/qpid-dispatch/pull/1126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Assigned] (DISPATCH-2054) SEGV in qdr_link_cleanup_deliveries_CT during system_tests_multi_tenancy

2021-04-16 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reassigned DISPATCH-2054: --- Assignee: Ganesh Murthy > SEGV in qdr_link_cleanup_deliveries_CT during

[jira] [Commented] (DISPATCH-2054) SEGV in qdr_link_cleanup_deliveries_CT during system_tests_multi_tenancy

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323813#comment-17323813 ] ASF GitHub Bot commented on DISPATCH-2054: -- asfgit closed pull request #1128: URL:

[jira] [Resolved] (DISPATCH-2054) SEGV in qdr_link_cleanup_deliveries_CT during system_tests_multi_tenancy

2021-04-16 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-2054. - Fix Version/s: 1.16.0 Resolution: Fixed > SEGV in

[GitHub] [qpid-dispatch] asfgit closed pull request #1128: DISPATCH-2054: Set tracking_addr on deliveries to zero since those ad…

2021-04-16 Thread GitBox
asfgit closed pull request #1128: URL: https://github.com/apache/qpid-dispatch/pull/1128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (DISPATCH-2054) SEGV in qdr_link_cleanup_deliveries_CT during system_tests_multi_tenancy

2021-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323812#comment-17323812 ] ASF subversion and git services commented on DISPATCH-2054: --- Commit

[jira] [Commented] (DISPATCH-2048) system_tests_router_mesh failure due to leak of qd_deferred_call_t

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323810#comment-17323810 ] ASF GitHub Bot commented on DISPATCH-2048: -- kgiusti commented on a change in pull request

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1127: DISPATCH-2048: Added code to clean out the qdr_delivery_cleanup_t on …

2021-04-16 Thread GitBox
kgiusti commented on a change in pull request #1127: URL: https://github.com/apache/qpid-dispatch/pull/1127#discussion_r614837591 ## File path: src/router_core/router_core.c ## @@ -258,6 +260,22 @@ void qdr_core_free(qdr_core_t *core) link =

[jira] [Commented] (DISPATCH-2048) system_tests_router_mesh failure due to leak of qd_deferred_call_t

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323808#comment-17323808 ] ASF GitHub Bot commented on DISPATCH-2048: -- kgiusti commented on a change in pull request

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1127: DISPATCH-2048: Added code to clean out the qdr_delivery_cleanup_t on …

2021-04-16 Thread GitBox
kgiusti commented on a change in pull request #1127: URL: https://github.com/apache/qpid-dispatch/pull/1127#discussion_r614835424 ## File path: src/router_core/router_core.c ## @@ -258,6 +260,22 @@ void qdr_core_free(qdr_core_t *core) link =

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323789#comment-17323789 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl edited a comment on pull request #309: URL:

[GitHub] [qpid-proton] DreamPearl edited a comment on pull request #309: [WIP] PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-16 Thread GitBox
DreamPearl edited a comment on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-821153641 > My guess: you created a new file tag.hpp and forgot to commit it? I once created this file but later deleted it, then forgot to delete it from include :'(

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323788#comment-17323788 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on pull request #309: URL:

[GitHub] [qpid-proton] DreamPearl commented on pull request #309: [WIP] PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-16 Thread GitBox
DreamPearl commented on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-821153641 > My guess: you created a new file tag.hpp and forgot to commit it? I once created this file but later deleted it, then forgot to delete it from include. :'(

[jira] [Updated] (QPIDJMS-535) Looping failure after SASL negotiation with Artemis v2.16

2021-04-16 Thread David Martin (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Martin updated QPIDJMS-535: - Description: This is not a production issue for us so tagging it as minor. Encountered during

[jira] [Commented] (DISPATCH-2050) fields for received delivery state are not relayed

2021-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323784#comment-17323784 ] ASF subversion and git services commented on DISPATCH-2050: --- Commit

[jira] [Created] (QPIDJMS-535) Looping failure after SASL negotiation with Artemis v2.16

2021-04-16 Thread David Martin (Jira)
David Martin created QPIDJMS-535: Summary: Looping failure after SASL negotiation with Artemis v2.16 Key: QPIDJMS-535 URL: https://issues.apache.org/jira/browse/QPIDJMS-535 Project: Qpid JMS

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323769#comment-17323769 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on pull request #309: URL:

[GitHub] [qpid-proton] jiridanek commented on pull request #309: [WIP] PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-16 Thread GitBox
jiridanek commented on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-821132679 @DreamPearl It's probably a high time you fixed the CI failure https://github.com/apache/qpid-proton/pull/309/checks?check_run_id=2362084471#step:11:185 ```

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323766#comment-17323766 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pull request #309:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: [WIP] PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-16 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r614789081 ## File path: cpp/src/sender.cpp ## @@ -64,10 +64,17 @@ namespace { uint64_t tag_counter = 0; } -tracker sender::send(const message ) { +tracker

  1   2   >