[GitHub] qpid-cpp issue #17: QPID-8187 Allow incompatible function casts for SASL com...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-cpp/pull/17
  
My mistake.  It's actually committed at 
https://github.com/apache/qpid-cpp/commit/706b5f3fb2fd4bb89ef8268575a8592b7b66272e


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp issue #14: QPID-8186 Use const ref when catching exceptions

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-cpp/pull/14
  
Commited at 
https://github.com/apache/qpid-cpp/commit/8b09d246f2529ea59809cac743e55af3920b4895


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp issue #17: QPID-8187 Allow incompatible function casts for SASL com...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-cpp/pull/17
  
@chrisrichardson77 , this one is on master at


https://github.com/apache/qpid-cpp/commit/8b09d246f2529ea59809cac743e55af3920b4895

Would you close the PR?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[ssorj]

Github user ssorj commented on the pull request:


https://github.com/apache/qpid-proton/commit/3dd3bd4913af915d1632fed57c350d76a5cd0ba2#commitcomment-30626644
  
In ruby/lib/core/connection.rb:
In ruby/lib/core/connection.rb on line 117:
I tried and failed to figure it out last time, so I resorted to the really 
long line ;).  I'll try again.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #296: Introduce a new structure under docs for multiple ...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-dispatch/pull/296
  
Squashed and merged at 
https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=f77f92c .


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #296: WIP - Introduce a new structure under docs for mul...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-dispatch/pull/296
  
@bhardesty, agreed.  I'll get final confirmation from the dispatch folks 
and then go ahead.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #95: PROTON-1412 Add fuzzers to proton-c tests

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/95
  
+1

On Mon, May 14, 2018 at 1:55 PM jirkadanek <notificati...@github.com> wrote:

> @astitcher <https://github.com/astitcher> @ssorj
> <https://github.com/ssorj> I found the Dockerfile. Are we ok with
> submitting that to oss-fuzz? (They would accept qpid proton, I've checked
> that long time ago.)
>
> PR at google/oss-fuzz#1417 <https://github.com/google/oss-fuzz/pull/1417>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/qpid-proton/pull/95#issuecomment-388959793>,
> or mute the thread
> 
<https://github.com/notifications/unsubscribe-auth/ABZTwBSiSSFlOrAR5ehEk-4zjfcx_oY4ks5tye9KgaJpZM4MH4ja>
> .
>



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #296: WIP - Introduce a new structure under docs for mul...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-dispatch/pull/296
  
@bhardesty , I think internal-resources/ is too restrictive.  We usually 
notes to mean freestyle topic-oriented stuff, usually in something informal 
such as markdown or plain text.  The content need not be internal in any sense. 
 It's just not part of some bigger doc component.

That's not to say having internal-resources/ is necessarily wrong, but I 
don't think I understand what "internal" means here.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #296: WIP - Introduce a new structure under docs for mul...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-dispatch/pull/296
  
That is indeed what I was thinking for book/reference-guide/.  But it's not 
actually there in the source.  You should feel free to choose another name if 
it's a better fit.

BTW, I don't mind rebasing this at all, so go ahead with any commits you 
have lined up.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #296: WIP - Introduce a new structure under docs ...

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-dispatch/pull/296

WIP - Introduce a new structure under docs for multiple books

The structure:

```
  docs/
notes/
man/ <- Much of the non-book content and scripting that was previously 
directly under doc/
books/
  common/ <- Common book stuff
  user-guide/ <- Was new-book/
  old-user-guide/ <- Was book/
  reference-guide/ <- To be added later on
```

 - Add scripting to generate the now primary "user-guide"
 - Rename doc/ to the more Qpid conventional docs/ and add a "make docs" 
target
 - Stop installing some files that IMO are likely not used much or at all 
since they are available online
 - Convert docs/README to markdown

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-dispatch ssorj-docs-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #296


commit 3554433f685bd293305c21130fa3949fcc037752
Author: Justin Ross <jross@...>
Date:   2018-04-26T22:17:29Z

Isolate the books from the other doc stuff, under a new directory structure

commit 60c4ef68f92fe4cb9da8fbaf43f9edd73efd479d
Author: Justin Ross <jross@...>
Date:   2018-04-26T23:01:47Z

Move the notes to the new docs structure

commit 1e4e7c197813291a749db3226431cb24349c0967
Author: Justin Ross <jross@...>
Date:   2018-04-26T23:53:57Z

Move the remaining man-related pieces into the new structure

commit bc02e3ee45c055bbf2ef8110de5156ab57c86bc9
Author: Justin Ross <jross@...>
Date:   2018-04-26T23:59:25Z

Remove the rest of doc/

commit 5d68e01dc27ef83fba5397eb06bbe80489150ae1
Author: Justin Ross <jross@...>
Date:   2018-04-27T00:16:54Z

Move this closer to where we use it

commit 3ec79d26dfe777206cf0a62ffcbe3bed1e14566c
Author: Justin Ross <jross@...>
Date:   2018-04-27T22:19:15Z

Don't install the html or adoc files




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #132: PROTON-1728: WIP: Reorganize the source tree ...

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/132


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #136: WIP - Remove deprecated bindings and APIs

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/136


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #138: WIP - Remove obsolete docs and test code

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/138


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #140: PROTON-1638, PROTON-1728: Reorganize the sour...

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/140


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp issue #12: WIP - A batch of C++ updates

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-cpp/pull/12
  
The related issues:

https://issues.apache.org/jira/issues/?jql=project%20%3D%20QPID%20and%20resolution%20is%20null%20and%20component%20in%20(%22C%2B%2B%20Broker%22%2C%20%22C%2B%2B%20Build%22%2C%20%22C%2B%2B%20Client%22%2C%20%22C%2B%2B%20Clustering%22%2C%20%22C%2B%2B%20Documentation%22%2C%20%22C%2B%2B%20Tests%22%2C%20%22C%2B%2B%20Tools%22%2C%20%22.NET%20Client%22%2C%20%22Perl%20Client%22%2C%20%22Python%20Client%20(Wrapped)%22%2C%20%22QMF%22%2C%20%22Ruby%20Client%22)%20and%20fixversion%20%3D%20qpid-cpp-1.38.0%20


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp pull request #12: WIP - A batch of C++ updates

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-cpp/pull/12

WIP - A batch of C++ updates

This is a slate of doc updates and patch applications for the C++ code 
base.  Please let me know if you see any problems here.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-cpp master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-cpp/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit 5899b313ae9a9cbf0d70bfa55527ebdd5c6addc7
Author: Justin Ross <jross@...>
Date:   2018-01-09T23:34:43Z

QPID-8073: Add missing package to help text

commit 4b1463abab12ae3d6b18c47ade723213fc6d2d6c
Author: Justin Ross <jross@...>
Date:   2018-03-12T18:32:28Z

QPID-8128: Link to libqpid-proton-core, not libqpid-proton; remove an 
obsolete way to find the proton config

commit ce769f7790e726ba84932ba57a209cb9d322abaa
Author: Justin Ross <jross@...>
Date:   2018-03-12T19:41:15Z

QPID-8072, QPID-8129: Remove the long deprecated Ruby and Python bindings 
to QMF2

commit 8d036fa5accf496eba39a838cffc553d30ddda93
Author: Justin Ross <jross@...>
Date:   2018-03-12T20:15:04Z

QPID-7051: Fix crash after reconnect with transactional session.  This is a 
patch from HÃ¥kan Johansson

commit e17a6f85a1bf90c51520d7ad7ed6739e81a84fdf
Author: Justin Ross <jross@...>
Date:   2018-03-12T20:49:23Z

QPID-7999: Move Fedora-specific init scripts to the fedora dir; disable 
their installation, but keep them in the build output so packagers can pick 
them up as needed

commit 25590819c54a780f2a48c74ad19bbe4c30bf0bc9
Author: Justin Ross <jross@...>
Date:   2018-03-12T22:05:50Z

QPID-7089: Add a note linking to OS packages

commit 00a7e9bb7975808659076fadfcbfd1bb64c5ed24
Author: Justin Ross <jross@...>
Date:   2018-03-12T22:37:45Z

QPID-7821: Add man pages for all executables.  Adapted from a patch from 
Irina Boverman.

commit 6186f50d0fdb73ef76918d163473c6e2a905f39c
Author: Justin Ross <jross@...>
Date:   2018-03-12T23:37:14Z

QPID-7630: Add a CMake switch to allow -Werror to be switched off

commit 9da6baaf7f67ad446c386070643449c8a23d6188
Author: Justin Ross <jross@...>
Date:   2018-03-12T23:52:42Z

QPID-8128: Remove the Proton version warning and raise the minimum version

commit 889813351649b9cdeef26b211d34eb87c9c5f1f6
Author: Justin Ross <jross@...>
Date:   2018-03-13T01:08:20Z

QPID-7054: Fix crash when closing a sender after the connection has been 
closed.  Thanks to HÃ¥kan Johansson for the patch.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #140: PROTON-1638, PROTON-1728: Reorganize the sour...

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/140

PROTON-1638, PROTON-1728: Reorganize the source tree

I plan to squash this on merge.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton 
ssorj-reorganize-the-source-tree

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit bb53a69334a88a0dbdb11550882b085660e765c7
Author: Justin Ross <jross@...>
Date:   2017-12-21T14:32:50Z

Remove old docs; some of this content will be restored to new locations

commit 6a0801b08e47f888d5074def67eb65f237e8f884
Author: Justin Ross <jross@...>
Date:   2017-12-21T17:39:06Z

Rename version.txt to VERSION.txt

commit 4dddef8019633f47f537645440c439d17102f349
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:00:14Z

Add a .txt extension to LICENSE and NOTICE, for nicer behavior on Windows

commit 654874b7ad62e3e850e4cc15fc7f6fb18d703690
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:21:29Z

Fixups for file name conventions

commit 7ce68cadcd25e718e87d8aa8241344f1f8ac81b7
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:29:48Z

Rename tools/py to tools/python to match the other python dirs

commit f36eba5aa4a988fe01432f19415c9878e6f5eec7
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:33:39Z

Make a space for ancillary files

commit 2beb5236ca6e0647c814a659db8d34bc4e3a1e94
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:46:30Z

Move the docs dir to the top level

commit 8a457c031132266014bc3b8f524c105d349495b6
Author: Justin Ross <jross@...>
Date:   2017-12-21T19:06:23Z

Move mllib to live with other python tools

commit f0531db10070e9a37f049f4f629cbd8fbd906add
Author: Justin Ross <jross@...>
Date:   2017-12-21T20:03:51Z

Move some includes and package configs to the top level

commit 9bc93610f183e26e8c8a0ab9ba3678b15cf110f6
Author: Justin Ross <jross@...>
Date:   2017-12-21T21:45:08Z

Lift all of proton-c/* to the top level and adjust paths

commit d1b359473f8e4ed899ed564a110866f8437ac68e
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:29:34Z

Adjust some reacharound paths

commit 2d8f4b87e2a42dacdfe559a1b0530f7e21185398
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:33:49Z

xproton.py is no longer used

commit 6434aee3d7930555259deb498b1c3dadde16c526
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:44:03Z

Move env.py with the other scripts in bin/

commit 4117280ca6b0d5eff0e3e6a8ca2818a6ac3c270c
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:59:24Z

Move tox.ini to misc/

commit 53facd9b7a676c1967983fd1c3ebf693cda46fb8
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:14:13Z

Move the env config scripts to misc/; adjust the target for tox.ini.in

commit 066afffcdd596613033fb44a14307106df07d0d5
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:17:51Z

Move soak-check with the other scripts

commit 781e3c9a586f6295ee1d84e363373eb7d22625c7
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:27:23Z

Remove the C++ reactor app

commit 2baa52785d683b6c4e68e99fd463e96d5d8bec0d
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:42:29Z

Move the legacy test apps to tools/test-apps/

commit 3864ff36be56c603f556d69918eb0cd17390
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:46:30Z

Correct some paths I missed

commit 7345c8c9e3174dea64580111e3f6a2cac189d9a9
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:49:37Z

Rename appveyor.yml to .appveyor.yml

commit b368b2a2b3adb351dfb3264b2a3c495d835d4e9d
Author: Justin Ross <jross@...>
Date:   2017-12-22T00:07:19Z

Fix a broken path

commit 82f3d53f93da9a53bf9c9b06e5e83fcadd1e056c
Author: Justin Ross <jross@...>
Date:   2017-12-22T00:26:41Z

Move some of the less frequently used readme files to docs/

commit 4f87c3e5794b98ea0468593821070d2f433a3747
Author: Justin Ross <jross@...>
Date:   2018-02-14T01:16:15Z

Remove the perl, php, node, and javascript bindings

commit a54afc17b38a4e4719afe286ffb55cc8e7c5e337
Author: Justin Ross <jross@...>
Date:   2018-02-14T02:31:07Z

Remove the messenger docs

commit 4c7227bd906f4afb44ce61fff7c432df1fb1cd5d
Author: Justin Ross <jross@...>
Date:   2018-02-14T02:34:40Z

Remove the python messenger API

commit 00e3f95bb83756230a468d67a98ea32c64cd276b
Author: Justin Ross <jross@...>
Date:   2018-02-14T03:16:19Z

Remove the ruby messenger API

commit b931a410ba77bd49151cce52bbba69d15f1dd3d4
Author: Justin Ross <jross@...>
Date:   2018-03-06T23:06:36Z

Remove the rea

[GitHub] qpid-proton pull request #138: WIP - Remove obsolete docs and test code

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/138

WIP - Remove obsolete docs and test code

Part two of the planned source reorg.  This is intended to follow after 
https://github.com/apache/qpid-proton/pull/136 .


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton 
ssorj-remove-obsolete-docs-and-test-code

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #138


commit 93e54946349509d46ea007a67c57c14e14bed517
Author: Justin Ross <jross@...>
Date:   2018-02-14T01:16:15Z

Remove the perl, php, node, and javascript bindings

commit 1bcd14bbf0bd0b86f4e4e56f0ecb4bf49911aa6d
Author: Justin Ross <jross@...>
Date:   2018-02-14T02:31:07Z

Remove the messenger docs

commit e72f0260cf60c258ba65060739eab552e519d81a
Author: Justin Ross <jross@...>
Date:   2018-02-14T02:34:40Z

Remove the python messenger API

commit cc1af07068f0bbc5858e62a3302a4ca7e256c97f
Author: Justin Ross <jross@...>
Date:   2018-02-14T03:16:19Z

Remove the ruby messenger API

commit 3c2933f0337d9bcf78be8d03ba131f501ec56e75
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:27:23Z

Remove the C++ reactor app

commit b25c790042ba8682107004d983ddfcc60270196b
Author: Justin Ross <jross@...>
Date:   2017-12-21T14:32:50Z

Remove old docs; some of this content will be restored to new locations

commit 91641343baa970c1ce6bbe62a36995a9fbcc116d
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:33:49Z

xproton.py is no longer used

commit 17cd911bf3588bbec44aeacc5744fad765a41824
Author: Justin Ross <jross@...>
Date:   2018-03-06T23:06:36Z

Remove the reactor-based quick_perf

commit 598a72486c724b75c10c57416d0f3af0a3a83b8d
Author: Justin Ross <jross@...>
Date:   2018-03-06T23:13:35Z

Remove the python reactor-send impl




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #136: WIP - Remove deprecated bindings and APIs

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/136

WIP - Remove deprecated bindings and APIs

This is part one of the planned source reorg.

Note that the SSL test coverage may be impacted by the tests removed in 
tests/python/proton_tests/ssl.py (MessengerSSLTests).  I can raise a jira for 
that if we think there is something useful that should be replaced.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton 
ssorj-remove-deprecated-bindings-and-apis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #136


commit 20a477d8387b32cf73cd3e1cfffef4aac5c71117
Author: Justin Ross <jross@...>
Date:   2018-02-14T01:16:15Z

Remove the perl, php, node, and javascript bindings

commit 2c77fdda6749c2939446755d20d39e66e7be77ca
Author: Justin Ross <jross@...>
Date:   2018-02-14T02:31:07Z

Remove the messenger docs

commit 3c620994417880bd35394fb145faf42718aeb3be
Author: Justin Ross <jross@...>
Date:   2018-02-14T02:34:40Z

Remove the python messenger API

commit b5c5e86292b4bc9fd332c5522051cfab687924e5
Author: Justin Ross <jross@...>
Date:   2018-02-14T03:16:19Z

Remove the ruby messenger API




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #244: DISPATCH-89: Exchange Binding forwarder (ex...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/244#discussion_r163612727
  
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -1126,6 +1126,106 @@
 }
 },
 
+"router.config.exchange": {
+"description":"[EXPERIMENTAL] Defines a topic exchange.",
+"extends": "configurationEntity",
+"operations": ["CREATE", "DELETE"],
+"attributes": {
+"address": {
--- End diff --

Ken and I chatted about how to make things more consistent.

In order to avoid two divergent conventions, I've added a request to change 
from "addr" to "address" to https://issues.apache.org/jira/browse/DISPATCH-918 .

We looked at how the router currently does statistics and just generally 
audited the names here. We came to the following changes.

Section | Current | Proposed
-- | -- | --
exchange | alternate | alternateAddress
  | deliveriesReceived | receivedCount
  | deliveriesDropped | droppedCount
  | deliveriesForwarded | forwardedCount
  | deliveriesAlternate | divertedCount
binding | exchange | exchangeName
  | nextHop | nextHopAddress
  | phase | nextHopPhase
  | key | bindingKey
  | deliveriesMatched | matchedCount




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #244: DISPATCH-89: Exchange Binding forwarder (ex...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/244#discussion_r163344546
  
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -1126,6 +1126,106 @@
 }
 },
 
+"router.config.exchange": {
+"description":"[EXPERIMENTAL] Defines a topic exchange.",
+"extends": "configurationEntity",
+"operations": ["CREATE", "DELETE"],
+"attributes": {
+"address": {
--- End diff --

I think address on router.node should change to "addr".  It's the only 
outlier.  The rest of the config is using "addr" consistently.

Side note: "address" for one address and "addr" for multiple addresses is 
an automatic user gotcha.  There is zero help for the user in those names.

And data point: The doc for "addr" on autoLink says it is just one address.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #244: DISPATCH-89: Exchange Binding forwarder (ex...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/244#discussion_r163318304
  
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -1126,6 +1126,106 @@
 }
 },
 
+"router.config.exchange": {
+"description":"[EXPERIMENTAL] Defines a topic exchange.",
+"extends": "configurationEntity",
+"operations": ["CREATE", "DELETE"],
+"attributes": {
+"address": {
--- End diff --

@kgiusti , maybe this should be "addr".  That's the established name for 
addresses in the config.  (I prefer "address", but it's more important to avoid 
two different names the same thing.)


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #132: PROTON-1728: WIP: Reorganize the source tree and rem...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/132
  
One more change I'd like to consider making is moving the language-specific 
examples with their binding code.  That's consistent with how we currently 
handle docs, and it will make the cmake logic a bit more natural.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #132: PROTON-1728: WIP: Reorganize the source tree ...

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/132

PROTON-1728: WIP: Reorganize the source tree and remove deprecated bindings

WIP! For review only.

Note that this doesn't attempt any significant clean up of the cmake logic. 
 I left that for another day.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton ssorj-source-reorg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #132


commit 4bfffc7562959ff5a91235f77a9a6f5f773c24cc
Author: Justin Ross <jross@...>
Date:   2017-12-21T14:32:50Z

Remove old docs; some of this content will be restored to new locations

commit dc9f16503abc9dcd2630ef45e0ac977c12e85058
Author: Justin Ross <jross@...>
Date:   2017-12-21T17:39:06Z

Rename version.txt to VERSION.txt

commit 0fbf1bba3b3a19050f5cbb0240e23b7ed5c81ca8
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:00:14Z

Add a .txt extension to LICENSE and NOTICE, for nicer behavior on Windows

commit df52a496454bba1d013fc63f489e53334d359256
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:13:19Z

Remove unused test code

commit a90f8636d7ae7a9a689b361763e21eda846b3ab2
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:21:29Z

Fixups for file name conventions

commit b87af3b679d3b3c0290e4bebe482500abc0abf09
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:29:48Z

Rename tools/py to tools/python to match the other python dirs

commit 79089187d426ff393c97bdd4842a5ad1fae771d2
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:33:39Z

Make a space for ancillary files

commit 3852892c4f677fb02fe2dc2e09c3e7337dcff3da
Author: Justin Ross <jross@...>
Date:   2017-12-21T18:46:30Z

Move the docs dir to the top level

commit 64bea13516ebf4baf7e406380e3246f26c7cb7e6
Author: Justin Ross <jross@...>
Date:   2017-12-21T19:06:23Z

Move mllib to live with other python tools

commit 854be9fdd6ab497009310a7922c377c68e763f06
Author: Justin Ross <jross@...>
Date:   2017-12-21T20:03:51Z

Move some includes and package configs to the top level

commit f6e153d3639c740d5ba607b3a04de6a7ed42574e
Author: Justin Ross <jross@...>
Date:   2017-12-21T21:45:08Z

Lift all of proton-c/* to the top level and adjust paths

commit 8901f2e2ebd428f177e8c78a55a333e0768a461a
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:07:26Z

Remove the unmaintained javascript, node, perl, and php bindings

commit b31d2ec9287bc1e1ed588e6c21b53a1fd801f4d0
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:29:34Z

Adjust some reacharound paths

commit 1695aba83452606ceeb0e3e7ab9435bdb4cd4dd8
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:33:49Z

xproton.py is no longer used

commit 32338a0644a1cfe8a02489b4b13ae1ad84f55fce
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:44:03Z

Move env.py with the other scripts in bin/

commit c9d076e8645ed26e3a44bc3cd389ef419d20258f
Author: Justin Ross <jross@...>
Date:   2017-12-21T22:59:24Z

Move tox.ini to misc/

commit 39c5818b1425dd54bb9779091c8ab94fd0b93b86
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:03:10Z

Move versions.cmake to src/lib-versions.cmake

commit 9edf75bab8f4f26b2b94bf8b3c65734de56fa6f4
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:14:13Z

Move the env config scripts to misc/; adjust the target for tox.ini.in

commit ab6550fa23c9d33bc542ab5ae74e1d869bd77318
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:17:51Z

Move soak-check with the other scripts

commit 618e22aafef560ff5056f85e2d20171370c7f486
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:27:23Z

Remove the C++ reactor app

commit 586061d038b9d08d1c328ed109398ee14b0934db
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:42:29Z

Move the legacy test apps to tools/test-apps/

commit 0ac09ee8d9b46169a5936f770d21bdd21e978026
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:46:30Z

Correct some paths I missed

commit ced4cef433404f1100cfe1b9b6260a2d83e14b9e
Author: Justin Ross <jross@...>
Date:   2017-12-21T23:49:37Z

Rename appveyor.yml to .appveyor.yml

commit 5d4156d96327d78d6e65c535b9ebc1093a5902a7
Author: Justin Ross <jross@...>
Date:   2017-12-22T00:02:44Z

Back to just versions.cmake - no need to be overly narrow

commit 038857d8f49a781731eff9397038cc02738acb72
Author: Justin Ross <jross@...>
Date:   2017-12-22T00:07:19Z

Fix a broken path

commit e397ef25143cd4aa434bfe1de4adc5a486668f1c
Author: Justin Ross <jross@...>
Date:   2017-12-22T00:26:41Z

Move some of the less f

[GitHub] qpid-proton pull request #:

[ssorj]

Github user ssorj commented on the pull request:


https://github.com/apache/qpid-proton/commit/fe9069f9d9f5e27a8c3609eec366517ed8207b20#commitcomment-26196677
  
In tools/py/proctest.py:
In tools/py/proctest.py on line 10:
This looks unintended.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
@dmitrytokarev , I was failing at making it merge the way I wanted.  I will 
try to figure out the right sequence of commands so I get it right next time. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
@aikchar , I applied this patch.  Please close when you get a chance.


https://github.com/apache/qpid-proton/commit/2b033949c54549591113e61ea33e625f9b898cbb


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #127: PROTON-1651 Fix typos found by the spellchecker

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/127
  
@jdanekrh , I adapted this patch and applied it.  I excluded any diffs 
against the Ruby binding since it's been revamped.  If you're satisified, 
please close.


https://github.com/apache/qpid-proton/commit/e22ca536c69e840bbe9816029a5903408c9a2570


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #130: Add coverage reporting for the Ruby binding

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/130
  
We'll get this when 0.20.0 opens.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #95: PROTON-1412 Add fuzzers to proton-c tests

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/95
  
We'll try to get this for 0.20.0.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #106: Added command line parameters for configure URL and ...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/106
  
@ppatierno , would you close this.  It's now part of 0.18.0.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/224#discussion_r155647815
  
--- Diff: src/connection_manager.c ---
@@ -45,6 +45,7 @@ struct qd_config_ssl_profile_t {
 char*ssl_certificate_file;
 char*ssl_private_key_file;
 char*ciphers;
+char*protocols;
--- End diff --

*ssl_protocols?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/224#discussion_r155652198
  
--- Diff: include/qpid/dispatch/server.h ---
@@ -305,6 +305,12 @@ typedef struct qd_server_config_t {
  */
 char *ciphers;
 
+/**
+ * This list is a space separated string of the allowed TLS protocols. 
The current possibilities are TLSv1 TLSv1.1 TLSv1.2.
--- End diff --

A possible enhancement is to sub spaces for commas and document it as a 
comma-separated list.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/224#discussion_r155651659
  
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -515,7 +515,12 @@
 "type": "string",
 "description": "Specifies the enabled ciphers so the 
SSL Ciphers can be hardened. In other words, use this field to disable weak 
ciphers. The ciphers are specified in the format understood by the OpenSSL 
library. For example, ciphers can be set to 
ALL:!aNULL:!EXPORT56:RC4+RSA:+HIGH:+MEDIUM:+LOW:+SSLv2:+EXP; -- The full list 
of allowed ciphers can be viewed using the openssl ciphers command",
 "create": true
-},
+},  
+"protocols": {
+"type": "string",
+"description": "This list is a space separated string 
of the allowed TLS protocols. The current possibilities are TLSv1 TLSv1.1 
TLSv1.2. For example, if you want to permit only TLS V.1.1 and TLSv1.2, your 
value for the protocols would be TLSv1.1 TLSv1.2. If this attribute is not set, 
then all the TLS protocols are allowed.",
--- End diff --

"then all the protocols are allowed" is not quite right.  If unset, it 
defers to the system-wide configuration.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/224#discussion_r155647744
  
--- Diff: src/connection_manager.c ---
@@ -45,6 +45,7 @@ struct qd_config_ssl_profile_t {
 char*ssl_certificate_file;
 char*ssl_private_key_file;
 char*ciphers;
--- End diff --

*ssl_ciphers?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #224: DISPATCH-884 - Added schema property protoc...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/224#discussion_r155649659
  
--- Diff: include/qpid/dispatch/server.h ---
@@ -305,6 +305,12 @@ typedef struct qd_server_config_t {
  */
 char *ciphers;
 
+/**
+ * This list is a space separated string of the allowed TLS protocols. 
The current possibilities are TLSv1 TLSv1.1 TLSv1.2.
+ * For example, if you want to permit only TLS V.1.1 and TLSv1.2, your 
value for the protocols would be TLSv1.1 TLSv1.2. If this attribute is not set, 
then all the TLS protocols are allowed.
--- End diff --

"TLS V.1.1" -> "TLSv1.1"


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #126: PROTON-1632: WIP: Split library versions

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/126


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #126: PROTON-1632: WIP: Split library versions

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/126
  
https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=7c252e9


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #126: PROTON-1632: WIP: Split library versions

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/126

PROTON-1632: WIP: Split library versions



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton ssorj-versions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit 3009a235e232e933f740e1b7e067868897dd67e4
Author: Justin Ross <jr...@apache.org>
Date:   2017-10-14T23:56:03Z

Split library versions




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp issue #10: Assorted C++ build fixes for review

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-cpp/pull/10
  
@chrisrichardson77, thanks for taking a look at this.  I really appreciate 
it.

I adjusted my changes locally in according to your suggestions.  Only one 
initialization problem arises now.

  https://gist.github.com/ssorj/cb3da19880716089becdb7ff95837356

That does indeed look like a specious GCC [maybe-]warning.  It looks like 
other people have run into this.

  
https://stackoverflow.com/questions/21755206/how-to-get-around-gcc-void-b-4-may-be-used-uninitialized-in-this-funct

I currently see two options.  I can keep the unnecessary s("") to avoid 
this particular warning, or we can deploy the big hammer and stop failing the 
build on maybe-uninitialized warnings.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #120: PROTON-1369: Add deprecation warnings to the C++ bin...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/120
  
Changes made per the review.

I took part of the logic from the cmake deprecation macro, but kept some of 
the conditions from the previous iteration because they are more consistent 
with the rest of the defines in export.hpp.

I will squash these before commit.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #120: PROTON-1369: Add deprecation warnings to the C++ bin...

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/120
  
"I note that it doesn't include the declaration itself - I take this to 
mean that you can choose the correct place to put the macro do it works for all 
the supported compilers - This certainly seems neater to me."

I don't get this one.  Isn't the idea that VS puts the attribute before the 
declaration, and GCC after, so you need to explicitly position the declaration?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #121: PROTON-1368: Remove parser from the public AP...

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/121


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #121: PROTON-1368: Remove parser from the public API

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/121
  

https://github.com/apache/qpid-proton/commit/ea02b93374b527206eef3a1c7def939eff7804fb


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #121: PROTON-1368: Remove parser from the public AP...

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/121

PROTON-1368: Remove parser from the public API



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton ssorj-make-parser-internal

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #121


commit 464cd45bfcf0cc7695e26358c764e2993066f631
Author: Justin Ross <jr...@apache.org>
Date:   2017-09-26T18:41:38Z

PROTON-1368: Remove parser from the public API




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #120: PROTON-1369: Add deprecation warnings to the ...

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/120

PROTON-1369: Add deprecation warnings to the C++ binding

Changes

 - Add warnings for default_container.hpp, function.hpp, url.hpp, and some 
methods in value.hpp
 - Removed some deprecated type conversion functions that were never 
published as API
 - Convert examples that used the URL class to instead split the connection 
URL and address into two args
 - Some minor example improvements

Notes and questions

 - This approach requires users define PN_CPP_USE_DEPRECATED_API if they 
want to carry on without moving to the preferred APIs.
- The alternative is #pragma message (just a warning), but that's not 
as portable as #error.  #warning is regrettably non-standard.
 - I'm using #define PN_CPP_USE_DEPRECATED_API/#undef for internal uses - 
what's the other approach?  I remember a recommendation to use an ORed set of 
internal variables, but I unfortunately lost the details.
 - I wasn't able to find the cmake support for deprecation macros.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton ssorj-deprecations

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #120


commit d5f17b9e7b8021e7e8a5614ba92cda5f8ed80def
Author: Justin Ross <jr...@apache.org>
Date:   2017-09-26T17:53:48Z

PROTON-1369: Add deprecation warnings




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-cpp/pull/10

Assorted C++ build fixes for review

Do not merge.  For review purposes only.

This includes the sketchy initialization changes to make things compile on 
Fedora 26.  It now also includes the clang linking fix, eliminates the swig 
cmake warnings, and bumps the max tested proton version.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-cpp master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-cpp/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit be2668472f8cf82afa181d523a328ac8b289e933
Author: Justin Ross <jr...@apache.org>
Date:   2017-09-20T23:11:58Z

QPID-7893: Dubious fixes for initialization warnings

commit f32608eaa665c6e107da8e80e4300718310db172
Author: Justin Ross <jr...@apache.org>
Date:   2017-09-21T23:46:55Z

QPID-7713: The proximate fix for the clang linking problem

commit ac94a96dfe1319b5cf65070750c9e4620acb8442
Author: Justin Ross <jr...@apache.org>
Date:   2017-09-22T00:09:37Z

QPID-7860: Fix swig deprecation warnings

commit 64b0cdafd51c4d0db3faca12e873236112fb3b53
Author: Justin Ross <jr...@apache.org>
Date:   2017-09-22T00:24:38Z

QPID-7920: Increment the max safe proton version




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp pull request #9: Highly sketchy fixes for initialization warnings

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-cpp/pull/9


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp pull request #9: Highly sketchy fixes for initialization warnings

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-cpp/pull/9

Highly sketchy fixes for initialization warnings

Don't merge this.

This commit gets things building on Fedora 26, addressing QPID-7893 [1].  
I'm stabbing in the dark when it comes to C++ initialization.  Please help me 
determine if these changes are correct and harmless.

[1]: https://issues.apache.org/jira/browse/QPID-7893

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-cpp master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-cpp/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit be2668472f8cf82afa181d523a328ac8b289e933
Author: Justin Ross <jr...@apache.org>
Date:   2017-09-20T23:11:58Z

QPID-7893: Dubious fixes for initialization warnings




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/115

PROTON-1533: Fix swig deprecation warnings

For review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #115


commit 7fa4bf7be0f7e5cf6e43683a3294675df908f46c
Author: Justin Ross <jr...@apache.org>
Date:   2017-08-08T23:49:31Z

Use swig_add_library instead of the now deprecated swig_add_module; provide 
a fallback impl

commit 5c2b1529e610171172565eb802cec8102a9e48be
Author: Justin Ross <jr...@apache.org>
Date:   2017-08-09T00:07:42Z

Correct a cmake test expression

commit 04c07670a445ceb7188a56070c5141e8bded56a0
Author: Justin Ross <jr...@apache.org>
Date:   2017-08-09T12:02:24Z

Remove extraneous macro definition




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/105#discussion_r117524549
  
--- Diff: proton-c/bindings/cpp/include/proton/work_queue.hpp ---
@@ -0,0 +1,368 @@
+#ifndef PROTON_EVENT_LOOP_HPP
--- End diff --

This needs a rename.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #105: Port of C++ binding to Proton Proactor

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/105#discussion_r117524348
  
--- Diff: proton-c/bindings/cpp/include/proton/message.hpp ---
@@ -329,11 +329,7 @@ class message {
 mutable annotation_map message_annotations_;
 mutable annotation_map delivery_annotations_;
 
-/// Decode the message corresponding to a delivery from a link.
--- End diff --

How does this relate to the other changes here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #93: PROTON-1312: fix memory leak on BlockingConnec...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/93#discussion_r95481951
  
--- Diff: proton-c/bindings/python/proton/__init__.py ---
@@ -2581,6 +2581,9 @@ def close(self):
 """
 self._update_cond()
 pn_connection_close(self._impl)
+if hasattr(self, '_session_policy'):
--- End diff --

Gotcha, consistent with the existing code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #93: PROTON-1312: fix memory leak on BlockingConnec...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/93#discussion_r95481898
  
--- Diff: proton-c/bindings/python/proton/utils.py ---
@@ -132,10 +132,12 @@ def __init__(self, connection, receiver, fetcher, 
credit=1):
 raise LinkException("Failed to open receiver %s, source does 
not match" % self.link.name)
 if credit: receiver.flow(credit)
 self.fetcher = fetcher
+self.container = connection.container
 
 def __del__(self):
 self.fetcher = None
-self.link.handler = None
+self.link.handler = None  # fails if reactor finalizes first
--- End diff --

Maybe clarify that comment then.  As it stands, it appears to describe as 
normal a state that you have taken trouble to avoid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #93: PROTON-1312: fix memory leak on BlockingConnec...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/93#discussion_r95426588
  
--- Diff: proton-c/bindings/python/proton/utils.py ---
@@ -132,10 +132,12 @@ def __init__(self, connection, receiver, fetcher, 
credit=1):
 raise LinkException("Failed to open receiver %s, source does 
not match" % self.link.name)
 if credit: receiver.flow(credit)
 self.fetcher = fetcher
+self.container = connection.container
 
 def __del__(self):
 self.fetcher = None
-self.link.handler = None
+self.link.handler = None  # fails if reactor finalizes first
--- End diff --

What happens with the error if it fails?  I suppose in that case it doesn't 
matter that the subsequent statement is not reached?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #93: PROTON-1312: fix memory leak on BlockingConnec...

[ssorj]

Github user ssorj commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/93#discussion_r95426083
  
--- Diff: proton-c/bindings/python/proton/__init__.py ---
@@ -2581,6 +2581,9 @@ def close(self):
 """
 self._update_cond()
 pn_connection_close(self._impl)
+if hasattr(self, '_session_policy'):
--- End diff --

Out of curiosity, why isn't _session_policy a stable attribute of the 
object?  That is, could we simply assign None here?  I would prefer that a bit 
if it makes no difference.  This likely predates your change, but I usually try 
to avoid having to test for the presence of attributes in Python objects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org