Re: Review Request 15353: Add --paging-dir broker option

2013-11-12 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15353/ --- (Updated Nov. 12, 2013, 9:42 a.m.) Review request for qpid. Changes ---

Re: Review Request 15353: Add --paging-dir broker option

2013-11-12 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15353/#review28738 --- Ship it! Ship It! - Andrew Stitcher On Nov. 12, 2013, 9:42

Re: Review Request 15353: Add --paging-dir broker option

2013-11-11 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15353/ --- (Updated Nov. 11, 2013, 12:30 p.m.) Review request for qpid. Changes ---

Re: Review Request 15353: Add --paging-dir broker option

2013-11-11 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15353/#review28679 --- /trunk/qpid/cpp/src/qpid/broker/Broker.cpp

Re: Review Request 15353: Add --paging-dir broker option

2013-11-11 Thread Gordon Sim
On Nov. 11, 2013, 7:31 p.m., Andrew Stitcher wrote: /trunk/qpid/cpp/src/qpid/broker/Broker.cpp, line 220 https://reviews.apache.org/r/15353/diff/2/?file=381997#file381997line220 [Just my personal preference] I think it would be clearer to make this:

Re: Review Request 15353: Add --paging-dir broker option

2013-11-11 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15353/#review28699 --- Ship it! - Andrew Stitcher On Nov. 11, 2013, 12:30 p.m., Gordon

Re: Review Request 15353: Add --paging-dir broker option

2013-11-11 Thread Andrew Stitcher
On Nov. 11, 2013, 7:31 p.m., Andrew Stitcher wrote: /trunk/qpid/cpp/src/qpid/broker/Broker.cpp, line 220 https://reviews.apache.org/r/15353/diff/2/?file=381997#file381997line220 [Just my personal preference] I think it would be clearer to make this:

Review Request 15353: Add --paging-dir broker option

2013-11-08 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15353/ --- Review request for qpid. Bugs: QPID-5316

Re: Review Request 15353: Add --paging-dir broker option

2013-11-08 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15353/#review28552 --- /trunk/qpid/cpp/src/qpid/DataDir.cpp

Re: Review Request 15353: Add --paging-dir broker option

2013-11-08 Thread Jakub Scholz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15353/#review28601 --- I can't really comment on the code. But as far as the functionality