[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/73 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73290304 --- Diff: query_optimizer/rules/BottomUpRule.hpp --- @@ -80,6 +81,14 @@ class BottomUpRule : public Rule { */ virtual TreeNodePtr

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

Github user pateljm commented on the issue: https://github.com/apache/incubator-quickstep/pull/75 This looks good Caleb (@cwelton)! Can you rebase so that I can merge this commit? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-quickstep issue #74: Removed the redundant query id in the optimiz...

Github user pateljm commented on the issue: https://github.com/apache/incubator-quickstep/pull/74 @jianqiao @hbdeshmukh Did any of you want the query_id for use in the future? @zuyu: Can you expand on the reason to drop the query_id further? Thanks! --- If your

[GitHub] incubator-quickstep issue #76: Visualize execution plan DAGs annotated with ...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/76 Thanks Harshad! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-quickstep pull request #79: Constructed Generators once in the opt...

Github user zuyu closed the pull request at: https://github.com/apache/incubator-quickstep/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep issue #73: Move hash join's probe and build node decisio...

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/73 @jianqiao Per workflow, please delete the branch after merged. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

Github user cwelton commented on the issue: https://github.com/apache/incubator-quickstep/pull/75 Rebase complete --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/75 @pateljm We need to reverse this merge, due to an incorrect rebase. @cwelton We expect a different rebase result where this PR only contains a single commit ahead of the

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

Github user cwelton commented on the issue: https://github.com/apache/incubator-quickstep/pull/75 Ah, sorry, just thought you wanted the extraneous merge commit squashed. I've reordered the commits in my branch. For some reason the hashjoin commit is still showing up in this PR,

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

Github user cwelton commented on the issue: https://github.com/apache/incubator-quickstep/pull/75 Thanks for fixing, I suggest adding a contributor's guide with your suggested git workflow, to help streamline future contributors/contributions. --- If your project is set up for it,

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/75 @cwelton No worry for this PR. I've addressed the issues in the `master` branch. Thanks again for submitting a PR. Next time if we run `git fetch origin/master` and then `git rebase

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

Github user pateljm commented on the issue: https://github.com/apache/incubator-quickstep/pull/75 Thanks @cwelton! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-quickstep pull request #76: Visualize execution plan DAGs annotate...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/76#discussion_r73384912 --- Diff: query_execution/QueryExecutionTypedefs.hpp --- @@ -98,6 +98,12 @@ enum QueryExecutionMessageType : message_type_id { #endif

[GitHub] incubator-quickstep issue #74: Removed the redundant query id in the optimiz...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/74 This change looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-quickstep pull request #74: Removed the redundant query id in the ...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #77: Added TMB Client Id in QueryHandle.

GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/77 Added TMB Client Id in QueryHandle. W/ the concurrent query support, `QueryHandle` needs to capture the TMB client id of the `CLI` which submits the query, so `Foreman` could later reply

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/75 Yes, we should add a workflow for contributors as well. Stay tuned! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/75 @cwelton I've created [the guideline](https://cwiki.apache.org/confluence/display/QUICKSTEP/Workflow+For+Contributors) as suggested. Cheers! --- If your project is set up for it, you can

Re: Podling Report Reminder - August 2016

Thanks Julian for the reminder! Just added the report for Quickstep. Cheers, Jignesh On Wed, Aug 3, 2016 at 2:57 PM, Julian Hyde wrote: > Today is the deadline for the report. If you miss the deadline, this will > be the second consecutive month that you have failed to

Re: 5 things

Thanks Julian! Nope hadn't seen those emails -- I bet its in my (now deleted) Pivotal mailbox. @Julian: Nice feedback on using the Apache terms. Makes sense. New proposal attached. @Roman: We do have a new README.md file in the main repo to get started. @Julian and @Roman: Feedback well taken

Re: 5 things

Did you see my reply[1] and Roman’s reply[2] to your message? I think it’s great that you are thinking about governance, review process, and a path for people to become members of the project. But before you invent concepts like “core contributor”, are you familiar with the Apache concepts

Re: [jira] [Commented] (QUICKSTEP-38) Enhance python scripts to support Python3

Good point on adding changes to our git workflow. @Zuyu - I see you are on the wiki in edit mode, so will let you make the changes. Thanks in advance! On Wed, Aug 3, 2016 at 1:58 PM, ASF GitHub Bot (JIRA) wrote: > > [ >

[GitHub] incubator-quickstep pull request #78: Processed InitiateRebuild message for ...

GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/78 Processed InitiateRebuild message for the distributed version. You can merge this pull request into a Git repository by running: $ git pull

Re: 5 things

See below, comments on specific points. > On Aug 3, 2016, at 1:35 PM, J Patel wrote: > > All: Would love to hear your thoughts on a release. I'd like to propose mid > to late November, which likely works out best given the semester cadence > (yeah -- I know we are far

[GitHub] incubator-quickstep issue #76: Visualize execution plan DAGs annotated with ...

Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/76 Looks good to me. Thanks for this feature, it should be quite useful! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-quickstep pull request #76: Visualize execution plan DAGs annotate...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #79: Constructed Generators once in the opt...

GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/79 Constructed Generators once in the optimizer. Instead of creating generators each time per query, do so once, and reuse the instances for every query. You can merge this pull request into

Re: 5 things

Dear Julian, Your feedback is very welcome and valuable as usual. Comments inlined below, but overall I thought I was proposing that seems to be in line with the Apache governance model. If there are specific issues, would love if you can point it out in general and I can go work on it. > In