[GitHub] incubator-quickstep pull request #79: Constructed Generators once in the opt...

[zuyu]

Github user zuyu closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/79


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #76: Visualize execution plan DAGs annotated with ...

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/76
  
Thanks Harshad!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #79: Constructed Generators once in the opt...

[zuyu]

GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/79

Constructed Generators once in the optimizer.

Instead of creating generators each time per query, do so once, and reuse 
the instances for every query.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-quickstep refactor-optimizer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 15d2cbd6d7f3814956bf92e264a34d7064d7dfc7
Author: Zuyu Zhang 
Date:   2016-08-04T00:19:07Z

Constructed Generators once in the optimizer.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #76: Visualize execution plan DAGs annotate...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/76


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #76: Visualize execution plan DAGs annotated with ...

[hbdeshmukh]

Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/76
  
Looks good to me. Thanks for this feature, it should be quite useful! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #78: Processed InitiateRebuild message for ...

[zuyu]

GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/78

Processed InitiateRebuild message for the distributed version.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zuyu/incubator-quickstep dist-init-rebuild

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit bd104d5bc1bfb65bdf4aec4a7535c3c64beaa014
Author: Zuyu Zhang 
Date:   2016-08-03T22:28:00Z

Processed InitiateRebuild message for the distributed version.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: 5 things

[J Patel]

Dear Julian,

Your feedback is very welcome and valuable as usual. Comments inlined
below, but overall I thought I was proposing that seems to be in line with
the Apache governance model. If there are specific issues, would love if
you can point it out in general and I can go work on it.

> In general, it is expected that to maintain
> > membership in the Committer group, the developer must be active in the
> > project in the preceding 6-month period.
>
> Procedures to allow committers and PMC members to “go emeritus” do
> exist[1] but in my opinion they are solving a non-problem.
>

Great. Sounds like this part is ok then.


> > PMC members can commit code directly to the main repository, but are
> > generally advised to open a PR and allow another Committer to close the
> PR.
>
> The role of the PMC (actually PPMC while Quickstep is incubating) is
> solely governance. PPMC members should not have more rights than committers
> where it comes to code. We don’t want to create two tiers of committers.
>

Good point -- will remove this distinction.


>
> > A Contributor can become a Committer by getting support from at least two
> > existing Committers. It is expected that a Contributor will have
> > demonstrated proficiency in understanding and working with the core
> engine
> > to become part of the Committer group.
>
> Per Apache rules committers are appointed by achieving consensus
> (typically a vote) in the PMC[2].
>

Got it. I read [2] as being general guidelines but not binding. It is okay
to do this by consensus too over email.


> > The PMC meets at least annually. Meetings are announced at least two
> weeks
> > in advance on the project developer list. Any Committer is welcome to
> > propose agenda items for the meeting. The PMC chair consults the overall
> > PMC to finalize the agenda. The meeting agenda must be finalized two days
> > before the meeting and communicated on the project developer list. Agenda
> > items can include, but is not limited to, voting for changes to the PMC,
> > changes to the Committers group, and changes to the community governance
> > document. Only existing PMC members can vote on motions. For a motion to
> > carry, a majority of the votes that are cast must be in favor of the
> > motion. Ties are broken by the PMC Chair. Proxies are permitted, and must
> > be communicated to the PMC Chair prior to the meeting.
>
> Per Apache, the PMC meets continually… via email. I suppose the PMC could
> have an annual meeting, but business such as appointing members does not
> have to wait for that.
>

Agreed. I worded this carefully to say "at least" ; limit on the
upper-bound. So, I'm not seeing a conflict there.


> Apache has a procedure for appointing members to the PMC[3]. You need to
> follow this.
>

I did get this part wrong. Nice catch! I should really propose simply
following the guidelines there. I was hoping there was some way for the
existing PPMC to agree on a proposed new PPMC member before emailing
bo...@apache.org. So, perhaps what I have could be applied to getting
consensus on a proposal within the Quickstep PPMC and then making a formal
proposal.


> Jignesh, As I said in a previous email, it’s good that you are thinking
> about governance. But we are going to be at odds until you read &
> understand the existing Apache governance. I think you need to take the
> time to do this before proposing alternatives. The Apache governance is
> well established and is proven. And considerable parts of it are mandatory.
>

If the above largely covers it, I'll work on making another round over the
next few days.

Agreed Julian  about your point about me not fully understanding the
governance. It is somewhat complicated, and in some cases information is a
bit scattered. I am still learning about the Apache way, and very much
appreciate your detailed input.

Cheers,
Jignesh

Re: 5 things

[Julian Hyde]

See below, comments on specific points.

> On Aug 3, 2016, at 1:35 PM, J Patel  wrote:
> 
> All: Would love to hear your thoughts on a release. I'd like to propose mid
> to late November, which likely works out best given the semester cadence
> (yeah -- I know we are far skewed in the Committer to that, at least for
> now).

November seems a very long way off. Remember, a release is a good way to 
attract contributors, and does not need to be “perfect” or a big splash in 
terms of marketing.

> In general, it is expected that to maintain
> membership in the Committer group, the developer must be active in the
> project in the preceding 6-month period.

Procedures to allow committers and PMC members to “go emeritus” do exist[1] but 
in my opinion they are solving a non-problem.

> PMC members can commit code directly to the main repository, but are
> generally advised to open a PR and allow another Committer to close the PR.

The role of the PMC (actually PPMC while Quickstep is incubating) is solely 
governance. PPMC members should not have more rights than committers where it 
comes to code. We don’t want to create two tiers of committers.

> A Contributor can become a Committer by getting support from at least two
> existing Committers. It is expected that a Contributor will have
> demonstrated proficiency in understanding and working with the core engine
> to become part of the Committer group.

Per Apache rules committers are appointed by achieving consensus (typically a 
vote) in the PMC[2].


> The PMC meets at least annually. Meetings are announced at least two weeks
> in advance on the project developer list. Any Committer is welcome to
> propose agenda items for the meeting. The PMC chair consults the overall
> PMC to finalize the agenda. The meeting agenda must be finalized two days
> before the meeting and communicated on the project developer list. Agenda
> items can include, but is not limited to, voting for changes to the PMC,
> changes to the Committers group, and changes to the community governance
> document. Only existing PMC members can vote on motions. For a motion to
> carry, a majority of the votes that are cast must be in favor of the
> motion. Ties are broken by the PMC Chair. Proxies are permitted, and must
> be communicated to the PMC Chair prior to the meeting.

Per Apache, the PMC meets continually… via email. I suppose the PMC could have 
an annual meeting, but business such as appointing members does not have to 
wait for that.

Apache has a procedure for appointing members to the PMC[3]. You need to follow 
this.

Jignesh, As I said in a previous email, it’s good that you are thinking about 
governance. But we are going to be at odds until you read & understand the 
existing Apache governance. I think you need to take the time to do this before 
proposing alternatives. The Apache governance is well established and is 
proven. And considerable parts of it are mandatory.

Julian

[1] http://www.apache.org/dev/pmc.html#pmc-removal 


[2] http://www.apache.org/dev/pmc.html#newcommitter 


[3] http://www.apache.org/dev/pmc.html#newpmc 
 

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
@cwelton I've created [the 
guideline](https://cwiki.apache.org/confluence/display/QUICKSTEP/Workflow+For+Contributors)
 as suggested. Cheers!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [jira] [Commented] (QUICKSTEP-38) Enhance python scripts to support Python3

[J Patel]

Good point on adding changes to our git workflow.

@Zuyu - I see you are on the wiki in edit mode, so will let you make the
changes. Thanks in advance!

On Wed, Aug 3, 2016 at 1:58 PM, ASF GitHub Bot (JIRA) 
wrote:

>
> [
> https://issues.apache.org/jira/browse/QUICKSTEP-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406422#comment-15406422
> ]
>
> ASF GitHub Bot commented on QUICKSTEP-38:
> -
>
> Github user cwelton commented on the issue:
>
> https://github.com/apache/incubator-quickstep/pull/75
>
> Thanks for fixing, I suggest adding a contributor's guide with your
> suggested git workflow, to help streamline future
> contributors/contributions.
>
>
> > Enhance python scripts to support Python3
> > -
> >
> > Key: QUICKSTEP-38
> > URL: https://issues.apache.org/jira/browse/QUICKSTEP-38
> > Project: Apache Quickstep
> >  Issue Type: Improvement
> >  Components: Utility
> >Reporter: Caleb Welton
> >Assignee: Caleb Welton
> >Priority: Minor
> >
> > Currently cyclic_dependency.py and validate_cmakelists.py both only
> support python2.  I propose updating them to support both python2 and
> python3.
> > Reason, Python 3 is has reached a level of maturity that it can be
> considered ready for prime time, adding support for Python 3 is a minimal
> cost and increases both future readiness and availability on more systems.
> The change to support both versions of the language is relatively small and
> non-invasive.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>

Re: Podling Report Reminder - August 2016

[J Patel]

Thanks Julian for the reminder! Just added the report for Quickstep.

Cheers,
Jignesh

On Wed, Aug 3, 2016 at 2:57 PM, Julian Hyde  wrote:

> Today is the deadline for the report. If you miss the deadline, this will
> be the second consecutive month that you have failed to report. The IPMC
> and Board do not appreciate multiple missed reports.
>
> Julian
>
>
> > On Jul 27, 2016, at 10:18 AM, Julian Hyde  wrote:
> >
> > Quickstep missed its report last month, so it is very important to file
> this month.
> >
> > Who is going to write the report?
> >
> > Julian
> >
> >
> >> On Jul 27, 2016, at 4:47 AM, johndam...@apache.org wrote:
> >>
> >> Dear podling,
> >>
> >> This email was sent by an automated system on behalf of the Apache
> >> Incubator PMC. It is an initial reminder to give you plenty of time to
> >> prepare your quarterly board report.
> >>
> >> The board meeting is scheduled for Wed, 17 August 2016, 10:30 am PDT.
> >> The report for your podling will form a part of the Incubator PMC
> >> report. The Incubator PMC requires your report to be submitted 2 weeks
> >> before the board meeting, to allow sufficient time for review and
> >> submission (Wed, August 03).
> >>
> >> Please submit your report with sufficient time to allow the Incubator
> >> PMC, and subsequently board members to review and digest. Again, the
> >> very latest you should submit your report is 2 weeks prior to the board
> >> meeting.
> >>
> >> Thanks,
> >>
> >> The Apache Incubator PMC
> >>
> >> Submitting your Report
> >>
> >> --
> >>
> >> Your report should contain the following:
> >>
> >> *   Your project name
> >> *   A brief description of your project, which assumes no knowledge of
> >>   the project or necessarily of its field
> >> *   A list of the three most important issues to address in the move
> >>   towards graduation.
> >> *   Any issues that the Incubator PMC or ASF Board might wish/need to be
> >>   aware of
> >> *   How has the community developed since the last report
> >> *   How has the project developed since the last report.
> >>
> >> This should be appended to the Incubator Wiki page at:
> >>
> >> http://wiki.apache.org/incubator/August2016
> >>
> >> Note: This is manually populated. You may need to wait a little before
> >> this page is created from a template.
> >>
> >> Mentors
> >> ---
> >>
> >> Mentors should review reports for their project(s) and sign them off on
> >> the Incubator wiki page. Signing off reports shows that you are
> >> following the project - projects that are not signed may raise alarms
> >> for the Incubator PMC.
> >>
> >> Incubator PMC
> >
>
>

Re: 5 things

[J Patel]

Thanks Julian! Nope hadn't seen those emails -- I bet its in my (now
deleted) Pivotal mailbox.

@Julian: Nice feedback on using the Apache terms. Makes sense. New proposal
attached.

@Roman: We do have a new README.md file in the main repo to get started.

@Julian and @Roman:  Feedback well taken on the release.

All: Would love to hear your thoughts on a release. I'd like to propose mid
to late November, which likely works out best given the semester cadence
(yeah -- I know we are far skewed in the Committer to that, at least for
now).


QUICKSTEP DEVELOPER COMMUNITY GOVERNANCE


Quickstep is a data platform that is written in C++ and uses advanced C++
techniques including template meta-programming and various abstractions to
balance high-performance with extensibility. Thus, a good grasp over C++
concepts is essential for a Quickstep developer.



Quickstep has a group of *Committers* who are collectively responsible for
the code repository. Committers have write access to the code repository
and must have signed a Contributors License Agreement (CLA). In addition,
there is a set of *Contributors* who contribute individual changes. The
overall stewardship of the project rests with the Project Management
Committee (*PMC*), which is a subset of the Committers. A member of the PMC
is selected as the *PMC Chair*.


Contributors and Committers must submit pull requests (PR) for proposed
code changes. Only Committers can close PRs. But, a committer can not close
their own PR, which must be examined and closed by another Committer.
Anyone can open a PR and once a PR has been accepted that developer becomes
part of the Contributors group. In general, it is expected that to maintain
membership in the Committer group, the developer must be active in the
project in the preceding 6-month period.


PMC members can commit code directly to the main repository, but are
generally advised to open a PR and allow another Committer to close the PR.


A Contributor can become a Committer by getting support from at least two
existing Committers. It is expected that a Contributor will have
demonstrated proficiency in understanding and working with the core engine
to become part of the Committer group.


The PMC meets at least annually. Meetings are announced at least two weeks
in advance on the project developer list. Any Committer is welcome to
propose agenda items for the meeting. The PMC chair consults the overall
PMC to finalize the agenda. The meeting agenda must be finalized two days
before the meeting and communicated on the project developer list. Agenda
items can include, but is not limited to, voting for changes to the PMC,
changes to the Committers group, and changes to the community governance
document. Only existing PMC members can vote on motions. For a motion to
carry, a majority of the votes that are cast must be in favor of the
motion. Ties are broken by the PMC Chair. Proxies are permitted, and must
be communicated to the PMC Chair prior to the meeting.


*Core Contributors, also the PMC (as of August 5, 2016):*
Harshad Deshmukh
Rogers Jeffrey Leo John
Hakan Memisoglu
Jignesh M. Patel (PMC Chair)
Navneet Potti
Saket Saurabh
Marc Spehlmann
Zuyu Zhang

Jianqiao Zhu

*Core Collaborators (as of August 5, 2016):*
Shoban Chandrabose
Craig Chasseur
Shixuan Fan
Julian Hyde
Yinan Li
Rathijit Sen
Roman Shaposhnik
Adalbert Gerald Soosai Raj
Siddharth Suresh
Caleb Welton

> Qiang Zeng

[GitHub] incubator-quickstep pull request #77: Added TMB Client Id in QueryHandle.

[zuyu]

GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/77

Added TMB Client Id in QueryHandle.

W/ the concurrent query support, `QueryHandle` needs to capture the TMB 
client id of the `CLI` which submits the query, so `Foreman` could later reply 
the query result to the right `CLI`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-quickstep refactor-q-handle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #77


commit f26541c602c613982e76323e5b538c0608d7a84b
Author: Zuyu Zhang 
Date:   2016-08-03T19:19:48Z

Added TMB Client Id in QueryHandle.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: 5 things

[Julian Hyde]

Did you see my reply[1] and Roman’s reply[2] to your message?

I think it’s great that you are thinking about governance, review process, and 
a path for people to become members of the project. But before you invent 
concepts like “core contributor”, are you familiar with the Apache concepts 
such as “committer”?[3]

Since Quickstep is in incubation, your goal must be to understand the Apache 
Way and craft the project’s governance model within that.

Julian

[1] 
http://mail-archives.apache.org/mod_mbox/incubator-quickstep-dev/201607.mbox/%3C0B87BE6C-93F4-4959-BD9A-D9E89E0A3835%40apache.org%3E
 

 

[2] 
http://mail-archives.apache.org/mod_mbox/incubator-quickstep-dev/201607.mbox/%3CCA%2BULb%2BtWAA_c4e-YYAitXfDMAz60Y_XVZMSN4QUPvOgNE7dojA%40mail.gmail.com%3E
 


[3] http://www.apache.org/foundation/how-it-works.html#roles 



> On Aug 3, 2016, at 11:59 AM, J Patel  wrote:
> 
> Hello everyone,
> 
> Since no objections have been raised to the developer community governance
> as outlined below, I'd like to move forward with adopting the version
> below.  *Does anyone know if we need to vote for it? *
> 
> Note: I made a few changes from the previous draft. The key ones are:
> 
> #1: Adding Caleb Welton to the general contributors' list.  (Thanks Caleb
> for your contribution, which has now been merged to the master!).
> 
> #2: Sorted both lists by the last name.
> 
> I'd love to put it on our web page before the end of the week.
> 
> Thanks!
> 
> Cheers,
> Jignesh
> 
> QUICKSTEP DEVELOPER COMMUNITY GOVERNANCE
> 
> Quickstep is a data platform that is written in C++ and uses advanced C++
> techniques including template meta-programming and various abstractions to
> balance high-performance with extensibility. Thus, a good grasp over C++
> concepts is essential for a Quickstep developer.
> 
> 
> 
> Quickstep has a set of *core contributors* who are collectively the
> stewards of the project. In addition, there is a set of *general
> contributors* who contribute individual changes. The initial list of core
> and general contributors is listed below.
> 
> 
> 
> Core contributors can close pull requests, except pull requests that they
> have created (which must be examined and closed by another core
> contributor). Anyone can open a pull request and once a pull request has
> been accepted that committer becomes part of the general contributors
> group.
> 
> 
> 
> A general contributor can become a core contributor by getting support from
> at least two core contributors. It is expected that a general contributor
> will have demonstrated proficiency in understanding and working with the
> core engine to become part of the core contributors group.
> 
> 
> 
> To maintain membership in the core contributors group, the contributor must
> be active in the project in the preceding 6-month period. Membership of the
> core contributors is examined and determined bi-annually by the Apache
> Quickstep PPMC.
> 
> 
> 
> *Core Contributors (as of August 5, 2016:*
> Harshad Deshmukh
> Rogers Jeffrey Leo John
> Hakan Memisoglu
> Jignesh M. Patel
> Navneet Potti
> Saket Saurabh
> Marc Spehlmann
> Zuyu Zhang
> 
> Jianqiao Zhu
> 
> *Core Collaborators (as of August 5, 2016):*
> Shoban Chandrabose
> Craig Chasseur
> Julian Hyde
> Yinan Li
> Rathijit Sen
> Roman Shaposhnik
> Adalbert Gerald Soosai Raj
> Siddharth Suresh
> Caleb Welton
> 
>> Qiang Zeng

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Yes, we should add a workflow for contributors as well. Stay tuned!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

[cwelton]

Github user cwelton commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Ah, sorry, just thought you wanted the extraneous merge commit squashed.  
I've reordered the commits in my branch.  For some reason the hashjoin commit 
is still showing up in this PR, not sure why.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

[cwelton]

Github user cwelton commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Thanks for fixing, I suggest adding a contributor's guide with your 
suggested git workflow, to help streamline future contributors/contributions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #74: Removed the redundant query id in the ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
@cwelton No worry for this PR. I've addressed the issues in the `master` 
branch. Thanks again for submitting a PR.

Next time if we run `git fetch origin/master` and then `git rebase -i 
origin/master`, I think we are good to go.

Cheers!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
@pateljm We need to reverse this merge, due to an incorrect rebase.

@cwelton We expect a different rebase result where this PR only contains a 
single commit ahead of the `origin/master`, instead of having another unrelated 
commit from a merged PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

[pateljm]

Github user pateljm commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Thanks @cwelton! Merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

[cwelton]

Github user cwelton commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Rebase complete


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #76: Visualize execution plan DAGs annotate...

[hbdeshmukh]

Github user hbdeshmukh commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/76#discussion_r73384912
  
--- Diff: query_execution/QueryExecutionTypedefs.hpp ---
@@ -98,6 +98,12 @@ enum QueryExecutionMessageType : message_type_id {
 #endif
 };
 
+// WorkOrder profiling data structures.
+// A tuple of 
+typedef std::tuple 
WorkOrderTimeEntry;
+
+typedef std::unordered_map 
WorkOrderTimeRecorder;
--- End diff --

Can you briefly describe the key and value in this map, as a comment above 
this line? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #74: Removed the redundant query id in the optimiz...

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/74
  
This change looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #73: Move hash join's probe and build node decisio...

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/73
  
@jianqiao Per workflow, please delete the branch after merged. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #74: Removed the redundant query id in the optimiz...

[pateljm]

Github user pateljm commented on the issue:

https://github.com/apache/incubator-quickstep/pull/74
  
@jianqiao @hbdeshmukh Did any of you want the query_id for use in the 
future? 

@zuyu: Can you expand on the reason to drop the query_id further? 

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

[pateljm]

Github user pateljm commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
This looks good Caleb (@cwelton)! Can you rebase so that I can merge this 
commit? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/73


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/73#discussion_r73290304
  
--- Diff: query_optimizer/rules/BottomUpRule.hpp ---
@@ -80,6 +81,14 @@ class BottomUpRule : public Rule {
*/
   virtual TreeNodePtr applyToNode(const TreeNodePtr ) = 0;
 
+  /**
+   * @brief Initialization code to be used for each node.
--- End diff --

The initialization is only applied with the tree's root node but not "each 
node".
Other places look good. I'll do this minor revision and then merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---