[GitHub] incubator-quickstep issue #234: Add protobuf support for UNION ALL operator.

Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/234 LTM if comments are addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-quickstep pull request #234: Add protobuf support for UNION ALL op...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/234#discussion_r112333485 --- Diff: relational_operators/UnionAllOperator.hpp --- @@ -149,6 +151,11 @@ class UnionAllOperator : public RelationalOperator {

[GitHub] incubator-quickstep pull request #234: Add protobuf support for UNION ALL op...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/234#discussion_r11271 --- Diff: relational_operators/UnionAllOperator.cpp --- @@ -128,14 +128,56 @@ bool UnionAllOperator::getAllWorkOrders( } bool

[GitHub] incubator-quickstep pull request #234: Add protobuf support for UNION ALL op...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/234#discussion_r112333067 --- Diff: relational_operators/UnionAllOperator.cpp --- @@ -128,14 +128,56 @@ bool UnionAllOperator::getAllWorkOrders( } bool

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112325082 --- Diff: cli/LineReaderBuffered.hpp --- @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112324538 --- Diff: cli/LineReaderBuffered.hpp --- @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112324457 --- Diff: cli/LineReaderBuffered.cpp --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112323095 --- Diff: cli/LineReaderBuffered.cpp --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112322839 --- Diff: cli/IOInterface.hpp --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] incubator-quickstep pull request #235: API to get total pending work orders ...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #233: QUICKSTEP-88 Topological sort functio...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep issue #233: QUICKSTEP-88 Topological sort functionality ...

Github user hakanmemisoglu commented on the issue: https://github.com/apache/incubator-quickstep/pull/233 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-quickstep pull request #233: QUICKSTEP-88 Topological sort functio...

Github user hakanmemisoglu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/233#discussion_r112284625 --- Diff: utility/tests/DAG_unittest.cpp --- @@ -490,6 +490,88 @@ TEST(DAGTest, LinkMetadataBoolTest) {

[GitHub] incubator-quickstep pull request #235: API to get total pending work orders ...

GitHub user hbdeshmukh opened a pull request: https://github.com/apache/incubator-quickstep/pull/235 API to get total pending work orders for an operator The total count includes normal and rebuild work orders. You can merge this pull request into a Git repository by running:

[GitHub] incubator-quickstep pull request #233: QUICKSTEP-88 Topological sort functio...

Github user hakanmemisoglu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/233#discussion_r112069450 --- Diff: utility/tests/DAG_unittest.cpp --- @@ -490,6 +490,51 @@ TEST(DAGTest, LinkMetadataBoolTest) {

[GitHub] incubator-quickstep pull request #233: QUICKSTEP-88 Topological sort functio...

Github user hakanmemisoglu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/233#discussion_r112067899 --- Diff: utility/DAG.hpp --- @@ -489,6 +495,40 @@ bool DAG::hasCycleHelper(const typename DAG:

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112250274 --- Diff: cli/LineReaderBuffered.cpp --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112250845 --- Diff: cli/LineReaderBuffered.hpp --- @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249998 --- Diff: cli/IOInterface.hpp --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112250621 --- Diff: cli/LineReaderBuffered.hpp --- @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249915 --- Diff: cli/IOInterface.hpp --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249411 --- Diff: cli/IOInterface.hpp --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249378 --- Diff: cli/IOInterface.hpp --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249266 --- Diff: cli/IOInterface.hpp --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/232#discussion_r112248871 --- Diff: cli/Flags.cpp --- @@ -87,4 +87,15 @@ DEFINE_bool(preload_buffer_pool, false, "accepting queries (should also set

[GitHub] incubator-quickstep issue #233: QUICKSTEP-88 Topological sort functionality ...

Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/233 Hi @hakanmemisoglu Can you please review this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If