[racket-dev] Can a TR wizard check my extflonum changes? [was [plt] Push #28592: master branch updated]
On 04/22/2014 10:48 AM, ntoro...@racket-lang.org wrote: ntoronto has updated `master' from 67805b9f04 to 14bbd662e9. http://git.racket-lang.org/plt/67805b9f04..14bbd662e9 ~~ 85deab7 Neil Toronto neil.toro...@gmail.com 2014-04-22 10:45 : | Added ExtFlonum (and subtypes) and ExtFlVector to the base type environment The changes mostly mimic the types and test cases for flonums and flvectors, but with adjustments to leave extflonums out of the numeric tower. Everything passes and extflonum expressions seem to type correctly, but I can't be sure I didn't miss anything. Can a more TR-internals-savvy person give the changes a quick once-over? Neil ⊥ _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] Can a TR wizard check my extflonum changes? [was [plt] Push #28592: master branch updated]
On Tue, Apr 22, 2014 at 1:06 PM, Neil Toronto neil.toro...@gmail.com wrote: The changes mostly mimic the types and test cases for flonums and flvectors, but with adjustments to leave extflonums out of the numeric tower. Everything passes and extflonum expressions seem to type correctly, but I can't be sure I didn't miss anything. Can a more TR-internals-savvy person give the changes a quick once-over? I'll have a look at this. In general we (the TR developers) prefer to review significant changes to TR beforehand, via GitHub pull requests. So that would be a good thing to do in the future. Sam _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] Can a TR wizard check my extflonum changes? [was [plt] Push #28592: master branch updated]
On 04/22/2014 11:50 AM, Sam Tobin-Hochstadt wrote: On Tue, Apr 22, 2014 at 1:06 PM, Neil Toronto neil.toro...@gmail.com wrote: The changes mostly mimic the types and test cases for flonums and flvectors, but with adjustments to leave extflonums out of the numeric tower. Everything passes and extflonum expressions seem to type correctly, but I can't be sure I didn't miss anything. Can a more TR-internals-savvy person give the changes a quick once-over? I'll have a look at this. In general we (the TR developers) prefer to review significant changes to TR beforehand, via GitHub pull requests. So that would be a good thing to do in the future. Noted, and I apologize for stepping out of bounds. Thanks for looking over it anyway. Neil ⊥ _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] Can a TR wizard check my extflonum changes? [was [plt] Push #28592: master branch updated]
On Tue, Apr 22, 2014 at 1:52 PM, Neil Toronto neil.toro...@gmail.com wrote: On 04/22/2014 11:50 AM, Sam Tobin-Hochstadt wrote: On Tue, Apr 22, 2014 at 1:06 PM, Neil Toronto neil.toro...@gmail.com wrote: The changes mostly mimic the types and test cases for flonums and flvectors, but with adjustments to leave extflonums out of the numeric tower. Everything passes and extflonum expressions seem to type correctly, but I can't be sure I didn't miss anything. Can a more TR-internals-savvy person give the changes a quick once-over? I'll have a look at this. In general we (the TR developers) prefer to review significant changes to TR beforehand, via GitHub pull requests. So that would be a good thing to do in the future. Noted, and I apologize for stepping out of bounds. Thanks for looking over it anyway. No apology is needed -- you just wrote a bunch of code for TR! I'm very pleased. Sam _ Racket Developers list: http://lists.racket-lang.org/dev
