Re: [racket-dev] What command should DrDr run by default?
Yesterday, Robby Findler wrote: > Raco test runs the file if there is not test sub module. Fwiw. That's what I thought first, with "run" being the same as what racket does. But it doesn't: it just runs the toplevel module as usual when the file is required (and does so unconditionally, of course), and then runs a `test' submodule if there is one. In the files in question, the tests are running in the `main' module, and raco test was therefore not running them. This seems like a fine behavior for raco test, but for drdr, it *should* run a `main' module if there is one, and if there is no `test' module. This avoids the need to abuse a `test' submodule as some semi-drdr-flag-thing, since files in some "tests" path shouldn't be required to have a `test' submodule. -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] What command should DrDr run by default?
The change I made was the minimum delta to make the tests run in DrDr, since the files already had a `main` submodule which ran the actual tests. Sam On Sun, Jul 7, 2013 at 4:42 AM, Robby Findler wrote: > Raco test runs the file if there is not test sub module. Fwiw. > > > On Saturday, July 6, 2013, Eli Barzilay wrote: >> >> It doesn't make much sense to use a test submodule in files that are >> intended to be (only) tests. >> >> >> Earlier today, Robby Findler wrote: >> > That's the plan. Thanks for fixing them. >> > >> > Robby >> > >> > >> > On Sat, Jul 6, 2013 at 8:47 AM, Sam Tobin-Hochstadt >> > wrote: >> > >> > I recently discovered that DrDr runs `raco test` by default on >> > files, >> > and has since February. However, the DrDr documentation says that it >> > runs `racket -t`. I discovered this because the change caused many >> > of >> > the `net` tests to no longer actually run; see >> > >> > >> > http://drdr.racket-lang.org/27042/pkgs/racket-pkgs/racket-test/tests/ >> > net/url.rkt >> > >> > which appears to be successful, even though running `racket` on that >> > file would have shown the error that I fixed in >> > https://github.com/plt/racket/commit/a4e529a816 . These tests are a >> > particularly bad case because they run all their tests in the `main` >> > submodule, and thus are *not* executed by `raco test`. If the plan >> > is >> > for everything to run with `raco test`, I'll fix these tests. But >> > what is the plan? >> >> -- >> ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: >> http://barzilay.org/ Maze is Life! _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] What command should DrDr run by default?
Raco test runs the file if there is not test sub module. Fwiw. On Saturday, July 6, 2013, Eli Barzilay wrote: > It doesn't make much sense to use a test submodule in files that are > intended to be (only) tests. > > > Earlier today, Robby Findler wrote: > > That's the plan. Thanks for fixing them. > > > > Robby > > > > > > On Sat, Jul 6, 2013 at 8:47 AM, Sam Tobin-Hochstadt > > > > wrote: > > > > I recently discovered that DrDr runs `raco test` by default on files, > > and has since February. However, the DrDr documentation says that it > > runs `racket -t`. I discovered this because the change caused many > of > > the `net` tests to no longer actually run; see > > > > > http://drdr.racket-lang.org/27042/pkgs/racket-pkgs/racket-test/tests/ > > net/url.rkt > > > > which appears to be successful, even though running `racket` on that > > file would have shown the error that I fixed in > > https://github.com/plt/racket/commit/a4e529a816 . These tests are a > > particularly bad case because they run all their tests in the `main` > > submodule, and thus are *not* executed by `raco test`. If the plan is > > for everything to run with `raco test`, I'll fix these tests. But > > what is the plan? > > -- > ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: > http://barzilay.org/ Maze is Life! > _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] What command should DrDr run by default?
It doesn't make much sense to use a test submodule in files that are intended to be (only) tests. Earlier today, Robby Findler wrote: > That's the plan. Thanks for fixing them. > > Robby > > > On Sat, Jul 6, 2013 at 8:47 AM, Sam Tobin-Hochstadt wrote: > > I recently discovered that DrDr runs `raco test` by default on files, > and has since February. However, the DrDr documentation says that it > runs `racket -t`. I discovered this because the change caused many of > the `net` tests to no longer actually run; see > > http://drdr.racket-lang.org/27042/pkgs/racket-pkgs/racket-test/tests/ > net/url.rkt > > which appears to be successful, even though running `racket` on that > file would have shown the error that I fixed in > https://github.com/plt/racket/commit/a4e529a816 . These tests are a > particularly bad case because they run all their tests in the `main` > submodule, and thus are *not* executed by `raco test`. If the plan is > for everything to run with `raco test`, I'll fix these tests. But > what is the plan? -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] What command should DrDr run by default?
Thanks for taking care of this. I'll push it out to the live DrDr site shortly. On Sat, Jul 6, 2013 at 8:31 AM, Sam Tobin-Hochstadt wrote: > These are now both done. Jay, if there's some bit of documentation I > missed, please let me know. > > Sam > > On Sat, Jul 6, 2013 at 10:03 AM, Robby Findler > wrote: >> I would say that if you know where to change, please go ahead. >> >> Robby >> >> >> On Sat, Jul 6, 2013 at 8:56 AM, Sam Tobin-Hochstadt >> wrote: >>> >>> Should I change the docs as well? Or do you want to do that, Jay? >>> >>> On Sat, Jul 6, 2013 at 9:53 AM, Robby Findler >>> wrote: >>> > That's the plan. Thanks for fixing them. >>> > >>> > Robby >>> > >>> > >>> > On Sat, Jul 6, 2013 at 8:47 AM, Sam Tobin-Hochstadt >>> > wrote: >>> >> >>> >> I recently discovered that DrDr runs `raco test` by default on files, >>> >> and has since February. However, the DrDr documentation says that it >>> >> runs `racket -t`. I discovered this because the change caused many of >>> >> the `net` tests to no longer actually run; see >>> >> >>> >> >>> >> >>> >> http://drdr.racket-lang.org/27042/pkgs/racket-pkgs/racket-test/tests/net/url.rkt >>> >> >>> >> which appears to be successful, even though running `racket` on that >>> >> file would have shown the error that I fixed in >>> >> https://github.com/plt/racket/commit/a4e529a816 . These tests are a >>> >> particularly bad case because they run all their tests in the `main` >>> >> submodule, and thus are *not* executed by `raco test`. If the plan is >>> >> for everything to run with `raco test`, I'll fix these tests. But >>> >> what is the plan? >>> >> >>> >> Sam >>> >> _ >>> >> Racket Developers list: >>> >> http://lists.racket-lang.org/dev >>> > >>> > >> >> -- Jay McCarthy Assistant Professor / Brigham Young University http://faculty.cs.byu.edu/~jay "The glory of God is Intelligence" - D&C 93 _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] What command should DrDr run by default?
These are now both done. Jay, if there's some bit of documentation I missed, please let me know. Sam On Sat, Jul 6, 2013 at 10:03 AM, Robby Findler wrote: > I would say that if you know where to change, please go ahead. > > Robby > > > On Sat, Jul 6, 2013 at 8:56 AM, Sam Tobin-Hochstadt > wrote: >> >> Should I change the docs as well? Or do you want to do that, Jay? >> >> On Sat, Jul 6, 2013 at 9:53 AM, Robby Findler >> wrote: >> > That's the plan. Thanks for fixing them. >> > >> > Robby >> > >> > >> > On Sat, Jul 6, 2013 at 8:47 AM, Sam Tobin-Hochstadt >> > wrote: >> >> >> >> I recently discovered that DrDr runs `raco test` by default on files, >> >> and has since February. However, the DrDr documentation says that it >> >> runs `racket -t`. I discovered this because the change caused many of >> >> the `net` tests to no longer actually run; see >> >> >> >> >> >> >> >> http://drdr.racket-lang.org/27042/pkgs/racket-pkgs/racket-test/tests/net/url.rkt >> >> >> >> which appears to be successful, even though running `racket` on that >> >> file would have shown the error that I fixed in >> >> https://github.com/plt/racket/commit/a4e529a816 . These tests are a >> >> particularly bad case because they run all their tests in the `main` >> >> submodule, and thus are *not* executed by `raco test`. If the plan is >> >> for everything to run with `raco test`, I'll fix these tests. But >> >> what is the plan? >> >> >> >> Sam >> >> _ >> >> Racket Developers list: >> >> http://lists.racket-lang.org/dev >> > >> > > > _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] What command should DrDr run by default?
I would say that if you know where to change, please go ahead. Robby On Sat, Jul 6, 2013 at 8:56 AM, Sam Tobin-Hochstadt wrote: > Should I change the docs as well? Or do you want to do that, Jay? > > On Sat, Jul 6, 2013 at 9:53 AM, Robby Findler > wrote: > > That's the plan. Thanks for fixing them. > > > > Robby > > > > > > On Sat, Jul 6, 2013 at 8:47 AM, Sam Tobin-Hochstadt > > wrote: > >> > >> I recently discovered that DrDr runs `raco test` by default on files, > >> and has since February. However, the DrDr documentation says that it > >> runs `racket -t`. I discovered this because the change caused many of > >> the `net` tests to no longer actually run; see > >> > >> > >> > http://drdr.racket-lang.org/27042/pkgs/racket-pkgs/racket-test/tests/net/url.rkt > >> > >> which appears to be successful, even though running `racket` on that > >> file would have shown the error that I fixed in > >> https://github.com/plt/racket/commit/a4e529a816 . These tests are a > >> particularly bad case because they run all their tests in the `main` > >> submodule, and thus are *not* executed by `raco test`. If the plan is > >> for everything to run with `raco test`, I'll fix these tests. But > >> what is the plan? > >> > >> Sam > >> _ > >> Racket Developers list: > >> http://lists.racket-lang.org/dev > > > > > _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] What command should DrDr run by default?
Should I change the docs as well? Or do you want to do that, Jay? On Sat, Jul 6, 2013 at 9:53 AM, Robby Findler wrote: > That's the plan. Thanks for fixing them. > > Robby > > > On Sat, Jul 6, 2013 at 8:47 AM, Sam Tobin-Hochstadt > wrote: >> >> I recently discovered that DrDr runs `raco test` by default on files, >> and has since February. However, the DrDr documentation says that it >> runs `racket -t`. I discovered this because the change caused many of >> the `net` tests to no longer actually run; see >> >> >> http://drdr.racket-lang.org/27042/pkgs/racket-pkgs/racket-test/tests/net/url.rkt >> >> which appears to be successful, even though running `racket` on that >> file would have shown the error that I fixed in >> https://github.com/plt/racket/commit/a4e529a816 . These tests are a >> particularly bad case because they run all their tests in the `main` >> submodule, and thus are *not* executed by `raco test`. If the plan is >> for everything to run with `raco test`, I'll fix these tests. But >> what is the plan? >> >> Sam >> _ >> Racket Developers list: >> http://lists.racket-lang.org/dev > > _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] What command should DrDr run by default?
That's the plan. Thanks for fixing them. Robby On Sat, Jul 6, 2013 at 8:47 AM, Sam Tobin-Hochstadt wrote: > I recently discovered that DrDr runs `raco test` by default on files, > and has since February. However, the DrDr documentation says that it > runs `racket -t`. I discovered this because the change caused many of > the `net` tests to no longer actually run; see > > > http://drdr.racket-lang.org/27042/pkgs/racket-pkgs/racket-test/tests/net/url.rkt > > which appears to be successful, even though running `racket` on that > file would have shown the error that I fixed in > https://github.com/plt/racket/commit/a4e529a816 . These tests are a > particularly bad case because they run all their tests in the `main` > submodule, and thus are *not* executed by `raco test`. If the plan is > for everything to run with `raco test`, I'll fix these tests. But > what is the plan? > > Sam > _ > Racket Developers list: > http://lists.racket-lang.org/dev > _ Racket Developers list: http://lists.racket-lang.org/dev
[racket-dev] What command should DrDr run by default?
I recently discovered that DrDr runs `raco test` by default on files, and has since February. However, the DrDr documentation says that it runs `racket -t`. I discovered this because the change caused many of the `net` tests to no longer actually run; see http://drdr.racket-lang.org/27042/pkgs/racket-pkgs/racket-test/tests/net/url.rkt which appears to be successful, even though running `racket` on that file would have shown the error that I fixed in https://github.com/plt/racket/commit/a4e529a816 . These tests are a particularly bad case because they run all their tests in the `main` submodule, and thus are *not* executed by `raco test`. If the plan is for everything to run with `raco test`, I'll fix these tests. But what is the plan? Sam _ Racket Developers list: http://lists.racket-lang.org/dev
