Re: Review Request 61025: Good coding practice in Ranger recommended by static code analysis

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61025/#review183423 --- Ship it! Ship It! - Velmurugan Periasamy On July 21, 2017,

Re: Review Request 61779: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

2017-08-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61779/#review183447 --- Ship it! Ship It! - Mehul Parikh On Aug. 21, 2017, 10 a.m.,

[jira] [Commented] (RANGER-1676) Policy Details popup from Access audit page not displaying details of masking policy

2017-08-21 Thread Nitin Galave (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136283#comment-16136283 ] Nitin Galave commented on RANGER-1676: -- Committed to [master |

[jira] [Updated] (RANGER-1717) User with "KEYADMIN" role is not able to see "Audit => Admin" logs.

2017-08-21 Thread bhavik patel (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bhavik patel updated RANGER-1717: - Attachment: RANGER-1717-master-01.patch > User with "KEYADMIN" role is not able to see "Audit =>

Re: Review Request 61782: Similar to RANGER-1541, the assignment logic is inconsistent for the value of the RANGER_ADMIN_HOME variable in changeusernameutil.py and changepasswordutil.py. It will cause

2017-08-21 Thread Qiang Zhang
> On 八月 22, 2017, 1:31 a.m., Velmurugan Periasamy wrote: > > security-admin/scripts/changepasswordutil.py > > Line 34 (original), 34 (patched) > > > > > > Can you please confirm this is tested on both linux and

[jira] [Created] (RANGER-1745) From the performance and code logic analysis, we should optimize the flush function of HDFSAuditDestination class.

2017-08-21 Thread Qiang Zhang (JIRA)
Qiang Zhang created RANGER-1745: --- Summary: From the performance and code logic analysis, we should optimize the flush function of HDFSAuditDestination class. Key: RANGER-1745 URL:

[jira] [Updated] (RANGER-1717) User with "KEYADMIN" role is not able to see "Audit => Admin" logs.

2017-08-21 Thread bhavik patel (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bhavik patel updated RANGER-1717: - Attachment: (was: RANGER-1717-master-01.patch) > User with "KEYADMIN" role is not able to

Re: Review Request 61782: Similar to RANGER-1541, the assignment logic is inconsistent for the value of the RANGER_ADMIN_HOME variable in changeusernameutil.py and changepasswordutil.py. It will cause

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61782/#review183422 --- security-admin/scripts/changepasswordutil.py Line 34 (original),

[jira] [Updated] (RANGER-1745) From the performance and code logic analysis, we should optimize the flush function of HDFSAuditDestination class.

2017-08-21 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1745: Attachment: 0001-RANGER-1745-From-the-performance-and-code-logic-anal.patch > From the performance

Re: Review Request 61776: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61776/#review183444 --- Ship it! Ship It! - Mehul Parikh On Aug. 21, 2017, 8:53

Re: Review Request 61421: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61421/#review183443 --- Ship it! Ship It! - Mehul Parikh On Aug. 21, 2017, 8:50

Re: Review Request 61778: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61778/#review183425 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 21, 2017,

Re: Review Request 61421: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61421/#review183424 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 21, 2017,

Review Request 61809: From the performance and code logic analysis, we should optimize the flush function of HDFSAuditDestination class.

2017-08-21 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61809/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O

Re: Review Request 61779: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

2017-08-21 Thread Nitin Galave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61779/ --- (Updated Aug. 21, 2017, 10 a.m.) Review request for ranger, Gautam Borad,

Re: Review Request 61778: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

2017-08-21 Thread Nitin Galave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61778/ --- (Updated Aug. 21, 2017, 10 a.m.) Review request for ranger, Gautam Borad,

[jira] [Updated] (RANGER-1676) Policy Details popup from Access audit page not displaying details of masking policy

2017-08-21 Thread Nitin Galave (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitin Galave updated RANGER-1676: - Fix Version/s: 0.7.2 1.0.0 > Policy Details popup from Access audit page not

Re: Review Request 61421: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-21 Thread Nitin Galave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61421/ --- (Updated Aug. 21, 2017, 8:50 a.m.) Review request for ranger, Gautam Borad,

Review Request 61778: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

2017-08-21 Thread Nitin Galave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61778/ --- Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and

Review Request 61783: created unit test for RANGER-1631

2017-08-21 Thread Endre Zoltan Kovacs via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61783/ --- Review request for ranger. Repository: ranger Description --- added

Review Request 61776: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-21 Thread Nitin Galave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61776/ --- Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and

Review Request 61779: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

2017-08-21 Thread Nitin Galave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61779/ --- Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and

Re: Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is not able to see "Audit => Admin" logs

2017-08-21 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61591/ --- (Updated Aug. 22, 2017, 5:35 a.m.) Review request for ranger, Ankita Sinha,

[jira] [Updated] (RANGER-1717) User with "KEYADMIN" role is not able to see "Audit => Admin" logs.

2017-08-21 Thread bhavik patel (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bhavik patel updated RANGER-1717: - Attachment: RANGER-1717-master-01.patch > User with "KEYADMIN" role is not able to see "Audit =>

Review Request 61782: Similar to RANGER-1541, the assignment logic is inconsistent for the value of the RANGER_ADMIN_HOME variable in changeusernameutil.py and changepasswordutil.py. It will cause a s

2017-08-21 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61782/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O

Re: Review Request 61519: RANGER-1728 - Upgrade PMD plugin and fix related issues

2017-08-21 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61519/#review183338 --- .git/rebase-apply/patch:81: trailing whitespace.

[jira] [Updated] (RANGER-1744) Similar to RANGER-1541, the assignment logic is inconsistent for the value of the RANGER_ADMIN_HOME variable in changeusernameutil.py and changepasswordutil.py. It will

2017-08-21 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1744: Attachment: 0001-RANGER-1744-Similar-to-RANGER-1541-the-assignment-lo.patch > Similar to

Re: Review Request 61771: Comment lines have not been filtered out when the populate_global_dict function parsed install.properties in security-admin/scripts/restrict_permissions.py. Like RANGER-1284,

2017-08-21 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61771/#review183341 --- Ship it! Ship It! - Qiang Zhang On 八月 20, 2017, 1:53 p.m.,

Re: Review Request 61769: The initd ran repeatedly when ranger-usersync-services.sh was running

2017-08-21 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61769/#review183340 --- Ship it! Ship It! - Qiang Zhang On 八月 20, 2017, 9:13 a.m.,

Re: Review Request 61770: Like setup.sh, the set_globals.sh should check whether the user group exists before created user group in security admin.

2017-08-21 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61770/#review183342 --- Ship it! Ship It! - Qiang Zhang On 八月 20, 2017, 1:31 p.m.,

[jira] [Created] (RANGER-1744) Similar to RANGER-1541, the assignment logic is inconsistent for the value of the RANGER_ADMIN_HOME variable in changeusernameutil.py and changepasswordutil.py. It will

2017-08-21 Thread Qiang Zhang (JIRA)
Qiang Zhang created RANGER-1744: --- Summary: Similar to RANGER-1541, the assignment logic is inconsistent for the value of the RANGER_ADMIN_HOME variable in changeusernameutil.py and changepasswordutil.py. It will cause a serious failure.

Re: Review Request 61768: There is a exception when the ranger_credential_helper.py was executed.

2017-08-21 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61768/#review183339 --- Ship it! Ship It! - Qiang Zhang On 八月 19, 2017, 3:26 p.m.,