Re: Review Request 58697: RANGER-1542:Exceptions occured when I test connection during create a new service for atlas-plugin

2017-04-27 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58697/ --- (Updated 四月 28, 2017, 1:21 a.m.) Review request for ranger, Don Bosco Durai, Co

Re: Review Request 58745: RANGER-1544: Misaligned input boxes and cleanup on Reports Search

2017-04-27 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58745/#review173268 --- Ship it! Ship It! - Gautam Borad On April 27, 2017, 9:25 p.m

[jira] [Commented] (RANGER-1544) Misaligned input boxes and cleanup on Reports Search

2017-04-27 Thread Anna Shaverdian (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987731#comment-15987731 ] Anna Shaverdian commented on RANGER-1544: - [~gautamborad] thanks, and sorry about

Re: Review Request 58745: RANGER-1544: Misaligned input boxes and cleanup on Reports Search

2017-04-27 Thread Anna Shaverdian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58745/ --- (Updated April 27, 2017, 9:25 p.m.) Review request for ranger. Summary (updat

[jira] [Updated] (RANGER-1471) Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Gautam Borad (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautam Borad updated RANGER-1471: - Fix Version/s: (was: master) 1.0.0 > Remember filters on all tabs of Range

Re: Review Request 58154: Policy engine updates to support tag-based masking policies

2017-04-27 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58154/ --- (Updated April 27, 2017, 8:40 p.m.) Review request for ranger and Madhan Neethi

[jira] [Commented] (RANGER-1499) Upgrade Tomcat version

2017-04-27 Thread Gautam Borad (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987531#comment-15987531 ] Gautam Borad commented on RANGER-1499: -- Committed to master: 45f30336fd885a7bda5bb37

[jira] [Commented] (RANGER-1546) Code Improvement To Follow Best Practices

2017-04-27 Thread Gautam Borad (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987528#comment-15987528 ] Gautam Borad commented on RANGER-1546: -- Committed to master : f1117f5fe6cd2749b91398

[jira] [Updated] (RANGER-1546) Code Improvement To Follow Best Practices

2017-04-27 Thread Gautam Borad (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautam Borad updated RANGER-1546: - Fix Version/s: 1.0.0 > Code Improvement To Follow Best Practices > --

[jira] [Commented] (RANGER-1522) Update consolidated db schema script for SQLServer DB flavor to reduce execution time

2017-04-27 Thread Gautam Borad (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987454#comment-15987454 ] Gautam Borad commented on RANGER-1522: -- Committed to master : c01d01f54622286de7ef17

Re: Review Request 58154: Policy engine updates to support tag-based masking policies

2017-04-27 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58154/#review173229 --- agents-common/src/main/java/org/apache/ranger/plugin/policyengine

[jira] [Updated] (RANGER-1471) Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Gautam Borad (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautam Borad updated RANGER-1471: - Fix Version/s: master > Remember filters on all tabs of Ranger Audits page >

[jira] [Commented] (RANGER-1471) Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Gautam Borad (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987094#comment-15987094 ] Gautam Borad commented on RANGER-1471: -- Committed to master : c7784876173bc9eafd1c47

Review Request 58804: RANGER-1549 - Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties

2017-04-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58804/ --- Review request for ranger. Bugs: RANGER-1549 https://issues.apache.org/jira

[jira] [Updated] (RANGER-1549) Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties

2017-04-27 Thread Colm O hEigeartaigh (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1549: Attachment: 0001-RANGER-1549-Add-COMPONENT_INSTALL_DIR_NAME-to-the-St.patch > Add C

[jira] [Created] (RANGER-1549) Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties

2017-04-27 Thread Colm O hEigeartaigh (JIRA)
Colm O hEigeartaigh created RANGER-1549: --- Summary: Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties Key: RANGER-1549 URL: https://issues.apache.org/jira/browse/RANGER-1549 Project:

Re: Review Request 57837: Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57837/#review173218 --- Ship it! Ship It! - Gautam Borad On April 26, 2017, 4:41 a.m

Re: Review Request 58733: RANGER-1471 : Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58733/#review173219 --- Ship it! Ship It! - Gautam Borad On April 26, 2017, 9:41 a.m

Re: Review Request 58526: RANGER-1522 : (Ranger-0.7 branch) Update consolidated db schema script for SQLServer DB flavor to reduce execution time

2017-04-27 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58526/#review173217 --- Ship it! Ship It! - Gautam Borad On April 26, 2017, 5:06 p.m

Re: Review Request 58525: RANGER-1522 : Update consolidated db schema script for SQLServer DB flavor to reduce execution time

2017-04-27 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58525/#review173216 --- Ship it! Ship It! - Gautam Borad On April 26, 2017, 5:02 p.m

Re: Review Request 58781: RANGER-1546 : Code Improvement To Follow Best Practice

2017-04-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58781/#review173206 --- Ship it! Ship It! - Velmurugan Periasamy On April 27, 2017,

Re: Review Request 58526: RANGER-1522 : (Ranger-0.7 branch) Update consolidated db schema script for SQLServer DB flavor to reduce execution time

2017-04-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58526/#review173203 --- Ship it! Ship It! - Velmurugan Periasamy On April 26, 2017,

Re: Review Request 58733: RANGER-1471 : Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58733/#review173202 --- Ship it! Ship It! - Velmurugan Periasamy On April 26, 2017,

Re: Review Request 58525: RANGER-1522 : Update consolidated db schema script for SQLServer DB flavor to reduce execution time

2017-04-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58525/#review173201 --- Ship it! Ship It! - Velmurugan Periasamy On April 26, 2017,

Re: Review Request 58734: RANGER-1546 : Code Improvement To Follow Best Practices

2017-04-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58734/#review173200 --- Ship it! Ship It! - Velmurugan Periasamy On April 27, 2017,

Re: Review Request 58730: RANGER-1499 : Upgrade Tomcat version

2017-04-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58730/#review173199 --- Fix it, then Ship it! Revise the patch for ranger-0.7 pom.xml

Re: Review Request 57837: Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57837/#review173197 --- Ship it! Ship It! - Velmurugan Periasamy On April 26, 2017,

Review Request 58791: RANGER-1543:Fix the spelling in RangerBaseUdf

2017-04-27 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58791/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEige

Review Request 58787: Display detailed error messages in Ranger for Audit store issues

2017-04-27 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58787/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan

Review Request 58787: Display detailed error messages in Ranger for Audit store issues

2017-04-27 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58787/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan

Review Request 58788: Display detailed error messages in Ranger for Audit store issues

2017-04-27 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58788/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan

[jira] [Updated] (RANGER-1548) Display detailed error messages in Ranger for Audit store issues

2017-04-27 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1548: - Attachment: RANGER-1548_07.patch > Display detailed error messages in Ranger for Audit store issu

Re: Review Request 58219: Support administration of Tag-based masking policies

2017-04-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58219/#review173179 --- There are several instances where you are creating an Iterator whi

Re: Review Request 58781: RANGER-1546 : Code Improvement To Follow Best Practice

2017-04-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58781/#review173175 --- Ship it! Ship It! - Colm O hEigeartaigh On April 27, 2017, 7

[jira] [Commented] (RANGER-1531) Good coding practice while parsing XML documents in Ranger

2017-04-27 Thread Colm O hEigeartaigh (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986209#comment-15986209 ] Colm O hEigeartaigh commented on RANGER-1531: - Please mark the review request

Re: Review Request 58734: RANGER-1546 : Code Improvement To Follow Best Practices

2017-04-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58734/#review173171 --- Ship it! Ship It! - Colm O hEigeartaigh On April 27, 2017, 5

Re: Review Request 58154: Policy engine updates to support tag-based masking policies

2017-04-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58154/#review173170 --- The current patch doesn't apply to master. It's better to use Col

[jira] [Commented] (RANGER-1436) Turn Ranger deny policy & except condition blocks ON by default

2017-04-27 Thread Colm O hEigeartaigh (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986194#comment-15986194 ] Colm O hEigeartaigh commented on RANGER-1436: - Please close + mark as submitt

[jira] [Commented] (RANGER-1535) Add tag attributes to audit log record

2017-04-27 Thread Colm O hEigeartaigh (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986193#comment-15986193 ] Colm O hEigeartaigh commented on RANGER-1535: - Please close + mark as submitt

[jira] [Updated] (RANGER-1543) Fix the spelling in RangerBaseUdf

2017-04-27 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1543: Attachment: 0001-RANGER-1543-Fix-the-spelling-in-RangerBaseUdf.patch > Fix the spelling in RangerBa

[jira] [Comment Edited] (RANGER-1546) Code Improvement To Follow Best Practices

2017-04-27 Thread bhavik patel (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984582#comment-15984582 ] bhavik patel edited comment on RANGER-1546 at 4/27/17 7:01 AM:

Review Request 58781: RANGER-1546 : Code Improvement To Follow Best Practice

2017-04-27 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58781/ --- Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Ne