s might no longer support
building such malformed projects.
Diffs
-
intg/pom.xml 5a02d03da
Diff: https://reviews.apache.org/r/73104/diff/1/
Testing
---
Builds cleanly with the above warnings removed.
Thanks,
Abhay Kulkarni
---
Tested with datamask and rowfilter policies filtering in a cluster
Thanks,
Abhay Kulkarni
-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java
d868e397d
Diff: https://reviews.apache.org/r/73120/diff/1/
Testing
---
Tested with datamask and rowfilter policies filtering in a cluster
Thanks,
Abhay Kulkarni
/ranger/biz/RangerPolicyAdminImpl.java
d868e397d
Diff: https://reviews.apache.org/r/73120/diff/2/
Changes: https://reviews.apache.org/r/73120/diff/1-2/
Testing
---
Tested with datamask and rowfilter policies filtering in a cluster
Thanks,
Abhay Kulkarni
.
Thanks,
Abhay Kulkarni
/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java
eb332ac3f
Diff: https://reviews.apache.org/r/73117/diff/3/
Changes: https://reviews.apache.org/r/73117/diff/2-3/
Testing
---
Developed and ran all unit tests successfully
Thanks,
Abhay Kulkarni
Diff: https://reviews.apache.org/r/73117/diff/3/
Testing
---
Developed and ran all unit tests successfully
Thanks,
Abhay Kulkarni
ngine/test_policyengine_hdfs_incremental_delete.json
PRE-CREATION
security-admin/src/main/resources/META-INF/jpa_named_queries.xml f6951f6c4
Diff: https://reviews.apache.org/r/73156/diff/1/
Testing
---
Passes all existing unit tests.
Created unit tests for the fix.
Thanks,
Abhay Kulkarni
https://reviews.apache.org/r/73156/diff/1-2/
Testing
---
Passes all existing unit tests.
Created unit tests for the fix.
Thanks,
Abhay Kulkarni
e/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java
Line 216 (original), 216 (patched)
<https://reviews.apache.org/r/73159/#comment311634>
This is a regression from previous behavior. Please ocnfirm with Hbase that
this is desired.
- Abhay Kulkarni
On Jan. 25, 2021,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73159/#review222531
---
Ship it!
Ship It!
- Abhay Kulkarni
On Jan. 26, 2021, 6:36
/sqlserver/optimized/current/ranger_core_db_sqlserver.sql
80307af38
security-admin/src/main/java/org/apache/ranger/patch/PatchForHBaseDefaultPolicyUpdate_J10045.java
PRE-CREATION
Diff: https://reviews.apache.org/r/73162/diff/1/
Testing
---
Thanks,
Abhay Kulkarni
://reviews.apache.org/r/73162/diff/2/
Changes: https://reviews.apache.org/r/73162/diff/1-2/
Testing
---
Thanks,
Abhay Kulkarni
.java
Line 127 (original), 127 (patched)
<https://reviews.apache.org/r/73165/#comment311648>
Is a normal user allowed to see KMS service-def? The code changes seem to
open up all service-definitions to all users. Please clarify.
- Abhay Kulkarni
On Jan. 29, 2021, 11:31 a.m., Mahesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73165/#review222561
---
Ship it!
Ship It!
- Abhay Kulkarni
On Jan. 29, 2021, 11:31
rom the authorizer
code.
- Abhay Kulkarni
On Jan. 27, 2021, 9:19 p.m., Ramesh Mani wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73178/#review222585
---
Ship it!
Ship It!
- Abhay Kulkarni
On Feb. 11, 2021, 12:04
scenarios described above in a cluster and verified that incremental
policy updates are applied on the plugin side, and the resulting policies are
correct.
Thanks,
Abhay Kulkarni
.
Thanks,
Abhay Kulkarni
/RangerPathResourceMatcher.java
4a158a276
Diff: https://reviews.apache.org/r/73189/diff/1/
Testing
---
Passed all unit tests.
Thanks,
Abhay Kulkarni
/RangerPathResourceMatcherTest.java
5c497779d
Diff: https://reviews.apache.org/r/73189/diff/2/
Changes: https://reviews.apache.org/r/73189/diff/1-2/
Testing (updated)
---
Developed unit tests to test SELF_OR_CHILD scope for PathResourceMatcher.
Passed all unit tests.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73191/#review222637
---
Ship it!
Ship It!
- Abhay Kulkarni
On Feb. 18, 2021, 1:09
-admin/src/main/java/org/apache/ranger/common/RangerAdminTagEnricher.java
09e5c5083
Diff: https://reviews.apache.org/r/73206/diff/1/
Testing
---
Passed all unit tests.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73195/#review222652
---
Ship it!
Ship It!
- Abhay Kulkarni
On Feb. 21, 2021, 2:20
Diff: https://reviews.apache.org/r/73227/diff/1/
Testing
---
Passed all unit tests
Thanks,
Abhay Kulkarni
/policyengine/RangerResourceTrie.java
71491359d
Diff: https://reviews.apache.org/r/73232/diff/1/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
va/org/apache/ranger/rest/ServiceREST.java
838184271
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java
09d3beac2
Diff: https://reviews.apache.org/r/73245/diff/1/
Testing (updated)
---
Passed all unit tests.
Verified that tag policy is applied correctly in the step 5 described in the
scenario in the description.
Thanks,
Abhay Kulkarni
one tag policy is created
in the security zone.
4. When the policy download is completed, and access is made forcing
authorization calls to Ranger plugin.
5. Before the patch, authorization always fails as policy-engine is not created
correctly. After patch is applied, policy-engine is correctly constructed and
the authorization proceeds normally.
Thanks,
Abhay Kulkarni
,
Abhay Kulkarni
disassociated from the security-zone, all
zone policies in that tag service are deleted. Also verified that the zone
deletion is successful.
Verified that when security zone is deleted, all zone policies in all
associated tag services are deleted.
Thanks,
Abhay Kulkarni
} macro and
SELF_OR_CHILD and SELF scoped access requests. Ran all unit tests successfully.
Thanks,
Abhay Kulkarni
Diff: https://reviews.apache.org/r/73291/diff/1/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
-for-service-resource.sql
PRE-CREATION
security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql
d15015009
security-admin/db/sqlserver/patches/052-create-index-for-service-resource.sql
PRE-CREATION
Diff: https://reviews.apache.org/r/73298/diff/1/
Testing
---
Pass
atched)
<https://reviews.apache.org/r/73300/#comment312020>
Consider changing the log message to indicate the entry to the module here.
Also consider misleading changing log message at line 2970.
- Abhay Kulkarni
On April 25, 2021, 10:14 p.m., Rames
l
PRE-CREATION
Diff: https://reviews.apache.org/r/73298/diff/2/
Changes: https://reviews.apache.org/r/73298/diff/1-2/
Testing
---
Passed unit tests
Thanks,
Abhay Kulkarni
/RangerServicePoliciesCache.java
1176e0b9e
security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java
0a1d1c142
Diff: https://reviews.apache.org/r/73301/diff/1/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
a
Line 2949 (original), 2967 (patched)
<https://reviews.apache.org/r/73300/#comment312043>
Please review and fix log message here and in line 2952
- Abhay Kulkarni
On April 26, 2021, 8:25 p.m., Ramesh Mani wrote:
>
> --
l
PRE-CREATION
Diff: https://reviews.apache.org/r/73298/diff/3/
Changes: https://reviews.apache.org/r/73298/diff/2-3/
Testing
---
Passed unit tests
Thanks,
Abhay Kulkarni
n from the actual records read from the
change log table.
- Abhay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73301/#review222884
----
://reviews.apache.org/r/73301/diff/1-2/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73300/#review222886
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 27, 2021, 5:39
://reviews.apache.org/r/73301/diff/2-3/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73272/#review222896
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 8, 2021, 7:04
/RangerServicePoliciesCache.java
1176e0b9e
security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java
0a1d1c142
Diff: https://reviews.apache.org/r/73301/diff/4/
Changes: https://reviews.apache.org/r/73301/diff/3-4/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
/XXPolicyChangeLogDao.java
0a1d1c142
Diff: https://reviews.apache.org/r/73301/diff/5/
Changes: https://reviews.apache.org/r/73301/diff/4-5/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
(original), 662 (patched)
<https://reviews.apache.org/r/73303/#comment312085>
Please consider if 'continue;' can be avoided for code readability.
- Abhay Kulkarni
On April 27, 2021, 10:42 p.m., Sailaja Polavarapu wrote:
>
> --
/RangerBasePlugin.java
Line 681 (original), 723 (patched)
<https://reviews.apache.org/r/73327/#comment312093>
Please add a null pointer check for refresher here and elsewhere in this
class.
- Abhay Kulkarni
On May 1, 2021, 6:24 a.m., Madhan Neethiraj
va
Lines 504 (patched)
<https://reviews.apache.org/r/73326/#comment312106>
How is this method different from one on line 484? Can the earlier method
be used generically everwhere the class-type needs to be specified (and this
method be removed)?
- Abhay Kulkarni
On April 30, 2021, 8:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73303/#review222945
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 29, 2021, 9:26
policies in a loop and ensured
that incremental policy download requests at random intervals are processed
correctly. Also ensured that unusual conditions emit warning messages both in
Ranger-Admin and in the plugin.
Thanks,
Abhay Kulkarni
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/7/#review222947
-------
On May 4, 2021, 11:42 p.m., Abhay Kulkarni wrote:
>
> ---
> This is an automati
conditions emit warning messages both in
Ranger-Admin and in the plugin.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73334/#review222950
---
Ship it!
Ship It!
- Abhay Kulkarni
On May 5, 2021, 1:35 a.m
rows
are created in x_policy_change_log and x_tag_change_log tables.
Thanks,
Abhay Kulkarni
created, a tag service, if not already
present, is created and linked with the resource-service by the task scheduled
to run after the transaction that created resource service is committed.
Thanks,
Abhay Kulkarni
unit tests.
Ensured that the x_service_version_info table is correctly updated when any
change to service/policy/tag is effected. Also ensured that correct set of rows
are created in x_policy_change_log and x_tag_change_log tables.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73309/#review222986
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 29, 2021, 1:32
s.
Ensured that the x_service_version_info table is correctly updated when any
change to service/policy/tag is effected. Also ensured that correct set of rows
are created in x_policy_change_log and x_tag_change_log tables.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73357/#review222998
---
Ship it!
Ship It!
- Abhay Kulkarni
On May 17, 2021, 12:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73326/#review222999
---
Ship it!
Ship It!
- Abhay Kulkarni
On May 13, 2021, 1:17
/RangerHdfsAuthorizer.java
Line 1000 (original), 1000 (patched)
<https://reviews.apache.org/r/73361/#comment312163>
Can the lines from 1000-1006 be replaced with
isAuditEnabled = result.getIsAudited();
- Abhay Kulkarni
On May 18, 2021, 10:52 p.m., Ramesh Mani
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73361/#review223010
---
Ship it!
Ship It!
- Abhay Kulkarni
On May 19, 2021, 8:36
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73362/#review223012
---
Ship it!
Ship It!
- Abhay Kulkarni
On May 20, 2021, 12:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73360/#review223016
---
Ship it!
Ship It!
- Abhay Kulkarni
On May 20, 2021, 12:15
iff/1/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
.java
0aab80945
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
2369f4193
Diff: https://reviews.apache.org/r/73363/diff/2/
Changes: https://reviews.apache.org/r/73363/diff/1-2/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
/RangerTransactionSynchronizationAdapter.java
Lines 157 (patched)
<https://reviews.apache.org/r/73365/#comment312188>
Please consider providing a unit test (or documentation) showing/describing
how this issue can be reproduced without the patch.
- Abhay Kulkarni
On May 21, 2021, 11:36 a.m.
/plugin/test_plugin_capability.json
a9f741b58
Diff: https://reviews.apache.org/r/73373/diff/1/
Testing
---
Passed all unit tests.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73355/#review223042
---
Ship it!
Ship It!
- Abhay Kulkarni
On May 14, 2021, 1:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73374/#review223045
---
Ship it!
Ship It!
- Abhay Kulkarni
On May 25, 2021, 8:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73365/#review223074
---
Ship it!
Ship It!
- Abhay Kulkarni
On May 26, 2021, 11:24
8b12affe2
tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java
62a5f7382
tagsync/src/main/resources/ranger-tagsync-default.xml 1034bc6e5
Diff: https://reviews.apache.org/r/73407/diff/1/
Testing
---
Passes all unit tests.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73413/#review223131
---
Ship it!
Ship It!
- Abhay Kulkarni
On June 10, 2021, 10:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71899/#review223151
---
Ship it!
Ship It!
- Abhay Kulkarni
On June 5, 2021, 7:48
-create-index-for-service-resource.sql
301aa42e0
Diff: https://reviews.apache.org/r/73425/diff/1/
Testing
---
Passed on unit tests.
Thanks,
Abhay Kulkarni
involving resource_signature column also includes
service-id column.
- Abhay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73425/#review223163
-------
/73425/diff/2/
Changes: https://reviews.apache.org/r/73425/diff/1-2/
Testing
---
Passed on unit tests.
Thanks,
Abhay Kulkarni
DROP INDEX
> > }
> > CREATE INDEX
Accepted.
- Abhay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73425/#review223169
------
/73425/diff/3/
Changes: https://reviews.apache.org/r/73425/diff/2-3/
Testing
---
Passed on unit tests.
Thanks,
Abhay Kulkarni
ache.org/r/73425/diff/4/
Changes: https://reviews.apache.org/r/73425/diff/3-4/
Testing
---
Passed on unit tests.
Thanks,
Abhay Kulkarni
/
Changes: https://reviews.apache.org/r/73425/diff/4-5/
Testing
---
Passed on unit tests.
Thanks,
Abhay Kulkarni
g logging level to DEBUG.
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
Lines 5843 (patched)
<https://reviews.apache.org/r/73432/#comment312292>
Please consider changing logging level to DEBUG
- Abhay Kulkarni
On June 24, 2021, 7:18
Testing
---
Passed all existing test cases.
Created a unit test for the use-case outlined in the JIRA, and ensured that it
passes.
Thanks,
Abhay Kulkarni
.
Thanks,
Abhay Kulkarni
,
Abhay Kulkarni
r both RangerAdminRESTClient and
RangerAdminJersey2RESTClient methods.
- Abhay Kulkarni
On July 10, 2021, 6:57 a.m., Ramesh Mani wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
n) is thread-safe.
- Abhay Kulkarni
On July 8, 2021, 10:59 p.m., Madhan Neethiraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
test cases.
Created a unit test for the use-case outlined in the JIRA, and ensured that it
passes.
Thanks,
Abhay Kulkarni
ted a unit test for the use-case outlined in the JIRA, and ensured that it
passes.
Thanks,
Abhay Kulkarni
scenario and ensured that the Policy-cache is not modified, and the
downloaded policies are same as the database copy.
Thanks,
Abhay Kulkarni
://reviews.apache.org/r/73466/diff/1/
Testing
---
Tested the scenario and ensured that the Policy-cache is not modified, and the
downloaded policies are same as the database copy.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73444/#review223252
---
Ship it!
Ship It!
- Abhay Kulkarni
On July 14, 2021, 4:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73471/#review223255
---
Ship it!
Ship It!
- Abhay Kulkarni
On July 22, 2021, 6:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73432/#review223291
---
Ship it!
Ship It!
- Abhay Kulkarni
On July 29, 2021, 6:45
Diff: https://reviews.apache.org/r/73497/diff/1/
Testing
---
Passed all unit tests.
Thanks,
Abhay Kulkarni
/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
831b6d4ad
Diff: https://reviews.apache.org/r/73497/diff/2/
Changes: https://reviews.apache.org/r/73497/diff/1-2/
Testing
---
Passed all unit tests.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73512/#review223329
---
Ship it!
Ship It!
- Abhay Kulkarni
On Aug. 10, 2021, 3:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73514/#review223331
---
Ship it!
Ship It!
- Abhay Kulkarni
On Aug. 11, 2021, 7:50
+1
On Wed, Aug 11, 2021 at 4:35 PM Madhan Neethiraj wrote:
>
> Rangers,
>
>
>
> Please review the following draft report and let me know your
> comments/feedback.
>
>
>
> Thanks,
>
> Madhan
>
>
>
> ## Description:
>
> Apache Ranger is a framework to enable, monitor and manage comprehensive data
not filled in earlier.
Thanks,
Abhay Kulkarni
701 - 800 of 1706 matches
Mail list logo
