[jira] [Commented] (RANGER-2599) Add more audit data to HBase grant/revoke events

2019-10-07 Thread Zsombor Gegesy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945922#comment-16945922 ] Zsombor Gegesy commented on RANGER-2599: Thanks for your patch, the commi

Re: Review Request 71566: RANGER-2599. Add more audit data to HBase grant/revoke events

2019-10-07 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71566/#review218114 --- Ship it! Ship It! - Zsombor Gegesy On Oct. 4, 2019, 12:17

Re: Review Request 71566: RANGER-2599. Add more audit data to HBase grant/revoke events

2019-10-02 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71566/#review218018 --- Ship it! Ship It! - Zsombor Gegesy On Oct. 2, 2019, 12:33

Re: Review Request 71566: RANGER-2599. Add more audit data to HBase grant/revoke events

2019-10-01 Thread Zsombor Gegesy
and you can use it like: var title = titleMap[model.get('serviceType')] || 'Request Data'; - Zsombor Gegesy On Oct. 1, 2019, 1:45 p.m., Andor Molnar wrote: > > --- > This is an a

[jira] [Commented] (RANGER-2599) Add more audit data to HBase grant/revoke events

2019-10-01 Thread Zsombor Gegesy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941845#comment-16941845 ] Zsombor Gegesy commented on RANGER-2599: Sorry, I can't assign this

[jira] [Updated] (RANGER-2599) Add more audit data to HBase grant/revoke events

2019-10-01 Thread Zsombor Gegesy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2599: --- Fix Version/s: 2.1.0 > Add more audit data to HBase grant/revoke eve

[jira] [Updated] (RANGER-2599) Add more audit data to HBase grant/revoke events

2019-10-01 Thread Zsombor Gegesy (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2599: --- Affects Version/s: 2.0.0 > Add more audit data to HBase grant/revoke eve

Re: Review Request 71527: Upgrade jackson-databind

2019-09-20 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71527/#review217892 --- Ship it! Ship It! - Zsombor Gegesy On Sept. 20, 2019, 1:39

[jira] [Resolved] (RANGER-2394) Filter/exclude multiple users in audit search

2019-06-06 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2394. Resolution: Fixed Merged into [master|https://github.com/apache/ranger/commit

Re: Review Request 70389: RANGER-2394 - filter multiple users or exclude multiple users in audit search

2019-06-05 Thread Zsombor Gegesy
ching for multiple users * excluding one user * excluding multiple users * searching for one user + 'excluding service users' * searching for multiple users + 'excluding service users' * excluding one user + 'excluding service users' * excluding multiple users + 'excluding service users' works as expected. Thanks, Zsombor Gegesy

[jira] [Updated] (RANGER-2394) Filter/exclude multiple users in audit search

2019-06-05 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2394: --- Attachment: RANGER-2394-6.patch > Filter/exclude multiple users in audit sea

[jira] [Updated] (RANGER-2394) Filter/exclude multiple users in audit search

2019-05-30 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2394: --- Attachment: RANGER-2394-5.patch > Filter/exclude multiple users in audit sea

Re: Review Request 70389: RANGER-2394 - filter multiple users or exclude multiple users in audit search

2019-05-30 Thread Zsombor Gegesy
sers' * excluding one user + 'excluding service users' * excluding multiple users + 'excluding service users' works as expected. Thanks, Zsombor Gegesy

Review Request 70615: RANGER-2421 - add http client to atlas plugin

2019-05-09 Thread Zsombor Gegesy
://reviews.apache.org/r/70615/diff/1/ Testing --- Added the necessary jars to a deployed Atlas server, and noticed that the exception disapears, and audit correctly sent. Thanks, Zsombor Gegesy

[jira] [Updated] (RANGER-2421) Solr audit fails in Atlas plugin

2019-05-09 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2421: --- Attachment: RANGER-2421.patch > Solr audit fails in Atlas plu

[jira] [Created] (RANGER-2421) Solr audit fails in Atlas plugin

2019-05-09 Thread Zsombor Gegesy (JIRA)
Zsombor Gegesy created RANGER-2421: -- Summary: Solr audit fails in Atlas plugin Key: RANGER-2421 URL: https://issues.apache.org/jira/browse/RANGER-2421 Project: Ranger Issue Type: Bug

Re: Review Request 70389: RANGER-2394 - filter multiple users or exclude multiple users in audit search

2019-05-03 Thread Zsombor Gegesy
sers' * excluding one user + 'excluding service users' * excluding multiple users + 'excluding service users' works as expected. Thanks, Zsombor Gegesy

Re: Review Request 70389: RANGER-2394 - filter multiple users or exclude multiple users in audit search

2019-04-27 Thread Zsombor Gegesy
#x27;excluding service users' * excluding multiple users + 'excluding service users' works as expected. Thanks, Zsombor Gegesy

Re: Review Request 70389: RANGER-2394 - filter multiple users or exclude multiple users in audit search

2019-04-11 Thread Zsombor Gegesy
for multiple users * excluding one user * excluding multiple users * searching for one user + 'excluding service users' * searching for multiple users + 'excluding service users' * excluding one user + 'excluding service users' * excluding multiple users + 'excluding service users' works as expected. Thanks, Zsombor Gegesy

[jira] [Updated] (RANGER-2394) Filter/exclude multiple users in audit search

2019-04-05 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2394: --- Attachment: RANGER-2394.patch > Filter/exclude multiple users in audit sea

Review Request 70389: RANGER-2394 - filter multiple users or exclude multiple users in audit search

2019-04-04 Thread Zsombor Gegesy
ervice users' * searching for multiple users + 'excluding service users' * excluding one user + 'excluding service users' * excluding multiple users + 'excluding service users' works as expected. Thanks, Zsombor Gegesy

[jira] [Created] (RANGER-2394) Filter/exclude multiple users in audit search

2019-04-04 Thread Zsombor Gegesy (JIRA)
Zsombor Gegesy created RANGER-2394: -- Summary: Filter/exclude multiple users in audit search Key: RANGER-2394 URL: https://issues.apache.org/jira/browse/RANGER-2394 Project: Ranger Issue

[jira] [Updated] (RANGER-2386) Code duplication due to RangerCredentialProvider.getCredentialString returns char[]

2019-03-29 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2386: --- Attachment: RANGER-2386.patch > Code duplication due

Review Request 70339: RANGER-2386: Code duplication due to RangerCredentialProvider.getCredentialString returns char[]

2019-03-29 Thread Zsombor Gegesy
.java 44cadfba2dc2f209a94b11f6d3ad7e7582f3d8cb agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java 971ee681a33dfcf5993e4d79e25c648c90646df2 Diff: https://reviews.apache.org/r/70339/diff/1/ Testing --- Tested with plugins on a cluster Thanks, Zsombor Gegesy

[jira] [Created] (RANGER-2386) Code duplication due to RangerCredentialProvider.getCredentialString returns char[]

2019-03-29 Thread Zsombor Gegesy (JIRA)
Zsombor Gegesy created RANGER-2386: -- Summary: Code duplication due to RangerCredentialProvider.getCredentialString returns char[] Key: RANGER-2386 URL: https://issues.apache.org/jira/browse/RANGER-2386

Re: Review Request 70057: RANGER-2324 Bootstrapping Solr in Ranger service start-up

2019-03-29 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70057/#review214200 --- Ship it! Ship It! - Zsombor Gegesy On March 28, 2019, 4:10

Re: Review Request 70057: RANGER-2324 Bootstrapping Solr in Ranger service start-up

2019-03-28 Thread Zsombor Gegesy
pper.java Lines 237 (patched) <https://reviews.apache.org/r/70057/#comment300360> In this case, when config is not specified correctly, I don't think re-trying the same would make sense - Zsombor Gegesy On March 27, 2019, 1:04 p.m., bhavik patel wrote: > > ---

Re: Review Request 70312: RANGER-2381 Failed to refresh policies when servicename contains space

2019-03-27 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70312/#review214099 --- Ship it! Ship It! - Zsombor Gegesy On March 27, 2019, 1:56

[jira] [Created] (RANGER-2378) KeySecure HSM Integration is not compatible with Java9

2019-03-22 Thread Zsombor Gegesy (JIRA)
Zsombor Gegesy created RANGER-2378: -- Summary: KeySecure HSM Integration is not compatible with Java9 Key: RANGER-2378 URL: https://issues.apache.org/jira/browse/RANGER-2378 Project: Ranger

Re: Review Request 70254: RANGER-2373 : User creation POST and PUT response not showing groupIdList and groupNameList with expected data

2019-03-22 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70254/#review213910 --- Ship it! Ship It! - Zsombor Gegesy On March 22, 2019, 7:17

Re: Review Request 70257: RANGER-2375: RangerAuthContext is not correctly initialized

2019-03-20 Thread Zsombor Gegesy
checks that addOrReplaceRequestContextEnricher and preProcess(RangerAccessRequest) works as expected? - Zsombor Gegesy On March 20, 2019, 7:52 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 70187: RANGER-2353:Upgrade Apache Thrift Java client library to 0.12.0

2019-03-20 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70187/#review213849 --- Ship it! Ship It! - Zsombor Gegesy On March 11, 2019, 7:49

Re: Review Request 70226: RANGER-2354:Add custom condition at policy level

2019-03-20 Thread Zsombor Gegesy
/policyevaluator/RangerDefaultPolicyEvaluator.java Lines 1224 (patched) <https://reviews.apache.org/r/70226/#comment299948> perf is always null, it never logs anything. - Zsombor Gegesy On March 20, 2019, 5:03 a.m., Ramesh Mani

Re: Review Request 70254: User creation POST and PUT response not showing groupIdList and groupNameList with expected data

2019-03-20 Thread Zsombor Gegesy
w ArrayList<>(); ... } security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java Line 610 (original), 616 (patched) <https://reviews.apache.org/r/70254/#comment299947> Could you add a check that getGroupIdList() is not empty, but contains a group id? - Zsombor Gegesy

Re: Review Request 70204: RANGER-2358: Upgrade Jackson Databind to 2.9.8

2019-03-13 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70204/#review213667 --- Ship it! Ship It! - Zsombor Gegesy On March 13, 2019, 12:41

[jira] [Resolved] (RANGER-2317) Enable compilation on JDK11

2019-03-13 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2317. Resolution: Fixed Merged to [master|https://github.com/apache/ranger/commit

[jira] [Resolved] (RANGER-2356) External user's email address can be edited

2019-03-13 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2356. Resolution: Fixed Merged to   [master|https://github.com/apache/ranger/commit

Re: Review Request 70194: RANGER-2356: External user's email address can be edited

2019-03-12 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70194/#review213624 --- Ship it! Ship It! - Zsombor Gegesy On March 12, 2019, 1:35

Re: Review Request 69655: RANGER-2317 : make Ranger buildable on newer JDKs

2019-03-11 Thread Zsombor Gegesy
ded' scope. Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11: https://travis-ci.org/gzsombor/ranger/builds/474559352 Thanks, Zsombor Gegesy

[jira] [Commented] (RANGER-2336) Ranger HBase plugin should pack guava lib as a dependency.

2019-02-26 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778605#comment-16778605 ] Zsombor Gegesy commented on RANGER-2336: In [this commit|https://github

Re: Review Request 70057: RANGER-2324 Bootstrapping Solr in Ranger service start-up

2019-02-26 Thread Zsombor Gegesy
a/org/apache/ranger/server/tomcat/SolrSetupUtil.java Lines 531 (patched) <https://reviews.apache.org/r/70057/#comment299120> I don't think, that you can do anything, if you can't talk to Solr, and you don't get the collections, I would rather have the exception propagated to

Re: Review Request 69984: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-25 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69984/#review213161 --- Ship it! Ship It! - Zsombor Gegesy On Feb. 25, 2019, 12:59

Re: Review Request 69985: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-25 Thread Zsombor Gegesy
> On Feb. 20, 2019, 12:08 p.m., Zsombor Gegesy wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java > > Lines 72 (patched) > > <https://reviews.apache.org/r/69985/diff/2/?file=2125810#file2125810line72> > > > >

Re: Review Request 69985: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-25 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69985/#review213155 --- Ship it! Ship It! - Zsombor Gegesy On Feb. 21, 2019, 6:30

Re: Review Request 69985: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-25 Thread Zsombor Gegesy
> On Feb. 20, 2019, 12:08 p.m., Zsombor Gegesy wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java > > Lines 130 (patched) > > <https://reviews.apache.org/r/69985/diff/2/?file=2125808#file2125808line130> > > > >

[jira] [Updated] (RANGER-2317) Enable compilation on JDK11

2019-02-22 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2317: --- Attachment: RANGER-2317-3.patch > Enable compilation on JD

Re: Review Request 69655: RANGER-2317 : make Ranger buildable on newer JDKs

2019-02-22 Thread Zsombor Gegesy
or in Maven plugin config, or has 'provided' scope. Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11: https://travis-ci.org/gzsombor/ranger/builds/474559352 Thanks, Zsombor Gegesy

Re: Review Request 69985: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-20 Thread Zsombor Gegesy
> On Feb. 14, 2019, 12:02 p.m., Zsombor Gegesy wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java > > Lines 50 (patched) > > <https://reviews.apache.org/r/69985/diff/1/?file=2125358#file2125358line50> > > > > You can

Re: Review Request 69985: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-20 Thread Zsombor Gegesy
> On Feb. 14, 2019, 12:02 p.m., Zsombor Gegesy wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java > > Lines 50 (patched) > > <https://reviews.apache.org/r/69985/diff/1/?file=2125358#file2125358line50> > > > > You can

Re: Review Request 69985: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-20 Thread Zsombor Gegesy
72 (patched) <https://reviews.apache.org/r/69985/#comment298828> myStore is never null here - even if KeyStore.getInstance would return a null (but it wont do), the myStore.load would trigger an NPE before. - Zsombor Gegesy On Feb. 19, 2019, 1:58 p.m.,

Re: Review Request 69985: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-19 Thread Zsombor Gegesy
> On Feb. 14, 2019, 12:02 p.m., Zsombor Gegesy wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java > > Lines 50 (patched) > > <https://reviews.apache.org/r/69985/diff/1/?file=2125358#file2125358line50> > > > > You can

Re: Review Request 69985: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-14 Thread Zsombor Gegesy
.org/r/69985/#comment298716> I don't get, why it throws NoSuchAlgorithmException, CertificateException, and IOException, but catch KeyStoreException ? - Zsombor Gegesy On Feb. 14, 2019, 9:59 a.m., Gautam Borad wrote: > >

Re: Review Request 69984: RANGER-2331 : Ranger-KMS - KeySecure HSM Integration

2019-02-14 Thread Zsombor Gegesy
you please close one of it? - Zsombor Gegesy On Feb. 14, 2019, 9:55 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69740: RANGER-2322 - Use "TLS" in SSLContext.getInstance

2019-01-24 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69740/#review212294 --- Ship it! Ship It! - Zsombor Gegesy On Jan. 14, 2019, 11:20

[jira] [Commented] (RANGER-2287) Improve and optimize db_setup.py file code

2019-01-23 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749768#comment-16749768 ] Zsombor Gegesy commented on RANGER-2287: Awesome, you removed nearly 4000 l

Re: Review Request 69677: RANGER-2287: Improve and optimize db_setup.py file code

2019-01-23 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69677/#review212231 --- Ship it! Ship It! - Zsombor Gegesy On Jan. 22, 2019, 1:47

Re: Review Request 69740: RANGER-2322 - Use "TLS" in SSLContext.getInstance

2019-01-16 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69740/#review212075 --- What about changing to "TLSv1.2"? - Zsombor Gegesy

[jira] [Updated] (RANGER-2321) Docker build fails due to PhantomJS dependency

2019-01-16 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2321: --- Fix Version/s: 2.0.0 > Docker build fails due to PhantomJS depende

[jira] [Resolved] (RANGER-2321) Docker build fails due to PhantomJS dependency

2019-01-16 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2321. Resolution: Fixed Thanks for the patch, it has been merged to [master|https://github.com

Re: Review Request 69731: RANGER-2321 Docker build fails due to PhantomJS dependency

2019-01-13 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69731/#review211940 --- Ship it! Ship It! - Zsombor Gegesy On Jan. 13, 2019, 7:18

Re: Review Request 69731: RANGER-2321 Docker build fails due to PhantomJS dependency

2019-01-12 Thread Zsombor Gegesy
tps://reviews.apache.org/r/69731/#comment297501> ${basedir}/target is the same as ${project.build.directory}, isn't it? Can you use it everywhere? - Zsombor Gegesy On Jan. 12, 2019, 2:41 p.m., Csaba Koncz wrote: > > ---

Re: Review Request 69677: RANGER-2287: Improve and optimize db_setup.py file code

2019-01-11 Thread Zsombor Gegesy
> On Jan. 8, 2019, 11:48 a.m., Zsombor Gegesy wrote: > > It's great news, that you could delete thousands of lines of repetitive > > code, however you could achieve more, if instead of putting everything into > > one class, and put > > '&#

[jira] [Resolved] (RANGER-2319) Remove deprecated phantomjs NPM package

2019-01-11 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2319. Resolution: Fixed Fix Version/s: 2.0.0 Thanks for the patch, applied to [master

Re: Review Request 69693: RANGER-2319 remove deprecated phantomjs package

2019-01-10 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69693/#review211824 --- Ship it! Ship It! - Zsombor Gegesy On Jan. 10, 2019, 8:46

Re: Review Request 69693: RANGER-2319 remove deprecated phantomjs package

2019-01-08 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69693/#review211763 --- Ship it! Ship It! - Zsombor Gegesy On Jan. 8, 2019, 11:28

Re: Review Request 69677: RANGER-2287: Improve and optimize db_setup.py file code

2019-01-08 Thread Zsombor Gegesy
_something differently in the MySQL/PostgreSQL/Oracle specific adapter class - Zsombor Gegesy On Jan. 7, 2019, 6:37 a.m., Pradeep Agrawal wrote: > > --- > This is an automatically generated e-mail. To reply,

[jira] [Updated] (RANGER-2317) Enable compilation on JDK11

2019-01-07 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2317: --- Attachment: (was: RANGER-2317.patch) > Enable compilation on JD

[jira] [Updated] (RANGER-2317) Enable compilation on JDK11

2019-01-07 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2317: --- Attachment: RANGER-2317-2.patch > Enable compilation on JD

Re: Review Request 69655: RANGER-2317 : make Ranger buildable on newer JDKs

2019-01-07 Thread Zsombor Gegesy
scope. Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11: https://travis-ci.org/gzsombor/ranger/builds/474559352 Thanks, Zsombor Gegesy

[jira] [Resolved] (RANGER-2255) Add JavaScript unit tests

2019-01-04 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2255. Resolution: Fixed Commited to [master|https://github.com/apache/ranger/commit

[jira] [Commented] (RANGER-2318) Incorrect git url on the homepage

2019-01-04 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734101#comment-16734101 ] Zsombor Gegesy commented on RANGER-2318: Commited to [master|h

Re: Review Request 69067: RANGER-2255 JavaScript tests for UI loading

2019-01-03 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69067/#review211633 --- Ship it! Ship It! - Zsombor Gegesy On Jan. 3, 2019, 1:43

[jira] [Updated] (RANGER-2318) Incorrect git url on the homepage

2019-01-03 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2318: --- Attachment: RANGER-2318.patch > Incorrect git url on the homep

[jira] [Created] (RANGER-2318) Incorrect git url on the homepage

2019-01-03 Thread Zsombor Gegesy (JIRA)
Zsombor Gegesy created RANGER-2318: -- Summary: Incorrect git url on the homepage Key: RANGER-2318 URL: https://issues.apache.org/jira/browse/RANGER-2318 Project: Ranger Issue Type: Bug

Review Request 69659: RANGER-2318 - homepage has a wrong git URL

2019-01-03 Thread Zsombor Gegesy
documentation Thanks, Zsombor Gegesy

Review Request 69655: RANGER-2317 : make Ranger buildable on newer JDKs

2019-01-02 Thread Zsombor Gegesy
r/ranger/builds/474559352 Thanks, Zsombor Gegesy

[jira] [Updated] (RANGER-2317) Enable compilation on JDK11

2019-01-01 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2317: --- Attachment: RANGER-2317.patch > Enable compilation on JD

[jira] [Created] (RANGER-2317) Enable compilation on JDK11

2019-01-01 Thread Zsombor Gegesy (JIRA)
Zsombor Gegesy created RANGER-2317: -- Summary: Enable compilation on JDK11 Key: RANGER-2317 URL: https://issues.apache.org/jira/browse/RANGER-2317 Project: Ranger Issue Type: Improvement

Re: Review Request 68620: RANGER-2206: Add Policy Validity Period and Override as search filters and add distinguishing icons in policy listing page

2019-01-01 Thread Zsombor Gegesy
solution, I think. It would be much simpler, if RangerValiditySchedule would contain an Instant for startTime and endTime, and the caller service would similarly put an Instant or a ZonedDateTime into the SearchFilter and this filtering could be done on comparing Instants. - Zsombor Gegesy On Sept

Re: Review Request 69067: RANGER-2255 JavaScript tests for UI loading

2019-01-01 Thread Zsombor Gegesy
/main/webapp/tests' folder, instead under 'src/test/javascript'? This way, these js files are added to the webapp, isn't it? - Zsombor Gegesy On Oct. 22, 2018, 8:34 p.m., Csaba Koncz wrote: > > --- > This is

Re: Review Request 68685: RANGER-2216: Ranger Audit UI lacks the feature to search the audits using Policy Id

2019-01-01 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68685/#review211590 --- Ship it! Ship It! - Zsombor Gegesy On Sept. 11, 2018, 1:29

Review Request 69524: RANGER-2307 - native authentication improvements

2018-12-07 Thread Zsombor Gegesy
unixauthpam/src/main/c/pamCredValidator.c 60d38aebd Diff: https://reviews.apache.org/r/69524/diff/1/ Testing --- Tryied to call both method on live cluster - as root / non-root, with wrong username, missing password from shadow file, etc. Thanks, Zsombor Gegesy

[jira] [Updated] (RANGER-2307) Native code can segfault or return misleading error messages

2018-12-07 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2307: --- Attachment: RANGER-2307-native-fixes.patch > Native code can segfault or return mislead

[jira] [Created] (RANGER-2307) Native code can segfault or return misleading error messages

2018-12-07 Thread Zsombor Gegesy (JIRA)
Zsombor Gegesy created RANGER-2307: -- Summary: Native code can segfault or return misleading error messages Key: RANGER-2307 URL: https://issues.apache.org/jira/browse/RANGER-2307 Project: Ranger

Re: Review Request 68881: RANGER-2203: Review and update database schema for ranger policies to minimize database queries/updates

2018-10-18 Thread Zsombor Gegesy
a List ? security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefConditionDao.java Lines 41 (patched) <https://reviews.apache.org/r/68881/#comment294323> You can return Collections.emptyList() in every negative case. - Zsombor Gegesy On Oct

Re: Review Request 67782: RANGER-2144 - refactor DAO creation

2018-09-06 Thread Zsombor Gegesy
/67782/diff/3/ Changes: https://reviews.apache.org/r/67782/diff/2-3/ Testing --- Tested with unit tests and on a live cluster. Thanks, Zsombor Gegesy

[jira] [Updated] (RANGER-2144) Refactor DAO usage

2018-09-05 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2144: --- Attachment: RANGER-2144-3.patch > Refactor DAO us

[jira] [Updated] (RANGER-2144) Refactor DAO usage

2018-09-05 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2144: --- Attachment: (was: RANGER-2144.patch) > Refactor DAO us

Re: Review Request 68128: RANGER-2170:Ranger supports plugin to enable, monitor and manage Elasticsearch

2018-08-10 Thread Zsombor Gegesy
sticsearch/plugin/action/filter/RangerSecurityActionFilter.java Lines 88 (patched) <https://reviews.apache.org/r/68128/#comment290261> Isn't it a security problem, if no user name is there, the plugin allows everything? - Zsombor Gegesy On Aug. 1, 2018, 9:27 a.m., Qiang Zhang w

Re: Review Request 68286: RANGER-2186: Increment service-specific policy and tag versions after update transaction is committed

2018-08-10 Thread Zsombor Gegesy
runnable.run(); } } } ``` - Zsombor Gegesy On Aug. 10, 2018, 12:58 a.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 68288: RANGER-2177 Fix browser hangs bug

2018-08-10 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68288/#review207071 --- Ship it! Ship It! - Zsombor Gegesy On Aug. 10, 2018, 5:43

Re: Review Request 68290: RANGER-2185:when user has access to some of Hive databases, execute command 'show databases' will show the access databases

2018-08-10 Thread Zsombor Gegesy
ssType=USE. Adding unit test would be nice too. - Zsombor Gegesy On Aug. 10, 2018, 11:14 a.m., dhomme wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 67782: RANGER-2144 - refactor DAO creation

2018-08-06 Thread Zsombor Gegesy
/TestUserService.java c48739b94 Diff: https://reviews.apache.org/r/67782/diff/2/ Changes: https://reviews.apache.org/r/67782/diff/1-2/ Testing --- Tested with unit tests and on a live cluster. Thanks, Zsombor Gegesy

Re: Review Request 68083: RANGER-2167 - Upgrade to Apache parent pom version 20

2018-08-01 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68083/#review206730 --- Ship it! Ship It! - Zsombor Gegesy On July 27, 2018, 3:28

[jira] [Commented] (RANGER-1951) build problems with the saveVersion.py script

2018-07-27 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559651#comment-16559651 ] Zsombor Gegesy commented on RANGER-1951: Patch merged to [master|h

[jira] [Resolved] (RANGER-1951) build problems with the saveVersion.py script

2018-07-27 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-1951. Resolution: Fixed > build problems with the saveVersion.py scr

Re: Review Request 68077: RANGER-2166: A ClassNotFound exception is thrown with atlasrest as a tag source

2018-07-27 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68077/#review206541 --- Ship it! Ship It! - Zsombor Gegesy On July 27, 2018, 1:37

Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

2018-07-27 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68042/#review206540 --- Ship it! Ship It! - Zsombor Gegesy On July 27, 2018, 7:32

Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

2018-07-26 Thread Zsombor Gegesy
/RangerConstants.java Lines 175 (patched) <https://reviews.apache.org/r/68042/#comment289474> This could be "final", and maybe Set, as only the "contains" method is used. - Zsombor Gegesy On July 25, 2018,

Re: Review Request 68059: RANGER-2162: Upgrade c3p0 libraries

2018-07-26 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68059/#review206495 --- Ship it! Ship It! - Zsombor Gegesy On July 26, 2018, 8:20

  1   2   3   4   5   >