Re: Review Request 71467: RANGER-2565 Remove duplicate error messages when test connection fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71467/#review219012 --- Ship it! Ship It! - pengjianhua On 九月 11, 2019, 9:50 a.m

Re: Review Request 71467: RANGER-2565 Remove duplicate error messages when test connection fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71467/#review218969 --- Ship it! Ship It! - pengjianhua On 九月 11, 2019, 9:50 a.m

Re: Review Request 71876: RANGER-2662 Upgrade Kylin version to 2.6.4

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71876/#review218967 --- Ship it! Ship It! - pengjianhua On 十二月 5, 2019, 11:28 a.m

Re: Review Request 71877: RANGER-2663 Add elasticsearch-plugin infomation to README.txt

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71877/#review218968 --- Ship it! Ship It! - pengjianhua On 十二月 5, 2019, 11:50 a.m

Re: Review Request 71418: RANGER-2533: update ‘xasecure.audit.is.enabled’ default value to ‘true’ in AuditProviderFactory.java and remove unnecessary unit test changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71418/#review217645 --- Ship it! Ship It! - pengjianhua On 八月 31, 2019, 2:38 a.m

Re: Review Request 71438: RANGER-2560 Solve the problem of the order of the configuration items of the Solr plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71438/#review217644 --- Ship it! Ship It! - pengjianhua On 九月 5, 2019, 12:12 p.m

Re: Review Request 71325: RANGER-2542 Similar to RANGER-2515, add .gitignore for project plugin-ozone and ranger-ozone-plugin-shim

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71325/#review217329 --- Ship it! Ship It! - pengjianhua On 八月 20, 2019, 8:50 a.m

Re: Review Request 71261: RANGER-2533: After setting 'xasecure.audit.is.enabled' to 'false', the audit log is still logged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71261/#review217197 --- Ship it! Ship It! - pengjianhua On 八月 9, 2019, 7:44 a.m

Re: Review Request 71153: RANGER-2515: add .gitignore for project plugin-presto and ranger-presto-plugin-shim

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71153/#review216872 --- Ship it! Ship It! - pengjianhua On July 24, 2019, 10:57 a.m

Re: Review Request 70312: RANGER-2381 Failed to refresh policies when servicename contains space

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70312/#review214148 --- Ship it! Ship It! - pengjianhua On 三月 27, 2019, 1:56 a.m

Re: Review Request 69959: RANGER-2336:Ranger HBase plugin should pack guava lib as a dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69959/#review212773 --- Ship it! Ship It! - pengjianhua On 二月 12, 2019, 10:34 p.m

Re: Review Request 69637: RANGER-2314 Do some code improvement for the error message in SqoopClient.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69637/#review211547 --- Ship it! Ship It! - pengjianhua On 十二月 27, 2018, 7:17 a.m

Re: Review Request 69466: RANGER-2294:Front-end and back-end email address regular expression should be the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69466/#review211137 --- Ship it! Ship It! - pengjianhua On 十一月 28, 2018, 8:16 a.m

Re: Review Request 69489: RANGER-2299 Modify the permissions of the kms install.properties file to 700

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69489/#review211136 --- Ship it! Ship It! - pengjianhua On 十一月 30, 2018, 9:07 a.m

Re: Review Request 69488: RANGER-2298 Modify JAVA_VERSION_REQUIRED to 1.8 in install.properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69488/#review20 --- Ship it! Ship It! - pengjianhua On 十一月 30, 2018, 7:30 a.m

Re: Review Request 69506: RANGER-2303:Add kylin-plugin infomation to README.txt

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69506/#review211109 --- Ship it! Ship It! - pengjianhua On 十二月 5, 2018, 6:15 a.m

Re: Review Request 69406: RANGER-2289 Unable to get Audit Admin tab page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69406/#review210746 --- Ship it! Ship It! - pengjianhua On 十一月 20, 2018, 9:47 a.m

Re: Review Request 69340: RANGER-2244 Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.91 or later.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69340/#review210641 --- Ship it! Ship It! - pengjianhua On 十一月 15, 2018, 9:01 a.m

Re: Review Request 69371: RANGER-2288 Sqoop repository config missing "Common Name for Certificate"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69371/#review210602 --- Ship it! Ship It! - pengjianhua On 十一月 16, 2018, 7:12 a.m

Re: Review Request 69320: RANGER-2282 The error message for changing password is incorrect in User Profile page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69320/#review210599 --- Ship it! Ship It! - pengjianhua On 十一月 13, 2018, 2:51 a.m

Re: Review Request 69239: RANGER-2276:Email Address should be verified when Add New User in Ranger Admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69239/#review210595 --- Ship it! Ship It! - pengjianhua On 十一月 12, 2018, 8:34 a.m

Re: Review Request 69239: RANGER-2276:Email Address should be verified when Add New User in Ranger Admin

efined in a single-type import - pengjianhua On 十一月 2, 2018, 7:27 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 69156: RANGER-2267 Add a icon to differentiate the status of the service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69156/#review210435 --- Ship it! Ship It! - pengjianhua On 十月 31, 2018, 6:27 a.m

Re: Review Request 69248: RANGER-2277 Kylin repository config missing "Common Name for Certificate"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69248/#review210434 --- Ship it! Ship It! - pengjianhua On 十一月 5, 2018, 9:27 a.m

Re: Review Request 69297: RANGER-2280:The emptyText of User Sync and Plugin Status should be reasonable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69297/#review210433 --- Ship it! Ship It! - pengjianhua On 十一月 8, 2018, 7:08 a.m

Re: Review Request 69154: RANGER-2266:To make Id to ID in Audit Pages of Ranger Admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69154/#review210129 --- Ship it! Ship It! - pengjianhua On 十月 25, 2018, 7:18 a.m

Re: Review Request 69156: RANGER-2267 Add a "disabled" lable to differentiate the status of the service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69156/#review210130 --- Ship it! Ship It! - pengjianhua On 十月 25, 2018, 9:22 a.m

Re: Review Request 68990: RANGER-2248 Sorting does not work in AbstractPredicateUtil.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68990/#review209913 --- Ship it! Ship It! - pengjianhua On 十月 11, 2018, 7:32 a.m

Re: Review Request 69081: RANGER-2258 Improve the policy list page to prompt users when the service is disabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69081/#review209912 --- Ship it! Ship It! - pengjianhua On 十月 19, 2018, 8:06 a.m

Re: Review Request 69080: RANGER-2257:Add policyID to error message when click the Access log of Audit

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69080/#review209911 --- Ship it! Ship It! - pengjianhua On 十月 19, 2018, 3:26 a.m

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68871/#review209474 --- Ship it! Ship It! - pengjianhua On 十月 8, 2018, 2:08 a.m

Re: Review Request 68864: RANGER-2237 Upgrade Kylin version to 2.5.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68864/#review209086 --- Ship it! Ship It! - pengjianhua On 九月 27, 2018, 7:19 a.m

Re: Review Request 68849: RANGER-2235 Modify the login session detail page as a modal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68849/#review209063 --- Ship it! Ship It! - pengjianhua On 九月 26, 2018, 9:01 a.m

Re: Review Request 68681: RANGER-2213 Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.90.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68681/#review208836 --- Ship it! Ship It! - pengjianhua On 九月 11, 2018, 3:07 a.m

Re: Review Request 68423: RANGER-2193 Form validation during testconnection should be consistent with service creation/editing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68423/#review208791 --- Ship it! Ship It! - pengjianhua On 八月 18, 2018, 5:48 a.m

Re: Review Request 68682: RANGER-2214 Do some code improvement for the error message for KylinClient.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68682/#review208790 --- Ship it! Ship It! - pengjianhua On 九月 11, 2018, 3:30 a.m

Re: Review Request 68676: RANGER-2212 Add multiple urls tips for the ‘Kylin URL’ configuration item when creating the kylin-plugin service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68676/#review208789 --- Ship it! Ship It! - pengjianhua On 九月 10, 2018, 7:43 a.m

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68010/#review206829 --- Ship it! Ship It! - pengjianhua On Aug. 2, 2018, 7:42 a.m

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68010/#review206584 --- Ship it! - pengjianhua On July 27, 2018, 6:45 a.m., Qiang

Re: Review Request 67919: RANGER-2152 Incorrect debugging information in RangerPluginClassLoader.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67919/#review206490 --- Ship it! Ship It! - pengjianhua On July 14, 2018, 5:47 a.m

Re: Review Request 66810: RANGER-2085 :- Add resource lookup for entity-id in Atlas service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66810/#review202053 --- Ship it! Ship It! - pengjianhua On 四月 26, 2018, 12:36 p.m

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201392 --- Ship it! Ship It! - pengjianhua On 四月 18, 2018, 6:05 a.m

Re: Review Request 66627: RANGER-1985:Auditing for Ranger Usersync operations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66627/#review201373 --- Ship it! Ship It! - pengjianhua On 四月 16, 2018, 2:35 p.m

Re: Review Request 66600: Fix ranger.plugin.hbase.policy.rest.ssl.config.file parameter error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66600/#review201181 --- Ship it! Ship It! - pengjianhua On 四月 13, 2018, 8:25 a.m

Re: Review Request 66593: RANGER-2066: Hbase column family access is authorized by a tagged column in the column family

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66593/#review201072 --- Ship it! Ship It! - pengjianhua On 四月 13, 2018, 12:41 a.m

Re: Review Request 66581: Supply the function of viewing policy history version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66581/#review201070 --- Ship it! Ship It! - pengjianhua On 四月 12, 2018, 3:19 a.m

Re: Review Request 66588: RANGER-2066: Hbase column family access is authorized by a tagged column in the column family

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66588/#review201066 --- Ship it! Ship It! - pengjianhua On 四月 12, 2018, 6:13 p.m

Re: Review Request 66389: RANGER-2054:Fix new findBugs in RangerAdminClientImpl.java for kylin plugin test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66389/#review200337 --- Ship it! Ship It! - pengjianhua On 四月 2, 2018, 7:13 a.m

Re: Review Request 66298: Fix execute sql failure in db_setup.py file of the admin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66298/#review200032 --- Ship it! Ship It! - pengjianhua On 三月 27, 2018, 6:37 a.m

Re: Review Request 66275: Add hbase policy and click the 'Test Connection' button. Connection Failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66275/#review200023 --- Ship it! Ship It! - pengjianhua On 三月 26, 2018, 6:42 a.m

Re: Ranger SSL Configuration Issues

Please tell me which version you are using. I tested the 0.7.0, 0.7.1, 1.0.0. There are no problems with these versions. Maybe your configuration is wrong. 在 2018年03月25日 04:48, rohit sinha 写道: *Hello,We have a ranger plugin which works perfectly fine with non-SSL Ranger but we turn on SSL

Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66079/#review199310 --- Ship it! Ship It! - pengjianhua On 三月 15, 2018, 6:55 a.m

Re: Review Request 61021: RANGER-1672:Ranger supports plugin to enable, monitor and manage apache kylin

. Because of the large number of codes, I merged it to avoid code conflicts due to different developer submissions. Thanks. - pengjianhua On 三月 5, 2018, 8:23 a.m., Qiang Zhang wrote: > > --- > This is an automatically generat

Re: Review Request 65894: Remove invalid packages and import commands package to installer to fixed RANGER-1469 defect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65894/#review198606 --- Ship it! Ship It! - pengjianhua On 三月 4, 2018, 2:56 p.m

Re: Review Request 65858: RANGER-2001:Similar to RANGER-1469, we should check whether the user or group has existed before the installer create a new user or group when user install usersync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65858/#review198493 --- Ship it! Ship It! - pengjianhua On 三月 1, 2018, 7:06 a.m

Re: Review Request 65709: RANGER-1987 - Upgrade to Storm 1.2.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65709/#review198251 --- Ship it! Ship It! - pengjianhua On 二月 19, 2018, 4:21 p.m

Re: Prep for ranger-1.0.0 release

I agree with Colm's point of view. Zhangqiang am developing this issue to upgrade Kafka whichwas delayed due to our Spring Festival. I also hope to merge the Apacke Kylin Plugin into the ranger 1.0.0. the 2.3.0 version of the Apache kylin is being voted. The Apacke Kylin Plugin of the ranger

Re: Review Request 65599: RANGER-1976: Upgrade Apache POI to 3.15

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65599/#review197356 --- Ship it! Ship It! - pengjianhua On 二月 12, 2018, 8:58 a.m

Re: Review Request 65604: RANGER-1977: Upgrade Apache commons-beanutils to 1.9.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65604/#review197354 --- Ship it! Ship It! - pengjianhua On 二月 12, 2018, 11:31 a.m

Re: Review Request 65605: RANGER-1979: Upgrade Spring-LDAP to 2.3.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65605/#review197353 --- Ship it! Ship It! - pengjianhua On 二月 12, 2018, 12:13 p.m

Re: Review Request 65387: RANGER-1965 - Prevent NPE on decrypting a null password

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65387/#review196506 --- Ship it! Ship It! - pengjianhua On 一月 29, 2018, 4:19 p.m

Re: Review Request 63659: The exception infomation print error for RangerPolicyServiceBase.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63659/#review194502 --- Ship it! Ship It! - pengjianhua On 十一月 8, 2017, 8:29 a.m

Review Request 64764: RANGER-1941:Use already defined methods and optimized log printing in RangerScriptExecutionContext class

/RangerScriptExecutionContext.java 0c8df41 Diff: https://reviews.apache.org/r/64764/diff/1/ Testing --- Tested it. Thanks, pengjianhua

Re: Review Request 64723: Ranger tagsync should process ENTITY_CREATE notification, to support Atlas import feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64723/#review194289 --- Ship it! Ship It! - pengjianhua On 十二月 19, 2017, 9:07 p.m

Re: Review Request 64634: RANGER-1929:The ranger should support the View policy.

> On 十二月 19, 2017, 11:14 a.m., Colm O hEigeartaigh wrote: > > Looks good thanks, but please see Vel's comments on the JIRA. Ok. I had fixed it according to Vel's comments. Please get it from https://reviews.apache.org/r/64634/diff/5/. Thanks. - pe

Re: Review Request 64634: RANGER-1929:The ranger should support the View policy.

/ Changes: https://reviews.apache.org/r/64634/diff/4-5/ Testing --- Thanks, pengjianhua

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

> On 十二月 19, 2017, 11:53 a.m., Colm O hEigeartaigh wrote: > > Better to have "!tokens.isEmpty()" than "tokens.size() > 0". Also, the > > indentation inside the if statement is wrong "if (providerName == null) {". Hi,

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

d ArrayIndexOutOfBoundsException. Diffs (updated) - agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java b095000 Diff: https://reviews.apache.org/r/64677/diff/3/ Changes: https://reviews.apache.org/r/64677/diff/2-3/ Testing --- Tested it. Thanks, pengjianhua

Re: Review Request 64634: RANGER-1929:The ranger should support the View policy.

/RangerPolicyDetail_tmpl.html PRE-CREATION Diff: https://reviews.apache.org/r/64634/diff/4/ Testing --- Thanks, pengjianhua

Re: Review Request 64634: RANGER-1929:The ranger should support preview policy.

> On 十二月 18, 2017, 4:20 p.m., Colm O hEigeartaigh wrote: > > Looks pretty good to me. Could you remove the whitespace errors from the > > patch? Ok. I had fixed it. Please get it from https://reviews.apache.org/r/64634/diff/4/. Thanks.

Re: Review Request 64634: RANGER-1929:The ranger should support preview policy.

/ Changes: https://reviews.apache.org/r/64634/diff/3-4/ Testing --- Thanks, pengjianhua

Re: Review Request 64634: RANGER-1929:The ranger should support preview policy.

/ Changes: https://reviews.apache.org/r/64634/diff/2-3/ Testing --- Thanks, pengjianhua

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

gt; Please modify tokens.size() > 1 to tokens.size() > 0 Ok, I had updated the patch ,please review again. - pengjianhua --- This is an automatically generated e-mail. To reply, visit: htt

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

if (name != null && !name.isEmpty()) { setName(name); }" " public void setName(String name) { providerName = name; }" So. add the following code segment."if (tokens.size() > 1)" is

Re: Review Request 63756: RANGER-1738 - RangerYarnAuthorizer not compatible with Hadoop-3.0.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63756/#review194049 --- This is a good idea. +1 - pengjianhua On 十一月 13, 2017, 2:55

Re: Review Request 64640: RANGER-1932:After create the service of yarndev, the policy named 'all-queue' created for the default user should have all the permissions.However, this policy does't take e

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64640/#review194048 --- Ship it! Ship It! - pengjianhua On 十二月 15, 2017, 5:27 a.m

Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

Diffs - agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java b095000 Diff: https://reviews.apache.org/r/64677/diff/1/ Testing --- Tested it. Thanks, pengjianhua

Re: Review Request 64634: RANGER-1929:The ranger should support preview policy.

/ Changes: https://reviews.apache.org/r/64634/diff/1-2/ Testing --- Thanks, pengjianhua

Review Request 64634: RANGER-1929:The ranger should support preview policy.

security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION Diff: https://reviews.apache.org/r/64634/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 64525: RANGER-1924:Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml

also works fine after removing gson.jar Diffs - hdfs-agent/pom.xml 0b6773d hive-agent/pom.xml c195443 src/main/assembly/hdfs-agent.xml 5279a9a src/main/assembly/hive-agent.xml ca65c80 Diff: https://reviews.apache.org/r/64525/diff/2/ Testing --- Tested it. Thanks, pengjianhua

Re: Review Request 64525: RANGER-1924:Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml

://reviews.apache.org/r/64525/diff/2/ Changes: https://reviews.apache.org/r/64525/diff/1-2/ Testing --- Tested it. Thanks, pengjianhua

Re: Review Request 64529: RANGER-1925:Remove invalid code from plugin script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64529/#review193520 --- Ship it! Ship It! - pengjianhua On 十二月 12, 2017, 9:29 a.m

Re: Review Request 64409: RANGER-1920 - Remove SOLR dependencies from the KMS service + plugins

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64409/#review193519 --- Ship it! Ship It! - pengjianhua On 十二月 7, 2017, 12:40 p.m

Re: Review Request 64500: RANGER-1923 - Simplify Hive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64500/#review193518 --- Ship it! Ship It! - pengjianhua On 十二月 11, 2017, 11:36 a.m

Re: Review Request 64447: RANGER-1922 - Simplify HBase dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64447/#review193517 --- Ship it! Ship It! - pengjianhua On 十二月 8, 2017, 12:38 p.m

Review Request 64525: RANGER-1924:Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml

. Result: the ranger-hdfs plugin also works fine after removing gson.jar. Diffs - src/main/assembly/hdfs-agent.xml 5279a9a Diff: https://reviews.apache.org/r/64525/diff/1/ Testing --- Tested it. Thanks, pengjianhua

Review Request 64404: RANGER-1918:Optimize logic and remove unnecessary temporary variables in YarnClient.class

;String errMsg = errMessage;" just use errMessage is better practice. Diffs - plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java b61a07e Diff: https://reviews.apache.org/r/64404/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 63182: RANGER-1849 - Remove PasswordGenerator and FileStoreUtil

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63182/#review193079 --- Ship it! Ship It! - pengjianhua On 十一月 16, 2017, 12:18 p.m

Re: Review Request 64051: RANGER-1906 - Simplify Atlas plugin dependency management

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64051/#review193078 --- Ship it! Ship It! - pengjianhua On 十一月 28, 2017, 11:44 a.m

Re: Review Request 64375: RANGER-1917 - Remove solr dependency from Kafka + Sqoop modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64375/#review193069 --- Ship it! Ship It! - pengjianhua On 十二月 6, 2017, 12:37 p.m

Review Request 64365: RANGER-1916:Remove duplicate code and optimize code in AtlasClient.class

uot;AtlasClient atlasClient = null;" Diffs - plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java 857df87 Diff: https://reviews.apache.org/r/64365/diff/1/ Testing --- Tested it. Thanks, pengjianhua

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

> On 十一月 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > <https://reviews.apache.org/r/62495/diff/2/?file=1850092#file1850092line212> > > > > @PengJianhua, > > I used attach

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

> On 十一月 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > <https://reviews.apache.org/r/62495/diff/2/?file=1850092#file1850092line212> > > > > @PengJianhua, > > I used attach

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

/main/assembly/admin-web.xml aa37426f src/main/assembly/kms.xml 7c40ce4e Diff: https://reviews.apache.org/r/62495/diff/5/ Changes: https://reviews.apache.org/r/62495/diff/4-5/ Testing --- Thanks, pengjianhua

Review Request 64323: RANGER-1915:Optimize the code and keep the code style consistent in the RangerAdminRESTClient class

://reviews.apache.org/r/64323/diff/1/ Testing --- Tested it. Thanks, pengjianhua

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

> On 十一月 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > <https://reviews.apache.org/r/62495/diff/2/?file=1850092#file1850092line212> > > > > @PengJianhua, > > I used attach

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

Diff: https://reviews.apache.org/r/62495/diff/4/ Changes: https://reviews.apache.org/r/62495/diff/3-4/ Testing --- Thanks, pengjianhua

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

> On 十一月 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > <https://reviews.apache.org/r/62495/diff/2/?file=1850092#file1850092line212> > > > > @PengJianhua, > > I used attach

Review Request 64293: RANGER-1914:Modify crypt_algo_array.length to avoid java.lang.ArrayIndexOutOfBoundsException in PasswordUtils.class

length > 4)". Diffs - agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35 Diff: https://reviews.apache.org/r/64293/diff/1/ Testing --- Tested it. Thanks, pengjianhua

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

> On 十一月 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > <https://reviews.apache.org/r/62495/diff/2/?file=1850092#file1850092line212> > > > > @PengJianhua, > > I used attach

  1   2   3   4   >