Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/#review225785 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 25, 2023,

Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/ --- (Updated Sept. 25, 2023, 7:34 p.m.) Review request for ranger and madhan.

Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/ --- (Updated Sept. 25, 2023, 7:02 p.m.) Review request for ranger and madhan.

Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/ --- (Updated Sept. 22, 2023, 5:46 p.m.) Review request for ranger and madhan.

Re: Review Request 74609: RANGER-4234

> On Sept. 21, 2023, 4:06 p.m., Madhan Neethiraj wrote: > > Barbara - the recent update to the review doesn't include the changes. Can > > you please update again? > > Barbara Eckman wrote: > Yes, I apologize. I'm having trouble generating a new patch: > % git format-patch

Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/ --- (Updated Sept. 22, 2023, 3:43 p.m.) Review request for ranger and madhan.

Re: Review Request 74609: RANGER-4234

> On Sept. 21, 2023, 4:06 p.m., Madhan Neethiraj wrote: > > Barbara - the recent update to the review doesn't include the changes. Can > > you please update again? Yes, I apologize. I'm having trouble generating a new patch: % git format-patch origin/master

Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/#review225776 --- Barbara - the recent update to the review doesn't include the

Re: Review Request 74609: RANGER-4234

> On Sept. 18, 2023, 9:55 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > > Lines 1783 (patched) > > > > > > Can this validation/rewrite be moved out

Re: Review Request 74609: RANGER-4234

> On Sept. 18, 2023, 9:55 p.m., Madhan Neethiraj wrote: > > agents-common/pom.xml > > Line 43 (original), 43 (patched) > > > > > > Is this update necessary? pom.xml for other Ranger modulues have > > relativePath as

Re: Review Request 74609: RANGER-4234

> On Sept. 18, 2023, 6:18 p.m., Don Bosco Durai wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEdits.java > > Lines 51 (patched) > > > > > > I hope this won't throw an out of bound

Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/#review225769 --- agents-common/pom.xml Line 43 (original), 43 (patched)

Re: Review Request 74609: RANGER-4234

> On Sept. 18, 2023, 6:18 p.m., Don Bosco Durai wrote: > > Sorry, I uploaded diff 2 twice. there's no difference between diff 2 and 3. > On Sept. 18, 2023, 6:18 p.m., Don Bosco Durai wrote: > > agents-common/pom.xml > > Line 20 (original), 20 (patched) > >

Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/ --- (Updated Sept. 18, 2023, 8:36 p.m.) Review request for ranger and madhan.

Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/ --- (Updated Sept. 18, 2023, 8:31 p.m.) Review request for ranger and madhan.

Re: Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/#review225767 --- agents-common/pom.xml Line 20 (original), 20 (patched)

Review Request 74609: RANGER-4234

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/ --- Review request for ranger and madhan. Repository: ranger Description ---