Re: RiverClassLoaderSPI

2012-11-10 Thread Simon IJskes - QCG
On 10-11-12 00:07, Peter Firmstone wrote: tried developing experimental code directly in trunk unsuccessfully. I think we need to clarify our development processes. Lightweight. Only commit code that compiles. (s)he who breaks the build fixes the build. idem testing. No jumbo patches. No ju

Re: RiverClassLoaderSPI

2012-11-09 Thread Peter Firmstone
Simon IJskes - QCG wrote: On 09-11-12 13:48, Peter Firmstone wrote: Simon IJskes - QCG wrote: On 09-11-12 00:31, Peter Firmstone wrote: Ok, because it's small I think we can consider it, can you provide the hooks to load different providers? The non default providers themselves can be a subp

Re: RiverClassLoaderSPI

2012-11-09 Thread Peter Firmstone
Simon IJskes - QCG wrote: On 09-11-12 13:49, Peter Firmstone wrote: Simon IJskes - QCG wrote: On 09-11-12 11:44, Peter Firmstone wrote: Motivated by Sim's suggestions: Any objection to changing it to net.jini.io.MarshalClassResolverSPI? Leave it near net.jini.loader.ClassLoading. I would ha

Re: RiverClassLoaderSPI

2012-11-09 Thread Simon IJskes - QCG
On 09-11-12 13:48, Peter Firmstone wrote: Simon IJskes - QCG wrote: On 09-11-12 00:31, Peter Firmstone wrote: Ok, because it's small I think we can consider it, can you provide the hooks to load different providers? The non default providers themselves can be a subproject. We need to carefull

Re: RiverClassLoaderSPI

2012-11-09 Thread Simon IJskes - QCG
On 09-11-12 13:49, Peter Firmstone wrote: Simon IJskes - QCG wrote: On 09-11-12 11:44, Peter Firmstone wrote: Motivated by Sim's suggestions: Any objection to changing it to net.jini.io.MarshalClassResolverSPI? Leave it near net.jini.loader.ClassLoading. I would have implemented it in ClassL

Re: RiverClassLoaderSPI

2012-11-09 Thread Peter Firmstone
Simon IJskes - QCG wrote: On 09-11-12 11:44, Peter Firmstone wrote: Motivated by Sim's suggestions: Any objection to changing it to net.jini.io.MarshalClassResolverSPI? Leave it near net.jini.loader.ClassLoading. I would have implemented it in ClassLoading if i wasn't concerned about leaving

Re: RiverClassLoaderSPI

2012-11-09 Thread Peter Firmstone
Simon IJskes - QCG wrote: On 09-11-12 00:31, Peter Firmstone wrote: Ok, because it's small I think we can consider it, can you provide the hooks to load different providers? The non default providers themselves can be a subproject. We need to carefully consider security since we're making it p

Re: RiverClassLoaderSPI

2012-11-09 Thread Peter Firmstone
Dan Creswell wrote: One thing... On 9 November 2012 10:44, Peter Firmstone wrote: Motivated by Sim's suggestions: Any objection to changing it to net.jini.io.**MarshalClassResolverSPI? This places it right where it's needed. Since all URI in a code base string will reside in one ClassLo

Re: RiverClassLoaderSPI

2012-11-09 Thread Simon IJskes - QCG
On 09-11-12 11:44, Peter Firmstone wrote: Motivated by Sim's suggestions: Any objection to changing it to net.jini.io.MarshalClassResolverSPI? Leave it near net.jini.loader.ClassLoading. I would have implemented it in ClassLoading if i wasn't concerned about leaving mature classes untouched.

Re: RiverClassLoaderSPI

2012-11-09 Thread Dan Creswell
One thing... On 9 November 2012 10:44, Peter Firmstone wrote: > Motivated by Sim's suggestions: > > Any objection to changing it to net.jini.io.**MarshalClassResolverSPI? > > This places it right where it's needed. > > Since all URI in a code base string will reside in one ClassLoader, all > cla

Re: RiverClassLoaderSPI

2012-11-09 Thread Peter Firmstone
Motivated by Sim's suggestions: Any objection to changing it to net.jini.io.MarshalClassResolverSPI? This places it right where it's needed. Since all URI in a code base string will reside in one ClassLoader, all classes in that ClassLoader must use the same provider. For instance an osgi:,

Re: RiverClassLoaderSPI

2012-11-08 Thread Simon IJskes - QCG
On 09-11-12 00:31, Peter Firmstone wrote: Ok, because it's small I think we can consider it, can you provide the hooks to load different providers? The non default providers themselves can be a subproject. We need to carefully consider security since we're making it possible for downloaded code

Re: RiverClassLoaderSPI

2012-11-08 Thread Peter Firmstone
Simon IJskes - QCG wrote: On 08-11-12 13:40, Peter Firmstone wrote: Yes, but lets play around with it in skunk. Dan's made some valid Indeed Dan has made valid remarks, but i really dont like skunk. Tom suggested sub projects once. I did not see any benefits at that time. But i think it mi

Re: RiverClassLoaderSPI

2012-11-08 Thread Simon IJskes - QCG
You are probably aiming at a scheme based dispatching of classloader URI. Cool feature! Shall we put this in an implementation of RiverClassLoaderSpi? i meant, deriving, extending.

Re: RiverClassLoaderSPI

2012-11-08 Thread Greg Trasuk
I like the sub-projects idea. Greg. Jini Technology Starter Kit - Our current deliverable. On Thu, 2012-11-08 at 08:12, Simon IJskes - QCG wrote: > On 08-11-12 13:40, Peter Firmstone wrote: > > > Yes, but lets play around with it in skunk. Dan's made some valid > > Indeed Dan has made valid

Re: RiverClassLoaderSPI

2012-11-08 Thread Dan Creswell
ed environment? >>> >> >> You are probably aiming at a scheme based dispatching of classloader URI. >> Cool feature! Shall we put this in an implementation of RiverClassLoaderSpi? >> >> schemes like: maven:, system:, http:, codeservice: spring to mind. >> >&

Re: RiverClassLoaderSPI

2012-11-08 Thread Dan Creswell
On 8 November 2012 13:12, Simon IJskes - QCG wrote: > On 08-11-12 13:40, Peter Firmstone wrote: > > Yes, but lets play around with it in skunk. Dan's made some valid >> > > Indeed Dan has made valid remarks, but i really dont like skunk. Tom > suggested sub projects once. I did not see any bene

Re: RiverClassLoaderSPI

2012-11-08 Thread Simon IJskes - QCG
On 08-11-12 13:40, Peter Firmstone wrote: Yes, but lets play around with it in skunk. Dan's made some valid Indeed Dan has made valid remarks, but i really dont like skunk. Tom suggested sub projects once. I did not see any benefits at that time. But i think it might be helpful right now.

Re: RiverClassLoaderSPI

2012-11-08 Thread Peter Firmstone
feature! Shall we put this in an implementation of RiverClassLoaderSpi? schemes like: maven:, system:, http:, codeservice: spring to mind. Yes, but lets play around with it in skunk. Dan's made some valid points, I think we should use the simple implementation for now that solves the imme

Re: RiverClassLoaderSPI

2012-11-08 Thread Simon IJskes - QCG
On 08-11-12 12:19, Dan Creswell wrote: I don't want to be harsh but as a group we seemingly spend a lot of time thinking about all sorts of cool things we could do given we've already done this or that other thing. How about we do a few small steps in some promising (like valuable to our commun

Re: RiverClassLoaderSPI

2012-11-08 Thread Simon IJskes - QCG
implementation of RiverClassLoaderSpi? schemes like: maven:, system:, http:, codeservice: spring to mind.

Re: RiverClassLoaderSPI

2012-11-08 Thread Dan Creswell
On 8 November 2012 10:51, Peter Firmstone wrote: > I've been quite busy lately so haven't been able to contribute much to > discussion. > > However I've some thoughts on RMIClassLoaderSPI / RiverClassLoaderSPI / > CodebaseAccessClassLoader and finally ha

RiverClassLoaderSPI

2012-11-08 Thread Peter Firmstone
I've been quite busy lately so haven't been able to contribute much to discussion. However I've some thoughts on RMIClassLoaderSPI / RiverClassLoaderSPI / CodebaseAccessClassLoader and finally had some time to write them down. Notably RiverClassLoaderSPI solves t

Re: RiverClassLoaderSpi

2012-10-27 Thread Gregg Wonderly
On 10/27/2012 3:31 AM, Simon IJskes - QCG wrote: On 26-10-12 23:49, Gregg Wonderly wrote: I wonder if Peter pulled it out when some of the other stuff he was pushing into the build created some problems late last year? Humm, it should be in there. I will take a look at it. I've taken a short

Re: RiverClassLoaderSpi

2012-10-27 Thread Peter
- Original message - > The problem with RMIClassLoaderSPI is that you can't replace it's > implementation > except through the use of command line property values.  This is not a > workable > solution for many different reasons in many different environments.  So, just > putting in Codeb

Re: RiverClassLoaderSpi

2012-10-27 Thread Simon IJskes - QCG
On 26-10-12 23:49, Gregg Wonderly wrote: I wonder if Peter pulled it out when some of the other stuff he was pushing into the build created some problems late last year? Humm, it should be in there. I will take a look at it. I've taken a shortcut, and reduced the impact a little bit. Is a Sp

Re: RiverClassLoaderSpi

2012-10-26 Thread Simon IJskes - QCG
On 26-10-12 23:49, Gregg Wonderly wrote: The problem with RMIClassLoaderSPI is that you can't replace it's implementation except through the use of command line property values. This is not a workable solution for many different reasons in many different environments. So, just putting in Codeba

Re: RiverClassLoaderSpi

2012-10-26 Thread Gregg Wonderly
The problem with RMIClassLoaderSPI is that you can't replace it's implementation except through the use of command line property values. This is not a workable solution for many different reasons in many different environments. So, just putting in CodebaseAccessClassLoader as it sits, should

Re: RiverClassLoaderSpi

2012-10-26 Thread Simon IJskes - QCG
On 26-10-12 17:41, Gregg Wonderly wrote: I believe the patches shown there have been put in place now have they not? Peter was working on this a while back, and I thought that I'm not sure. Could you check? I've in the mean time implemented the Spi, and it works for me. I was bitten by the ex

Re: RiverClassLoaderSpi

2012-10-26 Thread Gregg Wonderly
I believe the patches shown there have been put in place now have they not? Peter was working on this a while back, and I thought that as least one person had put the changes into place for his private code base so that he could now trivially integrate with a JavaEE container. What I did was a

Re: RiverClassLoaderSpi

2012-10-26 Thread Simon IJskes - QCG
On 26-10-12 01:07, Simon IJskes - QCG wrote: On 26-10-12 00:56, Greg Trasuk wrote: Isn't there already java.rmi.server.RMIClassLoaderSpi that net.jini.loader.pref.PreferredClassProvider implements? What would a River-specific provider interface add? RMIClassLoaderSpi is used for instance in

Re: RiverClassLoaderSpi

2012-10-25 Thread Simon IJskes - QCG
On 26-10-12 00:56, Greg Trasuk wrote: Isn't there already java.rmi.server.RMIClassLoaderSpi that net.jini.loader.pref.PreferredClassProvider implements? What would a River-specific provider interface add? RMIClassLoaderSpi is used for instance in java webstart (javafx) to initialize if with

Re: RiverClassLoaderSpi

2012-10-25 Thread Greg Trasuk
Isn't there already java.rmi.server.RMIClassLoaderSpi that net.jini.loader.pref.PreferredClassProvider implements? What would a River-specific provider interface add? Cheers, Greg. On Thu, 2012-10-25 at 18:36, Simon IJskes - QCG wrote: > Anybody objects, is interested in a RiverClassL

RiverClassLoaderSpi

2012-10-25 Thread Simon IJskes - QCG
Anybody objects, is interested in a RiverClassLoaderSpi that makes it possible to intercept calls to the RMIClassLoader ?