[GitHub] [rocketmq] Jason918 commented on pull request #3337: [ISSUE #3359] Add function--Custom delay time

2021-10-01 Thread GitBox
Jason918 commented on pull request #3337: URL: https://github.com/apache/rocketmq/pull/3337#issuecomment-932673120 It's better to compare this with the solution in #2290 to see in what situation this approach fits better. -- This is an automated message from the Apache Git Service.

[GitHub] [rocketmq] liuxuzxx commented on a change in pull request #3386: [ISSUE #3369]Feature/enhancement fix illegal json by fastjson lx

2021-10-01 Thread GitBox
liuxuzxx commented on a change in pull request #3386: URL: https://github.com/apache/rocketmq/pull/3386#discussion_r720616493 ## File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java ## @@ -17,11 +17,17 @@ package

[GitHub] [rocketmq] lizhanhui commented on a change in pull request #3386: [ISSUE #3369]Feature/enhancement fix illegal json by fastjson lx

2021-10-01 Thread GitBox
lizhanhui commented on a change in pull request #3386: URL: https://github.com/apache/rocketmq/pull/3386#discussion_r720615560 ## File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java ## @@ -17,11 +17,17 @@ package

[GitHub] [rocketmq] lizhanhui commented on a change in pull request #3386: [ISSUE #3369]Feature/enhancement fix illegal json by fastjson lx

2021-10-01 Thread GitBox
lizhanhui commented on a change in pull request #3386: URL: https://github.com/apache/rocketmq/pull/3386#discussion_r720614648 ## File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java ## @@ -17,11 +17,17 @@ package

[GitHub] [rocketmq] lizhanhui commented on a change in pull request #3386: [ISSUE #3369]Feature/enhancement fix illegal json by fastjson lx

2021-10-01 Thread GitBox
lizhanhui commented on a change in pull request #3386: URL: https://github.com/apache/rocketmq/pull/3386#discussion_r720614648 ## File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java ## @@ -17,11 +17,17 @@ package

[GitHub] [rocketmq] liuxuzxx commented on issue #3389: The json-style of body in the message is illegal, because of the default settings for fastjson

2021-10-01 Thread GitBox
liuxuzxx commented on issue #3389: URL: https://github.com/apache/rocketmq/issues/3389#issuecomment-932667368 如果你在toJSON的时候,加入了SerializerFeature.WriteNonStringKeyAsString,那么你也需要在parsexxx系列方法加上这个配置,否则可能会出现问题! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [rocketmq] liuxuzxx commented on a change in pull request #3386: [ISSUE #3369]Feature/enhancement fix illegal json by fastjson lx

2021-10-01 Thread GitBox
liuxuzxx commented on a change in pull request #3386: URL: https://github.com/apache/rocketmq/pull/3386#discussion_r720612937 ## File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java ## @@ -17,11 +17,17 @@ package

[GitHub] [rocketmq] liuxuzxx commented on issue #3389: The json-style of body in the message is illegal, because of the default settings for fastjson

2021-10-01 Thread GitBox
liuxuzxx commented on issue #3389: URL: https://github.com/apache/rocketmq/issues/3389#issuecomment-932666738 > I have tried to implement some functions for [rocketmq-client-go](https://github.com/apache/rocketmq-client-go), and I got a illgal json-style body for the response of broker

[GitHub] [rocketmq] liuxuzxx commented on a change in pull request #3386: [ISSUE #3369]Feature/enhancement fix illegal json by fastjson lx

2021-10-01 Thread GitBox
liuxuzxx commented on a change in pull request #3386: URL: https://github.com/apache/rocketmq/pull/3386#discussion_r720612184 ## File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java ## @@ -17,11 +17,17 @@ package

[GitHub] [rocketmq-apis] lizhanhui commented on a change in pull request #1: Init first draft version of rocketmq new apis

2021-10-01 Thread GitBox
lizhanhui commented on a change in pull request #1: URL: https://github.com/apache/rocketmq-apis/pull/1#discussion_r720611926 ## File path: apache/rocketmq/v1/service.proto ## @@ -0,0 +1,382 @@ +syntax = "proto3"; + +import "google/protobuf/duration.proto"; +import

[GitHub] [rocketmq] liuxuzxx commented on a change in pull request #3386: [ISSUE #3369]Feature/enhancement fix illegal json by fastjson lx

2021-10-01 Thread GitBox
liuxuzxx commented on a change in pull request #3386: URL: https://github.com/apache/rocketmq/pull/3386#discussion_r720611791 ## File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java ## @@ -17,11 +17,17 @@ package

[GitHub] [rocketmq-apis] lizhanhui commented on a change in pull request #1: Init first draft version of rocketmq new apis

2021-10-01 Thread GitBox
lizhanhui commented on a change in pull request #1: URL: https://github.com/apache/rocketmq-apis/pull/1#discussion_r720611378 ## File path: README.md ## @@ -1 +1,13 @@ -# rocketmq-apis +## Overview + +## Extension Spec + +## Message Model + +## Producer Flow + +## Consumer

[GitHub] [rocketmq-apis] zhouxinyu commented on a change in pull request #1: Init first draft version of rocketmq new apis

2021-10-01 Thread GitBox
zhouxinyu commented on a change in pull request #1: URL: https://github.com/apache/rocketmq-apis/pull/1#discussion_r720611014 ## File path: apache/rocketmq/v1/definition.proto ## @@ -0,0 +1,311 @@ +syntax = "proto3"; + +import "google/protobuf/timestamp.proto"; +import

[GitHub] [rocketmq-apis] zhouxinyu commented on pull request #1: Init first draft version of rocketmq new apis

2021-10-01 Thread GitBox
zhouxinyu commented on pull request #1: URL: https://github.com/apache/rocketmq-apis/pull/1#issuecomment-932664582 > Why don't we put this in the [rocketmq](https://github.com/apache/rocketmq) repo? It seems like a better option OK, we can consider move it to the main repo or add

[GitHub] [rocketmq] lizhanhui commented on a change in pull request #3386: [ISSUE #3369]Feature/enhancement fix illegal json by fastjson lx

2021-10-01 Thread GitBox
lizhanhui commented on a change in pull request #3386: URL: https://github.com/apache/rocketmq/pull/3386#discussion_r716633768 ## File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java ## @@ -17,11 +17,17 @@ package

[GitHub] [rocketmq-apis] lizhanhui commented on a change in pull request #1: Init first draft version of rocketmq new apis

2021-10-01 Thread GitBox
lizhanhui commented on a change in pull request #1: URL: https://github.com/apache/rocketmq-apis/pull/1#discussion_r720610289 ## File path: apache/rocketmq/v1/definition.proto ## @@ -0,0 +1,311 @@ +syntax = "proto3"; + +import "google/protobuf/timestamp.proto"; +import

[GitHub] [rocketmq] duhenglucky commented on issue #3390: I want to participate in the development of 5.0

2021-10-01 Thread GitBox
duhenglucky commented on issue #3390: URL: https://github.com/apache/rocketmq/issues/3390#issuecomment-932640243 The community is planning to establish a 5.0 SIG. This SIG will not be as focused as other SIGs, but will help everyone find their areas of interest and participate in the

[GitHub] [rocketmq-apis] duhenglucky commented on pull request #1: Init first draft version of rocketmq new apis

2021-10-01 Thread GitBox
duhenglucky commented on pull request #1: URL: https://github.com/apache/rocketmq-apis/pull/1#issuecomment-932627455 Why don't we put this in the [rocketmq](https://github.com/apache/rocketmq) repo? It seems like a better option -- This is an automated message from the Apache Git

[GitHub] [rocketmq] Jason918 commented on issue #3378: Is it risky to run with jdk 11 ?

2021-10-01 Thread GitBox
Jason918 commented on issue #3378: URL: https://github.com/apache/rocketmq/issues/3378#issuecomment-932223961 > rocketmq server is completely compatible with jdk11, and we have already run it with jdk11 in production. Can you help run the unit test above? I am not sure if it's

Re: RIP 24: Introduce multi-protocol support

2021-10-01 Thread yukon
We have drafted the new rocketmq protocol and APIs, any feedback is welcome. Please refer https://github.com/apache/rocketmq-apis/pull/1/files for more details. Regards On Fri, Oct 1, 2021 at 9:40 AM yukon wrote: > Hello, community, > > Any further opinions about this RIP? If not, we would

[GitHub] [rocketmq] zhouxinyu commented on issue #3390: I want to participate in the development of 5.0

2021-10-01 Thread GitBox
zhouxinyu commented on issue #3390: URL: https://github.com/apache/rocketmq/issues/3390#issuecomment-932144460 We have some discussions about the RIPs of RocketMQ 5.0, welcome subscribe to our mailing lists(https://rocketmq.apache.org/about/contact/) for more details. We are looking

[GitHub] [rocketmq] zhouxinyu closed issue #3390: I want to participate in the development of 5.0

2021-10-01 Thread GitBox
zhouxinyu closed issue #3390: URL: https://github.com/apache/rocketmq/issues/3390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] RongtongJin closed issue #3388: HA may not avaiable when slave's commitLog not match master

2021-10-01 Thread GitBox
RongtongJin closed issue #3388: URL: https://github.com/apache/rocketmq/issues/3388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] RongtongJin commented on issue #3388: HA may not avaiable when slave's commitLog not match master

2021-10-01 Thread GitBox
RongtongJin commented on issue #3388: URL: https://github.com/apache/rocketmq/issues/3388#issuecomment-932057774 > Before start up the slave,check the commigLog data is correctly by manual is inconvenient to execute 。From the machine of slave broke down to it repaired,we did not modify

[GitHub] [rocketmq-spring] RongtongJin closed issue #396: support namespace

2021-10-01 Thread GitBox
RongtongJin closed issue #396: URL: https://github.com/apache/rocketmq-spring/issues/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-spring] RongtongJin commented on issue #396: support namespace

2021-10-01 Thread GitBox
RongtongJin commented on issue #396: URL: https://github.com/apache/rocketmq-spring/issues/396#issuecomment-932055191 Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [rocketmq-spring] RongtongJin merged pull request #397: [ISSUE #396]support namespace

2021-10-01 Thread GitBox
RongtongJin merged pull request #397: URL: https://github.com/apache/rocketmq-spring/pull/397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] RongtongJin closed issue #3391: Probably,LatencyFaultToleranceImpl#pickOneAtLeast result isn't first one When latency items size great to 3.

2021-10-01 Thread GitBox
RongtongJin closed issue #3391: URL: https://github.com/apache/rocketmq/issues/3391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: