[GitHub] [rocketmq] duhenglucky commented on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
duhenglucky commented on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526465219 @jimgreen2013 yep, RocketMQ 4.3.0 version changed the default "TBW102" value, this will lead to some compatibility issues and it is recommended

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526454166 hi~ @RongtongJin @vongosling @duhenglucky thanks for your help~ I have do some tests Here is the result: ### test case1 * br

[GitHub] [rocketmq] jimgreen2013 commented on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 commented on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526454166 hi~ @RongtongJin @vongosling @duhenglucky thanks for your help~ I have do some tests Here is the result: ### test case1 * broker ve

[GitHub] [rocketmq] RongtongJin commented on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
RongtongJin commented on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526444783 hi~ @jimgreen2013 1. As far as I know, if broker does not set `autoCreateTopicEnable = true`, the new modification will still return `No rou

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526440358 hi~ @RongtongJin your code have been merged to branch develop, i'd like to test your improvement with client version 4.3.0 and see wh

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526440358 hi~ @RongtongJin your code have been merged to branch develop, i'd like to test your improvement with client version 4.3.0 and see wh

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526440358 hi~ @RongtongJin your code have been merged to branch develop, i'd like to test your improvement with client version 4.3.0 and see wh

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526440358 hi~ @RongtongJin your code have been merged to branch develop, i'd like to test your improvement with client version 4.3.0 and see wh

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526440358 hi~ @RongtongJin your code have been merged to branch develop, i'd like to test your improvement with client version 4.3.0 and see wh

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526440358 hi~ @RongtongJin your code have been merged to branch develop, i'd like to test your improvement with client version 4.3.0 and see wh

[GitHub] [rocketmq-ons] duhenglucky merged pull request #8: Add pull consumer interface and polished Admin interface

2019-08-29 Thread GitBox
duhenglucky merged pull request #8: Add pull consumer interface and polished Admin interface URL: https://github.com/apache/rocketmq-ons/pull/8 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [rocketmq] jimgreen2013 commented on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 commented on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526440358 hi~ @RongtongJin your code have been merged to branch develop, i'd like to test your improvement with client version 4.3.0 and see what will

[GitHub] [rocketmq-spring] ShannonDing commented on issue #129: [ISSUE #103] support resolvePlaceholders for selectorExpression

2019-08-29 Thread GitBox
ShannonDing commented on issue #129: [ISSUE #103] support resolvePlaceholders for selectorExpression URL: https://github.com/apache/rocketmq-spring/pull/129#issuecomment-526436220 Ref ISSUE #103 This is an automated message

[GitHub] [rocketmq-spring] duhenglucky opened a new pull request #137: Upgrade rocketmq dependency to 4.5.2

2019-08-29 Thread GitBox
duhenglucky opened a new pull request #137: Upgrade rocketmq dependency to 4.5.2 URL: https://github.com/apache/rocketmq-spring/pull/137 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checkl

[GitHub] [rocketmq-client-go] ShannonDing commented on a change in pull request #181: [ISSUE #180]add tag filter example.

2019-08-29 Thread GitBox
ShannonDing commented on a change in pull request #181: [ISSUE #180]add tag filter example. URL: https://github.com/apache/rocketmq-client-go/pull/181#discussion_r319336000 ## File path: consumer/consumer.go ## @@ -799,10 +799,10 @@ func (dc *defaultConsumer) processPullRe

[GitHub] [rocketmq-client-go] ShannonDing commented on a change in pull request #181: [ISSUE #180]add tag filter example.

2019-08-29 Thread GitBox
ShannonDing commented on a change in pull request #181: [ISSUE #180]add tag filter example. URL: https://github.com/apache/rocketmq-client-go/pull/181#discussion_r319336000 ## File path: consumer/consumer.go ## @@ -799,10 +799,10 @@ func (dc *defaultConsumer) processPullRe

[GitHub] [rocketmq-spring] chinaTLJ commented on issue #135: on right, in Maven projects, some dependencies is red

2019-08-29 Thread GitBox
chinaTLJ commented on issue #135: on right,in Maven projects,some dependencies is red URL: https://github.com/apache/rocketmq-spring/issues/135#issuecomment-526428315 就是下了这个项目, ![image](https://user-images.githubusercontent.com/17891721/63988448-eac0df00-cb0e-11e9-924e-4ca3bdeb373c.png)

[GitHub] [rocketmq] coveralls edited a comment on issue #1431: Fix thread unsafe issue in `ConsumerFilterManager`

2019-08-29 Thread GitBox
coveralls edited a comment on issue #1431: Fix thread unsafe issue in `ConsumerFilterManager` URL: https://github.com/apache/rocketmq/pull/1431#issuecomment-526423931 [![Coverage Status](https://coveralls.io/builds/25435516/badge)](https://coveralls.io/builds/25435516) Coverage

Re: [RESTART][VOTE][#1] Release Apache RocketMQ Client CPP 1.2.3 RC2.

2019-08-29 Thread Yin James
+1 > On Aug 29, 2019, at 19:40, ShannonDing wrote: > > Hello RocketMQ Community, > > This is the vote for version 1.2.3 of Apache RocketMQ Client CPP. > > > > > This release included main futures below: > > Support transaction message. > Support C style batch message sending. > Support get

[GitHub] [rocketmq-spring] RongtongJin commented on issue #135: on right, in Maven projects, some dependencies is red

2019-08-29 Thread GitBox
RongtongJin commented on issue #135: on right,in Maven projects,some dependencies is red URL: https://github.com/apache/rocketmq-spring/issues/135#issuecomment-526423921 Could you please descript this question more detail? What are the dependencies you can't pull?

[GitHub] [rocketmq] coveralls commented on issue #1431: Fix thread unsafe issue in `ConsumerFilterManager`

2019-08-29 Thread GitBox
coveralls commented on issue #1431: Fix thread unsafe issue in `ConsumerFilterManager` URL: https://github.com/apache/rocketmq/pull/1431#issuecomment-526423931 [![Coverage Status](https://coveralls.io/builds/25435358/badge)](https://coveralls.io/builds/25435358) Coverage increas

[GitHub] [rocketmq] zongtanghu commented on issue #1430: [ISSUE#1429]Update Broker's Topic Read or Write Perm failed.

2019-08-29 Thread GitBox
zongtanghu commented on issue #1430: [ISSUE#1429]Update Broker's Topic Read or Write Perm failed. URL: https://github.com/apache/rocketmq/pull/1430#issuecomment-526415472 Hi @duhengforever,@ShannonDing, please help to review this pr.

[GitHub] [rocketmq] coveralls commented on issue #1424: optimize code style

2019-08-29 Thread GitBox
coveralls commented on issue #1424: optimize code style URL: https://github.com/apache/rocketmq/pull/1424#issuecomment-526234875 [![Coverage Status](https://coveralls.io/builds/25423581/badge)](https://coveralls.io/builds/25423581) Coverage decreased (-0.1%) to 50.463% when pulli

[GitHub] [rocketmq] aftersss opened a new pull request #1431: Fix thread unsafe issue in `ConsumerFilterManager`

2019-08-29 Thread GitBox
aftersss opened a new pull request #1431: Fix thread unsafe issue in `ConsumerFilterManager` URL: https://github.com/apache/rocketmq/pull/1431 `ConsumerFilterManager` is not thread safe: `ConsumerFilterManager.clean` may remove entry of filterDataByTopic, when this occur, the following

[RESTART][VOTE][#1] Release Apache RocketMQ Client CPP 1.2.3 RC2.

2019-08-29 Thread ShannonDing
Hello RocketMQ Community, This is the vote for version 1.2.3 of Apache RocketMQ Client CPP. This release included main futures below: Support transaction message. Support C style batch message sending. Support getting error information when C API returns false. Polish the TCP transport layer.

[GitHub] [rocketmq] vongosling commented on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
vongosling commented on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526143660 I will pin this issue util someone gives us some feedback for this improvement. Details see https://github.com/apache/rocketmq/pull/1415 ---

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526080981 hi~ @duhenglucky i am new to rocketmq. RocketMQ is cool and become more and more popular, so i'd like to help you guys to make the *q

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526080981 hi~ @duhenglucky i am new to rocketmq. RocketMQ is cool and become more and more popular, so i'd like to help you guys to make the *q

[GitHub] [rocketmq] coveralls commented on issue #1430: [ISSUE#1429]Update Broker's Topic Read or Write Perm failed.

2019-08-29 Thread GitBox
coveralls commented on issue #1430: [ISSUE#1429]Update Broker's Topic Read or Write Perm failed. URL: https://github.com/apache/rocketmq/pull/1430#issuecomment-526103615 [![Coverage Status](https://coveralls.io/builds/25416705/badge)](https://coveralls.io/builds/25416705) Covera

Still Failing: zongtanghu/rocketmq#109 (update_topic_perm_failed - db77463)

2019-08-29 Thread Travis CI
Build Update for zongtanghu/rocketmq - Build: #109 Status: Still Failing Duration: 16 mins and 18 secs Commit: db77463 (update_topic_perm_failed) Author: huzongtang Message: [ISSUE#1429]Update Broker's Topic Read or Write Perm failed. View the changeset: http

[GitHub] [rocketmq] zongtanghu commented on issue #1377: wipeWritePerm not take effect

2019-08-29 Thread GitBox
zongtanghu commented on issue #1377: wipeWritePerm not take effect URL: https://github.com/apache/rocketmq/issues/1377#issuecomment-526096198 You can look at this pr(https://github.com/apache/rocketmq/pull/1430).This pr will resolve your issue. -

[GitHub] [rocketmq] duhenglucky commented on issue #1429: Update Broker's Topic Read or Write Perm failed

2019-08-29 Thread GitBox
duhenglucky commented on issue #1429: Update Broker's Topic Read or Write Perm failed URL: https://github.com/apache/rocketmq/issues/1429#issuecomment-526096224 repeat with this [issue](https://github.com/apache/rocketmq/issues/1377)

[GitHub] [rocketmq] duhenglucky closed issue #1429: Update Broker's Topic Read or Write Perm failed

2019-08-29 Thread GitBox
duhenglucky closed issue #1429: Update Broker's Topic Read or Write Perm failed URL: https://github.com/apache/rocketmq/issues/1429 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [rocketmq] zongtanghu commented on issue #1429: Update Broker's Topic Read or Write Perm failed

2019-08-29 Thread GitBox
zongtanghu commented on issue #1429: Update Broker's Topic Read or Write Perm failed URL: https://github.com/apache/rocketmq/issues/1429#issuecomment-526095622 This issue will be resolve by this pr(https://github.com/apache/rocketmq/pull/1430) -

[GitHub] [rocketmq] zongtanghu opened a new pull request #1430: [ISSUE#1429]Update Broker's Topic Read or Write Perm failed.

2019-08-29 Thread GitBox
zongtanghu opened a new pull request #1430: [ISSUE#1429]Update Broker's Topic Read or Write Perm failed. URL: https://github.com/apache/rocketmq/pull/1430 ## What is the purpose of the change This pr will resolve the issue that updating broker's topic reading or writing perm fails.

[GitHub] [rocketmq] zongtanghu edited a comment on issue #1279: why nameserver not have acl ?

2019-08-29 Thread GitBox
zongtanghu edited a comment on issue #1279: why nameserver not have acl ? URL: https://github.com/apache/rocketmq/issues/1279#issuecomment-526089315 > when sometime I need nameserver expose outside network , but without acl feature,that mean anyone can add un safe broker to rocketmq ? >

[GitHub] [rocketmq] zongtanghu commented on issue #1279: why nameserver not have acl ?

2019-08-29 Thread GitBox
zongtanghu commented on issue #1279: why nameserver not have acl ? URL: https://github.com/apache/rocketmq/issues/1279#issuecomment-526089315 > when sometime I need nameserver expose outside network , but without acl feature,that mean anyone can add un safe broker to rocketmq ? > >

Still Failing: zongtanghu/rocketmq#107 (develop - 74ffae6)

2019-08-29 Thread Travis CI
Build Update for zongtanghu/rocketmq - Build: #107 Status: Still Failing Duration: 14 mins and 43 secs Commit: 74ffae6 (develop) Author: King Message: [ISSUE 504] Polish 'No route info of this topic' exception (#1415) * Polish 'no route info of this topic' exc

Failed: zongtanghu/rocketmq#108 (update_topic_perm_failed - 74ffae6)

2019-08-29 Thread Travis CI
Build Update for zongtanghu/rocketmq - Build: #108 Status: Failed Duration: 14 mins and 1 sec Commit: 74ffae6 (update_topic_perm_failed) Author: King Message: [ISSUE 504] Polish 'No route info of this topic' exception (#1415) * Polish 'no route info of this to

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526080981 hi~ @duhenglucky i am new to rocketmq. RocketMQ is cool and become more and more popular, so i'd like to help you guys to make the *q

[GitHub] [rocketmq] jimgreen2013 edited a comment on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 edited a comment on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526080981 hi~ @duhenglucky i am new to rocketmq and i'd like to help you guys to make the *quick start* more friendly to newbies like me. If th

[GitHub] [rocketmq] jimgreen2013 commented on issue #504: No route info of this topic problem

2019-08-29 Thread GitBox
jimgreen2013 commented on issue #504: No route info of this topic problem URL: https://github.com/apache/rocketmq/issues/504#issuecomment-526080981 hi~ @duhenglucky i am new to rocketmq and i'd like to help you guys to make the *quick start* more friendly to newbies like me. If there are

[GitHub] [rocketmq] zongtanghu commented on issue #1379: ACL exist a bug

2019-08-29 Thread GitBox
zongtanghu commented on issue #1379: ACL exist a bug URL: https://github.com/apache/rocketmq/issues/1379#issuecomment-526075624 And also I will report the useful information for acl config length limite issue. This is an auto

[GitHub] [rocketmq] zongtanghu commented on issue #1379: ACL exist a bug

2019-08-29 Thread GitBox
zongtanghu commented on issue #1379: ACL exist a bug URL: https://github.com/apache/rocketmq/issues/1379#issuecomment-526075328 You can change your acl's accessKey to more than 6 length. @lance12138 This is an automated messa

[GitHub] [rocketmq] zongtanghu opened a new issue #1429: Update Broker's Topic Read or Write Perm failed

2019-08-29 Thread GitBox
zongtanghu opened a new issue #1429: Update Broker's Topic Read or Write Perm failed URL: https://github.com/apache/rocketmq/issues/1429 **BUG REPORT** 1. Please describe the issue you observed: User use UpdateTopicPermSubCommand command to update broker's topic read or write per

[GitHub] [rocketmq] coveralls commented on issue #1427: Fix offset maybe lost problem.

2019-08-29 Thread GitBox
coveralls commented on issue #1427: Fix offset maybe lost problem. URL: https://github.com/apache/rocketmq/pull/1427#issuecomment-526060334 [![Coverage Status](https://coveralls.io/builds/25414660/badge)](https://coveralls.io/builds/25414660) Coverage decreased (-0.07%) to 50.506

[GitHub] [rocketmq] Shellbye commented on issue #1409: rocketmq tools queryMsgByKey may have bug!

2019-08-29 Thread GitBox
Shellbye commented on issue #1409: rocketmq tools queryMsgByKey may have bug! URL: https://github.com/apache/rocketmq/issues/1409#issuecomment-526059767 @zongtanghu My problem is solved, but not the original. This is an automa

[GitHub] [rocketmq] zongtanghu commented on issue #1409: rocketmq tools queryMsgByKey may have bug!

2019-08-29 Thread GitBox
zongtanghu commented on issue #1409: rocketmq tools queryMsgByKey may have bug! URL: https://github.com/apache/rocketmq/issues/1409#issuecomment-526059047 @Shellbye You can compare the tools.yml file to plain_acl.yml file.The admin accessKey and secretKey must be the same value. --

[GitHub] [rocketmq] coveralls commented on issue #1428: Correct Topic permission when broker has permission.

2019-08-29 Thread GitBox
coveralls commented on issue #1428: Correct Topic permission when broker has permission. URL: https://github.com/apache/rocketmq/pull/1428#issuecomment-526056534 [![Coverage Status](https://coveralls.io/builds/25414534/badge)](https://coveralls.io/builds/25414534) Coverage decre

[GitHub] [rocketmq] duhenglucky commented on issue #1409: rocketmq tools queryMsgByKey may have bug!

2019-08-29 Thread GitBox
duhenglucky commented on issue #1409: rocketmq tools queryMsgByKey may have bug! URL: https://github.com/apache/rocketmq/issues/1409#issuecomment-526055853 @Shellbye ok, I will reopen this issue, @zongtanghu could you help this guy to resolve this issue? ---

[GitHub] [rocketmq] honglouleiyan opened a new issue #1409: rocketmq tools queryMsgByKey may have bug!

2019-08-29 Thread GitBox
honglouleiyan opened a new issue #1409: rocketmq tools queryMsgByKey may have bug! URL: https://github.com/apache/rocketmq/issues/1409 when I close acl(aclEnable=false), execute the command:sh mqadmin queryMsgByKey -n 127.0.0.1:9876 -t topicH -k 12345678 ,I am able to get the correct resu