Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi Justin, I got it, thanks. And I will carry out our conclusion soon. Regards, yukon On Sat, Feb 11, 2017 at 2:51 PM, Justin Mclean wrote: > Hi, > > > So we can use the LICENSE and NOTICE files of `master branch` version > for our bin artifact, while use the LICENSE

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, > So we can use the LICENSE and NOTICE files of `master branch` version for our > bin artifact, while use the LICENSE and NOTICE of a old version[1][2] for our > source artifact. Does it ok? That looks right to me. Thanks, Justin

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi Justin, Thanks for the quick reply. So we can use the LICENSE and NOTICE files of `master branch` version for our bin artifact, while use the LICENSE and NOTICE of a old version[1][2] for our source artifact. Does it ok? And I will rename "binary dependency" to "bundles". [1].

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, > I updated the LICENSE file, the non ASF ALv2 licenses has been added to our > LICENSE file, and I think the mentioned [3],[4],[5] and [9] have been > resolved. In LICENSE rather than "binary dependency” I would put “bundles”. There are dependancies not listed and it the fact that they are

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, > I am not sure how to seperate LICENSE and NOTICE files for the source and > binary packages, Do you mean we need add four files at top level of the > source tree ? LICENSE and NOTICE for source release, while LICENSE-BIN and > NOTICE-BIN for binary release. That look good to me, as long

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi Justin, Many thanks for your kind help. I updated the LICENSE file, the non ASF ALv2 licenses has been added to our LICENSE file, and I think the mentioned [3],[4],[5] and [9] have been resolved. I am not sure how to seperate LICENSE and NOTICE files for the source and binary packages, Do

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, > Justin, you are right, I have polished the LICENSE and NOTICE files, would > you please check help us check it again at your convenience? > > [1]. https://github.com/apache/incubator-rocketmq/blob/master/LICENSE > [2]. https://github.com/apache/incubator-rocketmq/blob/master/NOTICE >

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, Justin, you are right, I have polished the LICENSE and NOTICE files, would you please check help us check it again at your convenience? [1]. https://github.com/apache/incubator-rocketmq/blob/master/LICENSE [2]. https://github.com/apache/incubator-rocketmq/blob/master/NOTICE Also please

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, > Can we call the RC3 vote now(RC3 is ready) and leave these change points in > next release? Up to the release manager, IMO it's still likely to pass a IPMC vote, so it could be done. However if we know it’s an issue and it’s easy to fix why not fix it now? I would also wait 24 hours to

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, Got it. > It still needs some work: 1,2,3. Can we call the RC3 vote now(RC3 is ready) and leave these change points in next release? Regards, yukon On Sat, Feb 11, 2017 at 8:50 AM, Justin Mclean wrote: > Hi, > > > And there is issue being raised that EPL

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, > And there is issue being raised that EPL 1.0 is not compatible with ASL2, > but RocketMQ has a dependency on logback which is under the EPL v1.0 and > the LGPL 2.1 License[1], Does it ok? EPL is compatible with ASLv2 it just can’t be included in source form. [1] > Also could you please

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Thanks Justin, we got it. And there is issue being raised that EPL 1.0 is not compatible with ASL2, but RocketMQ has a dependency on logback which is under the EPL v1.0 and the LGPL 2.1 License[1], Does it ok? Also could you please help us check the NOTICE file is correct or not? [1].

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, > The previous vote has been canceled, and we have resolved the issues > mentioned by mentors, below are change points: Just reminding people that a -1 on a release vote it not a veto, all you need for a release is 3 +1 binding votes and more +1’s than -1’s. Also being an incubating

[GitHub] incubator-rocketmq issue #57: [ROCKETMQ-91] Reduce lock granularity for putM...

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/57 [](https://coveralls.io/builds/10097782) Coverage increased (+0.3%) to 31.614% when pulling

[GitHub] incubator-rocketmq issue #56: [ROCKETMQ-90] Include client IP in consumerPro...

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/56 [](https://coveralls.io/builds/10096072) Coverage increased (+0.3%) to 31.58% when pulling

[GitHub] incubator-rocketmq issue #56: [ROCKETMQ-90] Include client IP in consumerPro...

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/56 [](https://coveralls.io/builds/10096072) Coverage increased (+0.3%) to 31.58% when pulling

[GitHub] incubator-rocketmq issue #56: [ROCKETMQ-90] Include client IP in consumerPro...

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/56 [](https://coveralls.io/builds/10096072) Coverage increased (+0.3%) to 31.58% when pulling

Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)

Looks good, Von. Thank you. Bruce On Thu, Feb 9, 2017 at 6:43 PM, Von Gosling wrote: > > Hi Bruce, > > I have polished it as you suggest, please review it :-) > > > > 在 2017年2月9日，22:09，Bruce Snyder 写道： > > > > all project development is now

Still Failing: lizhanhui/incubator-rocketmq#9 (ROCKETMQ-90 - 2874c56)

Build Update for lizhanhui/incubator-rocketmq - Build: #9 Status: Still Failing Duration: 10 minutes and 15 seconds Commit: 2874c56 (ROCKETMQ-90) Author: Zhanhui Li Message: Use IP from client instead of remoting IP from connection, which always and

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Excellent~ I have checked the update points in RC3. IMO, we could call vote thread again once the ASL2 and EPL license compatible problem is resolved. > 在 2017年2月10日，21:01，yukon 写道： > > Hi, > > The previous vote has been canceled, and we have resolved the issues > mentioned by

Re: [DISCUSS] Release Apache RocketMQ 4.0.0(incubating)

Hi, The previous vote has been canceled, and we have resolved the issues mentioned by mentors, below are change points: 1. Use a 4096 bit key to sign the RC. 2. Add license notice for all the dependencies. 3. Remove the 3rd party links in README. 4. Polish bin/README file. The new vote will be

Fwd: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)

Thanks Willem advice :-) We cancel this vote thread here. > 1. README.md in the source and binary files has some enhanced feature descriptions all lead to Alibaba ONS. We could just provide a commercial support page in the RocketMQ web site. > 2. README.md in the bin directory of binaray has the

[GitHub] incubator-rocketmq-site pull request #7: Changes to the text on specifying n...

Github user shroman closed the pull request at: https://github.com/apache/incubator-rocketmq-site/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-rocketmq-site issue #7: Changes to the text on specifying name ser...

Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/7 This PR has been merged. @shroman you may close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-rocketmq pull request #54: [ROCKETMQ-83] Fix quick start, annotate...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)

-1. Please address the below issues before starting a new vote. 1. README.md in the source and binary files has some enhanced feature descriptions all lead to Alibaba ONS. We could just provide a commercial support page in the RocketMQ web site. 2. README.md in the bin directory of binaray has

[GitHub] incubator-rocketmq-site issue #7: Changes to the text on specifying name ser...

Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/7 I'll check and merge. It looks I do not have permission to close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as