[GitHub] incubator-rocketmq issue #20: [ROCKETMQ-23] MappedFileQueue#flush should ret...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/20 @shroman It seems that last cleaning, for too long-time no-resolved prs, included this one. If you feel it is necessary to reopen this PR, please feel free to do it. you may

[GitHub] incubator-rocketmq pull request #133: [ROCKETMQ-249] Do not attempt to clear...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/133#discussion_r140402297 --- Diff: store/src/test/java/org/apache/rocketmq/store/CleanCommitLogServiceTest.java --- @@ -0,0 +1,115 @@ +/* + * Licensed

[GitHub] incubator-rocketmq pull request #138: [ROCKETMQ-138]add implement SelectMess...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/138#discussion_r140401564 --- Diff: client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByConsistentHash.java --- @@ -0,0 +1,132

[GitHub] incubator-rocketmq issue #142: [ROCKETMQ-255] Fix offsetStore being null aft...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/142 LGTM @zhouxinyu @vsair @Jaskey please help do a review? ---

[GitHub] incubator-rocketmq issue #143: [ROCKETMQ-256] Clean commit log files manuall...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/143 @lizhanhui This purge is not be safe for scheduled message. ---

[GitHub] incubator-rocketmq pull request #143: [ROCKETMQ-256] Clean commit log files ...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/143#discussion_r140139906 --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java --- @@ -1392,6 +1397,14 @@ public void run

[GitHub] incubator-rocketmq pull request #143: [ROCKETMQ-256] Clean commit log files ...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/143#discussion_r140139302 --- Diff: common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java --- @@ -89,6 +89,14 @@ public void

[GitHub] incubator-rocketmq pull request #146: [ROCKETMQ-265] fix consume queue’s d...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/146#discussion_r140138721 --- Diff: store/src/test/java/org/apache/rocketmq/store/ConsumeQueueTest.java --- @@ -131,6 +130,65 @@ protected void putMsg

[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 LGTM @zhouxinyu @vongosling any view? ---

[GitHub] incubator-rocketmq issue #148: [ROCKETMQ-269] don’t need cal.setTimeInMill...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/148 @mark800 IMO, it is easy to add unit test for such change. just test if the return value of computNextHourTimeMillis(and other methods) is expected. I will merge this PR

[GitHub] incubator-rocketmq issue #149: [ROCKETMQ-136]Provide a handy message queue p...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/149 @zhouxinyu @vongosling any idea about this? ---

[GitHub] incubator-rocketmq pull request #149: [ROCKETMQ-136]Provide a handy message ...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/149#discussion_r140136764 --- Diff: client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByConsistentHash.java --- @@ -0,0 +1,94

[GitHub] incubator-rocketmq issue #152: [ROCKETMQ-278] Add clusterlist cmd by specifi...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/152 LGTM @zhouxinyu @vongosling ---

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @evthoriz may you mock a test for this scenario? ---

[GitHub] incubator-rocketmq issue #154: [Rocketmq-285] file test error when make link

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 @zwillim I want to merge this PR. Could you please change the target branch to apache:develop ? As all the PRs are merged into develop at first. ---

[GitHub] incubator-rocketmq pull request #156: [ROCKETMQ-271] add tools for Analyzing...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/156#discussion_r139868962 --- Diff: broker/src/main/java/org/apache/rocketmq/broker/ServerTracerTimeUtil.java --- @@ -0,0 +1,108 @@ +/* + * Licensed

[GitHub] incubator-rocketmq pull request #156: [ROCKETMQ-271] add tools for Analyzing...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/156#discussion_r139869169 --- Diff: broker/src/main/java/org/apache/rocketmq/broker/mqtrace/TrackerTimeSendMessageHook.java --- @@ -0,0 +1,62

[GitHub] incubator-rocketmq issue #156: [ROCKETMQ-271] add tools for Analyzing messag...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/156 LGTM @zhouxinyu @vongosling ---

[GitHub] incubator-rocketmq issue #165: fix DefaultMessageStoreTest bug: wait more ti...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/165 @wenweihu86 By default, the commitlog will flush in real-time. If enable flushCommitLogTimed, then it will flush at the interval. So there is no need to sleep 100 ms, 10

[GitHub] incubator-rocketmq issue #167: Merge pull request #1 from apache/master

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/167 @warning5 this pr has no files changed. ---

[GitHub] incubator-rocketmq issue #28: [ROCKETMQ-27]Add store commitlog path online

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/28 @lizhanhui LGTM. Version 4.2.0 is going to be released now. It will be nice to contain this feature. Could you please add one IT Test to maintain the quality? ---

[GitHub] incubator-rocketmq issue #20: [ROCKETMQ-23] MappedFileQueue#flush should ret...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/20 @shroman could you please resolve the conflicts? IMO, the return value of flush() and commit(), means whether there is data left to be flushed or committed, that is OK

Re: [ANNOUNCE]RocketMQ cpp client entered into Apache RocketMQ community

Nice to see a CPP client, and its performance is impressive. It will be great if other clients also provides such test results. 2017-09-05 10:30 GMT+08:00 Von Gosling : > Hi wangqiwei, > > > Thanks for your contribution. Looking forward to your on-going maintenance > of

[GitHub] incubator-rocketmq pull request #158: [Rocketmq-281] add check policy for pr...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/158#discussion_r135689337 --- Diff: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java --- @@ -257,4 +268,28 @@ public static Options

[GitHub] incubator-rocketmq pull request #157: [Rocketmq-277] fix get localhost throw...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135681743 --- Diff: common/src/test/java/org/apache/rocketmq/common/MixAllTest.java --- @@ -93,4 +90,12 @@ public void testString2File() throws

[GitHub] incubator-rocketmq pull request #146: [ROCKETMQ-265] fix consume queue’s d...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/146#discussion_r134941603 --- Diff: store/src/test/java/org/apache/rocketmq/store/ConsumeQueueTest.java --- @@ -148,6 +148,52 @@ protected void deleteFile(File file

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

+1 Nice to see Apache RocketMQ to be TLP. 2017-08-21 8:40 GMT+08:00 Zhanhui Li : > +1 > > Glad to see the changes we have brought about since the initiative of > incubation and anticipate the potentials of the Apache RocketMQ as a TLP. > > > > On Fri, Aug 18, 2017 at 10:05

[GitHub] incubator-rocketmq pull request #126: [ROCKETMQ-231] fix pull consumer pull ...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/126#discussion_r132427103 --- Diff: store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java --- @@ -45,19 +47,22 @@ public void init() throws

[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 OK. IT tests have been added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 @lindzh It seems lack IT tests for TLS. IMO, it needs two IT Test at least. one for old client which dose not support TLS, one for new. --- If your project is set up for it, you

[GitHub] incubator-rocketmq issue #125: ROCKETMQ-205 :

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/125 @lqjack Thanks for you contribution. You may want to refactor the PR name and attach the jira issue in the comment. It is better to add some detailed words to the PR name

[ANNOUNCE] Release Apache RocketMQ 4.1.0 (incubating)

Hi all, The Apache RocketMQ team would like to announce the release of Apache RocketMQ 4.1.0 (incubating). Apache RocketMQ is a distributed messaging and streaming platform with low latency, high performance and reliability, trillion-level capacity and flexible scalability. The version

[ANNOUNCE] Release Apache RocketMQ 4.1.0 (incubating)

Hi all, The Apache RocketMQ team would like to announce the release of Apache RocketMQ 4.1.0 (incubating). Apache RocketMQ is a distributed messaging and streaming platform with low latency, high performance and reliability, trillion-level capacity and flexible scalability. The version

[RESULT][VOTE]: Release Apache RocketMQ 4.1.0(incubating)(RC1)

Hello RocketMQ Community, The Apache RocketMQ vote is now closed and has passed with 3 binding +1s, 3 non-binding +1s and no 0 or -1: Binding votes +1s: Justin Mclean (jmclean) Von Gosling (vongosling) yukon (yukon) Non-binding votes +1s: liuxue (vsair) wenfeng wang Jaskey Lam A vote on

[VOTE]: Release Apache RocketMQ 4.1.0(incubating)(RC1)

Hello RocketMQ Community, It is a pleasure to call a vote for releasing 4.1.0-incubating of Apache RocketMQ. This version has features of batch message, message filtering based on SQL92, log appender, implementation of the OpenMessaging specification 0.1.0-alpha version, etc. The

[GitHub] incubator-rocketmq pull request #114: [ROCKETMQ-220]Add IT test for Filter B...

Github user dongeforever closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/117 the client module and its dependencies should be compatible with 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-rocketmq pull request #114: [ROCKETMQ-220]Add IT test for Filter B...

GitHub user dongeforever opened a pull request: https://github.com/apache/incubator-rocketmq/pull/114 [ROCKETMQ-220]Add IT test for Filter By SQL 92 https://issues.apache.org/jira/browse/ROCKETMQ-220 @lizhanhui @zhouxinyu You can merge this pull request into a Git

[GitHub] incubator-rocketmq pull request #112: [ROCKETMQ-219] Add batch example

GitHub user dongeforever opened a pull request: https://github.com/apache/incubator-rocketmq/pull/112 [ROCKETMQ-219] Add batch example https://issues.apache.org/jira/browse/ROCKETMQ-219 @lizhanhui @zhouxinyu You can merge this pull request into a Git repository by running

[GitHub] incubator-rocketmq issue #110: [ROCKETMQ-208]incompatibility problem found i...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/110 @Jaskey This PR has been merged and will be released in 4.1.0. Thanks a lot for your work. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-rocketmq-site issue #14: [ROCKETMQ-216] - Website polish

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/14 +1 Nice --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-rocketmq issue #110: [ROCKETMQ-208]incompatibility problem found i...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/110 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rocketmq issue #86: [ROCKETMQ-160]SendHeartBeat may not be logged ...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/86 @Jaskey Yeah. it has been merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-rocketmq issue #59: Add test case for LocalFileOffsetStore

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/59 +1. This PR has been merged. @djKooks you may want to close it now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-rocketmq issue #101: [ROCKETMQ-194] log appender support

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/101 @lindzh this PR is merged. You may close this PR now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/103 @lizhanhui It seems that this PR had not been merged. I will handle this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-rocketmq issue #97: [ROCKETMQ-189] Misleading tip on consumeTimest...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/97 @lindzh This is PR is merged. you may close this PR now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-rocketmq issue #93: [ROCKETMQ-178] Fix -p -m options

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 LGTM, I will merge this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-rocketmq issue #105: [ROCKETMQ-200]-Cluster name is always missing...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/105 @zhouxinyu @lizhanhui it is time to merge this PR now, could you please have a double check? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-rocketmq issue #34: [ROCKETMQ-39] avoid duplicated codes.

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 @wu-sheng this PR has been merged. you may close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-rocketmq issue #3: [ROCKETMQ-6] Use logger for exceptions instead ...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/3 @shroman please resolve the conflicts and merge this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-rocketmq issue #92: [ROCKETMQ-175] Consumer may miss messages beca...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/92 @zhouxinyu @vongosling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-rocketmq issue #95: [ROCKETMQ-184]-It takes too long(3-33 seconds)...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/95 LGTM @zhouxinyu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-rocketmq issue #98: [ROCKETMQ-188]RemotingExecption is not consist...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/98 LGTM @zhouxinyu @vongosling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-rocketmq issue #99: Correct comment information

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/99 @liumian97 could you please follow the apache way of PR: create issue and rename pull request --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-rocketmq issue #104: Remove spaces before and after the properties

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/104 IMO. if using trim, it is better to trim in all related places --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-rocketmq issue #104: Remove spaces before and after the properties

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/104 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rocketmq issue #105: [ROCKETMQ-200]-Cluster name is always missing...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/105 LGTM @zhouxinyu @vongosling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-rocketmq pull request #87: [ROCKETMQ-161] Update runbroker.sh and ...

Github user dongeforever closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/87 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rocketmq issue #40: [ROCKETMQ-40]Ack mode support for consume conc...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/40 It seems good. And maybe the name(suffixed with V2) could be polished. And maybe different ack mode should support orderly consuming too. --- If your project is set up

Re: [DISCUSS] How to handle sub projects of RocketMQ

> > > 2. Create separate git repos for various sub projects, it's feasible as > > > Bruce said. But this way may bring extra management and delivery costs. > > > > > > > > > IMO, we should decide a way as soon as possible, and I insist that the > > > first way m

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/87 @shroman In runbroker.sh and runserver.sh, some default options, such as -Xmx8g, are placed after the JVM_OPTS, so user-defined -Xmx will not take effect. And if we put

[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 The PR is better not to be merged by the original author. @lizhanhui @zhouxinyu @shroman please help merge this PR. --- If your project is set up for it, you can reply

Re: RocketMQ support message filtering based on SQL92

Cool. Thank liuxue's work on documentation, this could be a good example for new features. -- Original -- From: "liuxue";; Date: Wed, May 3, 2017 08:55 PM To: "dev"; Subject: RocketMQ support message

[GitHub] incubator-rocketmq issue #92: [ROCKETMQ-175] Consumer may miss messages beca...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/92 @Jaskey It may take a long time to fix the issue ROCKETMQ-94. And we could improve it step by step. Now one consumer startup will refresh the subscriptions, but the consumer

[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 @lizhanhui @zhouxinyu @vongosling please have a review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-rocketmq pull request #96: [ROCKETMQ-187]Measure the code coverage...

GitHub user dongeforever opened a pull request: https://github.com/apache/incubator-rocketmq/pull/96 [ROCKETMQ-187]Measure the code coverage for Integration Tests, and add sonar-apache profile https://issues.apache.org/jira/browse/ROCKETMQ-187 Now we could browse the Unit

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/87 The intention is to make user-defined JVM flags to replace the initial ones. So just put JAVA_OPT_EXT after JAVA_OPT is enough. The later defined JVM parameters will replace

[GitHub] incubator-rocketmq issue #90: [ROCKETMQ-172]log improvement for rocketmq cli...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/90 @Jaskey This PR has been merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-rocketmq issue #90: [ROCKETMQ-172]log improvement for rocketmq cli...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/90 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/87 @shroman please help review and check it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-rocketmq-externals issue #9: [ROCKETMQ-171] Initialized the PHP_SD...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/9 @netroby This PR has been merged. If any new PR is submitted, please notice me. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-rocketmq-externals issue #7: [ROCKETMQ-170]Rename README.txt to RE...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/7 @netroby nice. I would merge this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/7 @vongosling @zhouxinyu please help add the component 'rocketmq-externals' or 'rocketmq-docker' --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/7 @netroby I want to merge this PR. Could you please provide your email address that could be identified as your github account ? --- If your project is set up for it, you

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/7 @vsair @netroby Yeah. how to setup docker env is not the major work here. --- If your project is set up for it, you can reply to this email and have your reply appear

Re: Disagreewith"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"forkorigin repository

Hi, Thanks for your preciseness. It impressed on me a lot. And some polishing is done[1]. [1] https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/ Regards dongeforever -- Original -- From: "Justin Mclean";<jus...@clas

Re: Disagree with"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork origin repository

Hi Justin: No doubt that > The correct URL is: > git://git.apache.org/incubator-rocketmq.git > There is a read only mirror on GitHub at: > https://github.com/apache/incubator-rocketmq "https://github.com/dongeforever; is just the forked repo, and has been

Re: [Big Data] RocketMQ community-Master election

repo. Regards dongeforever -- Original -- From: "Justin Mclean";<jus...@classsoftware.com>; Date: Sun, Apr 2, 2017 09:56 AM To: "dev"<dev@rocketmq.incubator.apache.org>; Subject: Re: [Big Data] RocketMQ community-Master

[GitHub] incubator-rocketmq-externals issue #8: update console's readme

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/8 @StyleTang Nice --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-rocketmq pull request #87: [ROCKETMQ-161] Update runbroker.sh and ...

GitHub user dongeforever opened a pull request: https://github.com/apache/incubator-rocketmq/pull/87 [ROCKETMQ-161] Update runbroker.sh and runserver.sh to support user defined jvm mem flag https://issues.apache.org/jira/browse/ROCKETMQ-161?filter=-1 You can merge this pull

[GitHub] incubator-rocketmq-externals issue #8: update console's readme

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/8 Communicate With Us: maybe add the users and dev mailing lists as a supplement --- If your project is set up for it, you can reply to this email and have your

Re: Disagree with "https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork origin repository

Hi Netroby: Maybe I describe something in a wrong way. As blog said "fork the original repo, and clone it": Forking the original repo is not a command, but an operation on github.com, so it was left out. And the https://github.com/dongeforever/incubator-rocketmq.git is t

[GitHub] incubator-rocketmq-externals issue #6: Update rocketmq console's readme.md

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/6 @StyleTang maybe you could squash your commits into only single one. This blog may help you: https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request

rocketmq-docker has been added as an external project

polishing is welcome. Regards dongeforever

[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/52 @shroman I have merged this PR. and I will have a review for the PR #57 later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/52 @vongosling OK. I would merge this PR. and @shroman could you help me check the PR: https://github.com/apache/incubator-rocketmq/pull/57 --- If your project is set up for it, you

[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/52 @shroman It seems that you could merge this PR now. And according to new branching model, it is better to merge this to the 'develop' branch --- If your project is set up

Re: [DISCUSS] Details of the feature "Provider a docker image for RocketMQ"

Hi Rick?? I am testing the existed image now, and I would migrate it to rocketmq-external repository as soon as possible. IMO, build a new one is unnecessary, and polishing is welcome. Regards dongeforever -- Original -- From: "Rick

[GitHub] incubator-rocketmq issue #53: [ROCKETMQ-80] Add batch feature

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/53 this PR has been merged into develop branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Committer Jira Account Ready

Hi Von Gosling: It seems not ok. I cannot commit to the git://git.apache.org/incubator-rocketmq.git with user.name=dongeforever user.email=dongefore...@apache.org is there anything wrong? dongeforever Best Regards -- Original -- From: "Von Go

Re: Podling Report Reminder - March 2017

tant. Best Regards dongeforever -- Original -- From: "Justin Mclean";<jus...@classsoftware.com>; Date: Wed, Mar 8, 2017 05:48 PM To: "dev"<dev@rocketmq.incubator.apache.org>; Subject: Re: Podling Report Reminder - March 2017 Hi, >

[DISCUSS]Add batch feature

to reach out with any question. Best Regards dongeforever

[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r104348323 --- Diff: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java --- @@ -331,7 +331,7 @@ public long getMinOffsetInQueue

Re: [DISCUSS] How to handle sub projects of RocketMQ

+1 all external projects in one place, same repo or better the same group As a user, I would be glad to see these integrated projects in a managed central place and feel free to use it, otherwise I may lack confidence in the quality. -- Original -- From:

[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/52 Thanks @shroman , it is very useful for other projects' integration tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: Looking for contributors for sub-project RocketMQ-JMS

Cool. Sorry for a time not involved in it. Now I am working on the batch feature. After finishing it , more time will spent on this project. Maybe we can release a early version based on the previous work, and get more users involved in. -- Original -- From:

[GitHub] incubator-rocketmq issue #53: [ROCKETMQ-80] Add batch feature

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/53 @Jaskey Sorry. You are right. And it is worth a new PR, maybe we can add batch id along with a new optimized consumeOrderlyService. --- If your project is set up for it, you can

[GitHub] incubator-rocketmq issue #53: [ROCKETMQ-80] Add batch feature

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/53 @Jaskey Now there is no batch id, but the messages in one batch are sent to the same queue, and they can only be sent all successfully or all unsuccessfully. You could check

Re: [RESTART][VOTE][#3]: Release Apache RocketMQ 4.0.0(incubating)

compile from source It seems perfect! Thanks. dongeforever -- Original -- From: "yukon";<yu...@apache.org>; Date: Sun, Feb 12, 2017 11:44 AM To: "dev"<dev@rocketmq.incubator.apache.org>; Subject: [RESTART][VOTE][#3]: Release

  1   2   >