[GitHub] incubator-rocketmq issue #19: [ROCKETMQ-14] rocketmq-14 unit test updated

2017-01-03 Thread Jaskey
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/19 @vongosling Is there any problem on this unit test code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

On RocketMQ community projects

2017-01-03 Thread Roman Shtykh
Folks, I think an important part of RocketMQ project growth will be an integration with other platforms.Currently, there are a couple of such integrations [1], but they are a bit outdated and not all of them have Apache license. Shall we make them Apache licensed? Shall we keep them in [1]? I

Re: Podling Report Reminder - January 2017

2017-01-03 Thread Bruce Snyder
Thank you, Justin. I'm not sure if the IP review is complete. I have submitted the podling report via the Incubator wiki page. Bruce On Tue, Jan 3, 2017 at 3:05 PM, Justin Mclean wrote: > Hi, > > > - A list of the three most important issues to address in the move >

Re: Podling Report Reminder - January 2017

2017-01-03 Thread Justin Mclean
Hi, > - A list of the three most important issues to address in the move towards > graduation Here’s my suggestions: 1. Confirm the IP review is complete. 2. Make our first Apache release 3. Vote in our first committer / PMC members Is 1 complete? Thanks, Justin

Re: Podling Report Reminder - January 2017

2017-01-03 Thread Bruce Snyder
John and Justin, The one item where I would like some guidance is with the following item in the report: - A list of the three most important issues to address in the move towards graduation I'm not sure what the IPMC would like to see in this item specifically beyond what the project

Re: Podling Report Reminder - January 2017

2017-01-03 Thread Bruce Snyder
Review Board is really nice if the project decides to adopt the RTC model because it can hook directly into the git commit process preventing commits until the review has completed successfully. I have used it with great success in the past on a project with more than 30 team members committing

Re: Podling Report Reminder - January 2017

2017-01-03 Thread Von Gosling
Hi, 1. Refer to RTC or CTR problem For commit, may be, we could use CTR. For PR, we would prefer to RTC. We are high valuing the quality in RocketMQ. So, it is a better way to use the conservative strategy from my opinion :-) 2. Refer to PPMC and committer relationship Thanks Justin

[GitHub] incubator-rocketmq issue #17: [ROCKETMQ-19] Synchronize LinkedList.add() in ...

2017-01-03 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/17 Thanks for your ISSUE review before PR @Zhang-Ke --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-rocketmq issue #26: [ROCKETMQ-26]add new way to send messages in a...

2017-01-03 Thread thisisbaozi
Github user thisisbaozi commented on the issue: https://github.com/apache/incubator-rocketmq/pull/26 @vongosling I have added a example for it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [DISCUSS] Getting rid of MixAll class

2017-01-03 Thread Roman Shtykh
Hi Lollipop, Thanks! Great to know your opinion, since this class is used throughout most of the code base. Regards, Roman Shtykh On Tuesday, January 3, 2017 3:57 PM, lollipop wrote: Hi,Roman: It seems cool to combine the helper methods from MixAll and UtilAll