Hi,

 1. Refer to RTC or CTR problem

For commit, may be, we could use CTR. For PR, we would prefer to RTC. We are 
high valuing the quality in RocketMQ. So, it is a better way to use the 
conservative strategy from my opinion :-)

2.   Refer to PPMC and committer relationship
Thanks Justin refers. We are not familiar with Apache recommended way for this 
problem. But i  have learn about something about PMC additional 
responsibilities. IMO, we really want to keep the community diversity. 
Committer may be a good candidate for entering into PMC. For the same reason, 
contributor may be a good candidate for becoming Committer.

AFAIK, Apache Tomcat have separate the PMC member and committer role. And, 
Apache Storm may regard as the committer as PMC member when someone make a 
great achievement for the project[1].

1. http://storm.apache.org/contribute/People.html 
<http://storm.apache.org/contribute/People.html>



> 在 2017年1月3日,16:33,Justin Mclean <jus...@classsoftware.com> 写道:
> 
> Hi,
> 
>> IMO, not only the number of PR, more concerned about the quality of PR.
> 
> Just try not to have the bar too high / wait too long to vote potential 
> candidates in. This may discourage people being invoved and hinder community 
> growth. But it’s totally up to this PPMC to decide this.
> 
>> PPMC number of members should be less than the number of committer, IMHO,
>> the committers are not all PPMC.
> 
> Which is fine being a PPMC/PMC member had additional responsibilities [1]
> 
>> RTC +1 The reference quality is the first priority.
> 
> JFYI This is uncommon in Apache projects and all projects I have been 
> involved in have been CTR. In CTR any commit is just a revert away. I’ve not 
> seen many cases where it’s been an issue, especially where you have good test 
> coverage and code quality metrics. But again it’s totally up to the PPMC to 
> decide.
> 
> Thanks,
> Justin
> 
> 1. https://www.apache.org/dev/pmc.html#policy

Reply via email to