[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/132
  

[![Coverage 
Status](https://coveralls.io/builds/12789603/badge)](https://coveralls.io/builds/12789603)

Coverage increased (+0.2%) to 38.926% when pulling 
**f7b7b5b1d8b7536f69504fd9bbe68d2511d8865f on evthoriz:develop-my** into 
**98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/132
  

[![Coverage 
Status](https://coveralls.io/builds/12789603/badge)](https://coveralls.io/builds/12789603)

Coverage increased (+0.2%) to 38.926% when pulling 
**f7b7b5b1d8b7536f69504fd9bbe68d2511d8865f on evthoriz:develop-my** into 
**98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re:Re: contribute rocketmq client4cpp

[王启伟]

Hi All,
I had passed ICLA, Thanks.






At 2017-08-09 14:55:46, "Von Gosling"  wrote:



Hi,


Additional email, sorry for forgetting to paste wangqiwei email.


I am very pleased to see your contribution for RocketMQ community, especially 
for this sustainable c++ sdk. Looking forward to hear from you. As there're 
more and more dev. activities, you may have to request ICLA[1] for future 
contribution. Thank you again for your timely assistance and let's move this 
project to the community[2] :-)


[1] https://www.apache.org/licenses/#clas
[2] https://github.com/apache/incubator-rocketmq-externals




Best Regards,
Von Gosling






在 2017年8月7日，17:09，王启伟  写道：


Hi devs:
I take charge of rocketmq multiple language client development more than 3 
years at my company's middleware department; There are lots of multiple 
language clients for rocketmq, such as C++, .NET, Python, PHP, Go and so on, 
all these clients are popular in our company;


Rocketmq client for cpp had gone through 3 years time-tested，and had been used 
widly by many services, such as IM service, Navigation, advertisement tool, 
on-line shopping service and so on; it is stable with perfect disaster recovery 
ability, low latency，and high send/subscribe QPS;


I noticed there are lots of clients in incubator-rocketmq-externals, but CPP 
and DoNET client is not complete， So I hope to contribute this linux cpp client 
to incubator-rocketmq-externals, windows CPP and DoNET will be contributed 
later, thanks! Also, welcome any volunteers to join us!

[GitHub] incubator-rocketmq pull request #126: [ROCKETMQ-231] fix pull consumer pull ...

[dongeforever]

Github user dongeforever commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/126#discussion_r132427103
  
--- Diff: 
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -45,19 +47,22 @@ public void init() throws Exception {
 BornHost = new 
InetSocketAddress(InetAddress.getByName("127.0.0.1"), 0);
 }
 
+public MessageStore buildMessageStore() throws Exception {
+MessageStoreConfig messageStoreConfig = new MessageStoreConfig();
+messageStoreConfig.setMapedFileSizeCommitLog(1024 * 1024 * 10);
+messageStoreConfig.setMapedFileSizeConsumeQueue(1024 * 1024 * 10);
+messageStoreConfig.setMaxHashSlotNum(1);
+messageStoreConfig.setMaxIndexNum(100 * 100);
+messageStoreConfig.setFlushDiskType(FlushDiskType.ASYNC_FLUSH);
+return new DefaultMessageStore(messageStoreConfig, new 
BrokerStatsManager("simpleTest"), new MyMessageArrivingListener(), new 
BrokerConfig());
--- End diff --

The MessageStore uses the default store path(~/store).
And the test forgets to delete files in that path.
Two suggestions:
1. create temp path, and set it as storePath
2. delete all the files after the testing



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #141: [ROCKETMQ-254] fix logger appender unit test ...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12777678/badge)](https://coveralls.io/builds/12777678)

Coverage decreased (-0.4%) to 38.728% when pulling 
**9b5dfd8c0dbbaec8a1ba46e3d9171fd90bea262a on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #143: [ROCKETMQ-256] Clean commit log files manuall...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/143
  

[![Coverage 
Status](https://coveralls.io/builds/12774632/badge)](https://coveralls.io/builds/12774632)

Coverage increased (+0.03%) to 38.772% when pulling 
**e767801526ef804a4945270720bba59a490bfc03 on lizhanhui:store_clean** into 
**98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #143: [ROCKETMQ-256] Clean commit log files manuall...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/143
  

[![Coverage 
Status](https://coveralls.io/builds/12774632/badge)](https://coveralls.io/builds/12774632)

Coverage increased (+0.03%) to 38.772% when pulling 
**e767801526ef804a4945270720bba59a490bfc03 on lizhanhui:store_clean** into 
**98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #142: [ROCKETMQ-255] Fix offsetStore being null aft...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/142
  

[![Coverage 
Status](https://coveralls.io/builds/12774581/badge)](https://coveralls.io/builds/12774581)

Coverage decreased (-0.04%) to 38.701% when pulling 
**18cb81b21ad6fa03b457c037aa474123b93caf1f on lizhanhui:offset_store** into 
**98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #143: [ROCKETMQ-256] Clean commit log files manuall...

[lizhanhui]

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/143
  
1. "As force delete may cause message lost,how about add a warnning in 
command help?"--->Added.
2. "And also add a monitor disk usage tool command for check." --> I do not 
follow this comment, could you please  articulate it more specifically?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #141: [ROCKETMQ-254] fix logger appender unit test ...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12774185/badge)](https://coveralls.io/builds/12774185)

Coverage decreased (-0.5%) to 38.622% when pulling 
**ee2e2cdb01c3711504215c6f3b55a5e9223dbd42 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #141: [ROCKETMQ-254] fix logger appender unit test ...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12774185/badge)](https://coveralls.io/builds/12774185)

Coverage decreased (-0.5%) to 38.622% when pulling 
**ee2e2cdb01c3711504215c6f3b55a5e9223dbd42 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/132
  
@evthoriz we usually need some measure to verify our correction, no matter 
what you do. IMO, unit test is a effective practice when we coding. Looking 
forward to hear from you again :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #144: [ROCKETMQ-257] name server address and...

[lindzh]

Github user lindzh commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132393089
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
 ---
@@ -225,10 +225,13 @@ public void start() throws MQClientException {
 switch (this.serviceState) {
 case CREATE_JUST:
 this.serviceState = ServiceState.START_FAILED;
-// If not specified,looking address from name server
-if (null == this.clientConfig.getNamesrvAddr()) {
+// name server address and web server address should 
be specified at least one
+if (null == this.clientConfig.getNamesrvAddr() && 
MixAll.getWSAddr().equals(MixAll.WS_ADDR)) {
+throw new MQClientException("name server address 
and web server address should be specified at least one.", null);
--- End diff --

What if someone want to use default wsaddr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #142: [ROCKETMQ-255] Fix offsetStore being null aft...

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/142
  
I created this thread just to address some unit test naming problem. Do we 
need normalize here ? naming are various nowadays, IMO, methodTest_condition or 
testMethond_condition may be a good practice, thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #141: [ROCKETMQ-254] fix logger appender uni...

[lindzh]

Github user lindzh commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/141#discussion_r132391646
  
--- Diff: 
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
 ---
@@ -70,24 +76,28 @@ public static MQProducer getInstance(String 
nameServerAddress, String group) thr
 }
 
 
-public static void removeAndClose(String nameServerAddress, String 
group) {
+public void removeAndClose(String nameServerAddress, String group) {
 if (group == null) {
 group = DEFAULT_GROUP;
 }
 String genKey = genKey(nameServerAddress, group);
-MQProducer producer = producerMap.remove(genKey);
+MQProducer producer = 
getProducerInstance().producerMap.remove(genKey);
 
 if (producer != null) {
 producer.shutdown();
 }
 }
 
-public static void closeAll() {
-Set> entries = 
producerMap.entrySet();
+public void closeAll() {
+Set> entries = 
getProducerInstance().producerMap.entrySet();
 for (Map.Entry entry : entries) {
-producerMap.remove(entry.getKey());
+getProducerInstance().producerMap.remove(entry.getKey());
 entry.getValue().shutdown();
 }
 }
 
+public static void setInstance(ProducerInstance instance1) {
--- End diff --

Yes ,it is dangerous for only test and this problem has been fixed with 
reflect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---