Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
This Pull Request has been merged and it's safe to close this PR.
@vincentWangKB
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
This patch looks good enough to be merged. Thanks @vincentWangKB
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Though there are still quite a few unused files, I am fine to merge this PR
first and fix issues later on.
---
If your project is set up for it, you can reply to this email
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135698929
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -407,12 +408,50 @@ private static String localhost
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Maybe, we can merge it and create JIRA tickets to polish the code. Any idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/150#discussion_r134941070
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1094,34 +1090,15 @@ private boolean
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/146#discussion_r134940614
--- Diff:
store/src/test/java/org/apache/rocketmq/store/ConsumeQueueTest.java ---
@@ -148,6 +148,52 @@ protected void deleteFile(File file
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/146#discussion_r134940511
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -238,7 +238,7 @@ public void
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
@vincentWangKB Another issue with the code, currently all classes sit in
the namespace of metaq, we should rename it to rocketmq.
---
If your project is set up for it, you
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
@vesense Yes, we will do this before actually merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Yes, I see your update...Thanks for you contribution. CMake, IMO, is very
good to have!
One more thing, I think we can assume dependent libraries are all
installed
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/146
Please add a link to the JIRA issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
As it's now part of the Apache RocketMQ project, IMO, rocketmq namespace
should be used instead of metaq.
---
If your project is set up for it, you can reply to this email
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
A second issue about alog, there are only header files and binary static
lib file, where is source code for the static lib files?
---
If your project is set up for it, you
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Trying to create a CMakeLists.txt on top of this PR, but it looks there is
something missing:
```cpp
MetaqJson::Value json
```
I grepped MetaqJson in the code
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/143
1. "As force delete may cause message lost,how about add a warnning in
command help?"--->Added.
2. "And also add a monitor disk usage tool command for check.&quo
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/143
[ROCKETMQ-256] Clean commit log files manually to specified disk usage
watermark
Associated JIRA ticket is:
https://issues.apache.org/jira/browse/ROCKETMQ-256
You can merge
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130515522
--- Diff:
client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java ---
@@ -27,16 +28,19 @@
public static final String
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130515214
--- Diff:
client/src/test/java/org/apache/rocketmq/client/log/ClientLogTest.java ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/139#discussion_r130507692
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -255,19 +255,17 @@ public void start
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/127
@shroman This issue is to reduce fruitless polling for consumer clients. If
a consumer subscribes topics which ship messages no that frequent, it may stop
for a while in a smart way
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/140
[ROCKETMQ-253]Compress RegisterBrokerBody
Refer to the description part of [this
issue](https://issues.apache.org/jira/browse/ROCKETMQ-253) please.
You can merge this pull request
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/110
@Jaskey Please close this PR at your earliest convenient time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/119
All right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124500517
--- Diff: client/src/main/java/org/apache/rocketmq/client/ClientConfig.java
---
@@ -173,12 +177,20 @@ public void setVipChannelEnabled(final
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124500269
--- Diff:
remoting/src/main/java/org/apache/rocketmq/remoting/netty/FileRegionEncoder.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124494325
--- Diff: client/src/main/java/org/apache/rocketmq/client/ClientConfig.java
---
@@ -173,12 +177,20 @@ public void setVipChannelEnabled(final
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124493428
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/RequestCode.java ---
@@ -17,7 +17,9 @@
package
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124492935
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/RequestCode.java ---
@@ -17,7 +17,9 @@
package
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124492297
--- Diff:
remoting/src/main/java/org/apache/rocketmq/remoting/netty/FileRegionEncoder.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/119
Looks good to me. Actually some of the client code relies on presence of
the topic which would log exceptions otherwise.
IMO, we'd better rename the variable name only
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/119
I am +1 to rename the default topic name.
In addition, we'd better resolve all known issues relating the
auto-create-topic mechanism.
1. Can we rename the name
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
+1
Nice catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/127#discussion_r124255531
--- Diff:
test/src/test/java/org/apache/rocketmq/test/client/producer/tls/TlsIntegrationTestBase.java
---
@@ -0,0 +1,29
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/118
[ROCKETMQ-28] Encrypt transmission layer.
JIRA issue is [here](https://issues.apache.org/jira/browse/ROCKETMQ-28)
You can merge this pull request into a Git repository by running
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/18#discussion_r121620804
--- Diff: _docs/20-logappender-example.md ---
@@ -0,0 +1,80 @@
+---
+title: "Logappender Example"
+permal
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
Yes, best to have this change log.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/115
@Jaskey I'll check it today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/111#discussion_r121319741
--- Diff:
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java
---
@@ -169,6 +188,7 @@ public void initChannel
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/115#discussion_r120857815
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -324,11 +324,16 @@ public void
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/16
This pull request has been merged and please close it at your convenient
time. Thanks for your efforts and contribution.
---
If your project is set up for it, you can reply
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/16
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/15
This PR contains contents simple enough, IMO, we can merge it directly as
the original content is pretty misleading.
---
If your project is set up for it, you can reply
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/15
@dongeforever @zhouxinyu Any idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/113#discussion_r120558511
--- Diff: README.md ---
@@ -30,12 +30,11 @@ It offers a variety of features as follows:
## Apache RocketMQ Community
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/113#discussion_r120557452
--- Diff: README.md ---
@@ -3,18 +3,18 @@
[](https
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/114
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/114#discussion_r120556852
--- Diff:
test/src/main/java/org/apache/rocketmq/test/listener/AbstractListener.java ---
@@ -95,6 +95,28 @@ public void stopRecv
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/112
Overall +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/112#discussion_r120554000
--- Diff:
example/src/main/java/org/apache/rocketmq/example/batch/SplitBatchProducer.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/15
[ROCKETMQ-217] Polish scheduled message example
https://issues.apache.org/jira/browse/ROCKETMQ-217
You can merge this pull request into a Git repository by running:
$ git
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq-site/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/109
@dongeforever @shroman @zhouxinyu Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/111
[ROCKETMQ-28] Add TLS support to provide end-2-end security
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/109#discussion_r119598779
--- Diff:
client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMachineRoomNearby.java
---
@@ -0,0 +1,129
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/95
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
@shroman @Jaskey @dongeforever @zhouxinyu Guys, please review this minor
improvement pull request.
---
If your project is set up for it, you can reply to this email and have your
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/106
[ROCKETMQ-202] Using the native transport
Since 4.0.16, Netty provides the native socket transport for Linux using
JNI. This transport has higher performance and produces less garbage
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
It's OK to introduce an extra variable to override default Java VM options.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/103
@StyleTang Merged, please close this issue at your earliest convenient
time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/103
+1
Considering this is a trivial change and unlikely to introduce any risk,
I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/12
Double checked, 'package' is not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/89#discussion_r115650129
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -306,6 +310,19 @@ public SendResult sendMessage
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/101
Hi, @lindzh could you further justify this PR? Aka, explain why it's
reasonable to create a custom appender?
---
If your project is set up for it, you can reply to this email
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/102
This issue has been fixed in the develop branch, could you please
double-check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
> please resolve the conflicts firstly, we have to be cautious about this
PR.
Agree, this PR introduces too many trivial changes and I'd like abandon
this PR and create seve
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115647528
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java
---
@@ -27,23 +27,23 @@
public class
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115645553
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -907,10 +907,10 @@ public void queryMessage
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/93
> Any trouble is still ?
No. It's a trivial change and should have been merged/closed.
---
If your project is set up for it, you can reply to this email and have your
re
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/96
It's good and looks it's already been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/12
Add missing maven goal 'package' in get-started document
As per title.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/100
> please comply with PR best practice for title as you have corrected
before.
Yes. Fixed.
> 2. you can consider the order when many logic and operator together
Wh
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/100
BugFix: ROCKETMQ-191
As we are setting socket options(sndbuf/recvbuf size) for the future
SocketChannel, we need to use childOption for ServerBootstrap class.
Semantics
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/95
You are right that more changes are required for my suggested approach.
But, IMO, the suggested way is more unified in design and may also save a few
memory footprint in case we have
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/95
Thanks @Jaskey, this is indeed a good place to improve.
For the implementation, I suggest an alternative generic way, instead of
add a close future for each request, we add
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/95
invokeOneway should also be updated if so, otherwise, it's likely to leak
semaphore.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/95#discussion_r112623142
--- Diff:
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java
---
@@ -306,29 +307,35 @@ public void
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/56
@zhouxinyu it's been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/11
@hooligan520 Support for Windows is removed, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/11#discussion_r111867144
--- Diff: rocketmq-client4cpp/example/demo/AsyncProducer.cpp ---
@@ -0,0 +1,253 @@
+/**
+* Copyright (C) 2013 suwenkuang
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/11#discussion_r111866538
--- Diff: rocketmq-client4cpp/example/demo/AsyncProducer.cpp ---
@@ -0,0 +1,253 @@
+/**
+* Copyright (C) 2013 suwenkuang
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/93
> No output has been received in the last 10m0s, this potentially indicates
a stalled build or something wrong with the build itself. Check the details on
how to adjust your bu
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user lizhanhui reopened a pull request:
https://github.com/apache/incubator-rocketmq/pull/93
[ROCKETMQ-178] Fix -p -m options
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-178
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/93
[ROCKETMQ-178] Fix -p -m options
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-178
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524663
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111522507
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/82
Will look into this PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111319070
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
If the change is non
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/91
[ROCKETMQ-174]Fix spelling errors
This is to fix large number of spelling errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r67855
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r67737
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/89
Comment to bump up this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/78
Guys, any idea on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
> But I don't quite understand why it has to have so many levels -- why not
to remove rmqAddressServerDomain and let the user use only
rocketmq.namesrv.domain ... ?
Yes, I
1 - 100 of 160 matches
Mail list logo
