Re: Build failed in Jenkins: royale-asjs_jsonly #3219

> > >> > >> > >> [1] https://github.com/google/closure-compiler/issues/2134 > >> > >> > >> > >> > >> From: Harbs > >> Sent: Tuesday, July 9, 2019 11:58:10 AM > >> To: dev@roy

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

get some direction >> there. >> >> >> >> [1] https://github.com/google/closure-compiler/issues/2134 >> >> >> >> ________ >> From: Harbs >> Sent: Tuesday, July 9, 2019 11:58:10 AM >> To

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

> > > > > > > > [1] https://github.com/apache/royale-typedefs/blob/develop/js/build.xml > > > > > > > > ____________ > > From: Piotr Zarzycki > > Sent: Tuesday, July 9, 2019 11:19:06 AM > > To: dev@royale.apache.org

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

We have 2-3 inject_html in Jewel that can be used to try to configure the inject_hmtl in other way. It would be great to implement some other option that not depend from a CDN load, so Jewel can "eat its own food". If someone have clear how to do that and provide one example of that I can work on

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

IMO, the ability to override the URL for an inject_html is just a missing feature. My 2 cents, -Alex On 7/9/19, 9:30 AM, "Josh Tynjala" wrote: Especially if the purpose of inject_html is to load JS from a CDN. There will definitely be users of Royale who cannot have external

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

IMO, for any wrapping of third-party libraries, there should be inject_html for the third-party JS code. The Basic framework should avoid any use of third-party libraries and thus avoid inject_html, but it would be great to have lots of third-party libraries supported by other SWCs in Royale.

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

Especially if the purpose of inject_html is to load JS from a CDN. There will definitely be users of Royale who cannot have external dependencies like that, and they'll need a way to override the behavior to load a JS file from their own server instead. -- Josh Tynjala Bowler Hat LLC

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

I’m really not excited about the use of inject_html in Framework code. > On Jul 9, 2019, at 7:13 PM, Carlos Rovira wrote: > > Hi Alex, > > El mar., 9 jul. 2019 a las 17:43, Alex Harui ( >) > escribió: > >> IMO, adding an API for missing.js should only be done

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

Hi Alex, El mar., 9 jul. 2019 a las 17:43, Alex Harui () escribió: > IMO, adding an API for missing.js should only be done for APIs that are > truly cross-browser. If an API requires a polyfill, then if we add it to > missing.js and someone tries to use it on the browser that doesn't support >

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

url.js is part of the standard externs in the closure compiler repo. We only need to download the ones from royale-extras for files that are modified from the google one. > On Jul 9, 2019, at 2:39 PM, Piotr Zarzycki wrote: > > I thought this is the right place, from where I should download it

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

+1. > On Jul 9, 2019, at 6:43 PM, Alex Harui wrote: > > IMO, adding an API for missing.js should only be done for APIs that are truly > cross-browser. If an API requires a polyfill, then if we add it to > missing.js and someone tries to use it on the browser that doesn't support > it, it

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

IMO, adding an API for missing.js should only be done for APIs that are truly cross-browser. If an API requires a polyfill, then if we add it to missing.js and someone tries to use it on the browser that doesn't support it, it won't work for them without the polyfill. Either there should be a

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

ok Josh, so this means I was doin it correctly from the beginning. I'll do the change to put that API in missing Thanks! El mar., 9 jul. 2019 a las 16:57, Josh Tynjala () escribió: > Generally, if we need a browser API that Closure doesn't include in it's > official externs, we add it to

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

Generally, if we need a browser API that Closure doesn't include in it's official externs, we add it to missing.js in the appropriate library in royale-typedefs. - Josh On Tue, Jul 9, 2019, 4:39 AM Piotr Zarzycki wrote: > I thought this is the right place, from where I should download it to

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

I see you added that line. It does not look like url.js was modified in royale-extras. Why are you downloading it from there? > On Jul 9, 2019, at 2:26 PM, Piotr Zarzycki wrote: > > Hi Harbs, > > Unfortunately I don't see different. externc-config.xml has url.js in >

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

Hi Harbs, Unfortunately I don't see different. externc-config.xml has url.js in target/downloads/browser/url.js. Ant build is downloading url.js to that folder [2]. Maven build is doing exactly the same [3]. What am I missing ? [1]

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

Hi Harbs, I think using it through the polyfill is safe [1], since Jewel is already using it and working in Safari, IE11 and Edge (check TabBar example, indicators animation is done with animate FLIP technique). I think is the same as dialog API, that we're using in Jewel Alert from the

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

Take a look at the following files in the typedef repo: Lines 108-166 in build.xml Line 67 and later in pom.xml Notice the different paths in externc-config.xml > On Jul 9, 2019, at 11:57 AM, Carlos Rovira wrote: > > So I can add Web Animations API externs there, but this will trigger some >

RE: Build failed in Jenkins: royale-asjs_jsonly #3219

t; > From: Piotr Zarzycki > Sent: Tuesday, July 9, 2019 11:19:06 AM > To: dev@royale.apache.org > Subject: Re: Build failed in Jenkins: royale-asjs_jsonly #3219 > > Hi Yishay, > > Should I add also my stuff to make it work to Royale-Extras ? >

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

> >> Thoughts? >> >> >> >> >> >> [1] https://developer.mozilla.org/en-US/docs/Web/API/Element/animate >> >> [2] >> https://github.com/royale-extras/closure-compiler/blob/master/externs/browser/w3c_css.js >> >> >> &

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

he/royale-typedefs/blob/develop/js/build.xml > > > > > From: Piotr Zarzycki > Sent: Tuesday, July 9, 2019 11:19:06 AM > To: dev@royale.apache.org > Subject: Re: Build failed in Jenkins: royale-asjs_jsonly #3219 > > Hi Yishay,

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

___ > From: Piotr Zarzycki > Sent: Tuesday, July 9, 2019 11:19:06 AM > To: dev@royale.apache.org > Subject: Re: Build failed in Jenkins: royale-asjs_jsonly #3219 > > Hi Yishay, > > Should I add also my stuff to make it work to Royale-Extras ? > > Thanks,

RE: Build failed in Jenkins: royale-asjs_jsonly #3219

/blob/develop/js/build.xml From: Piotr Zarzycki Sent: Tuesday, July 9, 2019 11:19:06 AM To: dev@royale.apache.org Subject: Re: Build failed in Jenkins: royale-asjs_jsonly #3219 Hi Yishay, Should I add also my stuff to make it work to Royale-Extras ? Thanks, Piotr

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

-extras/closure-compiler/blob/master/externs/browser/w3c_css.js > > > > > From: Carlos Rovira > Sent: Tuesday, July 9, 2019 9:50:44 AM > To: dev@royale.apache.org > Subject: Re: Build failed in Jenkins: royale-asjs_jsonly #3219 > >

RE: Build failed in Jenkins: royale-asjs_jsonly #3219

://developer.mozilla.org/en-US/docs/Web/API/Element/animate [2] https://github.com/royale-extras/closure-compiler/blob/master/externs/browser/w3c_css.js From: Carlos Rovira Sent: Tuesday, July 9, 2019 9:50:44 AM To: dev@royale.apache.org Subject: Re: Build failed in Jenkins: royale

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

Ah! ok Piotr, I remember that. will try. thanks! :) El mar., 9 jul. 2019 a las 9:33, Piotr Zarzycki () escribió: > Hi Carlos, > > It looks like you have bump into similar issue as I am some time ago. I was > preparing Maven build but have following compilation problems [1] - Alex > point me

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

Hi Carlos, It looks like you have bump into similar issue as I am some time ago. I was preparing Maven build but have following compilation problems [1] - Alex point me what to do, but it didn't help. I didn't have time yet to back to that task, but I will have to sooner or later. If you figure

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

I think the problem is we really don't have "animate" method in our Element JS API. I think yesterday I made some kind of wrong compilation. Can we add this? https://developer.mozilla.org/es/docs/Web/API/Element/animate If so, where should this be done? thanks El mar., 9 jul. 2019 a las 8:45,

Re: Build failed in Jenkins: royale-asjs_jsonly #3219

Seems this change I did yesterday is failing as well in my daily build. How is possible this compiled ok yesterday with Maven? but today is failing? I'll be looking at it this morning 641725 bytes written to