Build failed in Jenkins: royale-compiler-integration-tests #422

See Changes: -- [...truncated 129.94 KB...] [junit] SEVERE: goog/object/object.js:307: ERROR - This language feature is only

Build failed in Jenkins: TourDeFlexMigration #497

See Changes: -- [...truncated 123.86 KB...] [mxmlc] Loading configuration: C:\jenkins\workspace\royale-asjs\frameworks\flex-config.xml [mxmlc]

Build failed in Jenkins: Royale_ASDoc_Example #498

See Changes: -- [...truncated 41.18 KB...] [java] ^ [java] [java]

Re: MXML and warn-public vars

I'm not surprised that this change fixed a problem caused by removing @export. This is not a question about the technical accuracy of your work, which is always very good. This just doesn't feel like the right solution. Maybe we should start by agreeing on facts and then goals and then

Build failed in Jenkins: royale-compiler-integration-tests #421

See Changes: -- [...truncated 129.51 KB...] [junit] [junit] Jan 17, 2020 5:03:21 AM

Build failed in Jenkins: TourDeFlexMigration #496

See Changes: -- [...truncated 123.22 KB...] [mxmlc] Loading configuration: C:\jenkins\workspace\royale-asjs\frameworks\flex-config.xml [mxmlc]

Build failed in Jenkins: Royale_ASDoc_Example #497

See Changes: -- [...truncated 40.55 KB...] [java] ^ [java] [java]

Build failed in Jenkins: royale-compiler-integration-tests #420

See Changes: -- [...truncated 130.67 KB...] [junit] SEVERE: goog/object/object.js:307: ERROR - This language feature is only

Build failed in Jenkins: TourDeFlexMigration #495

See Changes: -- [...truncated 124.62 KB...] [mxmlc] Loading configuration: C:\jenkins\workspace\royale-asjs\frameworks\flex-config.xml [mxmlc]

Re: MXML and warn-public vars

Even if we find a way to prevent renaming, some people are going to want to keep renaming enabled to minimize the size of their generated JS. In that situation, goog.reflect.objectProperty() will still be necessary. With that in mind, it may not be the full solution, but it's one step closer. --

Build failed in Jenkins: Royale_ASDoc_Example #496

See Changes: -- [...truncated 41.83 KB...] [java] ^ [java] [java]

Re: MXML and warn-public vars

On 1/16/20, 2:24 PM, "Harbs" wrote: In other words reflection? The reflection classes already deal with this IIUC. You’re right that a simplistic serializer will not work, but for that they wouldn’t be able to take advantage of the advanced minification anyway.

Re: MXML and warn-public vars

In other words reflection? The reflection classes already deal with this IIUC. You’re right that a simplistic serializer will not work, but for that they wouldn’t be able to take advantage of the advanced minification anyway. The recommended solution should be to use reflection classes or

Re: MXML and warn-public vars

On 1/16/20, 2:14 PM, "Harbs" wrote: What do you mean? This is the solution recommended by the compiler. What are your concerns? Someone writes their own deserializer. It is going to do something like: Var listOfProperties = ["firstName", "lastName"]; Function

Re: MXML and warn-public vars

What do you mean? This is the solution recommended by the compiler. What are your concerns? > On Jan 17, 2020, at 12:11 AM, Alex Harui wrote: > > OK. I still think this is not the right solution. As I said public vars are > for more than MXML.

Re: MXML and warn-public vars

On 1/16/20, 2:08 PM, "Harbs" wrote: Uh. No. You’d see data = [function, 1, ‘publicVar', true, 'value’] It’s a function call which returns the fed parameter. OK. I still think this is not the right solution. As I said public vars are for more than MXML. -Alex

Re: MXML and warn-public vars

Uh. No. You’d see data = [function, 1, ‘publicVar', true, 'value’] It’s a function call which returns the fed parameter. > On Jan 17, 2020, at 12:06 AM, Alex Harui wrote: > > And so when I have to debug the structure in js-debug, I will see > > data = [function, 1, function, true, 'value'] >

Re: MXML and warn-public vars

And so when I have to debug the structure in js-debug, I will see data = [function, 1, function, true, 'value'] And have no idea what property is being set? I'm not in favor of this change. The public var warning is not just for MXML. It is for any dynamic access by property name whether

Re: MXML and warn-public vars

Before: var data = [ Component, 1, 'publicVar', true, 'value' ] After (debug): var data = [ Component, 1, goog.reflect.objectProperty('publicVar'), true, 'value' ] In a release build, Closure compiler replaces the function call completely with the

Re: MXML and warn-public vars

Where does the goog.reflect.objectProperty appear in the output? In the data stream? On 1/16/20, 1:35 PM, "Harbs" wrote: Amazing! > On Jan 16, 2020, at 10:59 PM, Josh Tynjala wrote: > > Thank you, Harbs! Wrapping the variable name in a >

Re: MXML and warn-public vars

Amazing! > On Jan 16, 2020, at 10:59 PM, Josh Tynjala wrote: > > Thank you, Harbs! Wrapping the variable name in a > goog.reflect.objectProperty() call works perfectly. This is exactly why I > started this thread, to see if anyone could suggest possible alternatives. > > Thankfully, we can

Build failed in Jenkins: royale-compiler-integration-tests #419

See Changes: [aharui] add getter function for binding to properties of private members [joshtynjala] MXMLDescriptorSpecifier: uses goog.reflect.objectProperty() to

Re: MXML and warn-public vars

That sounds great, thanks for working on that Josh! I was meaning to take a look into the same goog stuff for possible optimizations in reflection data and AMF, but I don't think any of that is in the same league as the improvement you just made (because they currently work in release build

Re: MXML and warn-public vars

Thank you, Harbs! Wrapping the variable name in a goog.reflect.objectProperty() call works perfectly. This is exactly why I started this thread, to see if anyone could suggest possible alternatives. Thankfully, we can keep the same simple data structure as before, and my initial proposal with

Build failed in Jenkins: TourDeFlexMigration #494

See Changes: [carlosrovira] maven-distribution: add all themes to distribution so asconfigc.json -- [...truncated 124.13 KB...]

Build failed in Jenkins: Royale_ASDoc_Example #495

See Changes: [carlosrovira] maven-distribution: add all themes to distribution so asconfigc.json -- [...truncated 40.55 KB...]

Re: Fixing Maven Distribution

I would definitely go with Alex's suggestion. On Thu, Jan 16, 2020, 7:07 PM Alex Harui wrote: > I'm not really paying much attention to this thread so apologies if I am > off-topic, but remember that we have reproducible binaries in Royale these > days, so it should be possible to run a diff on

Build failed in Jenkins: royale-compiler-integration-tests #418

See Changes: -- [...truncated 129.26 KB...] [junit] SEVERE: goog/object/object.js:307: ERROR - This language feature is only

Build failed in Jenkins: TourDeFlexMigration #493

See Changes: [carlosrovira] maven-distribution: add compjsc and mxmljsc dummy hars to distribution -- [...truncated 124.12 KB...]

Re: MXML and warn-public vars

Simple is usually best. Changing what is currently a simple data stream into something that cannot be easily seen in the debugger is adding complexity. I'm pretty sure we can control the renaming in the Closure Compiler without changing how we write our code for them. We are already doing

RE: "has" vs "is": sharing code, swapping out subsystems, and more...

We do use [1] hasOwnProperty(). What went wrong? Maybe this needs to be in a different thread though, because the original thread is more about a getBeadByType() search. [1]

Re: Fixing Maven Distribution

I'm not really paying much attention to this thread so apologies if I am off-topic, but remember that we have reproducible binaries in Royale these days, so it should be possible to run a diff on an Ant folder vs a Maven distribution folder and see the differences (assuming you set the

Build failed in Jenkins: Royale_ASDoc_Example #494

See Changes: [carlosrovira] maven-distribution: add compjsc and mxmljsc dummy hars to distribution -- [...truncated 40.54 KB...]

Re: "has" vs "is": sharing code, swapping out subsystems, and more...

Currently "has" is getBeadByType(ISomeInterface). I personally don't want to spend the energy adding a new keyword to the language. Also, this kind of "has" is not the same as "hasOwnProperty". This is more about composition, not what properties exist. My first proposal for optimization is

Re: MXML and warn-public vars

I should add one thing that I remembered soon after sending this. If we want to get rid of @export to ultimately remove public APIs that aren't used, a similar pattern will probably be necessary for setters too. Setters without @export get renamed too. Ultimately, we chose to use Closure compiler,

Re: "has" vs "is": sharing code, swapping out subsystems, and more...

I like the idea of a “has”. What would the syntax be and how would it work? I’d love to be able to write if(foo has Baz) (and that would be compiled to something like if(Language.has(foo,Baz)) I’d also guess that it would loop through the list of beads and test “is” on all of them. For

Re: MXML and warn-public vars

I’m not sure that this increases function call overhead or code size. I suspect it will have the opposite effect. Basically, to avoid function calls in MXML structure, we’re requiring getters and setters in every public member. That results in two function calls in every class instantiation

Build failed in Jenkins: royale-compiler-integration-tests #417

See Changes: -- [...truncated 130.54 KB...] [junit] SEVERE: goog/object/object.js:307: ERROR - This language feature is only

Build failed in Jenkins: TourDeFlexMigration #492

See Changes: -- [...truncated 125.40 KB...] [mxmlc] Loading configuration: C:\jenkins\workspace\royale-asjs\frameworks\flex-config.xml [mxmlc]

Build failed in Jenkins: Royale_ASDoc_Example #493

See Changes: -- [...truncated 41.82 KB...] [java] ^ [java] [java]

Build failed in Jenkins: royale-compiler-integration-tests #416

See Changes: -- [...truncated 129.35 KB...] [junit] SEVERE: goog/object/object.js:307: ERROR - This language feature is only

Re: Fixing Maven Distribution

This is not an VSCode issue I believe. It's something wrong with SDK in my opinion. czw., 16 sty 2020 o 10:19 Carlos Rovira napisał(a): > Hi Piotr, > > thanks. I open TDJ in VSCode and build with Run Task > "build with > asconfigc" > > This outputs: > > > > Executing task:

Re: Fixing Maven Distribution

Try with Nightly Build of Moonshine to setup that sdk and create Hello World. czw., 16 sty 2020 o 11:41 Piotr Zarzycki napisał(a): > This is not an VSCode issue I believe. It's something wrong with SDK in my > opinion. > > czw., 16 sty 2020 o 10:19 Carlos Rovira > napisał(a): > >> Hi Piotr, >>

Build failed in Jenkins: TourDeFlexMigration #491

See Changes: [aharui] implement contentBackgroundColor on SkinnableTextInput and color on -- [...truncated 124.21 KB...] [mxmlc]

Build failed in Jenkins: Royale_ASDoc_Example #492

See Changes: [aharui] implement contentBackgroundColor on SkinnableTextInput and color on -- [...truncated 40.55 KB...] [java]

Re: "has" vs "is": sharing code, swapping out subsystems, and more...

Hi, recently I want to do a "has" instead of "is", but I couldn't. I'm not talking about at "bead" level, just something like we use to do in Flash (hasOwnProperty) Taking the code in [1]. I'd like to change this if(!(_strand is IDataGridColumnList)) for something like this

Re: Fixing Maven Distribution

Hi Piotr, thanks. I open TDJ in VSCode and build with Run Task > "build with asconfigc" This outputs: > Executing task: asconfigc --sdk=/Users/carlosrovira/Dev/Royale/Source/royale-asjs < Configuration options in asconfig.json require Apache Royale. Path to SDK is not valid:

Re: empty class names

For me is ok to change to have just one way. I think it will be beneficial too. Taking some code like the one I posted, what's the proposal to get the same? Some example code to showcase would be the best to understand El jue., 16 ene. 2020 a las 5:38, Alex Harui () escribió: > > > On 1/15/20,