Re: findbugs-annotations?

2016-10-18 Thread Josh Elser
/apache/phoenix/blob/master/phoenix-core/pom.xml#L277-L280 Aaron D. Mihalik wrote: Josh, I put up a PR to move Rya to findbugs-annotations [1]. Besides removing some annotations, the biggest change was to go from "import javax.annotation.Nullable" to "import edu.umd.cs.findbugs.annot

Re: findbugs-annotations?

2016-10-18 Thread Aaron D. Mihalik
Josh, I put up a PR to move Rya to findbugs-annotations [1]. Besides removing some annotations, the biggest change was to go from "import javax.annotation.Nullable" to "import edu.umd.cs.findbugs.annotations.Nullable". Does that look correct? I went over to Apache Phoenix

Re: findbugs-annotations?

2016-10-17 Thread Aaron D. Mihalik
I meant "fluo has a transitive dependency on findbugs:jsr305". I agree that findbugs-annotations is good and jsr305 is bad. On Mon, Oct 17, 2016 at 2:51 PM Puja Valiyil wrote: > Yea findbugs-annotations is not LGPL: > https://github.com/stephenc/findbugs-annotations > It app

Re: findbugs-annotations?

2016-10-17 Thread Puja Valiyil
Yea findbugs-annotations is not LGPL: https://github.com/stephenc/findbugs-annotations It appears to be apache 2, though aaron you should verify. On Mon, Oct 17, 2016 at 11:19 AM, Aaron D. Mihalik wrote: > fluo has a transitive dependency on findbugs-annotations, not direct. > > My

Re: findbugs-annotations?

2016-10-17 Thread Aaron D. Mihalik
fluo has a transitive dependency on findbugs-annotations, not direct. My issue is that com.github.stephenc.findbugs:findbugs-annotations:3.0.1-1 isn't in maven central. I think it would be straightforward for us to exclude and replace with c.g.s.f:findbugs-annotations:3.0.1-1, but it'

Re: findbugs-annotations?

2016-10-16 Thread Josh Elser
bugs:jsr305 (i.e. hadoop and fluo). --Aaron [1] http://stephenc.github.io/findbugs-annotations/distribution-management.html [2] https://oss.sonatype.org/content/repositories/releases/com/github/stephenc/findbugs/findbugs-annotations/ [3] https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations/

Re: findbugs-annotations?

2016-10-16 Thread Josh Elser
t's not ok :). You're bundling code whose license is dodgy. Either way you need to exclude the Findbugs' findbugs-annotations from these dependencies. Whether or not you replace in c.g.s.f:findbugs-annotations instead is up to you (not sure if you would run into problems) Aaron

findbugs-annotations?

2016-10-14 Thread Aaron D. Mihalik
ed for RC2, but I'm hoping that's okay because other projects depend on findbugs:jsr305 (i.e. hadoop and fluo). --Aaron [1] http://stephenc.github.io/findbugs-annotations/distribution-management.html [2] https://oss.sonatype.org/content/repositories/releases/com/github/stephenc/findbugs