Re: Review Request 50583: SAMZA-954 Improve logging for Samza

> On July 28, 2016, 8:37 p.m., Navina Ramesh wrote: > > samza-core/src/main/scala/org/apache/samza/util/Logging.scala, line 30 > > > > > > what happens if a logger by name "startupLoggerName" is not defined? > >

Re: Review Request 50588: SAMZA-982: Add null check for offset update in OffsetManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50588/#review144045 --- Ship it! Ship It! - Jake Maes On July 29, 2016, 12:13 a.m.,

Review Request 50590: Update jackson version in hello-samza to match samza

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50590/ --- Review request for samza, Jake Maes, Navina Ramesh, and Yi Pan (Data

Review Request 50588: SAMZA-982: Add null check for offset update in OffsetManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50588/ --- Review request for samza. Repository: samza Description --- During the

Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50451/#review144018 --- Ship it! +1. I would recommend to add the reason for this

Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

> On July 26, 2016, 10:39 p.m., Boris Shkolnik wrote: > > Are we sure that noone will try to upgraded from a version before migration > > to version 11 directly? We never test upgrading a version from 0.9 to 0.11 for all the changes. Even we keep this code around, the confidence of upgrading

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

> On July 28, 2016, 8:37 p.m., Navina Ramesh wrote: > > samza-core/src/main/scala/org/apache/samza/util/Logging.scala, line 30 > > > > > > what happens if a logger by name "startupLoggerName" is not defined? It

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

> On July 28, 2016, 8:42 p.m., Xinyu Liu wrote: > > samza-core/src/main/scala/org/apache/samza/util/Logging.scala, line 32 > > > > > > Nit: this method does info log which is not very straghtforward from > > the

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/#review144003 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On July

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/#review143998 --- Ship it! One minor suggestion below.

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/ --- (Updated July 28, 2016, 8:41 p.m.) Review request for samza, Boris Shkolnik,

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/#review143994 --- samza-core/src/main/scala/org/apache/samza/util/Logging.scala

Review Request 50583: SAMZA-954 Improve logging for Samza

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes,

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review143972 --- Ship it! Looks like this covers my comments. However, the