[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

2019-03-07 Thread GitBox
lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263661144 ## File path:

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

2019-03-07 Thread GitBox
lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263661119 ## File path:

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

2019-03-07 Thread GitBox
lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263661134 ## File path:

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

2019-03-07 Thread GitBox
lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r26366 ## File path:

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

2019-03-07 Thread GitBox
lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263661126 ## File path:

[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

2019-03-07 Thread GitBox
rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263657205 ## File path:

[GitHub] [samza] shanthoosh commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

2019-03-07 Thread GitBox
shanthoosh commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263647669 ## File path:

[GitHub] [samza] vjagadish1989 edited a comment on issue #905: SAMZA-2055: [WIP] Async high level api

2019-03-07 Thread GitBox
vjagadish1989 edited a comment on issue #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#issuecomment-470775503 also adding @xinyuiscool in case he has additional feedback on the async-api

[GitHub] [samza] cameronlee314 commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

2019-03-07 Thread GitBox
cameronlee314 commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263639549 ## File path:

[GitHub] [samza] mynameborat commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

2019-03-07 Thread GitBox
mynameborat commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263637333 ## File path:

[GitHub] [samza] shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

2019-03-07 Thread GitBox
shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263628931 ## File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java

[GitHub] [samza] xinyuiscool merged pull request #943: Update Samza version for 1.1.0 release branch

2019-03-07 Thread GitBox
xinyuiscool merged pull request #943: Update Samza version for 1.1.0 release branch URL: https://github.com/apache/samza/pull/943 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [samza] shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

2019-03-07 Thread GitBox
shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263628931 ## File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java

[GitHub] [samza] shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

2019-03-07 Thread GitBox
shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263628931 ## File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java

[GitHub] [samza] dxichen opened a new pull request #944: Release version updates

2019-03-07 Thread GitBox
dxichen opened a new pull request #944: Release version updates URL: https://github.com/apache/samza/pull/944 Updated hard coded version for the upcoming release This is an automated message from the Apache Git Service. To

[GitHub] [samza] dxichen opened a new pull request #943: Update Samza version for 1.1.0 release branch

2019-03-07 Thread GitBox
dxichen opened a new pull request #943: Update Samza version for 1.1.0 release branch URL: https://github.com/apache/samza/pull/943 Change versions as per RELEASE.md This is an automated message from the Apache Git Service.

Re: Trouble running samza 0.14 in standalone mode

2019-03-07 Thread Yi Pan
Great! Glad that you were able to figure it out! -Yi On Thu, Mar 7, 2019 at 3:14 AM Anoop Krishnakumar < anoop.krishnaku...@gmail.com> wrote: > Hi Yi, > > Apologies for my ignorance. I did not realize that attachments wont make > through and gist is the preferred method of sharing logs and code

[GitHub] [samza] cameronlee314 edited a comment on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

2019-03-07 Thread GitBox
cameronlee314 edited a comment on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#issuecomment-470745081 > @cameronlee314 I'd prefer to not add new fields/semantics to IME if possible. I'm assuming you want

[GitHub] [samza] cameronlee314 commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

2019-03-07 Thread GitBox
cameronlee314 commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#issuecomment-470745081 > @cameronlee314 I'd prefer to not add new fields/semantics to IME if possible. I'm assuming you want to

[GitHub] [samza] cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

2019-03-07 Thread GitBox
cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#issuecomment-470744806 > Looks good. > General question around checkpoint offset vs offset: > Are there other systems that will

[GitHub] [samza] mynameborat commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

2019-03-07 Thread GitBox
mynameborat commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263599960 ## File path: samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java

Re: "send to" ordering is inconsistent

2019-03-07 Thread Prateek Maheshwari
Hi Tom, It looks like we won't be able to include SAMZA-2116 in the upcoming 1.1 release due to time constraints. It'll have to go in to the 1.2 release, which will tentatively be in June. Does that still work for you? Thanks, Prateek On Thu, Feb 28, 2019 at 2:16 PM Tom Davis wrote: > Thanks,

Re: [DISCUSS] Samza 1.1.0 release

2019-03-07 Thread Daniel Chen
Unfortunately, due to the timeline of the release and the current status of SAMZA-2116, we will not be able to complete it for this release. I will try to target that for the next release (tentatively in June). - Daniel On Thu, Mar 7, 2019 at 1:43 PM Jacob Maes wrote: > I think the schedule

Re: [POSSIBLE PHISHING] Task Partition Commit Failed After Upgrade

2019-03-07 Thread Prateek Maheshwari
Jeremiah, were you able to resolve this issue? - Prateek On Wed, Mar 6, 2019 at 10:08 AM Prateek Maheshwari wrote: > Hi Jeremiah, > > The configuration you want to look for is: > 'job.systemstreampartition.grouper.factory'. It should default to: >

[GitHub] [samza] prateekm commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

2019-03-07 Thread GitBox
prateekm commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#issuecomment-470707705 @cameronlee314 I'd prefer to not add new fields/semantics to IME if possible. I'm assuming you want to return the

Re: [DISCUSS] Samza 1.1.0 release

2019-03-07 Thread Jacob Maes
I think the schedule sounds good. A release would be great. On Thu, Mar 7, 2019 at 10:38 AM Prateek Maheshwari wrote: > Daniel, let's try to include the following change in the release as well. > SAMZA-2116: Make sendTo and sink operators non-terminal > > Other than that, +1 (binding). > > -

[GitHub] [samza] cameronlee314 commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

2019-03-07 Thread GitBox
cameronlee314 commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#discussion_r263575676 ## File path:

[GitHub] [samza] rmatharu commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

2019-03-07 Thread GitBox
rmatharu commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#discussion_r263554894 ## File path: samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java

[GitHub] [samza] rmatharu commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

2019-03-07 Thread GitBox
rmatharu commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#discussion_r263553107 ## File path:

[GitHub] [samza] vjagadish1989 commented on issue #905: SAMZA-2055: [WIP] Async high level api

2019-03-07 Thread GitBox
vjagadish1989 commented on issue #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#issuecomment-470672963 1. Can you add an e2e integration test for a `StreamApp` + async-api 2. Additionally, update our website-docs and add public code examples

[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

2019-03-07 Thread GitBox
rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263535250 ## File path:

[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

2019-03-07 Thread GitBox
rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263535250 ## File path:

[GitHub] [samza] cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

2019-03-07 Thread GitBox
cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#issuecomment-470661443 @rmatharu @mynameborat could you please take a look?

[GitHub] [samza] cameronlee314 commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

2019-03-07 Thread GitBox
cameronlee314 commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#issuecomment-470661609 @rmatharu @mynameborat could you please take a look?

Re: [DISCUSS] Samza 1.1.0 release

2019-03-07 Thread Wei Song
+1 On 3/7/19, 9:23 AM, "Xinyu Liu" wrote: +1 (binding) Thanks, Xinyu On Thu, Mar 7, 2019 at 12:43 AM santhosh venkat < santhoshvenkat1...@gmail.com> wrote: > +1 (non-binding) > > Thanks, > > On Wed, Mar 6, 2019 at 10:42 PM Yi Pan wrote:

Re: [DISCUSS] Samza 1.1.0 release

2019-03-07 Thread Prateek Maheshwari
Daniel, let's try to include the following change in the release as well. SAMZA-2116: Make sendTo and sink operators non-terminal Other than that, +1 (binding). - Prateek On Thu, Mar 7, 2019 at 9:22 AM Xinyu Liu wrote: > +1 (binding) > > Thanks, > Xinyu > > On Thu, Mar 7, 2019 at 12:43 AM

[GitHub] [samza] prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

2019-03-07 Thread GitBox
prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263506752 ## File path:

[GitHub] [samza] prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

2019-03-07 Thread GitBox
prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263505840 ## File path:

Re: [DISCUSS] Samza 1.1.0 release

2019-03-07 Thread Xinyu Liu
+1 (binding) Thanks, Xinyu On Thu, Mar 7, 2019 at 12:43 AM santhosh venkat < santhoshvenkat1...@gmail.com> wrote: > +1 (non-binding) > > Thanks, > > On Wed, Mar 6, 2019 at 10:42 PM Yi Pan wrote: > > > +1 (binding) > > > > On Wed, Mar 6, 2019 at 10:08 PM Daniel Chen wrote: > > > > > Hello

Re: Trouble running samza 0.14 in standalone mode

2019-03-07 Thread Anoop Krishnakumar
Hi Yi, Apologies for my ignorance. I did not realize that attachments wont make through and gist is the preferred method of sharing logs and code snippets. Issue is resolved. I was using the default task.name.grouper.factory instead of GroupByContainerIdsFactory. Appreciate and thanks for the

Re: [DISCUSS] Samza 1.1.0 release

2019-03-07 Thread santhosh venkat
+1 (non-binding) Thanks, On Wed, Mar 6, 2019 at 10:42 PM Yi Pan wrote: > +1 (binding) > > On Wed, Mar 6, 2019 at 10:08 PM Daniel Chen wrote: > > > Hello everyone, > > > > We have added couple of major features to master since 1.0.0 that > warrants > > a major release. > > > > Within LinkedIn,