[GitHub] [samza] mynameborat commented on issue #748: SAMZA-1949: Add java docs and configuration documentation for side inputs

2019-04-03 Thread GitBox
mynameborat commented on issue #748: SAMZA-1949: Add java docs and configuration documentation for side inputs URL: https://github.com/apache/samza/pull/748#issuecomment-479742678 @prateekm I lost access to the old account. Let me open a new PR resolving the conflict so that we can merg

[GitHub] [samza] mynameborat closed pull request #895: SAMZA-2087: Use separate thread pools for AsyncStreamTaskAdapter and AsyncRunLoop

2019-04-03 Thread GitBox
mynameborat closed pull request #895: SAMZA-2087: Use separate thread pools for AsyncStreamTaskAdapter and AsyncRunLoop URL: https://github.com/apache/samza/pull/895 This is an automated message from the Apache Git Service.

[GitHub] [samza] mynameborat commented on issue #895: SAMZA-2087: Use separate thread pools for AsyncStreamTaskAdapter and AsyncRunLoop

2019-04-03 Thread GitBox
mynameborat commented on issue #895: SAMZA-2087: Use separate thread pools for AsyncStreamTaskAdapter and AsyncRunLoop URL: https://github.com/apache/samza/pull/895#issuecomment-479741972 @prateekm will close this one. Let me continue the discussion in the JIRA and will reopen this one

[GitHub] [samza] mynameborat closed pull request #930: [Cleanup] Remove deprecated kafka systems and related code

2019-04-03 Thread GitBox
mynameborat closed pull request #930: [Cleanup] Remove deprecated kafka systems and related code URL: https://github.com/apache/samza/pull/930 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [samza] mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272007958 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIn

[GitHub] [samza] mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272007700 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/SendToTableOperator

[GitHub] [samza] mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272007095 ## File path: samza-api/src/main/java/org/apache/samza/operators/functions/SinkFunction.ja

[GitHub] [samza] mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272005571 ## File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java #

[GitHub] [samza] mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272005397 ## File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java #

[GitHub] [samza] mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272004338 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/OutputOperatorImpl.

[GitHub] [samza] mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
mynameborat commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272005754 ## File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java #

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271997073 ## File path: samza-core/src/test/java/org/apache/samza/operators/impl/TestWindowOperator.java

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271997044 ## File path: samza-core/src/test/java/org/apache/samza/operators/TestOperatorSpecGraph.java #

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271992529 ## File path: samza-core/src/main/java/org/apache/samza/operators/MessageStreamImpl.java #

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271997102 ## File path: samza-core/src/test/java/org/apache/samza/operators/impl/TestWindowOperator.java

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271996938 ## File path: samza-core/src/test/java/org/apache/samza/execution/TestJobGraphJsonGenerator.jav

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271997395 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegra

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271992473 ## File path: samza-core/src/main/java/org/apache/samza/operators/MessageStreamImpl.java #

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271996994 ## File path: samza-core/src/test/java/org/apache/samza/operators/TestJoinOperator.java ##

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271996528 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/SendToTableOperatorImpl.

[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271996335 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/OutputOperatorImpl.java

[GitHub] [samza] Sanil15 commented on issue #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test

2019-04-03 Thread GitBox
Sanil15 commented on issue #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test URL: https://github.com/apache/samza/pull/985#issuecomment-479710683 @prateekm for review! This is an automated message from the

[GitHub] [samza] Sanil15 opened a new pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test

2019-04-03 Thread GitBox
Sanil15 opened a new pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test URL: https://github.com/apache/samza/pull/985 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [samza] prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271985042 ## File path: samza-api/src/main/java/org/apache/samza/operators/functions/SinkFunction.java

[GitHub] [samza] prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271983634 ## File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java

[GitHub] [samza] prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271983405 ## File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java

[GitHub] [samza] prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271983441 ## File path: samza-core/src/main/java/org/apache/samza/operators/MessageStreamImpl.java ###

[GitHub] [samza] prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271984574 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/SendToTableOperatorImp

[GitHub] [samza] prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
prateekm commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271983546 ## File path: samza-core/src/main/java/org/apache/samza/operators/MessageStreamImpl.java ###

[GitHub] [samza] prateekm commented on issue #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
prateekm commented on issue #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#issuecomment-479707508 @bharathkk can you take a look? This is an automated m

[GitHub] [samza] Sanil15 opened a new pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

2019-04-03 Thread GitBox
Sanil15 opened a new pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984 This is an automated message from the Apache Git Service. To respond t

[GitHub] [samza] cameronlee314 commented on issue #930: [Cleanup] Remove deprecated kafka systems and related code

2019-04-03 Thread GitBox
cameronlee314 commented on issue #930: [Cleanup] Remove deprecated kafka systems and related code URL: https://github.com/apache/samza/pull/930#issuecomment-479700189 This PR is obsolete now, because it was done in the Kafka 2.0 upgrade PR, right? -

[GitHub] [samza] asfgit closed pull request #980: Cleaned up AM logs and naming convention

2019-04-03 Thread GitBox
asfgit closed pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: Context when Converting from Yarn Task to Standalone LocalApplicationRunner

2019-04-03 Thread Cameron Lee
Hi Jeremiah, If you would like to continue to use the low-level API (i.e. StreamTask), then you actually will want to use TaskApplication, not StreamApplication. Sorry for the confusion regarding the naming of the classes. Take a look at https://samza.apache.org/learn/documentation/latest/api/low-

Re: Context when Converting from Yarn Task to Standalone LocalApplicationRunner

2019-04-03 Thread Yi Pan
Hi, Jeremiah, In the new apis, you should be using ApplicationContainerContextFactory and ApplicationTaskContextFactory to instantiate context objects used in the whole container or in a task instance, respectively. The context factories should be implemented as dependencies injected to your imple

[GitHub] [samza] srinipunuru merged pull request #983: Samza-2154: Fixing the testSinkEndToEndWithKeyWithNullRecords test case

2019-04-03 Thread GitBox
srinipunuru merged pull request #983: Samza-2154: Fixing the testSinkEndToEndWithKeyWithNullRecords test case URL: https://github.com/apache/samza/pull/983 This is an automated message from the Apache Git Service. To respond

[GitHub] [samza] Zhangyx39 commented on issue #982: SAMZA-2153: Implement to Config for TableRetryPolicy

2019-04-03 Thread GitBox
Zhangyx39 commented on issue #982: SAMZA-2153: Implement to Config for TableRetryPolicy URL: https://github.com/apache/samza/pull/982#issuecomment-479660106 @weisong44 @dengpanyin This is an automated message from the Apache

[GitHub] [samza] srinipunuru opened a new pull request #983: Fixing the testSinkEndToEndWithKeyWithNullRecords test case

2019-04-03 Thread GitBox
srinipunuru opened a new pull request #983: Fixing the testSinkEndToEndWithKeyWithNullRecords test case URL: https://github.com/apache/samza/pull/983 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [samza] Zhangyx39 opened a new pull request #982: SAMZA-2153: Implement to Config for TableRetryPolicy

2019-04-03 Thread GitBox
Zhangyx39 opened a new pull request #982: SAMZA-2153: Implement to Config for TableRetryPolicy URL: https://github.com/apache/samza/pull/982 Added setTableId and getTableId to TablePart interface. Implemented toConfig method in TableRetryPolicy to serialize the class to json format so t

[GitHub] [samza] asfgit closed pull request #905: SAMZA-2055: Async high level api

2019-04-03 Thread GitBox
asfgit closed pull request #905: SAMZA-2055: Async high level api URL: https://github.com/apache/samza/pull/905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Context when Converting from Yarn Task to Standalone LocalApplicationRunner

2019-04-03 Thread Jeremiah Adams
?I am working to move our code from Yarn based StreamTask to standalone StreamApplication via LocalTaskRunner. I'm having some trouble understanding how to create/fetch a Context for use in the IntiableFunction.init() interface. My old code used context to get the store for LocalCacheManager i

[GitHub] [samza] asfgit closed pull request #981: SAMZA-2152 : Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when required

2019-04-03 Thread GitBox
asfgit closed pull request #981: SAMZA-2152 : Bugfix: Making KafkaSytemAdmin's metadataConsumer accesses thread-safe, enabling StreamRegexMonitors only when required URL: https://github.com/apache/samza/pull/981 This is an

Re: Running w/ multiple CPUs/container on YARN

2019-04-03 Thread Prateek Maheshwari
Glad you were able to figure it out. FWIW, I had the same interpretation as you. Let us know if you need anything else. - Prateek On Tue, Apr 2, 2019 at 4:55 PM Malcolm McFarland wrote: > Found the issue, and thank goodness it was a configuration issue on my end: > I was setting the yarn.schedu