Re: [VOTE] SEP 25: PR Title and Description Guidelines

2019-12-19 Thread Jake Maes
+1 (binding) On Thu, Dec 19, 2019, 10:59 AM wrote: > > +1 (non-binding) > > Thanks, > Daniel C > > > On Dec 19, 2019, at 1:48 PM, Xinyu Liu wrote: > > > > +1 (binding). > > > > Thanks, > > Xinyu > > > >> On Wed, Dec 18, 2019 at 7:49 PM Jagadish Venkatraman < > jagadish1...@gmail.com> > >>

Re: [VOTE] SEP-18: Startpoints - Manipulating Starting Offsets for Input Streams

2019-09-06 Thread Jake Maes
+1 (binding) Been looking forward to this one for a while. Nice work, Dan! On Fri, Sep 6, 2019 at 10:58 AM Prateek Maheshwari wrote: > +1 (binding). Thanks! > > - Prateek > > On Fri, Sep 6, 2019 at 8:32 AM Bharath Kumara Subramanian < > codin.mart...@gmail.com> wrote: > > > +1 (non-binding) > >

Re: [DISCUSS] 1.2 release

2019-05-20 Thread Jake Maes
ticket is > resolved as FIXED. I can remove it the tag from the jira, but I cannot > remove it from the git log. > > On Mon, May 20, 2019 at 9:39 AM Jake Maes wrote: > > > I don't think we did anything for "Making sendTo(table), sendTo(stream) > > non-terminal". The t

Re: [DISCUSS] 1.2 release

2019-05-20 Thread Jake Maes
I don't think we did anything for "Making sendTo(table), sendTo(stream) non-terminal". The ticket was just closed as a "won't fix" IIRC. Nevertheless, I think the Kafka 2.0 upgrade warrants a release by itself. Let's do it. On Fri, May 17, 2019 at 12:17 PM Boris S wrote: > Hi all, > > We have

Re: [VOTE] SEP-21: Samza Async API for High Level

2019-03-28 Thread Jake Maes
+1 (binding) On Mon, Mar 25, 2019 at 6:09 PM Jagadish Venkatraman wrote: > +1 (binding); > > thanks Bharath for the proposal and the implementation. > > LGTM; > > On Monday, March 25, 2019, Bharath Kumara Subramanian < > codin.mart...@gmail.com> wrote: > > > Hi all, > > > > > > This is a call

Re: [VOTE] Apache Samza 1.1.0 RC2

2019-03-18 Thread Jake Maes
Verified with check-all on RHEL 7 Verified pgp and sha. +1 (binding) On Fri, Mar 15, 2019 at 11:39 AM rayman preet wrote: > +1 (Non-binding) > > -- > thanks > rayman > > On Wed, Mar 13, 2019 at 7:17 PM Daniel Chen wrote: > > > Hi, > > > > I performed the following verifications: > > > > 1.

Streams Meetup at LinkedIn Sunnyvale, 3/20/2019

2019-03-04 Thread Jake Maes
Hi Folks, We're going to have another streams meetup at LinkedIn this month. The meetup will feature three great talks which touch on a number of stream processing technologies including Apache Samza , Brooklin Mirror Maker, and Facebook's Puma

Re: apache git link is no longer valid

2019-02-13 Thread Jake Maes
Hi Yang, Thanks for pointing this out! It looks like we missed this during the migration to gitbox. https://issues.apache.org/jira/browse/INFRA-17766 I'll file a ticket for it. Jake On Tue, Feb 12, 2019 at 1:40 PM Yang Zhang wrote: > Hello Samza, > > Many Samza tutorials (including the

Re: [VOTE] Migration of Samza git repo to gitbox.apache.org

2019-01-24 Thread Jake Maes
+1 (binding) On Wed, Jan 23, 2019 at 10:35 PM santhosh venkat < santhoshvenkat1...@gmail.com> wrote: > +1 (binding). > > Thanks, > > On Wed, Jan 23, 2019 at 2:43 PM Jagadish Venkatraman < > jagadish1...@gmail.com> > wrote: > > > +1 (binding). Thank you Pawas for driving this! > > > > On Wed, Jan

Re: [ANNOUNCE] New committer announcement

2019-01-15 Thread Jake Maes
Congrats and welcome, Shanthoosh! On Tue, Jan 15, 2019 at 11:50 AM Xinyu Liu wrote: > Hi, all, > > Please join me and the rest of the Samza PMC in welcoming a new committer: > > - Shanthoosh Venkataraman: of, but not limited to, his work on Samza > standalone. > > Through his work on

Re: [DISCUSS] Mandatory migration of Samza git repo to gitbox.apache.org

2019-01-15 Thread Jake Maes
Yeah, sounds pretty light weight. Quick question for committers: Do we anticipate this affecting our merge script? Perhaps we won't need the merge script, since we'll be able to use github directly. Thoughts? -Jake On Tue, Jan 15, 2019 at 11:49 AM Prateek Maheshwari wrote: > Thanks for

Re: Draft report to board - Jan 2019

2019-01-10 Thread Jake Maes
LGTM as well. Thanks, Yi! -Jake On Wed, Jan 9, 2019 at 12:41 PM Yi Pan wrote: > Thanks! Updated inline accordingly. > > -Yi > > On Wed, Jan 9, 2019 at 12:32 PM Prateek Maheshwari > wrote: > > > Thanks for the summary Yi. I'd change: "HDFS based backup/restore of > > state stores" to

Re: Release artifacts published for Samza 1.0.0

2018-11-08 Thread Jake Maes
Great! Thanks, Jagadish. On Thu, Nov 8, 2018 at 11:36 AM Jagadish Venkatraman wrote: > Hey everyone, > > Now that the vote has concluded, binaries for Samza 1.0.0 have been > published to Maven.. I'll follow up with a blogpost on the release early > next week. > > Note that Samza 1.0.0 has a

Re: Welcome Hai Lu and Aditya Toomla as committers to Apache Samza!

2018-11-06 Thread Jake Maes
Welcome Hai and Aditya. Nice work! On Tue, Nov 6, 2018 at 10:20 AM Yi Pan wrote: > Hi, all, > > All official steps are completed and please join me to welcome Hai and > Aditya to Apache Samza community as committers! They have been making > significant contribution to many important projects in

Re: Welcome Prateek Maheshwari to Apache Samza PMC

2018-11-02 Thread Jake Maes
Nice work, Prateek! On Thu, Nov 1, 2018 at 5:17 PM Yi Pan wrote: > Hi, all, > > Please join me to welcome Prateek Maheshwari to Apache Samza PMC! Great to > have you in the PMC, Prateek! > > Cheers! > > -Yi >

Re: [VOTE] Apache Samza 1.0.0 RC3

2018-10-30 Thread Jake Maes
+1 binding Ran check-all on OSX with Gradle 2.8 On Mon, Oct 29, 2018 at 10:13 PM Prateek Maheshwari wrote: > Hi all, > > This is a call for a vote on a release of Apache Samza 1.0.0. Thanks to > everyone who has contributed to this release. > > The release candidate can be downloaded from

Re: [VOTE] SEP-15: New Runtime Context API

2018-10-16 Thread Jake Maes
+1 (binding) On Tue, Oct 16, 2018 at 3:00 PM Yi Pan wrote: > +1 (binding) > > This has been long-waited feature to allow us to have better control and > access to shared object in different scope of context! > > -Yi > > On Mon, Oct 15, 2018 at 10:47 AM Jagadish Venkatraman < >

Re: [Discuss] Samza 0.14.1 release

2018-05-01 Thread Jake Maes
Yes, lets do it. On Tue, May 1, 2018 at 11:55 AM, Tom Davis wrote: > Yeah, I'd love that! > > > On Tue, May 1, 2018, at 1:05 PM, Yi Pan wrote: > > Yes, for Kafka 0.11 change, it mainly just affects the Kafka system > > factory, admin, consumer, and producer's

Re: please unsubscribe me from this samza list - thx

2018-03-17 Thread Jake Maes
Hey Roger, Try sending an email to this address: dev-unsubscr...@samza.apache.org The links for Samza mailing lists are provided on the mailing lists page: http://samza.apache.org/community/mailing-lists.html Hope this helps. -Jake On Fri, Mar 16, 2018 at 8:51 PM, Roger Sill

Streams Meetup at LinkedIn Sunnyvale 3/21/2018

2018-03-01 Thread Jake Maes
Hi Folks, We're going to have another streams meetup at LinkedIn this month. The meetup will feature three great talks which touch on a number of technologies used in stream processing including Apache Calcite , Kafka , Pulsar

Re: Welcome Xinyu as new Samza PMC!

2018-01-17 Thread Jake Maes
Nice work, Xinyu! On Wed, Jan 17, 2018 at 11:55 AM, Bharath Kumarasubramanian < bkumarasubraman...@linkedin.com> wrote: > Congratulations Xinyu! Well deserved ( > > On 1/17/18, 11:23 AM, "Fred Haifeng Ji" wrote: > > Congratulations Xinyu! > > Fred > > On Wed,

Re: [VOTE] Apache Samza 0.14.0 RC3

2017-12-20 Thread Jake Maes
+1 binding Verified git tag `release-0.14.0-rc3` Verified source signature Ran check-all.sh on both Linux and OSX Ran integration tests from OSX LGTM On Tue, Dec 19, 2017 at 10:00 AM, Boris S wrote: > Verified signature. > Ran unit and integration tests. > As usual had to

Re: Samza Standalone from multiple machines

2017-10-18 Thread Jake Maes
Hey Giridhar, Boris would have more knowledge on this, but I'll offer a couple pointers: Running the "Hello Samza" application on multiple hosts should just be a matter of changing the "job.coordinator.zk.connect" property in the config

[RESULT][VOTE] Release Apache Samza 0.13.0 (RC6)

2017-06-08 Thread Jake Maes
The vote of 0.13.0 RC6 has been open for more than 72 hours and we got +1 (binding) x 3 +1 (non-binding) x 4. Samza 0.13.0 officially passed the vote. The release and site will be published right away. If you don't see them by tomorrow, let me know. Thanks everyone! Jake

[VOTE] Apache Samza 0.13.0 RC6

2017-06-05 Thread Jake Maes
This is a call for a vote on a release of Apache Samza 0.13.0. Thanks to everyone who has contributed to this release. We are very glad to see some new contributors and features in this release. The release candidate can be downloaded from here: http://home.apache.org/~jmakes/samza-0.13.0-rc6/

Stream Processing Meetup on May 24th at LinkedIn Sunnyvale

2017-05-08 Thread Jake Maes
Hey Folks, We wanted to invite you to the upcoming Stream Processing meetup at the Linkedin Sunnyvale HQ. The meetup is on Wednesday May 24 from 6-9PM. We'll have food and refreshments as usual, but more importantly we have 3 exciting talks planned. - Streaming Data Pipelines with Brooklin

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

2017-02-08 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164782 --- Ship it! Ship It! - Jake Maes On Feb. 8, 2017, 9:37 p.m

[DISCUSS] SAMZA-1041 Multi-stage feature for Samza

2016-12-13 Thread Jake Maes
Hey folks, A while ago I created SAMZA-1041 to add a multistage feature to Samza. The goal was to enable users to deploy a set of processors as a unit with the intermediate topics being created automatically. There are a number of use cases,

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-16 Thread Jake Maes
on a JIRA - Jake Maes On Nov. 16, 2016, 5:44 a.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-11 Thread Jake Maes
--- On Nov. 11, 2016, 12:22 a.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53297/ > --- >

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-05 Thread Jake Maes
> On Nov. 5, 2016, 6:47 p.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java, line > > 75 > > <https://reviews.apache.org/r/53297/diff/1/?file=1549407#file1549407line75> > > > > I don't think the Me

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-05 Thread Jake Maes
the MetricsConfig constructure takes a subset. I think it takes the root and expects to find the "metrics" prefix - Jake Maes On Oct. 31, 2016, 9:18 p.m., Shanthoosh Venkataraman wrote: > > --- > This is a

Re: [DISCUSS] Offset checkpoint notification to the System Consumer

2016-10-26 Thread Jake Maes
Link, to save folks some time: https://issues.apache.org/jira/browse/SAMZA-1042 I'll take a look and post any comments in the JIRA soon. On Tue, Oct 25, 2016 at 9:37 AM, Boris Shkolnik wrote: > Currently we keep track of the progress of each consumer using > checkpointing

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-25 Thread Jake Maes
her yarn component or concept should be referenced. - Jake Maes On Oct. 25, 2016, 8:14 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-24 Thread Jake Maes
emoved. This could be just "node" - Jake Maes On Oct. 20, 2016, 9:52 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-24 Thread Jake Maes
> On Oct. 17, 2016, 9:38 p.m., Jake Maes wrote: > > One last thing that occurs to me. Since DefaultResourceFactory now includes both JobsResource and TasksResource, can you make sure the tutorial still works as written? We need every step to be exact s.t. users aren't confus

Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-20 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47994/#review153501 --- Ship it! LGTM, Thanks! - Jake Maes On Oct. 21, 2016, 12:45

Re: Review Request 52960: SAMZA-1029: Prepare release candidate for 0.11.0

2016-10-19 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52960/#review153288 --- Ship it! Ship It! - Jake Maes On Oct. 18, 2016, 9:28 p.m

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Jake Maes
s. Can this be done with Strings? https://google.github.io/guava/releases/19.0/api/docs/com/google/common/base/Strings.html Commons is probably a transitive dependency. So while, we could get away with it now, it could break later. - Jake Maes On Oct. 18, 2016, 10:53 p.m., Shan

Re: Review Request 53000: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

2016-10-18 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53000/#review153191 --- Ship it! Ship It! - Jake Maes On Oct. 18, 2016, 10:17 p.m

Re: Review Request 53004: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

2016-10-18 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53004/#review153193 --- Ship it! Ship It! - Jake Maes On Oct. 18, 2016, 10:17 p.m

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-17 Thread Jake Maes
ame in this class, do we really need to make this Yarn-specific or can we make it generic now? - Jake Maes On Oct. 13, 2016, 9:01 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-17 Thread Jake Maes
/SamzaContainer.scala (line 99) <https://reviews.apache.org/r/52168/#comment222160> shouldn't this line also use the new Util method to get the container name? - Jake Maes On Oct. 13, 2016, 11:57 p.m., Shanthoosh Venkataraman

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-17 Thread Jake Maes
(line 55) <https://reviews.apache.org/r/52168/#comment222151> Why has this property been added to this test? It should not be mandatory. - Jake Maes On Oct. 13, 2016, 11:57 p.m., Shanthoosh Venkataraman wrote: > > --- > T

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-17 Thread Jake Maes
> On Oct. 13, 2016, 12:55 a.m., Jake Maes wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55 > > <https://reviews.apache.org/r/52168/diff/5/?file=1533539#file1533539line55> > > > > What is the value of the container name? &

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-17 Thread Jake Maes
> On Oct. 5, 2016, 2:08 a.m., Jake Maes wrote: > > Looks better, but I think there's still one major part missing. > > > > In order to have agreement between a kafka changelog and the task storage, > > the changelog should be created with the same d

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-12 Thread Jake Maes
e TaskResourceConfig. Shouldn't it be BaseResourceConfig.CONFIG_JOB_INSTALLATIONS_PATH? There are multiple occurrences of this. samza-rest/src/test/java/org/apache/samza/rest/resources/TestJobsResource.java (line 55) <https://reviews.apache.org/r/52168/#comment221445>

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-12 Thread Jake Maes
> On Oct. 10, 2016, 7:27 p.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java, > > line 84 > > <https://reviews.apache.org/r/52492/diff/2/?file=1527756#file1527756line84> > > > > Shouldn't this

Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-10 Thread Jake Maes
> On Oct. 7, 2016, 9:04 p.m., Jake Maes wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/internal/Operators.java, > > line 61 > > <https://reviews.apache.org/r/47994/diff/3/?file=1522711#file1522711line61> > > > > 3 thoug

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-10 Thread Jake Maes
8/docs/technotes/guides/language/static-import.html "So when should you use static import? Very sparingly!" - Jake Maes On Oct. 8, 2016, 12:07 a.m., Shanthoosh Venkataraman wrote: > >

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-10 Thread Jake Maes
"So when should you use static import? Very sparingly!" samza-rest/src/test/java/org/apache/samza/rest/resources/TestTasksResource.java (line 60) <https://reviews.apache.org/r/52168/#comment220681> It's not sufficient to only test the happy path. The best way to enforce a c

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-04 Thread Jake Maes
l if those other systems have a delete retention policy. - Jake Maes On Oct. 4, 2016, 11:33 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 51689: Fix SAMZA-1012 - Generated changelog mappings are not consistent

2016-10-04 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51689/#review151342 --- Ship it! Ship It! - Jake Maes On Sept. 13, 2016, 12:26 p.m

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-03 Thread Jake Maes
. 2. I'm all for descriptive names, but this is almost un-tweet-able. :-) Could it be shortened to: testStoreDeletedWhenOffsetFileOlderThanDeleteRetention() - Jake Maes On Oct. 3, 2016, 5 p.m., Shanthoosh Venkat

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-27 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review150600 --- Ship it! Ship It! - Jake Maes On Sept. 27, 2016, 6:57 p.m

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-26 Thread Jake Maes
> On Sept. 26, 2016, 9:46 p.m., Jake Maes wrote: > > docs/learn/documentation/versioned/rest/monitors.md, lines 43-50 > > <https://reviews.apache.org/r/51703/diff/5/?file=1510337#file1510337line43> > > > > These properties replace monitor.classes and mo

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-26 Thread Jake Maes
nitorConfigs() traverses the keyset of the Map in MapConfig. The order of that keyset is not guaranteed, so it can be in a different order than the "expected" List. - Jake Maes On Sept. 26, 2016, 9:13 p.m., Shantho

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-26 Thread Jake Maes
t/src/test/java/org/apache/samza/monitor/TestMonitorService.java (lines 73 - 76) <https://reviews.apache.org/r/51703/#comment218432> If I'm reading this correctly, this test depends on MapConfig to retain ord

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-23 Thread Jake Maes
nitor config directly to get the interval, rather than exposing a method in the monitor (getSchedulingIntervalInMs) - Jake Maes On Sept. 23, 2016, 11:19 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically gener

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-23 Thread Jake Maes
> On Sept. 23, 2016, 8:33 p.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java, > > lines 75-76 > > <https://reviews.apache.org/r/51703/diff/2/?file=1498674#file1498674line75> > > > > What purpose does t

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-23 Thread Jake Maes
ervice should not fail because a new monitor is broken. It should definitely log it though. samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java (lines 74 - 75) <https://reviews.apache.org/r/51703/#comment218095> What purpose does this serve? - Jake Maes On Sept.

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-23 Thread Jake Maes
org/r/51703/#comment218092> I don't think this test actually verifies anything anymore. It's supposed to prove that an exception in a monitor instance will not cause the samza rest service to fail (via the ExceptionThrowingMonitor) - Jak

Re: Review Request 52030: Fix SAMZA-1018

2016-09-19 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52030/#review149475 --- Ship it! Ship It! - Jake Maes On Sept. 19, 2016, 12:26 p.m

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-13 Thread Jake Maes
/apache/samza/rest/SamzaRestConfig.java (line 69) <https://reviews.apache.org/r/51703/#comment216240> As mentioned above, I don't think this is necessary. It's simpler to have 1 config file for the entire rest service, parse it once, and subset it for the various components.

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-09-01 Thread Jake Maes
tter of personal taste, but I feel this code would be easier to parse and understand if the lambdas were predefined functions. For me lambdas are for the super simple cases. If the goal of this is to actually test the lambdas, then ignore this feedback. - Jake Maes On

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-09-01 Thread Jake Maes
ormer doesn't read like English. Could be slightly better if the name was "filterWith" but apply() still feels best. - Jake Maes On Aug. 26, 2016, 8:43 p.m., Yi Pan (Data Infrastructure) wrote: > > --- > This is an aut

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-08-30 Thread Jake Maes
est/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java (line 39) <https://reviews.apache.org/r/47835/#comment214313> Naming: Since this has been moved out of sql-core, the class should probably also be renamed to just "AvroSerdeTest" - Jake

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

2016-08-29 Thread Jake Maes
means this END_OF_STREAM_OFFSET.equals(...) bit wouldn't need to be repeated in AsyncRunLoop. - Jake Maes On Aug. 25, 2016, 11:52 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 51228: SAMZA-1000 Update readme for hello-samza with a local build

2016-08-18 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51228/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes

Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to not use latest branch by default

2016-08-18 Thread Jake Maes
e latest > > version of hello-samza documentation include the checkout latest and make > > this publishToMavenLocal as mandatory, while removing both the checkout > > latest and the publishToMavenLocal in the released version of document? > > Jake Maes wrote: > I thought we agreed tha

Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to not use latest branch by default

2016-08-18 Thread Jake Maes
, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-1000 https://issues.apache.org/jira/browse/SAMZA-1000 Repository: samza Description --- SAMZA-1000 Fix hello-samza documentation to not use latest branch

Re: Review Request 51225: SAMZA-1003: Restore lazy init for kafka system producer

2016-08-18 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51225/#review146138 --- Ship it! Ship It! - Jake Maes On Aug. 18, 2016, 10:12 p.m

Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to not use latest branch by default

2016-08-17 Thread Jake Maes
s? - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51047/#review145916 --- On Aug. 15, 2016, 6:18 p.m., Jake Maes wrote: > >

Re: Review Request 50151: SAMZA-975 Initial Samza REST Implementation

2016-08-17 Thread Jake Maes
, Chris Pettitt, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-975 https://issues.apache.org/jira/browse/SAMZA-975 Repository: samza Description --- SAMZA-975 Initial Samza REST Implementation Implementation closely reflects

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-17 Thread Jake Maes
ce.sh to be executable (chmod 755) > > Jake Maes wrote: > I think it is. I just applied the patch from JIRA to a fresh copy of > samza on both my mac and linux machines an had no problems running through > the tutorial. > > Also: > ``` > samza-rest[master]

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-17 Thread Jake Maes
ionFinder > > [WARN] Config path not found: > > /home/nramesh/Projects/samza-hello-samza/deploy/samza/config/config > > > > > > Looks like it is appening "config" to any path it tries to access. I > > have to look into your implementation

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-17 Thread Jake Maes
ionFinder > > [WARN] Config path not found: > > /home/nramesh/Projects/samza-hello-samza/deploy/samza/config/config > > > > > > Looks like it is appening "config" to any path it tries to access. I > > have to look into your implementation

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Jake Maes
, Chris Pettitt, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-976 https://issues.apache.org/jira/browse/SAMZA-976 Repository: samza Description --- SAMZA-976 Samza REST Documentation Diffs (updated) - .gitignore

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Jake Maes
a.m., Navina Ramesh wrote: > > bin/generate-javadocs.sh, line 21 > > <https://reviews.apache.org/r/50154/diff/6/?file=1458025#file1458025line21> > > > > We need to add this path to .gitignore. > > We should add this path to build.gra

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Jake Maes
, Chris Pettitt, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-976 https://issues.apache.org/jira/browse/SAMZA-976 Repository: samza Description --- SAMZA-976 Samza REST Documentation Diffs (updated) - .gitignore

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Jake Maes
enerated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review145822 --- On July 29, 2016, 6:58 p.m., Jake Maes wrote: > > --- > This is an automatically generated

Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to not use latest branch by default

2016-08-15 Thread Jake Maes
, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-1000 https://issues.apache.org/jira/browse/SAMZA-1000 Repository: samza Description --- SAMZA-1000 Fix hello-samza documentation to not use latest branch

Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to not use latest branch by default

2016-08-15 Thread Jake Maes
, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-1000 https://issues.apache.org/jira/browse/SAMZA-1000 Repository: samza Description --- SAMZA-1000 Fix hello-samza documentation to not use latest branch

Review Request 51047: SAMZA-1000 Fix hello-samza documentation to not use latest branch by default

2016-08-12 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51047/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes

Re: Review Request 47992: Improve logging by adding a startup logger.

2016-08-04 Thread Jake Maes
://reviews.apache.org/r/50583/ and can be discarded. - Jake Maes On July 20, 2016, 6:01 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 50682: SAMZA-993 Fix logging bug for some scala versions

2016-08-01 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50682/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes

Review Request 50667: SAMZA-989 - Update hello-samza to use the startup logger

2016-08-01 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50667/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes

Re: Review Request 50619: SAMZA-963: add KV storage engine timers to help identify the issues on kv stores and also add unit test

2016-07-29 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50619/#review144219 --- Ship it! LGTM - Jake Maes On July 29, 2016, 10:24 p.m

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Jake Maes
tps://reviews.apache.org/r/50614/#comment210202> This is the only change I'm unclear on. Does this affect the ".../latest/..." URL in the documentation site? If so, it seems we wouldn't want to change it. - Jake Maes On July 29, 2016, 9:04 p.m., Nav

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-29 Thread Jake Maes
, Chris Pettitt, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-976 https://issues.apache.org/jira/browse/SAMZA-976 Repository: samza Description --- SAMZA-976 Samza REST Documentation Diffs (updated) - bin/generate

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-29 Thread Jake Maes
> On July 27, 2016, 9:36 p.m., Navina Ramesh wrote: > > I think it will be simpler if we can just provide architectural overview in > > the website and add a separate tutorial to run it with samza-hello-samza. > > Thanks! > > Jake Maes wrote: > So, do you

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-29 Thread Jake Maes
, Chris Pettitt, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-976 https://issues.apache.org/jira/browse/SAMZA-976 Repository: samza Description --- SAMZA-976 Samza REST Documentation Diffs (updated) - bin/generate

Re: Review Request 50588: SAMZA-982: Add null check for offset update in OffsetManager

2016-07-28 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50588/#review144045 --- Ship it! Ship It! - Jake Maes On July 29, 2016, 12:13 a.m

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Jake Maes
ly generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/#review143994 --- On July 28, 2016, 8:41 p.m., Jake Maes wrote: > > --- > This is an auto

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Jake Maes
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/#review143998 ------- On July 28, 2016, 8:41 p.m., Jake Maes wrote: > > ---

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Jake Maes
, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-954 https://issues.apache.org/jira/browse/SAMZA-954 Repository: samza Description --- SAMZA-954 Improve logging for Samza Diffs (updated) - docs

Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Jake Maes
n be excluded. I can refer them to the JobsResource page if they're just getting started and want to try it out. - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/501

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Jake Maes
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review143826 --- On July 27, 2016, 8:47 p.m., Jake Maes wrote: > > --- > Thi

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Jake Maes
, Chris Pettitt, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-976 https://issues.apache.org/jira/browse/SAMZA-976 Repository: samza Description --- SAMZA-976 Samza REST Documentation Diffs (updated) - bin/generate

  1   2   3   >